1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • [gentoo-dev] [PATCH 4/7] cargo.eclass: set progress.when = "never" in c

    From Georgy Yakovlev@21:1/5 to All on Thu Feb 9 22:00:01 2023
    to avoid possible log file pollution

    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
    ---
    eclass/cargo.eclass | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/eclass/cargo.eclass b/eclass/cargo.eclass
    index 9c624d607cdd..0ab7ee0dc9b2 100644
    --- a/eclass/cargo.eclass
    +++ b/eclass/cargo.eclass
    @@ -273,6 +273,7 @@ cargo_gen_config() {
    [term]
    verbose = true
    $([[ "${NOCOLOR}" = true || "${NOCOLOR}" = yes ]] && echo "color = 'never'")
    + progress.when = "never"
    $(_cargo_gen_git_config)
    _EOF_

    --
    2.39.1

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?=@21:1/5 to Georgy Yakovlev on Fri Feb 10 07:10:01 2023
    On Thu, 2023-02-09 at 12:48 -0800, Georgy Yakovlev wrote:
    to avoid possible log file pollution

    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
    ---
    eclass/cargo.eclass | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/eclass/cargo.eclass b/eclass/cargo.eclass
    index 9c624d607cdd..0ab7ee0dc9b2 100644
    --- a/eclass/cargo.eclass
    +++ b/eclass/cargo.eclass
    @@ -273,6 +273,7 @@ cargo_gen_config() {
    [term]
    verbose = true
    $([[ "${NOCOLOR}" = true || "${NOCOLOR}" = yes ]] && echo "color = 'never'")
    + progress.when = "never"
    $(_cargo_gen_git_config)
    _EOF_


    What's that and why don't we want it? I thought we generally preferred
    more verbosity.

    --
    Best regards,
    Michał Górny

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Georgy Yakovlev@21:1/5 to All on Fri Feb 10 22:20:01 2023
    On Fri, 2023-02-10 at 07:03 +0100, Michał Górny wrote:
    On Thu, 2023-02-09 at 12:48 -0800, Georgy Yakovlev wrote:
    to avoid possible log file pollution

    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
    ---
     eclass/cargo.eclass | 1 +
     1 file changed, 1 insertion(+)

    diff --git a/eclass/cargo.eclass b/eclass/cargo.eclass
    index 9c624d607cdd..0ab7ee0dc9b2 100644
    --- a/eclass/cargo.eclass
    +++ b/eclass/cargo.eclass
    @@ -273,6 +273,7 @@ cargo_gen_config() {
            [term]
            verbose = true
            $([[ "${NOCOLOR}" = true || "${NOCOLOR}" = yes ]] && echo "color = 'never'")
    +       progress.when = "never"         $(_cargo_gen_git_config)
            _EOF_
     

    What's that and why don't we want it?  I thought we generally
    preferred
    more verbosity.

    This knob controls progress bar that can pollute logs in rare cases,
    not build verbosity. verbose is set just above.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?=@21:1/5 to Georgy Yakovlev on Sat Feb 11 07:30:01 2023
    On Fri, 2023-02-10 at 13:13 -0800, Georgy Yakovlev wrote:
    On Fri, 2023-02-10 at 07:03 +0100, Michał Górny wrote:
    On Thu, 2023-02-09 at 12:48 -0800, Georgy Yakovlev wrote:
    to avoid possible log file pollution

    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
    ---
     eclass/cargo.eclass | 1 +
     1 file changed, 1 insertion(+)

    diff --git a/eclass/cargo.eclass b/eclass/cargo.eclass
    index 9c624d607cdd..0ab7ee0dc9b2 100644
    --- a/eclass/cargo.eclass
    +++ b/eclass/cargo.eclass
    @@ -273,6 +273,7 @@ cargo_gen_config() {
            [term]
            verbose = true
            $([[ "${NOCOLOR}" = true || "${NOCOLOR}" = yes ]] && echo "color = 'never'")
    +       progress.when = "never"         $(_cargo_gen_git_config)
            _EOF_
     

    What's that and why don't we want it?  I thought we generally
    preferred
    more verbosity.

    This knob controls progress bar that can pollute logs in rare cases,
    not build verbosity. verbose is set just above.


    Ah, ok. I thought it was maybe "output something every N minutes when
    nothing else visible is happening".

    --
    Best regards,
    Michał Górny

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)