1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • [gentoo-dev] [PATCH] eclass/java-utils-2.eclass: testng print verbose o

    From Volkmar W. Pogatzki@21:1/5 to All on Tue Jun 28 19:10:01 2022
    Bug: https://bugs.gentoo.org/801694
    Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
    ---
    eclass/java-utils-2.eclass | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/eclass/java-utils-2.eclass b/eclass/java-utils-2.eclass
    index e5a2b611d11..cfe04d631a0 100644
    --- a/eclass/java-utils-2.eclass
    +++ b/eclass/java-utils-2.eclass
    @@ -1901,7 +1901,9 @@ etestng() {
    ${JAVA_TEST_RUNNER_EXTRA_ARGS[@]}
    )

    - [[ ! "${JAVA_TEST_RUNNER_EXTRA_ARGS[@]}" =~ "-usedefaultlisteners" ]] && args+=( -usedefaultlisteners false )
    + if [[ ! "${JAVA_TEST_RUNNER_EXTRA_ARGS[@]}" =~ "-usedefaultlisteners" ]]; then
    + args+=( -verbose 3 -usedefaultlisteners true )
    + fi

    args+=( -testclass ${tests} )

    --
    2.35.1

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Florian Schmaus@21:1/5 to Volkmar W. Pogatzki on Wed Jun 29 08:50:01 2022
    On 28/06/2022 19.04, Volkmar W. Pogatzki wrote:
    Bug: https://bugs.gentoo.org/801694
    Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
    ---
    eclass/java-utils-2.eclass | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/eclass/java-utils-2.eclass b/eclass/java-utils-2.eclass
    index e5a2b611d11..cfe04d631a0 100644
    --- a/eclass/java-utils-2.eclass
    +++ b/eclass/java-utils-2.eclass
    @@ -1901,7 +1901,9 @@ etestng() {
    ${JAVA_TEST_RUNNER_EXTRA_ARGS[@]}
    )

    - [[ ! "${JAVA_TEST_RUNNER_EXTRA_ARGS[@]}" =~ "-usedefaultlisteners" ]] && args+=( -usedefaultlisteners false )
    + if [[ ! "${JAVA_TEST_RUNNER_EXTRA_ARGS[@]}" =~ "-usedefaultlisteners" ]]; then
    + args+=( -verbose 3 -usedefaultlisteners true )
    + fi

    args+=( -testclass ${tests} )

    LGTM, but I would split the args value in multiple lines, which makes it
    clear what the argument name and the argument value is and hence makes
    it easier to read:

    args+=(
    -verbose 3
    -usedefaultlisteners true
    )

    - Flow

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)