1. Forum
  2. Usenet
  3. LINUX.DEBIAN.BUGS.DIST

  • Bug#1067243: openssh: please build without -fzero-call-used-regs=used o

    From Thorsten Glaser@21:1/5 to All on Wed Mar 20 20:30:01 2024
    XPost: linux.debian.ports.68k

    Source: openssh
    Version: 1:9.7p1-2
    Severity: important
    Justification: FTBFS on d-ports arch
    Tags: ftbfs
    X-Debbugs-Cc: tg@mirbsd.de, debian-68k@lists.debian.org

    On m68k, gcc-13 currently ICEs when -fzero-call-used-regs=used is
    used (see #1066891) in moduli.c, packet.c, etc. but the configury
    detects it and so it gets used. The upstream GCC bug comments say
    there is no plan to backport the possible fix to releases, but it
    has a short reproducer by doko:


    $ cat moduli.i
    int snprintf_eta;
    double snprintf_time_per_line;
    int snprintf(char *, int, char *, ...) {
    snprintf_eta = snprintf_time_per_line;
    }

    $ m68k-linux-gnu-gcc -c -O2 -fzero-call-used-regs=used -fPIE moduli.i
    during RTL pass: zero_call_used_regs
    moduli.i: In function ‘snprintf’:
    moduli.i:5:1: internal compiler error: in change_address_1, at emit-rtl.cc:2287


    Maybe this could be used in the configure script?

    I can confirm that appending…

    int snprintf_eta;
    double snprintf_time_per_line;
    int snprintf(char *str, size_t size, const char *format, ...) {
    snprintf_eta = snprintf_time_per_line;
    }

    … (lightly changed from the above) to the program from
    m4/openssh.m4 OSSH_COMPILER_FLAG_TEST_PROGRAM fails with:

    (pbuild-15711)root@ara2:/tmp# gcc -O2 -fPIE -fno-strict-aliasing -fzero-call-used-regs=used t.c
    during RTL pass: zero_call_used_regs
    t.c: In function 'snprintf':
    t.c:51:1: internal compiler error: in change_address_1, at emit-rtl.cc:2287
    51 | }
    | ^
    […]


    Alternatively, just hardcode disabling this flag on m68k for now,
    which we’ll eventually have to revert once GCC is on a fixed release
    (14 probably).

    Thanks in advance!

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Colin Watson@21:1/5 to Thorsten Glaser on Thu Mar 21 11:40:01 2024
    On Wed, Mar 20, 2024 at 07:14:42PM +0000, Thorsten Glaser wrote:
    I can confirm that appending…

    int snprintf_eta;
    double snprintf_time_per_line;
    int snprintf(char *str, size_t size, const char *format, ...) {
    snprintf_eta = snprintf_time_per_line;
    }

    … (lightly changed from the above) to the program from
    m4/openssh.m4 OSSH_COMPILER_FLAG_TEST_PROGRAM fails with:

    (pbuild-15711)root@ara2:/tmp# gcc -O2 -fPIE -fno-strict-aliasing -fzero-call-used-regs=used t.c
    during RTL pass: zero_call_used_regs
    t.c: In function 'snprintf':
    t.c:51:1: internal compiler error: in change_address_1, at emit-rtl.cc:2287
    51 | }
    | ^
    […]

    I don't love overriding snprintf here, since it seems possible that that
    could disturb the check on other architectures. Could you try the
    somewhat further reduced patch in https://salsa.debian.org/ssh-team/openssh/-/tree/zero-call-used-regs-m68k, please? I wanted to use the mitchy.debian.net porterbox but I got ECONNREFUSED.

    Alternatively, just hardcode disabling this flag on m68k for now,
    which we’ll eventually have to revert once GCC is on a fixed release
    (14 probably).

    This configure check doesn't use the usual autoconf result caching arrangements, which makes it a bit more awkward to override from
    debian/rules. There are options, but an extended configure check that I
    could send upstream would probably be best.

    Thanks,

    --
    Colin Watson (he/him) [cjwatson@debian.org]

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Thorsten Glaser@21:1/5 to All on Thu Mar 21 17:40:02 2024
    Colin Watson dixit:

    I don't love overriding snprintf here, since it seems possible that that

    Agreed.

    could disturb the check on other architectures. Could you try the
    somewhat further reduced patch in >https://salsa.debian.org/ssh-team/openssh/-/tree/zero-call-used-regs-m68k,

    Yes, but not sure I manage it tonight, and I’ll be gone all day
    tomorrow.

    please? I wanted to use the mitchy.debian.net porterbox but I got >ECONNREFUSED.

    Adrian, do you have an idea about that?

    This configure check doesn't use the usual autoconf result caching >arrangements, which makes it a bit more awkward to override from >debian/rules. There are options, but an extended configure check that I >could send upstream would probably be best.

    oic, yes, that’s definitely easier.

    For now I’ve built the last upload with the flag manually removed,
    so this isn’t a transition blocker any more, until the next upload
    anyway and perhaps not even then…

    bye,
    //mirabilos
    --
    "Using Lynx is like wearing a really good pair of shades: cuts out
    the glare and harmful UV (ultra-vanity), and you feel so-o-o COOL."
    -- Henry Nelson, March 1999

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Thorsten Glaser@21:1/5 to All on Thu Mar 21 23:50:01 2024
    Colin Watson dixit:

    Could you try the somewhat further reduced patch in

    I’ve started a build and will let you know probably when I get
    back late tomorrow.

    bye,
    //mirabilos
    --
    18:47⎜<mirabilos:#!/bin/mksh> well channels… you see, I see everything in the
    same window anyway 18:48⎜<xpt:#!/bin/mksh> i know, you have some kind of telnet with automatic pong 18:48⎜<mirabilos:#!/bin/mksh> haha, yes :D 18:49⎜<mirabilos:#!/bin/mksh> though that's more tinyirc – sirc is more comfy

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Colin Watson@21:1/5 to Thorsten Glaser on Fri Mar 22 00:10:01 2024
    On Thu, Mar 21, 2024 at 10:35:17PM +0000, Thorsten Glaser wrote:
    Colin Watson dixit:
    Could you try the somewhat further reduced patch in

    I’ve started a build and will let you know probably when I get
    back late tomorrow.

    Thanks! No rush - I won't be at a proper computer until Sunday or so
    anyway.

    --
    Colin Watson (he/him) [cjwatson@debian.org]

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Thorsten Glaser@21:1/5 to All on Fri Mar 22 00:40:01 2024
    Colin Watson dixit:

    Thanks! No rush - I won't be at a proper computer until Sunday or so
    anyway.

    OK sure… no rush is not the reason, the Atari VM I’m using having
    only 98 MHz is the one here ;-)

    But I already see:

    checking if cc supports compile flag -fzero-call-used-regs=used and linking succeeds... no

    So I guess it should work, but I’ll see tomorrow.

    bye,
    //mirabilos
    --
    16:47⎜«mika:#grml» .oO(mira ist einfach gut....) 23:22⎜«mikap:#grml»
    mirabilos: und dein bootloader ist geil :) 23:29⎜«mikap:#grml» und ich finds saugeil dass ich ein bsd zum booten mit grml hab, das muss ich dann gleich mal auf usb-stick installieren -- Michael Prokop über MirOS bsd4grml

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Thorsten Glaser@21:1/5 to All on Sat Mar 23 03:00:01 2024
    Colin Watson dixit:

    Could you try the somewhat further reduced patch in

    The package made from that branch built fine in my cowbuilder,
    and I have all reason to assume it’ll do so in sbuild/buildd.

    Thanks,
    //mirabilos
    --
    <ch> you introduced a merge commit │<mika> % g rebase -i HEAD^^
    <mika> sorry, no idea and rebasing just fscked │<mika> Segmentation
    <ch> should have cloned into a clean repo │ fault (core dumped)
    <ch> if I rebase that now, it's really ugh │<mika:#grml> wuahhhhhh

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From John Paul Adrian Glaubitz@21:1/5 to Thorsten Glaser on Sat Mar 23 11:30:01 2024
    Hi!

    On Thu, 2024-03-21 at 16:26 +0000, Thorsten Glaser wrote:
    please?  I wanted to use the mitchy.debian.net porterbox but I got ECONNREFUSED.

    Adrian, do you have an idea about that?

    mitchy is back up again. The hosting server was forcefully rebooted
    without me being notified. I assume that happened due to maintenance
    reasons since the other Gandi machines were rebooted as well.

    Adrian

    --
    .''`. John Paul Adrian Glaubitz
    : :' : Debian Developer
    `. `' Physicist
    `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Colin Watson@21:1/5 to Thorsten Glaser on Sun Mar 24 22:40:01 2024
    On Sat, Mar 23, 2024 at 01:49:19AM +0000, Thorsten Glaser wrote:
    Colin Watson dixit:
    Could you try the somewhat further reduced patch in

    The package made from that branch built fine in my cowbuilder,
    and I have all reason to assume it’ll do so in sbuild/buildd.

    Thanks for the testing!

    --
    Colin Watson (he/him) [cjwatson@debian.org]

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)