Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "batsignal":

* Package name : batsignal
Version : 1.8.0-1
Upstream contact : https://github.com/electrickite/batsignal
* URL : https://github.com/electrickite/batsignal
* License : ISC
* Vcs : https://salsa.debian.org/itd/batsignal
Section : utils

The source builds the following binary packages:

batsignal - Lightweight battery daemon written in C

To access further information about this package, please visit the following URL:

https://mentors.debian.net/package/batsignal/

Alternatively, you can download the package with 'dget' using this command:

dget -x https://mentors.debian.net/debian/pool/main/b/batsignal/batsignal_1.8.0-1.dsc

Changes for the initial release:

batsignal (1.8.0-1) unstable; urgency=medium
.
* Initial release.

I would like to move the Vcs to /debian/batsignal, whenever that is
convenient.

Regards,
-- itd

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Control: tags -1 moreinfo

Hi itd,

(Policy requires that the "Maintainer" has "their correct name and a working email
address", see Policy §3.3. I know that there are exceptions, but I'm not
sure about the conditions they require (for DMs/DDs, at least DAM needs
to know your name, but I don't know the rules for Debian Contributors.
Due to that, I will not sponsor this package, but I can certainly review the package.)

On Sun, Mar 17, 2024 at 12:17:52PM +0100, itd wrote:

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "batsignal":

* Package name : batsignal
Version : 1.8.0-1
Upstream contact : https://github.com/electrickite/batsignal
* URL : https://github.com/electrickite/batsignal
* License : ISC
* Vcs : https://salsa.debian.org/itd/batsignal
Section : utils

The source builds the following binary packages:

batsignal - Lightweight battery daemon written in C

To access further information about this package, please visit the following URL:

https://mentors.debian.net/package/batsignal/

Alternatively, you can download the package with 'dget' using this command:

dget -x https://mentors.debian.net/debian/pool/main/b/batsignal/batsignal_1.8.0-1.dsc

Changes for the initial release:

batsignal (1.8.0-1) unstable; urgency=medium
.
* Initial release.

Inital releases needs an ITP bug. Please file one and add the appropiate Closes: #xxxx stanca.

I would like to move the Vcs to /debian/batsignal, whenever that is convenient.

Let me know your salsa username and I'll make that happen.


A short, possibly incomplete review:
- d/copyright: I suggest to have the same license for debian/* as for
upstream, as this eases forwarding patches etc. Though ISC is
considered by the FSF to be compatible with the GPL, this is likely
fine too to keep it at is is.

- d/watch / this dsc
uscan download this:
c8c2a048f4aa105aae389d9d765b76057d4998dbfc29a7dfeaf66351eaa7cba1 batsignal_1.8.0.orig.tar.gz

your dsc contains:
d02e5c821d41e72c30d00bb88759287f9b74225e1217158e5e59f11ba03d5a5b batsignal_1.8.0.orig.tar.xz

when constructing your dsc, please make sure to use the same file as
uscan would produce. (I've verified that the content of both orig files is identical)

Package looks good, otherwise. Make sure to remove the moreinfo tag when
the above issues are fixed.

Cheers,
--
tobi

Regards,
-- itd

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Hi tobi,

Tobias Frost <tobi@debian.org> writes:

(Policy requires that the "Maintainer" has "their correct name and a working email
address", see Policy §3.3. I know that there are exceptions, but I'm not sure about the conditions they require (for DMs/DDs, at least DAM needs
to know your name, but I don't know the rules for Debian Contributors.
Due to that, I will not sponsor this package, but I can certainly review the package.)

understood, thanks for the review!

Inital releases needs an ITP bug. Please file one and add the appropiate Closes: #xxxx stanca.

Will look into this.

Let me know your salsa username and I'll make that happen.

My salsa username is: itd

A short, possibly incomplete review:
- d/copyright: I suggest to have the same license for debian/* as for
upstream, as this eases forwarding patches etc. Though ISC is
considered by the FSF to be compatible with the GPL, this is likely
fine too to keep it at is is.

Makes sense and works for me. Updated.

- d/watch / this dsc
uscan download this:
c8c2a048f4aa105aae389d9d765b76057d4998dbfc29a7dfeaf66351eaa7cba1 batsignal_1.8.0.orig.tar.gz

your dsc contains:
d02e5c821d41e72c30d00bb88759287f9b74225e1217158e5e59f11ba03d5a5b batsignal_1.8.0.orig.tar.xz

when constructing your dsc, please make sure to use the same file as
uscan would produce. (I've verified that the content of both orig files is identical)

Ouch, sorry about that. If I understand diffoscope correctly it's
indeed only the timestamps that differ. d/watch's version uses the date
of the upstream repo's 1.8.0 tag. My version, created via gbp, uses the
date of my repo's upstream/1.8.0 tag. I'll try to figure out how to
solve this.

Package looks good, otherwise. Make sure to remove the moreinfo tag when
the above issues are fixed.

Not fixed so not removed.

Thanks again!

Regards
itd

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Control: clone -1 -2
Control: reassign -2 wnpp
Control: retitle -2 ITP: batsignal -- Lightweight battery daemon written in C Control: tags -2 - moreinfo

Preparing an ITP bug for d/changelog by cloning and updating the clone.

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Control: tags -1 - moreinfo

Hi again,

itd <itd@net.in.tum.de> writes:

Tobias Frost <tobi@debian.org> writes:

Inital releases needs an ITP bug. Please file one and add the appropiate
Closes: #xxxx stanca.

Will look into this.

with 27dcd276 debian/changelog closes bug #1067606.

- d/watch / this dsc
uscan download this:
c8c2a048f4aa105aae389d9d765b76057d4998dbfc29a7dfeaf66351eaa7cba1 batsignal_1.8.0.orig.tar.gz

your dsc contains:
d02e5c821d41e72c30d00bb88759287f9b74225e1217158e5e59f11ba03d5a5b batsignal_1.8.0.orig.tar.xz

when constructing your dsc, please make sure to use the same file as
uscan would produce. (I've verified that the content of both orig files is identical)

Ouch, sorry about that. If I understand diffoscope correctly it's
indeed only the timestamps that differ. d/watch's version uses the date
of the upstream repo's 1.8.0 tag. My version, created via gbp, uses the
date of my repo's upstream/1.8.0 tag. I'll try to figure out how to
solve this.

As mentioned, looks like this was caused by a misconfiguration of uscan
and gbp on my side, sorry. I've unset the uscan variable, added, and
pushed the missing pristine-tar branch. With these changes the hash
matches. Updated package dput to mentors.

Regards
itd

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

XPost: linux.debian.devel.mentors

Hi,

Soren Stoutner <soren@debian.org> writes:

Without knowing for certain, I would suspect that the problem is that
gbp is repacking your orig.tar as an .xz (the upstream is .gz).

looks like the problem was caused by a forgotten USCAN_REPACK=yes in ~/.devscripts combined with a missing pristine-tar branch to allow gbp
to recreate the upstream tarball.

Thanks for the help!

Best regards
itd

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)