Forum: >>> Magnum BBS <<<

Dark
Log in

Username Password

comReadBuf() supports an infinite timeout (0)

From Deucе@1:103/705 to GitLab note in main/sbbs on Mon Jan 24 14:37:42 2022

https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2223

This seems very dangerous since it will continue block across a disconnection/new connection. Is that the intended use case?
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Jan 24 15:18:58 2022

https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2224

Yeah, I mentioned the risks to the requester (Nelgin) and he tested and was okay with the change: upon disconnect, the modem is always sending *something* to the application (SexPOTS), so it always aborts this loop. Still, I made the default timeout non-zero (60 seconds).
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Deucе@1:103/705 to GitLab note in main/sbbs on Mon Jan 24 15:55:48 2022

https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2225

While that works fine for his modem usage, I don't understand why he needs more than the 68 years allowed by the timeout value.
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Deucе@1:103/705 to GitLab note in main/sbbs on Mon Jan 24 16:02:25 2022

https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2226

I'm also not sure why his ask is important enough to potentially break existing consumers and/or add a special-case value.
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Deucе@1:103/705 to GitLab note in main/sbbs on Mon Jan 24 16:04:16 2022

https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2227

I think passing INT_MAX for infinite timeout would be *much* better than zero. --- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Jan 24 17:06:07 2022

https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2228

I did search and could not locate any caller of this function with a timeout parameter value of 0. Seemed like a safe-enough change but using INT_MAX or INT_MIN is fine too.
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Nelgin@1:103/705 to Deuc¿ on Tue Jan 25 00:42:01 2022

On Mon, 24 Jan 2022 15:55:48 -0800
"Deuc_" <deuc_@VERT> wrote:

https://gitlab.synchro.net/main/sbbs/-/commit/0b8517e11ce52702b4c56e2926990ae456dc23f6#note_2225

While that works fine for his modem usage, I don't understand why he
needs more than the 68 years allowed by the timeout value.

If someone had told me I cannot have an invite timeout but if you set
it to 0 then it'll be 68 years, I'd have been fine with that.
--
End Of The Line BBS - Plano, TX
telnet endofthelinebbs.com 23
---
� Synchronet � End Of The Line BBS - endofthelinebbs.com
--- SBBSecho 3.14-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

Who's Online
Recent Visitors
- Daniel Garrod
  Fri Jan 31 12:03:09 2025
  from Cambridge, Uk via Telnet
- Guest
  Fri Jan 31 08:49:29 2025
  from /bin/busybox Cat /proc/self/ex via Raw
- Plume
  Fri Jan 31 03:28:03 2025
  from Uk via Telnet
- Razorclad
  Fri Jan 31 03:18:22 2025
  from Denver, Co via Telnet
- Bob Worm
  Thu Jan 30 21:16:47 2025
  from Wales, Uk via Telnet
- Guest
  Thu Jan 30 15:56:01 2025
  from /bin/busybox Cat /proc/self/ex via Raw
- Guest
  Thu Jan 30 14:32:05 2025
  from /bin/busybox Cat /proc/self/ex via Raw
- Guest
  Thu Jan 30 13:05:51 2025
  from /bin/busybox Cat /proc/self/ex via Raw

System Info

Sysop:	Keyop
Location:	Huddersfield, West Yorkshire, UK
Users:	410
Nodes:	16 (2 / 14)
Uptime:	83:21:45
Calls:	8,580
Calls today:	4
Files:	13,228
Messages:	5,932,491