1. Forum
  2. FidoNet
  3. SYNC SYSOPS

  • WIP:Improvements to linux dosemu support

    From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Dec 7 19:18:40 2020
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1071

    Why the '\n' change? '\n' as a character, is a line-feed (Ctrl-J). The '\r' (Ctrl-M, Carriage-Return) made at least a little more sense.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Michael Long@1:103/705 to GitLab note in main/sbbs on Mon Dec 7 19:23:58 2020
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1074

    the \n does not seem to introduce any effects, which is what i want. the \r hits an enter, which is not ideal... ie if it says "Do you really want to proceed? [n/Y] you won't have a chance to pick an answer because it will hit enter for you. I could instead do a backspace, or any other character that would most likely have no action in a door (especially intercept i/o). Is of course fully configurable now, if someone is into \r
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Dec 7 19:57:04 2020
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1075

    It seems rather unfortunate that you'd have 2 command-lines configured here, that are 80% the same. Could we instead just *add* (append) the -I keystroke option via a key value for stdio xtrn's?```cmd=/usr/bin/env $TERM RUNTYPE=FOSSIL HOME=$CTRLDIR QUIET=1 DOSDRIVE_D=$NODEDIR NODEDIR=$NODEDIR $DOSEMUBIN -I"video { none }" $VIRTUALCONF -f$DOSEMUCONF -E$EXTBAT -o $NODEDIRdosemu_boot.log $EXTLOG[stdio]cmd-append=-I'keystroke "\n"'```... it's called the DRY principle: don't repeat yourself. :-)
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Dec 7 19:57:04 2020
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1076

    This renamed variable doesn't appear to be an improvement in a name. Just leave it?
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Dec 7 19:57:05 2020
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1077

    Looks like there some inconsistent use of spaces versus tabs introduced in the file. These are called "whitespace errors" and are just kind of annoying.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Dec 7 19:57:05 2020
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1078

    Again, I would prefer the original variable name to this.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Dec 7 19:57:06 2020
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1079

    Any reason the @echo off was removed?
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Dec 7 19:57:07 2020
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1080

    Don't use sprintf().
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Dec 7 19:57:07 2020
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1081

    So lines that you're not changing for any other reason, leave the sprintf stuff alone. Fixing those should be a separate commit/merge request as they're not related to the feature/improvement you're implementing and just serve to distract.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Dec 7 19:57:07 2020
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1082

    You *just* set `str[0]` to `'\0'`, so how would this `if()` ever evaluate to false?
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Dec 7 19:57:08 2020
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1083

    The indentation is all wonky here.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Dec 7 19:57:09 2020
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1084

    Let's remove this noise.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Dec 7 19:57:10 2020
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1085

    so this line allocates memory. Where are you freeing it?
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Dec 7 19:57:10 2020
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1086

    How were these magic numbers (100) chosen?
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Michael Long@1:103/705 to GitLab note in main/sbbs on Mon Dec 7 20:33:33 2020
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1088

    um...i'm probably not. open to suggestions here
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Michael Long@1:103/705 to GitLab note in main/sbbs on Mon Dec 7 20:32:41 2020
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/56#note_1087

    arbitrary...i think the max batch file line length is 8191 characters? which seems excessive, but i suppose the buffer could be set to that
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)