1. Forum
  2. FidoNet
  3. SYNC PROGRAMMING

  • Update Polyfills.

    From Michael J. Ryan@1:103/705 to GitLab note in main/sbbs on Sun Mar 21 10:58:24 2021
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/115#note_1745

    @Deuce @rswindell @echicken thoughts? There's already existing Array polyfills, wanted to add a couple missing methods as well as some Object methods missing... Would like to followup with a couple bits on strings as well.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Wed Mar 31 18:30:21 2021
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/115#note_1800

    I don't think we want your editor preferences in git.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Wed Mar 31 18:30:21 2021
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/115#note_1801

    If you're gonna do a white-space clean-up, make that a separate commit/PR.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Wed Mar 31 18:30:21 2021
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/115#note_1802

    Is anything actually using this library currently? Does it need these addition methods?In general, I'm not a fan of adding stuff "just because". It becomes a maintenance headache. Does someone actually need this stuff and have an immediate use for it (in Synchronet) or is just for completionism?If there's a need/use and it doesn't break anything else, I'm not opposed.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From echicken@1:103/705 to GitLab note in main/sbbs on Wed Mar 31 19:47:36 2021
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/115#note_1803

    I think I'm using exec/load/array.js for a few things in webv4. It's just a bunch of useful shorthand/convenience stuff that JS devs are accustomed to having available (and for that reason, it's nice to have it here).That said, I'll be using 'for' loops a lot more often now, when performance matters. Recent adventures in optimization have shown me that there's a lot of time to be saved that way - though it's not always worth worrying about.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Michael J. Ryan@1:103/705 to GitLab note in main/sbbs on Fri Apr 2 11:59:42 2021
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/115#note_1826

    I literally changed the heading, not just a whitespace cleanup.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Michael J. Ryan@1:103/705 to GitLab note in main/sbbs on Fri Apr 2 12:01:31 2021
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/115#note_1827

    The Array stuff is being used in a couple places currently... I added the missing methods and updated the heading.I also added missing Object polyfills... namely, I was wanting to use `Object.assign` but the others I use pretty regularly writing code.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Michael J. Ryan@1:103/705 to GitLab note in main/sbbs on Fri Apr 2 12:02:35 2021
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/115#note_1828

    I can alternatively add `.vscode` to `.gitignore`, but figured it would be usefull in order to prevent auto-format issues for anyone else contributing using vs code.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Michael J. Ryan@1:103/705 to GitLab note in main/sbbs on Fri Apr 2 12:03:59 2021
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/115#note_1829

    @echicken yeah, for loops are often faster, though I still prefer map/reduce syntax... if we had fat-arrow functions, it'd be much cleaner syntax wise.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Fri Apr 2 12:07:41 2021
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/115#note_1830

    Several of the changes in this commit appear to be just white-space changes. --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Fri Apr 2 12:07:41 2021
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/115#note_1831

    This is not the preferred/used tab size in the Synchronet C/C++ source code. The stated preference is 4, though some still insist on using 8.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Michael J. Ryan@1:103/705 to GitLab note in main/sbbs on Fri Apr 2 12:13:20 2021
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/115#note_1833

    kk... just opened a couple files, and it looked like it was using 2 spaces on then, will change to 4.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Fri Apr 2 12:16:51 2021
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/115#note_1841

    white-space change.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Fri Apr 2 12:16:52 2021
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/115#note_1842

    white-space change.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Fri Apr 2 12:16:52 2021
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/115#note_1843

    white-space change.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Fri Apr 2 12:16:53 2021
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/115#note_1844

    white-space change.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Fri Apr 2 12:16:53 2021
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/115#note_1845

    white-space change.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Fri Apr 2 12:16:48 2021
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/115#note_1836

    white-space change.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Fri Apr 2 12:16:49 2021
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/115#note_1837

    white-space change.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Fri Apr 2 12:16:49 2021
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/115#note_1838

    white-space change.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Fri Apr 2 12:16:49 2021
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/115#note_1839

    white-space change.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Fri Apr 2 12:16:50 2021
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/115#note_1840

    white-space change.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Michael J. Ryan@1:103/705 to GitLab note in main/sbbs on Fri Apr 2 12:23:11 2021
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/115#note_1860

    @rswindell in the future, in the "changes" tab, you can click the gears, and uncheck the show whitespace changes.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Fri Apr 2 12:23:26 2021
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/115#note_1861

    Re: "apparently necessary whitespace" I think you're missing the point.A merge request should address a single topic/problem domain. In this case, the topic is "Updated polyfills". That topic does not include unrelated white-space changes or your VSCode settings.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Fri Apr 2 12:25:33 2021
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/115#note_1862

    I'm well aware of how to view or ignore whitespace changes. That's not the point. If you want to submit a whitespace clean-up merge request, it'd likely be accepted/merged, but not as an incidental part of some other change set.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Michael J. Ryan@1:103/705 to GitLab note in main/sbbs on Fri Apr 2 12:26:32 2021
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/115#note_1863

    Fuck it.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)