1. Forum
  2. FidoNet
  3. SYNC PROGRAMMING

  • src/smblib/smblib.c

    From rswindell@1:103/705 to CVS commit on Sat Apr 4 15:11:36 2020
    src/smblib smblib.c 1.205 1.206
    Update of /cvsroot/sbbs/src/smblib
    In directory cvs:/home/rswindell/sbbs/src/smblib

    Modified Files:
    smblib.c
    Log Message:
    Include more details in "illegal header length increase" error msg.


    --- SBBSecho 3.10-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Tue Apr 14 01:22:54 2020
    src/smblib smblib.c 1.206 1.207
    Update of /cvsroot/sbbs/src/smblib
    In directory cvs:/tmp/cvs-serv6132

    Modified Files:
    smblib.c
    Log Message:
    On Windows, smb_addmsg() was slow because smb_updatethread() was slow:

    So on Windows, calling unlock() on a file region that you don't have locked, incurs a delay. Likewise, calling lock() on a file region that already have locked incurs a delay. These delays were seriously throttling message imports on Windows (e.g. importing echomail or QWK packets). What should take a few seconds, was taking minutes with noticeable delays. This code has been performing redundant locks/unlocks for over 15 years, so I can only conclude that the performance penalty is a new behavior introduced in recent version(s) of Windows.

    --- SBBSecho 3.10-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Tue Apr 14 01:50:32 2020
    src/smblib smblib.c 1.207 1.208
    Update of /cvsroot/sbbs/src/smblib
    In directory cvs:/tmp/cvs-serv11249

    Modified Files:
    smblib.c
    Log Message:
    Some very old, yet inconsistent, behavior of smb_hfield_add() could pretty easily result in a message body being added to a message base with no accompanying message header: if the header data was 0-length, the hfield_dat was not actually allocated and the applicable smbmsg_t convenience pointer was not set accordingly. This had the side effect that if a message were to be imported with a blank recipient ("To" field), the header was not created at
    all (to support mutliple header, single body msgs, i.e. bulkmail).
    The other functions that set the convenience pointers do not treat 0-length header field data special, so this was inconsistent behavior.
    Most message types (e.g. networks) don't want 0-length "to" fields, but that shoudl be enforced somewhere else, not here.

    --- SBBSecho 3.10-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From rswindell@1:103/705 to CVS commit on Thu May 7 12:30:23 2020
    src/smblib smblib.c 1.208 1.209
    Update of /cvsroot/sbbs/src/smblib
    In directory cvs:/tmp/cvs-serv3248

    Modified Files:
    smblib.c
    Log Message:
    smb_hfield_add_netaddr():
    Don't strip the "user@" portion of a *NETADDR header field if the specified net-type is NET_NONE.

    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Wed Dec 9 00:42:43 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/05104f134188b139a6f3e5ba
    Modified Files:
    src/smblib/smblib.c
    Log Message:
    When a message has been forwarded, invalidate the "to" ext/net ptrsThe convenience pointers to_ext and to_net need to be invalidated (nullified) if we are going to allow forwarding from local email boxes to network mail and keep all the original message header fields in tact.The "Forwarded" field must now be added *before* any new recipient information (local user extension or network address of the forwarding destination).This is part of the solution to request #83, #108, and #141.
    --- SBBSecho 3.11-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun May 2 17:14:43 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/ba1f38cc4126d388c6a897ef
    Modified Files:
    src/smblib/smblib.c
    Log Message:
    When adding a msg/file header, remove the DELETE attributeWhen moving or renewing files, they're first removed and then added and they were being added with the DELETE attribute set. The filenames are displayed in red when staged for deletion/removal, so that's how I noticed. Oops.
    --- SBBSecho 3.14-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Fri Dec 29 17:10:28 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/47fe4a60247147dc217ad02b
    Modified Files:
    src/smblib/smblib.c
    Log Message:
    Fix stale comments (msg.offset became msg.idx_offset a couple years back).
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Fri Sep 13 20:08:11 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/1ab4ef2bfe0d0b1c7598cc53
    Modified Files:
    src/smblib/smblib.c
    Log Message:
    smb_getmsgidx() now reads entire index records from file bases too

    chksmb needed this to perform filename checks (index against headers).
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Fri Sep 13 20:30:10 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/ffa2c51ba23c59641e1a6e47
    Modified Files:
    src/smblib/smblib.c
    Log Message:
    MSVC requires a 0 in the struct initializer
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Sun Nov 10 16:14:22 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/6224ce6476a079f5e1e7a880
    Modified Files:
    src/smblib/smblib.c
    Log Message:
    Fix printf formatting issue in error message

    GCC and Coverity (x 2) both flagged this one.
    --- SBBSecho 3.21-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)