Forum: >>> Magnum BBS <<<

DDFileLister: When displaying a file description, remove/replace curso

From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Sun Sep 15 19:57:34 2024

https://gitlab.synchro.net/main/sbbs/-/merge_requests/460#note_5640

^A0 through ^A7 - these are color codes (set background color) - not cursor movement codes. ^A8 and ^A9 are not (currently, at least) valid Ctrl-A codes.
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Sun Sep 15 20:01:47 2024

https://gitlab.synchro.net/main/sbbs/-/merge_requests/460#note_5641

File descriptions aren't supposed to have cursor movements codes in the first place, so I'm curious how this is happening.

Are we talking about file summary/descriptions, or extended descriptions (e.g. imported from TIC or DIZ) here?

How'd these files get added to the filebase in the first place?
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Eric Oulashin@1:103/705 to GitLab note in main/sbbs on Sun Sep 15 21:20:08 2024

https://gitlab.synchro.net/main/sbbs/-/merge_requests/460#note_5642

Whoops I meant to be checking for cursor right (128-255, according to the [attributes documentation](https://wiki.synchro.net/custom:ctrl-a_codes)
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Eric Oulashin@1:103/705 to GitLab note in main/sbbs on Sun Sep 15 21:24:09 2024

https://gitlab.synchro.net/main/sbbs/-/merge_requests/460#note_5643

They're from extended descriptions from a diz. I uploaded them yo my BBS (for testing) using the ;UPLOAD coand. These are a couple examples:

http://digitaldistortionbbs.com/api/files.ssjs?call=download-file&dir=uploads_up_other&file=avpack23.zip

http://digitaldistortionbbs.com/api/files.ssjs?call=download-file&dir=uploads_up_other&file=blndr2022b.zip
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Eric Oulashin@1:103/705 to GitLab note in main/sbbs on Sun Sep 15 21:24:39 2024

https://gitlab.synchro.net/main/sbbs/-/merge_requests/460#note_5643

They're from extended descriptions from a diz. I uploaded them yo my BBS (for testing) using the ;UPLOAD coand. These are a couple examples:

http://digitaldistortionbbs.com/api/files.ssjs?call=download-file&dir=uploads_up_other&file=avpack23.zip

http://digitaldistortionbbs.com/api/files.ssjs?call=download-file&dir=uploads_up_other&file=blndr2022b.zip

Nelgin reportrd this; I downloaded these files from his BBS.
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Eric Oulashin@1:103/705 to GitLab note in main/sbbs on Sun Sep 15 21:42:57 2024

https://gitlab.synchro.net/main/sbbs/-/merge_requests/460#note_5643

They're from extended descriptions from a diz. I uploaded them yo my BBS (for testing) using the ;UPLOAD coand. These are a couple examples:

http://digitaldistortionbbs.com/api/files.ssjs?call=download-file&dir=uploads_up_other&file=avpack23.zip

http://digitaldistortionbbs.com/api/files.ssjs?call=download-file&dir=uploads_up_other&file=blndr2022b.zip

Nelgin reportrd this; I downloaded these files from his BBS. I noticed these seem to at least have a / (newline) attribute.
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Eric Oulashin@1:103/705 to GitLab note in main/sbbs on Sun Sep 15 22:40:18 2024

https://gitlab.synchro.net/main/sbbs/-/merge_requests/460#note_5643

They're from extended descriptions from a diz. I uploaded them yo my BBS (for testing) using the ;UPLOAD coand. These are a couple examples:

http://digitaldistortionbbs.com/api/files.ssjs?call=download-file&dir=uploads_up_other&file=avpack23.zip

http://digitaldistortionbbs.com/api/files.ssjs?call=download-file&dir=uploads_up_other&file=blndr2022b.zip

Nelgin reportrd this; I downloaded these files from his BBS. He says he used addfiles eith the -diz option. I noticed these seem to at least have a / (newline) attribute.
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Sep 16 03:19:11 2024

https://gitlab.synchro.net/main/sbbs/-/merge_requests/460#note_5644

I imported adpack23.zip into vert and the extended description display fine, at least using the built file lister, in sbbs. I do see there are Ctrl-A codes for cursor-right positioning (which would need to be replaced with spaces, at minimum, for the original art to display correctly) and the conditional-newline sequence (Ctrl-A/) is also required for proper display matching the screen width provided in the SAUCE record of the FILE_ID.ANS file.

I'm not clear why these codes would be problematic for DDFileLister.
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Nigel Reed@1:103/705 to GitLab note in main/sbbs on Mon Sep 16 08:41:06 2024

https://gitlab.synchro.net/main/sbbs/-/merge_requests/460#note_5645

For the record, this is the original image that I showed Nightfox.

![image](/uploads/5a2a3a48a2d83d45086423ac28d1e6e3/image.png){width=1218 height=796}
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Eric Oulashin@1:103/705 to GitLab note in main/sbbs on Mon Sep 16 09:58:43 2024

https://gitlab.synchro.net/main/sbbs/-/merge_requests/460#note_5646

The cursor codes are problematic for DDMsgReader because, when using the scrolling ANSI interface, it writes the extended descriptions to the right of the file list; it doesn't expect the cursor to be moved when writing the description, so that currently is causing issues when displaying the descriptions, as part of the description ends up over the file list. Similar issues happen when viewing file info, where it uses a scrollable window on the screen (using frame.js). I think the best solution would be for DDFileLister to remove these cursor positioning codes so that they aren't a problem when writing the extended descriptions.
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Eric Oulashin@1:103/705 to GitLab note in main/sbbs on Mon Sep 16 10:13:00 2024

https://gitlab.synchro.net/main/sbbs/-/merge_requests/460#note_5647

When viewing information about avpack23.zip, without removing these control characters:
![image](/uploads/29b3a320dcdb1de25fee2ce27527e5e2/image.png)

And if it removes the control characters, it looks better: ![image](/uploads/171cee839ba1be8720e2a4a7ebcdb959/image.png) ![image](/uploads/bd042f17830a08b769708e9078d25a0f/image.png)
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Eric Oulashin@1:103/705 to GitLab note in main/sbbs on Mon Sep 16 10:51:41 2024

https://gitlab.synchro.net/main/sbbs/-/merge_requests/460#note_5650

Another example where the description looks bad when viewing file info without removing/replacing the cursor positioning codes:
![image](/uploads/dfb8d22258149582dce3f8c3e72cc5cc/image.png)

The same when the cursor position codes are removed/replaced: ![image](/uploads/6ecfea63d8ad5207eb6c87c1994e5470/image.png)
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Eric Oulashin@1:103/705 to GitLab note in main/sbbs on Mon Sep 16 11:09:43 2024

https://gitlab.synchro.net/main/sbbs/-/merge_requests/460#note_5651

avpack23.zip without this fix:

![image](/uploads/de284e36c816897743d63656ecae0ee2/image.png)

avpack23.zip with this fix:

![image](/uploads/94130a1e57e25be01cddf0d91b559728/image.png)
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Sep 16 12:14:39 2024

https://gitlab.synchro.net/main/sbbs/-/merge_requests/460#note_5652

Most of the Ctrl-A codes being stripped in this change should not actually exist in an extended description in the first place. So it just kind of looks like extra code/compares added for no reason.

Replacing a conditional new-line sequence with nothing (blank string), doesn't seem like the correct thing to do either.

All that said, I'll merge the change, but I expect you'll still have some problems with some imported/converted ANSI descriptions with this change.
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Eric Oulashin@1:103/705 to GitLab note in main/sbbs on Mon Sep 16 12:42:48 2024

https://gitlab.synchro.net/main/sbbs/-/merge_requests/460#note_5654

When using an ANSI terminal, it will replace a conditional newline with an actual newline. Only when displaying the short (1-line) descriptions, with extended descriptions turned off, will it replace the conditional newline with nothing.
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Sep 16 12:54:58 2024

https://gitlab.synchro.net/main/sbbs/-/merge_requests/460#note_5655

Are you actually seeing Ctrl-A codes in short (1-line) descriptions? You should not.
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Eric Oulashin@1:103/705 to GitLab note in main/sbbs on Mon Sep 16 13:34:35 2024

https://gitlab.synchro.net/main/sbbs/-/merge_requests/460#note_5690

I haven't done a thorough check. My concern was that if a file is imported (by addfiles with -diz), it might take the first line of the diz for the short 1-line description, and if some of these diz files have cursor control codes, the control codes could potentially be anywhere in the diz. I'm not sure if addfiles takes the first line of a diz for the short description though.
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Sep 16 15:35:13 2024

https://gitlab.synchro.net/main/sbbs/-/merge_requests/460#note_5693

File descriptions should never have Ctrl-A codes in them - they are stripped during import.
--- SBBSecho 3.20-Linux
* Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)

Who's Online
Recent Visitors
- Gwylbert
  Fri Nov 22 02:56:09 2024
  from Sydney, Nsw via Telnet
- Bob Worm
  Thu Nov 21 21:56:17 2024
  from Wales, Uk via Telnet
- Bob Worm
  Thu Nov 21 16:39:47 2024
  from Wales, Uk via Telnet
- Bob Worm
  Thu Nov 21 09:51:19 2024
  from Wales, Uk via Telnet
- Gwylbert
  Thu Nov 21 03:23:36 2024
  from Sydney, Nsw via Telnet
- Paul Ryan
  Wed Nov 20 22:14:07 2024
  from Mansfield, Nottinghamshire via Telnet
- Paul Ryan
  Wed Nov 20 21:46:23 2024
  from Mansfield, Nottinghamshire via Telnet
- Paul Ryan
  Wed Nov 20 21:32:50 2024
  from Mansfield, Nottinghamshire via Telnet

System Info

Sysop:	Keyop
Location:	Huddersfield, West Yorkshire, UK
Users:	368
Nodes:	16 (2 / 14)
Uptime:	53:23:25
Calls:	7,887
Calls today:	1
Files:	12,962
Messages:	5,788,777

DDFileLister: When displaying a file description, remove/replace curso

Who's Online

Recent Visitors

System Info