1. Forum
  2. FidoNet
  3. GOLDED

  • Final update

    From Nicholas Boel@1:154/10 to All on Sun Oct 22 17:54:56 2023
    Hello All,

    I believe I have it narrowed down a bit.

    I started over, and re-cloned the repo..

    "make BUILD=minimal" gives the previous error(s) reported.
    "make" by itself, works.

    Not only is the compile failing, but it seems to be trying to compile (some?) things that the BUILD=minimal option is supposed to prevent from building. Maybe this is assisting in the reason as to why the compilation is failing?

    Either way, it's up and running without that option.

    Regards,
    Nick

    ... "Take my advice, I don't use it anyway."
    --- GoldED+/LNX 1.1.5-b20231021
    * Origin: thePharcyde_ distribution system (Wisconsin) (1:154/10)
  • From Alan Ianson@1:153/757.2 to Nicholas Boel on Sun Oct 22 16:54:44 2023
    Hello Nicholas,

    I started over, and re-cloned the repo..

    "make BUILD=minimal" gives the previous error(s) reported.
    "make" by itself, works.

    This command works for me although my last build produced a binary sized at 1,436,104 bytes and my fresh build (using it now) is 2,018,112 bytes.

    I always remove the -DCFG_NO_MYSPELL line from Config.def so I get hunspell support in a minimal build.

    I don't know what the reason for that is but a minimal build does work for me here. I am using gcc 13.2.0.

    Not only is the compile failing, but it seems to be trying to compile (some?) things that the BUILD=minimal option is supposed to prevent
    from building. Maybe this is assisting in the reason as to why the compilation is failing?

    I suspect you are on to something here.

    Ttyl :-),
    Al

    ... Help! I've fallen and can't reach my beer!
    --- GoldED+/LNX 1.1.5-b20231021
    * Origin: The Rusty MailBox - Penticton, BC Canada (1:153/757.2)
  • From Alan Ianson@1:153/757.2 to Nicholas Boel on Sun Oct 22 17:08:02 2023
    Hello Nicholas,

    This command works for me although my last build produced a binary
    sized at 1,436,104 bytes and my fresh build (using it now) is
    2,018,112 bytes.

    I get those file sizes after running make strip.

    Ttyl :-),
    Al

    ... Beep. Invalid Input. I take only cash.
    --- GoldED+/LNX 1.1.5-b20231021
    * Origin: The Rusty MailBox - Penticton, BC Canada (1:153/757.2)
  • From Tommi Koivula@2:221/6 to Nicholas Boel on Mon Oct 23 08:25:20 2023
    Hi Nicholas.

    22 Oct 23 17:54, you wrote to All:

    "make BUILD=minimal" gives the previous error(s) reported.
    "make" by itself, works.

    I tried with "make BUILD=minimal" and it indeed gives me those errors too.

    'Tommi

    --- GoldED+/LNX 1.1.5-b20231021
    * Origin: nntps://news.fidonet.fi (2:221/6)
  • From Vitaliy Aksyonov@1:104/117 to Tommi Koivula on Mon Oct 23 07:01:36 2023
    Hello Tommi.

    23 Oct 23 08:25, you wrote to Nicholas Boel:

    "make BUILD=minimal" gives the previous error(s) reported.
    "make" by itself, works.
    I tried with "make BUILD=minimal" and it indeed gives me those errors
    too.

    Thanks for feedback. I'll check what's wrong with minimal build. I've never tried it.

    Vitaliy

    --- GoldED+/LNX 1.1.5-b20231021
    * Origin: Aurora, Colorado (1:104/117)
  • From Nicholas Boel@1:154/10 to Tommi Koivula on Mon Oct 23 16:36:50 2023
    Hello Tommi,

    On Mon Oct 23 2023 08:25:20, you wrote to me:

    "make BUILD=minimal" gives the previous error(s) reported.
    "make" by itself, works.

    I tried with "make BUILD=minimal" and it indeed gives me those errors
    too.

    Thank you for confirming!

    Regards,
    Nick

    ... "Take my advice, I don't use it anyway."
    --- GoldED+/LNX 1.1.5-b20231021
    * Origin: thePharcyde_ distribution system (Wisconsin) (1:154/10)
  • From Nicholas Boel@1:154/10 to Vitaliy Aksyonov on Mon Oct 23 16:37:14 2023
    Hello Vitaliy,

    On Mon Oct 23 2023 07:01:36, you wrote to Tommi Koivula:

    "make BUILD=minimal" gives the previous error(s) reported.
    "make" by itself, works.
    I tried with "make BUILD=minimal" and it indeed gives me those
    errors too.

    Thanks for feedback. I'll check what's wrong with minimal build. I've never tried it.

    Thank you for looking into it, Vitaliy!

    Regards,
    Nick

    ... "Take my advice, I don't use it anyway."
    --- GoldED+/LNX 1.1.5-b20231021
    * Origin: thePharcyde_ distribution system (Wisconsin) (1:154/10)
  • From Vitaliy Aksyonov@1:104/117 to Nicholas Boel on Mon Oct 23 18:27:56 2023
    Hello Nicholas.

    23 Oct 23 16:37, you wrote to me:

    "make BUILD=minimal" gives the previous error(s) reported.
    "make" by itself, works.
    I tried with "make BUILD=minimal" and it indeed gives me those
    errors too.
    Thanks for feedback. I'll check what's wrong with minimal build.
    I've never tried it.
    Thank you for looking into it, Vitaliy!

    I broke it, I fix it. :) Thanks for the logs. Fix is already on review, will be there soon.

    I just can't test all possible combinations. I'm already checking builds in Linux, Windows, using MSVC 6, 2005, GCC, clang, with C++98, etc. Now I have something else to check - minimal build.

    Vitaliy

    --- GoldED+/LNX 1.1.5-b20231021
    * Origin: Aurora, Colorado (1:104/117)
  • From Vitaliy Aksyonov@1:104/117 to Nicholas Boel on Tue Oct 24 14:08:32 2023
    Привет, Nicholas!

    23 Oct 23 16:37, ты писал(а) мне:

    "make BUILD=minimal" gives the previous error(s) reported.
    "make" by itself, works.
    I tried with "make BUILD=minimal" and it indeed gives me those
    errors too.
    Thanks for feedback. I'll check what's wrong with minimal build.
    I've never tried it.
    Thank you for looking into it, Vitaliy!

    It's fixed and pushed to main repo. Latest changes add better spell checking support if you'd like to use it.

    Best regards,
    Vitaliy Aksyonov.

    --- GoldED+/LNX 1.1.5-b20231021
    * Origin: Aurora, Colorado (1:104/117)
  • From Nicholas Boel@1:154/10 to Vitaliy Aksyonov on Tue Oct 24 17:00:44 2023
    Hello Vitaliy,

    On Mon Oct 23 2023 18:27:56, you wrote to me:

    I broke it, I fix it. :) Thanks for the logs. Fix is already on
    review, will be there soon.

    I just can't test all possible combinations. I'm already checking
    builds in Linux, Windows, using MSVC 6, 2005, GCC, clang, with C++98,
    etc. Now I have something else to check - minimal build.

    If it helps any, I don't care about any other builds besides Linux. ;)

    (Just a joke)

    Regards,
    Nick

    ... "Take my advice, I don't use it anyway."
    --- GoldED+/LNX 1.1.5-b20231021
    * Origin: thePharcyde_ distribution system (Wisconsin) (1:154/10)
  • From Nicholas Boel@1:154/10 to Vitaliy Aksyonov on Tue Oct 24 17:03:46 2023
    Hello Vitaliy,

    On Tue Oct 24 2023 14:08:32, you wrote to me:

    It's fixed and pushed to main repo. Latest changes add better spell checking support if you'd like to use it.

    Thank you!

    Is spell checking support only when using the internal editor?

    Regards,
    Nick

    ... "Take my advice, I don't use it anyway."
    --- GoldED+/LNX 1.1.5-b20231021
    * Origin: thePharcyde_ distribution system (Wisconsin) (1:154/10)
  • From Nicholas Boel@1:154/10 to Vitaliy Aksyonov on Tue Oct 24 17:47:46 2023
    Hello Vitaliy,

    On Tue Oct 24 2023 14:08:32, you wrote to me:

    It's fixed and pushed to main repo. Latest changes add better spell checking support if you'd like to use it.

    It now compiles with 'BUILD=minimal', and the executable is quite a bit smaller than just running 'make', so I'm guessing it's doing it's job. Thanks again!

    Regards,
    Nick

    ... "Take my advice, I don't use it anyway."
    --- GoldED+/LNX 1.1.5-b20231021
    * Origin: thePharcyde_ distribution system (Wisconsin) (1:154/10)
  • From Vitaliy Aksyonov@1:104/117 to Nicholas Boel on Tue Oct 24 17:13:58 2023
    Привет, Nicholas!

    24 Oct 23 17:03, ты писал(а) мне:

    It's fixed and pushed to main repo. Latest changes add better
    spell checking support if you'd like to use it.

    Thank you!

    Is spell checking support only when using the internal editor?

    Yes. It's only for internal editor. And it's not included in minimal build. And you need to configure it first.

    Best regards,
    Vitaliy Aksyonov.

    --- GoldED+/LNX 1.1.5-b20231021
    * Origin: Aurora, Colorado (1:104/117)