https://gitlab.synchro.net/main/sbbs/-/commit/3f17c245f7a2e514826e9a26
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Don't modify useron.misc during logon, even for AUTOTERM

We shouldn't need to set any of the autoterm flags in useron.misc these days (term_supports() checks autoterm when appropriate).

Try this Nelgin.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/88cef39afc51baf131c5a41f
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Beautification of the previous commit

And don't store the autoterm flags in useron.misc even when correcting a manual-PETSCII configuration.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f5fed0b229e70b79a5ebb330
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Fix access-control by terminal cap issue introduced a week ago

In commit 3f17c245, I was addressing the issue reported by Nelgin via IRC: <nelgin> If you login using a term that doesn't support ansi, it changes your settings - can you set 'em back when done?
<DigitalMan> if you have auto-term enabled, it doesn't actually change your settings, just what's in use during that session
<nelgin> I logged in using my BBC emulator which doesn't do ansi, then when I logged in through syncterm, I got the display like it was on the BBC. All my characters replaced with #'s and stuff.
<nelgin> I had to go back into the user menu to fix it. That is going to confuse users.

However, the chk_ar() function in userdat.c which is used to populate JS objects (e.g. xtrn_area.sec_list[].prog_list[]) uses the user.misc value (cannot call term_supports()), so the current user terminal flags need to be reflected in user.misc always. So the real fix for the originally reported problem is to clear the charset-related terminal settings when logging in with auto-terminal settings enabled (and before the auto-detected charset flags are OR'd in).

I toyed with the idea of storing a copy of the term_supports() result in client_t, which is passed to chk_ar() when appropriate, but decided that was a bit overkill and there were issues with servers that don't have term_supports (e.g. the web server) and properly populating access-controlled areas in the JS object model (e.g. door games that require ANSI). Better to use the last-auto-detected terminal caps than assuming "no" terminal capabilities in that scenario.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c0ef762adf57ff91307c3015
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Remove defunct files from batch download queue during logon

If a user doesn't have access to download a file that's in their batch queue, remove it without saying anything to the user (but log a notice-level message about it) during logon. Files that no longer exist in the filebase are treated the same way.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/8266da9c329d2ba49ff2001c
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Log an error if getstats() returns a failure

I saw my logon.jsonl file getting cycled multiple times a day recently on Vert and suspect this function call may have been failing.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e12c35049251dc97e8eafd7c
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Revert "Log an error if getstats() returns a failure"

This reverts commit 8266da9c329d2ba49ff2001cf542a0d05dc9987e.

We're already passing a sock_init callback (ls_cb) which is supposed to set
the socket options (call set_socket_options), so this change shouldn't be necessary and reportedly caused more issues binding ircd sockets when running ircd.js via jsexec (though I didn't see this myself).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/46f1f80e75b30d477cdb419c
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Revert "Revert "Log an error if getstats() returns a failure""

This reverts commit e12c35049251dc97e8eafd7c7fc12dfd9ba13ad9.

Wrong commit reverted. Oops.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/65f1df280bc72439e80b8a9f
Modified Files:
src/sbbs3/logon.cpp
Log Message:
A todo comment

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/cbf6a8b24c615e753801dbd2
Modified Files:
src/sbbs3/logon.cpp
Log Message:
I'm not sure what "node message indices" (data/msgs/*.ixb files) are/were

I don't recall this actually being a thing, ever, so certainly no reason to
be cleaning these files up during logon. <shrug>

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f315f34ce2c8b91e656fc5a4
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Change "On two nodes" to "On more than one node", since it's possible it's > 2

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/9544a3c6bf36555a2babc6bb
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Don't send NodeLoggedOn message to any nodes if user isn't being logged-on

If user is being kicked off for being on "More than one node at a time", then don't send a message to other any other nodes that the user logged-on successfully (they haven't). Previosuly, it'd send messages to all the lower-numbered nodes that were in-use (but not by the same user).

Reported by Nelgin.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 logon.cpp 1.77 1.78
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv24782

Modified Files:
logon.cpp
Log Message:
Use safe string operations. No functional change.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

src/sbbs3 logon.cpp 1.78 1.79
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv23090

Modified Files:
logon.cpp
Log Message:
Revert commit 1.61 from Aug-2015, use the documented behavior of the
"Use Location in User List" option. When set to false, the user's *note* (not IP address) is to be included in the user/logon lists.


---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/67edda7341b4d9a6a978eb69
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Automatically switch back from PETSCII to ANSI mode

If the user's terminal was auto-detected as being ANSI, yet they had their account settings manually-overridden to use PETSCII, automatically switch
back to auto-terminal mode (e.g. with ANSI).

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/34d46c3ef247966350809b53
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Don't force password-changes for users with blank passwords (e.g. Guest)

Wow. This is another one of those "forever bugs".

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

Re: src/sbbs3/logon.cpp
By: Rob Swindell to Git commit to sbbs/master on Thu Sep 24 2020 10:08 pm

https://gitlab.synchro.net/sbbs/sbbs/-/commit/34d46c3ef247966350809b53 Modified Files:
src/sbbs3/logon.cpp
Log Message:
Don't force password-changes for users with blank passwords (e.g. Guest)

Wow. This is another one of those "forever bugs".

aw man, i liked that one
---
þ Synchronet þ ::: BBSES.info - free BBS services :::

https://gitlab.synchro.net/sbbs/sbbs/-/commit/0a785fa5677d43760fbbad7a
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Fix birth month check during logon.

New bug, reported by Melkor (STARFRON).

---
ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/733ddc699d4b6c1a1ead869b
Modified Files:
src/sbbs3/logon.cpp
Log Message:
If all waiting-mail has been read, don't default to "Yes" read mail

Count the read mail-waiting and compare to the total mail-waiting and if they're the same, then default to "No" for the "Read Your Mail Now" prompt during logon.

Also, pass the difference (the unread mail) to the LiMailWaiting logon-info line.

As requested by altere via I.R.C.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/721b6a54ebb9f0bf357b67dc
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Fix inverted logic of noyes() prompt in previous commit.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c345c6ad034f1e64db2b88de
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Clear the Guest user's language (lang) field during logon - revert to default

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/3bcf61744225d8898eae6a00
Modified Files:
src/sbbs3/logon.cpp
Log Message:
Always close csts.ini file, even in error path (failure to open dsts.ini)

Fix for CID 509720

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net