Hi,

On Fri, Sep 29, 2017 at 03:25:12AM +0000, Chen-Yu Tsai wrote:

+#include "axp81x.dtsi"
+
+&reg_aldo1 {
+ regulator-always-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-name = "vcc18-csi2-dsi-efuse-hdmi-d4dp";
+};

I'm not really fond of these names. It's easy to miss some components (especially since we most of the time don't have the schematics), and
if it's not complete, the obscure name isn't worth it either.

What about vcc-1.8 for this one ?

+&reg_aldo2 {
+ regulator-always-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-name = "vdd-drampll-vcc18-pll-adc-cpvdd-ldoin";
+};

dram-pll?

+&reg_aldo3 {
+ regulator-always-on;
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3000000>;
+ regulator-name = "vcc-pl-avcc";
+};

avcc?

etc..

status = "disabled";
};

+&reg_vcc3v3 {
+ status = "disabled";
+};
+
&reg_vcc5v0 {
status = "disabled";
};

Why not simply remove the DTSI then?

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-----BEGIN PGP SIGNATURE-----

iQIcBAEBAgAGBQJZ0mglAAoJEBx+YmzsjxAgX7gQALPm1HSkqxE3dZbziH48L1Om nBNBGSoXHgy+++W0E6jNBFnlXgrmKK8zewN1g8xlqAzAkMrTRDyag4WUOxK6I/tn EYGT5HGblJO9cSz5wmh7728sE2t48iNdF5FtPNy13jEkxAAAq9ePFn0zuADrpc1x cqTFZxcgpuFgSGWckgVHuLtswaUFXBR77/INf/Fs87q7N9vNgoQTsv9SuGPmXrkT qxgrbkzeYXVDi9IKA+nQHRmnGuph2ymukF65UTedYF8b++n7Gnh1baaOZH7hUlZs oP2qeAimzRDdwpsYotstrYYeWoLVh1aJ2n8ftjojYwQHKRp2HyHC6YCJpI3nI3Te nF4DRzdi+bQfOeH23MfI4XgH43LRapUfj+F28CuFxjKD/5bZZ5VtlTA2YiQZYhgS voq0Edg9Bkk89kjOtFFxZ5pqmObbMqEf2l5xNxLjkhZGchTMVtlHv9oWkfU90nJT dpqen89JT2K281CnArkFzNnbSbzUWtkGBFwNg8HoDUMLEYONk1u9vowUiRxxjQFu O8LJHWqhChAhpbFcEPGnZ5AlKYqQ+iI7xhAwteT+RD/POkruyszU7b6EM4LdpnQ5 UT8grPCkE4UvDhL3cMi/fGbCuEJ2vRcPbbaznp1+q3d9XuDQvMPXRBYb6NefDzS8 6cYYkYVZx/ueuBd2Z6R9
=g6dE
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)