• [PATCH] mm/migrate: fix indexing bug (off by one) and avoid out of boun

    From =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse@21:1/5 to All on Mon Oct 2 22:50:07 2017
    From: Mark Hairgrove <mhairgrove@nvidia.com>

    Index was incremented before last use and thus the second array
    could dereference to an invalid address (not mentioning the fact
    that it did not properly clear the entry we intended to clear).

    Signed-off-by: Mark Hairgrove <mhairgrove@nvidia.com>
    Signed-off-by: Jérôme Glisse <jglisse@redhat.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    ---
    mm/migrate.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/mm/migrate.c b/mm/migrate.c
    index 6954c14..e00814c 100644
    --- a/mm/migrate.c
    +++ b/mm/migrate.c
    @@ -2146,8 +2146,9 @@ static int migrate_vma_collect_hole(unsigned long start,
    unsigned long addr;

    for (addr = start & PAGE_MASK; addr < end; addr += PAGE_SIZE) {
    - migrate->src[migrate->npages++] = MIGRATE_PFN_MIGRATE;
    + migrate->src[migrate->npages] = MIGRATE_PFN_MIGRATE;
    migrate->dst[migrate->npages] = 0;
    + migrate->npages++;
    migrate->cpages++;
    }

    --
    2.4.11

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)