1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • [gentoo-dev] [PATCH 1/2] linux-mod.eclass: drop unnecessary IUSE="kerne

    From Sam James@21:1/5 to All on Tue Jan 4 11:30:03 2022
    It's already an implicit IUSE, so we don't need this.

    Signed-off-by: Sam James <sam@gentoo.org>
    ---
    eclass/linux-mod.eclass | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/eclass/linux-mod.eclass b/eclass/linux-mod.eclass
    index 9f4ae64f6b55..496b9c98b526 100644
    --- a/eclass/linux-mod.eclass
    +++ b/eclass/linux-mod.eclass
    @@ -1,4 +1,4 @@
    -# Copyright 1999-2021 Gentoo Authors
    +# Copyright 1999-2022 Gentoo Authors
    # Distributed under the terms of the GNU General Public License v2

    # @ECLASS: linux-mod.eclass
    @@ -170,7 +170,7 @@ esac
    0) die "EAPI=${EAPI} is not supported with MODULES_OPTIONAL_USE_IUSE_DEFAULT due to lack of IUSE defaults" ;;
    esac

    -IUSE="kernel_linux dist-kernel
    +IUSE="dist-kernel
    ${MODULES_OPTIONAL_USE:+${_modules_optional_use_iuse_default}}${MODULES_OPTIONAL_USE}"
    SLOT="0"
    RDEPEND="
    --
    2.34.1

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Mike Gilbert@21:1/5 to sam@gentoo.org on Tue Jan 4 17:20:02 2022
    On Tue, Jan 4, 2022 at 5:23 AM Sam James <sam@gentoo.org> wrote:

    It's already an implicit IUSE, so we don't need this.

    I think it is better to declare it explicitly rather than relying on
    the IUSE_IMPLICIT setting in profiles.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?=@21:1/5 to Mike Gilbert on Tue Jan 4 23:00:01 2022
    On Tue, 2022-01-04 at 11:17 -0500, Mike Gilbert wrote:
    On Tue, Jan 4, 2022 at 5:23 AM Sam James <sam@gentoo.org> wrote:

    It's already an implicit IUSE, so we don't need this.

    I think it is better to declare it explicitly rather than relying on
    the IUSE_IMPLICIT setting in profiles.

    I agree. Perhaps we should go even further and remove them from
    implicit flags.

    --
    Best regards,
    Michał Górny

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sam James@21:1/5 to All on Wed Jan 5 00:00:01 2022
    On 4 Jan 2022, at 21:54, Michał Górny <mgorny@gentoo.org> wrote:

    On Tue, 2022-01-04 at 11:17 -0500, Mike Gilbert wrote:
    On Tue, Jan 4, 2022 at 5:23 AM Sam James <sam@gentoo.org> wrote:

    It's already an implicit IUSE, so we don't need this.

    I think it is better to declare it explicitly rather than relying on
    the IUSE_IMPLICIT setting in profiles.

    I agree. Perhaps we should go even further and remove them from
    implicit flags.


    (Note: I did push this change already to coalesce this
    with FreeBSD and other removals.)

    I don't think declaring it explicitly is helpful given
    in most cases (and even more now after recent
    cleanups), it's relied upon without declaring it anyway.

    Use within IUSE while it's implicit also means
    IUSE seems to regularly get out of sync with
    actual use within the ebuilds.

    As for removing implicit use entirely: while you might
    argue this could be okay for the Linux kernel, it would cause
    unnecessary rebuilds indefinitely whenever we add a new dep
    to an ebuild for e.g. Darwin, or if we did it for libcs,
    for say, musl/non-glibc.

    best,
    sam

    -----BEGIN PGP SIGNATURE-----

    iQGTBAEBCgB9FiEEYOpPv/uDUzOcqtTy9JIoEO6gSDsFAmHU0FNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDYw RUE0RkJGRkI4MzUzMzM5Q0FBRDRGMkY0OTIyODEwRUVBMDQ4M0IACgkQ9JIoEO6g SDu7TAgAlDEUNLAiBK6+MMxi2KoITE4+UC8vwE9Wz04B3rbNvRLT2AT/B37JikeF iGUmIZljG4ypGTKeobOVWsjP3hPP18Zpuvl0/1koQiBwFs+MYYWfxhuNT+SNZIIT otGxTx6vOQNEl2PQ2ZRmEKKlJZn7n7aia7wn1wNMCkcsDKQ5qPA7ACkI8pbREZ4C Sf0sSrghNi4S4BWaah9q1m/TZAD1JzHN71x0SXsY2VYXoEVaXh6XkGmMXRNLV0To fkBNWx8I0O2RSQ/Q+PusVPPy4SsDxKLFZe41oEusE6MVrvv7uZQ+Yp/aoR9W8s9X 2/SuuNZmQvs7Vhc8qBracwjf9RjyaA==
    =ul8C
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)