• [gentoo-dev] [PATCH] flag-o-matic.eclass: filter-lfs-flags: remove -D_T

    From Mike Gilbert@21:1/5 to All on Sat Dec 18 19:30:02 2021
    glibc only allows _TIME_BITS=64 when _FILE_OFFSET_BITS=64.

    Signed-off-by: Mike Gilbert <floppym@gentoo.org>
    ---
    eclass/flag-o-matic.eclass | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/eclass/flag-o-matic.eclass b/eclass/flag-o-matic.eclass
    index d262a60b6bb..32119cb9a52 100644
    --- a/eclass/flag-o-matic.eclass
    +++ b/eclass/flag-o-matic.eclass
    @@ -193,7 +193,8 @@ filter-lfs-flags() {
    # _LARGEFILE_SOURCE: enable support for new LFS funcs (ftello/etc...)
    # _LARGEFILE64_SOURCE: enable support for 64bit variants (off64_t/fseeko64/etc...)
    # _FILE_OFFSET_BITS: default to 64bit variants (off_t is defined as off64_t)
    - filter-flags -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
    + # _TIME_BITS: default to 64bit time_t (requires _FILE_OFFSET_BITS=64)
    + filter-flags -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_TIME_BITS=64
    }

    # @FUNCTION: filter-ldflags
    --
    2.34.1

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sam James@21:1/5 to All on Sat Dec 18 22:40:01 2021
    --Apple-Mail=_F4A22CA9-B7B5-4518-87A3-F368388C7F7D
    Content-Transfer-Encoding: quoted-printable
    Content-Type: text/plain;
    charset=us-ascii



    On 18 Dec 2021, at 18:27, Mike Gilbert <floppym@gentoo.org <mailto:floppym@gentoo.org>> wrote:

    glibc only allows _TIME_BITS=64 when _FILE_OFFSET_BITS=64.

    Signed-off-by: Mike Gilbert <floppym@gentoo.org <mailto:floppym@gentoo.org>> ---
    eclass/flag-o-matic.eclass | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/eclass/flag-o-matic.eclass b/eclass/flag-o-matic.eclass
    index d262a60b6bb..32119cb9a52 100644
    --- a/eclass/flag-o-matic.eclass
    +++ b/eclass/flag-o-matic.eclass
    @@ -193,7 +193,8 @@ filter-lfs-flags() {
    # _LARGEFILE_SOURCE: enable support for new LFS funcs (ftello/etc...)
    # _LARGEFILE64_SOURCE: enable support for 64bit variants (off64_t/fseeko64/etc...)
    # _FILE_OFFSET_BITS: default to 64bit variants (off_t is defined as off64_t)
    - filter-flags -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
    + # _TIME_BITS: default to 64bit time_t (requires _FILE_OFFSET_BITS=64)
    + filter-flags -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_TIME_BITS=64
    }

    # @FUNCTION: filter-ldflags
    --
    2.34.1




    LGTM and please go ahead so we can move forward with our planning for this (see https://wiki.gentoo.org/wiki/Project:Toolchain/time64_migration <https://wiki.gentoo.org/wiki/Project:Toolchain/time64_migration> for others).

    Best,
    sam

    --Apple-Mail=_F4A22CA9-B7B5-4518-87A3-F368388C7F7D
    Content-Transfer-Encoding: quoted-printable
    Content-Type: text/html;
    charset=us-ascii

    <html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""
    <div class="">On 18 Dec 2021, at 18:27, Mike Gilbert &lt;<a href="mailto:floppym@gentoo.org" class="">floppym@gentoo.org</a>&gt; wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">glibc only allows _TIME_BITS=64 when _FILE_
    OFFSET_BITS=64.<br class=""><br class="">Signed-off-by: Mike Gilbert &lt;<a href="mailto:floppym@gentoo.org" class="">floppym@gentoo.org</a>&gt;<br class="">---<br class=""> eclass/flag-o-matic.eclass | 3 ++-<br class=""> 1 file changed, 2 insertions(+),
    1 deletion(-)<br class=""><br class="">diff --git a/eclass/flag-o-matic.eclass b/eclass/flag-o-matic.eclass<br class="">index d262a60b6bb..32119cb9a52 100644<br class="">--- a/eclass/flag-o-matic.eclass<br class="">+++ b/eclass/flag-o-matic.eclass<br
    class="">@@ -193,7 +193,8 @@ filter-lfs-flags() {<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span># _LARGEFILE_SOURCE: enable support for new LFS funcs (ftello/etc...)<br class=""> <span class="Apple-tab-span" style="white-space:
    pre"> </span># _LARGEFILE64_SOURCE: enable support for 64bit variants (off64_t/fseeko64/etc...)<br class=""> <span class="Apple-tab-span" style="white-space:pre"> </span># _FILE_OFFSET_BITS: default to 64bit variants (off_t is defined as off64_t)<br
    class="">-<span class="Apple-tab-span" style="white-space:pre"> </span>filter-flags -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE<br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span># _TIME_BITS: default to 64bit
    time_t (requires _FILE_OFFSET_BITS=64)<br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span>filter-flags -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_TIME_BITS=64<br class=""> }<br class=""><br class=""> # @
    FUNCTION: filter-ldflags<br class="">-- <br class="">2.34.1<br class=""><br class=""><br class=""></div></div></blockquote></div><div class=""><br class=""></div><div class="">LGTM and please go ahead so we can move forward with our planning for this (
    see&nbsp;<a href="https://wiki.gentoo.org/wiki/Project:Toolchain/time64_migration" class="">https://wiki.gentoo.org/wiki/Project:Toolchain/time64_migration</a>&nbsp;for others).</div><div class=""><br class=""></div><div class="">Best,</div><div class="">
    sam</div></body></html>
    --Apple-Mail=_F4A22CA9-B7B5-4518-87A3-F368388C7F7D--

    -----BEGIN PGP SIGNATURE-----

    iQGTBAEBCgB9FiEEYOpPv/uDUzOcqtTy9JIoEO6gSDsFAmG+VMRfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDYw RUE0RkJGRkI4MzUzMzM5Q0FBRDRGMkY0OTIyODEwRUVBMDQ4M0IACgkQ9JIoEO6g SDtynQgAqpLxdkeZxKvoH4eL7Hr/6+h5DRgsZEieqi0kXmQWylLrHjWL0Ulp8O1J ngBxv/+EI06ZFoJNOeDkzxcFI9sSTUK5hGRTvXXkH+MbrXXXhiwSn68tw44Ymysh 1o9oRe1xjJ3zc1S8GyRcsXAK1eVYuCw8YwxQ63ASFD0Zqz/1s84sQiRnv4HtNNdW 1JTqQuWlWIa/Nbjf0FylSWPwwCJ8ApK/yzDUQsMLaVabyv2K+C04yWAcqvmUZiHP 6iOdIDbQLvZHrh/UBJ+tIOdzcu89DIJlvJCsg1zqdJI5eFYWLLUPJlxKysDx5+Du 3TbElUvsbHTe59cZQ/vw+5K/LpgLTw==
    =O9mc
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)