1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • Re: [gentoo-dev] Common options missed in OpenRC declarative scripts an

    From Michael Orlitzky@21:1/5 to Brian Evans on Thu Dec 2 13:40:02 2021
    On 2021-12-01 21:02:20, Brian Evans wrote:
    After a cursory scan of the Gentoo repository, I've noticed an
    overabundance of start_stop_daemon_args being declared in scripts committed.

    I would like to draw attention and see if we can clean these up together.

    A lot of this is covered in the service script guide:

    https://github.com/OpenRC/openrc/blob/master/service-script-guide.md

    There's a 2.5-year old bug to mention it in the devmanual:

    https://bugs.gentoo.org/684354

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Brian Evans@21:1/5 to All on Thu Dec 2 17:20:01 2021
    This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------AXEOmlO6wLrbJs5nLCbkwU0X
    Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64

    T24gMTIvMi8yMDIxIDc6MzQgQU0sIE1pY2hhZWwgT3JsaXR6a3kgd3JvdGU6DQo+IE9uIDIw MjEtMTItMDEgMjE6MDI6MjAsIEJyaWFuIEV2YW5zIHdyb3RlOg0KPj4gQWZ0ZXIgYSBjdXJz b3J5IHNjYW4gb2YgdGhlIEdlbnRvbyByZXBvc2l0b3J5LCBJJ3ZlIG5vdGljZWQgYW4NCj4+ IG92ZXJhYnVuZGFuY2Ugb2Ygc3RhcnRfc3RvcF9kYWVtb25fYXJncyBiZWluZyBkZWNsYXJl ZCBpbiBzY3JpcHRzIGNvbW1pdHRlZC4NCj4+DQo+PiBJIHdvdWxkIGxpa2UgdG8gZHJhdyBh dHRlbnRpb24gYW5kIHNlZSBpZiB3ZSBjYW4gY2xlYW4gdGhlc2UgdXAgdG9nZXRoZXIuDQo+ IA0KPiBBIGxvdCBvZiB0aGlzIGlzIGNvdmVyZWQgaW4gdGhlIHNlcnZpY2Ugc2NyaXB0IGd1 aWRlOg0KPiANCj4gICAgaHR0cHM6Ly9naXRodWIuY29tL09wZW5SQy9vcGVucmMvYmxvYi9t YXN0ZXIvc2VydmljZS1zY3JpcHQtZ3VpZGUubWQNCj4gDQo+IFRoZXJlJ3MgYSAyLjUteWVh ciBvbGQgYnVnIHRvIG1lbnRpb24gaXQgaW4gdGhlIGRldm1hbnVhbDoNCj4gDQo+ICAgIGh0 dHBzOi8vYnVncy5nZW50b28ub3JnLzY4NDM1NA0KPiANCkZvciBzdXJlLCB0aGVyZSBhcmUg c2V2ZXJhbCBwb2ludHMgdGhhdCBkb2N1bWVudCBjb3ZlcnMgdGhhdCBhcmUgDQpyZWl0ZXJh dGVkIGhlcmUuDQoNCkhvd2V2ZXIgc29tZSB2YXJpYWJsZSBvcHRpb25zIGFyZSBub3QgY292 ZXJlZCB0aGVyZS4gIFRoZXkgZG8gZXhpc3QgaW4gDQp0aGUgb3BlbnJjLXJ1biBtYW51YWwu DQoNCk15IG1haW4gcG9pbnQgaXMgaG93IHRvIGJlc3QgdXNlIHRoZXNlIG9wdGlvbnMgYW5k IHRoYXQgc29tZSBzY3JpcHRzIGFyZSANCm5vdCB0YWtpbmcgZnVsbCBhZHZhbnRhZ2UuDQoN CkJyaWFuDQo=

    --------------AXEOmlO6wLrbJs5nLCbkwU0X--

    -----BEGIN PGP SIGNATURE-----

    wsF5BAABCAAjFiEEZsLkTtkOMnWOfVXA0feB7/n0o7YFAmGo8Z4FAwAAAAAACgkQ0feB7/n0o7Yx 1w/6A0p7VG2UUaAaAKbW3EHUo3b8/b38+prCfSCvZ3EpJ65VvXxqrV+Vob9hKmJ9BdPuha9Yom1d RhgHeA+Bt1fNLnTvGEH6Z4FOeYKUDJgndeaznxyv1uJc05HQFIz3aNoWHq51fJ02eO4rSQWocI4b raKfLUFX0Qg2en98Zps5Nsenx4/0rq5HLlc5gtF9ZnmcFBPt8IiAEXFlD/bvnPe12VySuw5tiN0H 56pQVDEh6PZvtPdwNOFXqeQgPKaY3qq4NdVCPz74hlAViLwgvlKPDzMXjtmCm9RHRllIspUVvJVQ tRf2+VEw9Az0/fQzqSN88dKO4pJK65AMVULYnWcjOE/n2mEtu97m3eQxs0e9UqH+PSDja52GDW1P GsjR/t0awxEWw6thfujfIuw5lm5Qfvzv7nNDyF78WJNbhZiWizyu2ak6s1vgjmRU9ijYY+3m6lk3 QcJmxhVze3bi2YIrzqTVgLJ0ZnEHBGyS81IJqTbECmKCvL9G2oLCrii04sHZkgXetMyOlTGYw6+p jd8lb8K4CfnFKPRrEoAiz0JzvzioFLeRJwTajmyt/8ug0ZxHCX+8Oye3+NIJfsRm0Q91RQqZo7IW mR6Zcxq5W6cd2EUYryehUgkavQri15eRdK8iywN77mlnBLl3+Rx6XytJKkgqL+RKNRxTk70LBgeh b7o=
    =9MjC
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Alec Warner@21:1/5 to mjo@gentoo.org on Thu Dec 2 17:20:02 2021
    On Thu, Dec 2, 2021 at 4:34 AM Michael Orlitzky <mjo@gentoo.org> wrote:

    On 2021-12-01 21:02:20, Brian Evans wrote:
    After a cursory scan of the Gentoo repository, I've noticed an overabundance of start_stop_daemon_args being declared in scripts committed.

    I would like to draw attention and see if we can clean these up together.

    A lot of this is covered in the service script guide:

    https://github.com/OpenRC/openrc/blob/master/service-script-guide.md

    There's a 2.5-year old bug to mention it in the devmanual:

    https://bugs.gentoo.org/684354


    Can we automate any of it? Emit QA warnings? etc.

    -A

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Michael Orlitzky@21:1/5 to Alec Warner on Thu Dec 2 19:10:01 2021
    On 2021-12-02 08:12:55, Alec Warner wrote:

    Can we automate any of it? Emit QA warnings? etc.


    I would love to be proven wrong, but I don't think so. We have two
    main problems. First, The service scripts are POSIX sh, which is
    better than bash, but still can't easily be parsed for semantic
    information.

    Second, if the daemon is "special," then the service script is
    justified in being similarly unconventional. Unusual runtime behavior
    can't be statically detected, and I doubt that the well-behaved
    portion of daemons in the tree is large enough that we can warn about
    every script that smells a little bit fishy.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Marc Schiffbauer@21:1/5 to All on Fri Dec 3 10:50:02 2021
    * Michael Orlitzky schrieb am 02.12.21 um 08:05 Uhr:
    On 2021-12-02 08:12:55, Alec Warner wrote:

    Can we automate any of it? Emit QA warnings? etc.


    I would love to be proven wrong, but I don't think so. We have two
    main problems. First, The service scripts are POSIX sh, which is
    better than bash, but still can't easily be parsed for semantic
    information.

    Second, if the daemon is "special," then the service script is
    justified in being similarly unconventional. Unusual runtime behavior
    can't be statically detected, and I doubt that the well-behaved
    portion of daemons in the tree is large enough that we can warn about
    every script that smells a little bit fishy.

    For "special" daemons, the ebuild could just set a QA_* variable to
    silence a qa warning if required.

    -Marc

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)