• [gentoo-dev] [PATCH] go-module.eclass: Add GO_OPTIONAL flag

    From Florian Schmaus@21:1/5 to All on Sun Nov 21 12:00:01 2021
    Following the pattern found in other eclasses, add GO_OPTIONAL to the
    go-module eclass. This allows to inherit the eclass without pulling
    its dependencies. See, e.g., bug #775779 for the motivation.

    Signed-off-by: Florian Schmaus <flow@gentoo.org>
    ---
    eclass/go-module.eclass | 31 ++++++++++++++++++++++---------
    1 file changed, 22 insertions(+), 9 deletions(-)

    diff --git a/eclass/go-module.eclass b/eclass/go-module.eclass
    index 3ad8542a28ae..c9eb90ac62ea 100644
    --- a/eclass/go-module.eclass
    +++ b/eclass/go-module.eclass
    @@ -1,4 +1,4 @@
    -# Copyright 2019-2020 Gentoo Authors
    +# Copyright 2019-2021 Gentoo Authors
    # Distributed under the terms of the GNU General Public License v2

    # @ECLASS: go-module.eclass
    @@ -55,13 +55,17 @@ if [[ -z ${_GO_MODULE} ]]; then

    _GO_MODULE=1

    -BDEPEND=">=dev-lang/go-1.12"
    +if [[ ! ${GO_OPTIONAL} ]]; then
    + BDEPEND=">=dev-lang/go-1.12"

    -# Workaround for pkgcheck false positive: https://github.com/pkgcore/pkgcheck/issues/214
    -# MissingUnpackerDep: version ...: missing BDEPEND="app-arch/unzip"
    -# Added here rather than to each affected package, so it can be cleaned up just
    -# once when pkgcheck is improved.
    -BDEPEND+=" app-arch/unzip"
    + # Workaround for pkgcheck false positive: https://github.co
  • From Zac Medico@21:1/5 to All on Sun Nov 28 20:30:02 2021
    To: flow@gentoo.org (Florian Schmaus)
    To: williamh@gentoo.org

    This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------c40z3EGFhkr6f4rNs7MXBRJw
    Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64

    T24gMTEvMjEvMjEgMDI6NTcsIEZsb3JpYW4gU2NobWF1cyB3cm90ZToNCj4gRm9sbG93aW5n IHRoZSBwYXR0ZXJuIGZvdW5kIGluIG90aGVyIGVjbGFzc2VzLCBhZGQgR09fT1BUSU9OQUwg dG8gdGhlDQo+IGdvLW1vZHVsZSBlY2xhc3MuIFRoaXMgYWxsb3dzIHRvIGluaGVyaXQgdGhl IGVjbGFzcyB3aXRob3V0IHB1bGxpbmcNCj4gaXRzIGRlcGVuZGVuY2llcy4gU2VlLCBlLmcu LCBidWcgIzc3NTc3OSBmb3IgdGhlIG1vdGl2YXRpb24uDQo+IA0KPiBTaWduZWQtb2ZmLWJ5 OiBGbG9yaWFuIFNjaG1hdXMgPGZsb3dAZ2VudG9vLm9yZz4NCj4gLS0tDQo+ICAgZWNsYXNz L2dvLW1vZHVsZS5lY2xhc3MgfCAzMSArKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0t DQo+ICAgMSBmaWxlIGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0p DQo+IA0KPiBkaWZmIC0tZ2l0IGEvZWNsYXNzL2dvLW1vZHVsZS5lY2xhc3MgYi9lY2xhc3Mv Z28tbW9kdWxlLmVjbGFzcw0KPiBpbmRleCAzYWQ4NTQyYTI4YWUuLmM5ZWI5MGFjNjJlYSAx MDA2NDQNCj4gLS0tIGEvZWNsYXNzL2dvLW1vZHVsZS5lY2xhc3MNCj4gKysrIGIvZWNsYXNz L2dvLW1vZHVsZS5lY2xhc3MNCj4gQEAgLTEsNCArMSw0IEBADQo+IC0jIENvcHlyaWdodCAy MDE5LTIwMjAgR2VudG9vIEF1dGhvcnMNCj4gKyMgQ29weXJpZ2h0IDIwMTktMjAyMSBHZW50 b28gQXV0aG9ycw0KPiAgICMgRGlzdHJpYnV0ZWQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBH TlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSB2Mg0KPiAgIA0KPiAgICMgQEVDTEFTUzogZ28t bW9kdWxlLmVjbGFzcw0KPiBAQCAtNTUsMTMgKzU1LDE3IEBAIGlmIFtbIC16ICR7X0dPX01P RFVMRX0gXV07IHRoZW4NCj4gICANCj4gICBfR09fTU9EVUxFPTENCj4gICANCj4gLUJERVBF TkQ9Ij49ZGV2LWxhbmcvZ28tMS4xMiINCj4gK2lmIFtbICEgJHtHT19PUFRJT05BTH0gXV07 IHRoZW4NCj4gKwlCREVQRU5EPSI+PWRldi1sYW5nL2dvLTEuMTIiDQo+ICAgDQo+IC0jIFdv cmthcm91bmQgZm9yIHBrZ2NoZWNrIGZhbHNlIHBvc2l0aXZlOiBodHRwczovL2dpdGh1Yi5j b20vcGtnY29yZS9wa2djaGVjay9pc3N1ZXMvMjE0DQo+IC0jIE1pc3NpbmdVbnBhY2tlckRl cDogdmVyc2lvbiAuLi46IG1pc3NpbmcgQkRFUEVORD0iYXBwLWFyY2gvdW56aXAiDQo+IC0j IEFkZGVkIGhlcmUgcmF0aGVyIHRoYW4gdG8gZWFjaCBhZmZlY3RlZCBwYWNrYWdlLCBzbyBp dCBjYW4gYmUgY2xlYW5lZCB1cCBqdXN0DQo+IC0jIG9uY2Ugd2hlbiBwa2djaGVjayBpcyBp bXByb3ZlZC4NCj4gLUJERVBFTkQrPSIgYXBwLWFyY2gvdW56aXAiDQo+ICsJIyBXb3JrYXJv dW5kIGZvciBwa2djaGVjayBmYWxzZSBwb3NpdGl2ZTogaHR0cHM6Ly9naXRodWIuY29tL3Br Z2NvcmUvcGtnY2hlY2svaXNzdWVzLzIxNA0KPiArCSMgTWlzc2luZ1VucGFja2VyRGVwOiB2 ZXJzaW9uIC4uLjogbWlzc2luZyBCREVQRU5EPSJhcHAtYXJjaC91bnppcCINCj4gKwkjIEFk ZGVkIGhlcmUgcmF0aGVyIHRoYW4gdG8gZWFjaCBhZmZlY3RlZCBwYWNrYWdlLCBzbyBpdCBj YW4gYmUgY2xlYW5lZCB1cCBqdXN0DQo+ICsJIyBvbmNlIHdoZW4gcGtnY2hlY2sgaXMgaW1w cm92ZWQuDQo+ICsJQkRFUEVORCs9IiBhcHAtYXJjaC91bnppcCINCj4gKw0KPiArCUVYUE9S VF9GVU5DVElPTlMgc3JjX3VucGFjaw0KPiArZmkNCj4gICANCj4gICAjIEZvcmNlIGdvIHRv IGJ1aWxkIGluIG1vZHVsZSBtb2RlLg0KPiAgICMgSW4gdGhpcyBtb2RlIHRoZSBHT1BBVEgg ZW52aXJvbm1lbnQgdmFyaWFibGUgaXMgaWdub3JlZC4NCj4gQEAgLTgzLDggKzg3LDYgQEAg UUFfRkxBR1NfSUdOT1JFRD0nLionDQo+ICAgIyBHbyBwYWNrYWdlcyBzaG91bGQgbm90IGJl IHN0cmlwcGVkIHdpdGggc3RyaXAoMSkuDQo+ICAgUkVTVFJJQ1QrPSIgc3RyaXAiDQo+ICAg DQo+IC1FWFBPUlRfRlVOQ1RJT05TIHNyY191bnBhY2sNCj4gLQ0KPiAgICMgQEVDTEFTUy1W QVJJQUJMRTogRUdPX1NVTQ0KPiAgICMgQERFU0NSSVBUSU9OOg0KPiAgICMgVGhpcyBpcyBh biBhcnJheSBiYXNlZCBvbiB0aGUgZ28uc3VtIGNvbnRlbnQgZnJvbSBpbnNpZGUgdGhlIHRh cmdldCBwYWNrYWdlLg0KPiBAQCAtMTQ3LDYgKzE0OSwxNyBAQCBFWFBPUlRfRlVOQ1RJT05T IHNyY191bnBhY2sNCj4gICAjIGRpcmVjdG9yeSBzdHJ1Y3R1cmUuDQo+ICAgZGVjbGFyZSAt QSAtZyBfR09NT0RVTEVfR09TVU1fUkVWRVJTRV9NQVANCj4gICANCj4gKyMgQEVDTEFTUy1W QVJJQUJMRTogR09fT1BUSU9OQUwNCj4gKyMgQERFRkFVTFRfVU5TRVQNCj4gKyMgQFBSRV9J TkhFUklUDQo+ICsjIEBERVNDUklQVElPTjoNCj4gKyMgSWYgc2V0IHRvIGEgbm9uLW51bGwg dmFsdWUgYmVmb3JlIGluaGVyaXQsIHRoZW4gdGhlIEdvIHBhcnQgb2YgdGhlDQo+ICsjIGVi dWlsZCB3aWxsIGJlIGNvbnNpZGVyZWQgb3B0aW9uYWwuIE5vIGRlcGVuZGVuY2llcyB3aWxs IGJlIGFkZGVkIGFuZA0KPiArIyBubyBwaGFzZSBmdW5jdGlvbnMgd2lsbCBiZSBleHBvcnRl ZC4NCj4gKyMNCj4gKyMgSWYgeW91IGVuYWJsZSBHT19PUFRJT05BTCwgeW91IGhhdmUgdG8g c2V0IEJERVBFTkQgb24gPj1kZXYtbGFuZy9nby0xLjEyDQo+ICsjIGZvciB5b3VyIHBhY2th Z2UgYW5kIGNhbGwgZ28tbW9kdWxlX3NyY191bnBhY2sgbWFudWFsbHkuDQo+ICsNCj4gICAj IEBGVU5DVElPTjogZ28tbW9kdWxlX3NldF9nbG9iYWxzDQo+ICAgIyBAREVTQ1JJUFRJT046 DQo+ICAgIyBDb252ZXJ0IHRoZSBpbmZvcm1hdGlvbiBpbiBFR09fU1VNIGZvciBvdGhlciB1 c2FnZSBpbiB0aGUgZWJ1aWxkLg0KPiANCg0KSG93IGFib3V0IGlmIHdlIGFsc28gYWRkIGEg R09fREVQRU5EIHZhcmlhYmxlLCBzbyB0aGF0IGVjbGFzc2hpIA0KY29uc3VtZXJzIGNhbiBk byBzb21ldGhpbmcgbGlrZSBCREVQRU5EPSJnbz8gKCAke0dPX0RFUEVORH0gKSIgPw0KLS0g DQpUaGFua3MsDQpaYWMNCg==

    --------------c40z3EGFhkr6f4rNs7MXBRJw--

    -----BEGIN PGP SIGNATURE-----

    wsF5BAABCAAjFiEE8OgXaltWzqgSupCu0HX7jBBKPSAFAmGj1yQFAwAAAAAACgkQ0HX7jBBKPSB3 uQ/+JX5cufJIxkDZD28kyElxZXJl2UtZkElGZDB6ify9yvVwAojA8OnEeIBkyECxYbj4mNP50fcX jurtAJgaIn0xmsbzahOF3fiP6yQ3kiRoRayCM0AKJEyUGBl7eph4odDcWpB3gjyrmDRq5e4tPj2Y j5yPB2/MQfSB/mTitlKAihg8W3Q4YI1MM1gevwHzGGL78Je6w1R7OZ+9nTBCaxtBdNkmpTyw+pih A3g62AY0pdtvpFy1NxIKg0cmxpBtr2ZD5a4slD1AzQofn1zDj8XNjU7XSOLZ/7qYEyo3fUaCw2z9 jPlIGiWxcy37P+aYfo6RbUESKtgXRa2g17/jPWGqe+6HDITOt9va1pNGFzsN3+XKwUbl+vWS93Sf 1YeztuXD4oeyi/Q024XG20VKeBvttAUxd/MyGadC1Eymy9ifCWhap+GBeAO314wiLT25ia5Scr6M V4O+lxT/0noxrq6kEfXu53nhuJXEh3O1uS7BKHpGmltHLWe4Iy1aSDAxBla9Nf9wvD4fpPM8Lwki 6mnbIWlBsO6OedabmNUV9ZGjgYqVNj3go11QqKyQv2Hh6lgLGIXVD8zIxMsUOqCbv6yoCy16gp2h +1b9ZUO1+x34O+7ZNRz7r5v+iIpeH1Du+DIXWRm7fwK8HK0Mthmaqp92rIbfixiO4u7vsR70iC7C shk=
    =IE8C
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From William Hubbs@21:1/5 to Zac Medico on Sun Nov 28 21:00:02 2021
    On Sun, Nov 28, 2021 at 11:23:16AM -0800, Zac Medico wrote:
    On 11/21/21 02:57, Florian Schmaus wrote:
    Following the pattern found in other eclasses, add GO_OPTIONAL to the go-module eclass. This allows to inherit the eclass without pulling
    its dependencies. See, e.g., bug #775779 for the motivation.

    Signed-off-by: Florian Schmaus <flow@gentoo.org>
    ---
    eclass/go-module.eclass | 31 ++++++++++++++++++++++---------
    1 file changed, 22 insertions(+), 9 deletions(-)

    diff --git a/eclass/go-module.eclass b/eclass/go-module.eclass
    index 3ad8542a28ae..c9eb90ac62ea 100644
    --- a/eclass/go-module.eclass
    +++ b/eclass/go-module.eclass
    @@ -1,4 +1,4 @@
    -# Copyright 2019-2020 Gentoo Authors
    +# Copyright 2019-2021 Gentoo Authors
    # Distributed under the terms of the GNU General Public License v2

    # @ECLASS: go-module.eclass
    @@ -55,13 +55,17 @@ if [[ -z ${_GO_MODULE} ]]; then

    _GO_MODULE=1

    -BDEPEND=">=dev-lang/go-1.12"
    +if [[ ! ${GO_OPTIONAL} ]]; then
    + BDEPEND=">=dev-lang/go-1.12"

    -# Workaround for pkgcheck false positive: https://github.com/pkgcore/pkgcheck/issues/214
    -# MissingUnpackerDep: version ...: missing BDEPEND="app-arch/unzip"
    -# Added here rather than to each affected package, so it can be cleaned up just
    -# once when pkgcheck is improved.
    -BDEPEND+=" app-arch/unzip"
    + # Workaround for pkgcheck false positive: https://github.com/pkgcore/pkgcheck/issues/214
    + # MissingUnpackerDep: version ...: missing BDEPEND="app-arch/unzip"
    + # Added here rather than to each affected package, so it can be cleaned up just
    + # once when pkgcheck is improved.
    + BDEPEND+=" app-arch/unzip"
    +
    + EXPORT_FUNCTIONS src_unpack
    +fi

    # Force go to build in module mode.
    # In this mode the GOPATH environment variable is ignored.
    @@ -83,8 +87,6 @@ QA_FLAGS_IGNORED='.*'
    # Go packages should not be stripped with strip(1).
    RESTRICT+=" strip"

    -EXPORT_FUNCTIONS src_unpack
    -
    # @ECLASS-VARIABLE: EGO_SUM
    # @DESCRIPTION:
    # This is an array based on the go.sum content from inside the target package.
    @@ -147,6 +149,17 @@ EXPORT_FUNCTIONS src_unpack
    # directory structure.
    declare -A -g _GOMODULE_GOSUM_REVERSE_MAP

    +# @ECLASS-VARIABLE: GO_OPTIONAL
    +# @DEFAULT_UNSET
    +# @PRE_INHERIT
    +# @DESCRIPTION:
    +# If set to a non-null value before inherit, then the Go part of the
    +# ebuild will be considered optional. No dependencies will be added and
    +# no phase functions will be exported.
    +#
    +# If you enable GO_OPTIONAL, you have to set BDEPEND on >=dev-lang/go-1.12 +# for your package and call go-module_src_unpack manually.
    +
    # @FUNCTION: go-module_set_globals
    # @DESCRIPTION:
    # Convert the information in EGO_SUM for other usage in the ebuild.


    How about if we also add a GO_DEPEND variable, so that eclasshi
    consumers can do something like BDEPEND="go? ( ${GO_DEPEND} )" ?
    --
    Thanks,
    Zac

    this is on my radar. I haven't read the bug yet, but I'll look at it, if
    not today, sometime this week.

    Without looking at the bug, I'm not sure why you would want to use this
    eclass without depending on dev-lang/go.

    Also, if you have to write src_unpack you can call go-module_setup_proxy
    in src_unpack to set things up.

    William


    -----BEGIN PGP SIGNATURE-----

    iF0EABECAB0WIQTVeuxEZo4uUHOkQAluVBb0MMRlOAUCYaPeAQAKCRBuVBb0MMRl OGdXAJ42JiLDxnFY/O606BIJdHZVOxStegCgmn+w1SL+GlmrCKFSiMqVPMGBGQo=
    =Xa2M
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Alec Warner@21:1/5 to williamh@gentoo.org on Mon Nov 29 05:20:01 2021
    On Sun, Nov 28, 2021 at 11:52 AM William Hubbs <williamh@gentoo.org> wrote:

    On Sun, Nov 28, 2021 at 11:23:16AM -0800, Zac Medico wrote:
    On 11/21/21 02:57, Florian Schmaus wrote:
    Following the pattern found in other eclasses, add GO_OPTIONAL to the go-module eclass. This allows to inherit the eclass without pulling
    its dependencies. See, e.g., bug #775779 for the motivation.

    Signed-off-by: Florian Schmaus <flow@gentoo.org>
    ---
    eclass/go-module.eclass | 31 ++++++++++++++++++++++---------
    1 file changed, 22 insertions(+), 9 deletions(-)

    diff --git a/eclass/go-module.eclass b/eclass/go-module.eclass
    index 3ad8542a28ae..c9eb90ac62ea 100644
    --- a/eclass/go-module.eclass
    +++ b/eclass/go-module.eclass
    @@ -1,4 +1,4 @@
    -# Copyright 2019-2020 Gentoo Authors
    +# Copyright 2019-2021 Gentoo Authors
    # Distributed under the terms of the GNU General Public License v2

    # @ECLASS: go-module.eclass
    @@ -55,13 +55,17 @@ if [[ -z ${_GO_MODULE} ]]; then

    _GO_MODULE=1

    -BDEPEND=">=dev-lang/go-1.12"
    +if [[ ! ${GO_OPTIONAL} ]]; then
    + BDEPEND=">=dev-lang/go-1.12"

    -# Workaround for pkgcheck false positive: https://github.com/pkgcore/pkgcheck/issues/214
    -# MissingUnpackerDep: version ...: missing BDEPEND="app-arch/unzip"
    -# Added here rather than to each affected package, so it can be cleaned up just
    -# once when pkgcheck is improved.
    -BDEPEND+=" app-arch/unzip"
    + # Workaround for pkgcheck false positive: https://github.com/pkgcore/pkgcheck/issues/214
    + # MissingUnpackerDep: version ...: missing BDEPEND="app-arch/unzip"
    + # Added here rather than to each affected package, so it can be cleaned up just
    + # once when pkgcheck is improved.
    + BDEPEND+=" app-arch/unzip"
    +
    + EXPORT_FUNCTIONS src_unpack
    +fi

    # Force go to build in module mode.
    # In this mode the GOPATH environment variable is ignored.
    @@ -83,8 +87,6 @@ QA_FLAGS_IGNORED='.*'
    # Go packages should not be stripped with strip(1).
    RESTRICT+=" strip"

    -EXPORT_FUNCTIONS src_unpack
    -
    # @ECLASS-VARIABLE: EGO_SUM
    # @DESCRIPTION:
    # This is an array based on the go.sum content from inside the target package.
    @@ -147,6 +149,17 @@ EXPORT_FUNCTIONS src_unpack
    # directory structure.
    declare -A -g _GOMODULE_GOSUM_REVERSE_MAP

    +# @ECLASS-VARIABLE: GO_OPTIONAL
    +# @DEFAULT_UNSET
    +# @PRE_INHERIT
    +# @DESCRIPTION:
    +# If set to a non-null value before inherit, then the Go part of the
    +# ebuild will be considered optional. No dependencies will be added and +# no phase functions will be exported.
    +#
    +# If you enable GO_OPTIONAL, you have to set BDEPEND on >=dev-lang/go-1.12
    +# for your package and call go-module_src_unpack manually.
    +
    # @FUNCTION: go-module_set_globals
    # @DESCRIPTION:
    # Convert the information in EGO_SUM for other usage in the ebuild.


    How about if we also add a GO_DEPEND variable, so that eclasshi
    consumers can do something like BDEPEND="go? ( ${GO_DEPEND} )" ?
    --
    Thanks,
    Zac

    this is on my radar. I haven't read the bug yet, but I'll look at it, if
    not today, sometime this week.

    Without looking at the bug, I'm not sure why you would want to use this eclass without depending on dev-lang/go.

    I was going to say "just read the bug" but bugs have been misbehaving
    recently, so I will summarize.

    A package has an optional component that is golang based; users can
    enable the component via a USE flag.
    That component needs the go eclasses to build. While we can have USE
    flag'd components, it's a QA violation to conditionally inherit an
    eclass. This results in packages of this type needed to always inherit
    the golang eclasses; even if the user has not enabled the golang
    functionality.
    The eclass always adds a dep on dev-lang/go (https://gitweb.gentoo.org/repo/gentoo.git/tree/eclass/go-module.eclass)
    This change let's ebuild callers control that golang dep; because it
    should only be added when it's required, not on the eclass inherit.

    You could also do other stuff (like not modify DEPEND in global scope
    in the go eclasses), which is what Zac was suggesting. Many ways to
    skin a cat and all that.

    -A


    Also, if you have to write src_unpack you can call go-module_setup_proxy
    in src_unpack to set things up.

    William


    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sam James@21:1/5 to All on Mon Nov 29 06:00:02 2021
    --Apple-Mail=_F4065935-84FA-4753-999D-0792CBD747DD
    Content-Transfer-Encoding: quoted-printable
    Content-Type: text/plain;
    charset=us-ascii



    On 28 Nov 2021, at 19:23, Zac Medico <zmedico@gentoo.org> wrote:

    [snip]

    How about if we also add a GO_DEPEND variable, so that eclasshi consumers can do something like BDEPEND="go? ( ${GO_DEPEND} )" ?
    --

    My preference is to go with what we've been doing more recently (do _OPTIONAL) so that
    consumers handle things properly and we don't have to try account for various cases
    (this was the problem with eclass variables which add a USE flag or depend only if a USE flag is set).

    But that said, I can't immediately think of any such annoying edge
    cases with this idea. It'd be additional to GO_OPTIONAL and it'd
    ensure a sane baseline Go version is chosen. So, why not?


    --Apple-Mail=_F4065935-84FA-4753-999D-0792CBD747DD
    Content-Transfer-Encoding: quoted-printable
    Content-Type: text/html;
    charset=us-ascii

    <html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""
    <div class="">On 28 Nov 2021, at 19:23, Zac Medico &lt;<a href="mailto:zmedico@gentoo.org" class="">zmedico@gentoo.org</a>&gt; wrote:</div><br class="Apple-interchange-newline"><div class=""><meta charset="UTF-8" class=""><div class="content-isolator__
    container" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space:
    normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;"><blockquote type="cite" class="">[snip]</blockquote><br class="">How about if we also add a GO_DEPEND variable, so that eclasshi consumers can do something like BDEPEND="
    go? ( ${GO_DEPEND} )" ?<br class="">--<span class="Apple-converted-space">&nbsp;</span><br class=""></div></div></blockquote><div><br class=""></div><div>My preference is to go with what we've been doing more recently (do _OPTIONAL) so that</div><div>
    consumers handle things properly and we don't have to try account for various cases</div><div>(this was the problem with eclass variables which add a USE flag or depend only</div><div>if a USE flag is set).</div><div><br class=""></div><div>But that said,
    I can't immediately think of any such annoying edge</div><div>cases with this idea. It'd be additional to GO_OPTIONAL and it'd</div><div>ensure a sane baseline Go version is chosen. So, why not?</div></div><br class=""></body></html>
    --Apple-Mail=_F4065935-84FA-4753-999D-0792CBD747DD--

    -----BEGIN PGP SIGNATURE-----

    iQGTBAEBCgB9FiEEYOpPv/uDUzOcqtTy9JIoEO6gSDsFAmGkXPFfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDYw RUE0RkJGRkI4MzUzMzM5Q0FBRDRGMkY0OTIyODEwRUVBMDQ4M0IACgkQ9JIoEO6g SDvbTwf8DFc1RbF8l4LJeK4lUfUHQA4C52GVS3Uf/7ZTcB/NjdEmZqnVVixojkik NHUR+vkGAWnzao9MX982hdZ7be6nZsMdDRilGIZvEI9QQjCpl9ck0oym/RAJdw94 YQi17+HavKPTin+5BcVx7SyERiaBIo1/eQljInLlamT2ncXyTUrae0MSvb64TaSp WF1BXIHw5rLevfUVbSaeMWi23b09nNywdPJIaBhI4pDLfwx2rXX2WBx/zGSmqR1/ QHpqA4qKhWG6RkaRvz/miBv8hLlG69PZmj+nPttw8A8djvU5aTj7WUudQs/zB3Ef 0iW7mjCRYZ5MbPWp0HTu1m+qEO4+mA==
    =FS7r
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Florian Schmaus@21:1/5 to William Hubbs on Tue Dec 7 21:30:02 2021
    On 28/11/2021 20.52, William Hubbs wrote:
    this is on my radar. I haven't read the bug yet, but I'll look at it, if
    not today, sometime this week.

    Friendly reminder: where are we with that patch?

    - Flow

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From William Hubbs@21:1/5 to All on Sat Dec 11 22:50:02 2021
    This is committed.

    Thanks,

    William

    -----BEGIN PGP SIGNATURE-----

    iF0EABECAB0WIQTVeuxEZo4uUHOkQAluVBb0MMRlOAUCYbUb6wAKCRBuVBb0MMRl ONJVAKCsNRGXopG3BL+8Wuk3lIpFn/QDpgCfRGbLsVbOqmWkk+bNUBlwbxyaxzg=
    =FzvA
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)