1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • Re: [gentoo-dev] [PATCH] vdr-plugin-2.eclass: make qa warning condition

    From Sam James@21:1/5 to Eli Schwartz on Fri May 3 06:40:01 2024
    Eli Schwartz <eschwartz93@gmail.com> writes:

    On 5/1/24 10:10 AM, Martin Dummer wrote:
    Since Agostino's tinderbox tests now report qa warning, the group
    vdr@gentoo.org has 101 open bugs assigned, most of them caused by qa
    warnings from vdr-plugin-2.eclass.

    Many vdr plugins need small adjustments because API or makefile changes
    in upstream media-video/vdr which can be easily fixed with small changes.

    These warnings are only useful for the vdr plugin maintainers, so I
    propose they should (only) be reported as QA-warnings when the global
    variable
        VDR_MAINTAINER_MODE="1"
    is set in make.conf

    This patch is also put to github in
    https://github.com/gentoo/gentoo/pull/36504

    The PR is lacking many many "Closes: ...." tags, which I will fill in soon. >>
    Any comments?


    What does "only useful for the vdr plugin maintainers" mean? Why can't
    anyone fix them?

    There are lots of QA warnings that a package can generate, and lots of
    them are "only" relevant to someone editing the upstream source code.
    Why should vdr plugins be special?

    From a quick glance at the warning messages, my inexpert feeling is that
    two of them are a bit "wishy-washy" and could be classified as "a
    warning to be picky and do best practices":

    - gettext handling
    - old Makefile handling

    The others seem like worrisome issues that should very much be reported
    in tinderboxes and get fixed.

    What we really need is:
    a) https://bugs.gentoo.org/162450 to avoid scaring users;
    b) possibly some level of QA notice to distinguish between "check this
    out" (think e.g. qa-vdb LHS where it _might_ be unused, but not
    necessarily), and "this is definitely wrong"

    I am convinced we need a), I am not-at-all convinced we need b) - at
    least not in terms of whether bugs are reported.


    Automatically sed'ing out source code, especially for the one that says "please recheck", very much looks like the purpose of the qa warning is
    that the functionality isn't trusted to be correct, is offered on a best-effort basis, and needs to be manually reviewed and marked as okay
    (by applying as a real patch) in order to squelch the warnings.

    In other words, there are "QA issues" and "QA nitpicks".

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Martin Dummer@21:1/5 to All on Thu May 9 14:10:01 2024
    This is a multi-part message in MIME format.
    Am 03.05.24 um 06:39 schrieb Sam James:

    What we really need is:
    a)https://bugs.gentoo.org/162450 to avoid scaring users;
    b) possibly some level of QA notice to distinguish between "check this
    out" (think e.g. qa-vdb LHS where it _might_ be unused, but not
    necessarily), and "this is definitely wrong"

    I am convinced we need a), I am not-at-all convinced we need b) - at
    least not in terms of whether bugs are reported.

    AFAIS https://bugs.gentoo.org/162450 is not implemented.

    Maybe we can agree that the qa-warnings in vdr-eclass make more sense if
    i change them to "eawarn" or "einfo"?

    In my opinion, most plugins in the vdr context will practically not
    develop any further anyway. It is more important to keep the current
    status of vdr-software in the ecosystem up to date as well as possible.

    So I need a practical useful approach instead of a fundamental
    discussion please.

    <!DOCTYPE html>
    <html>
    <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
    </head>
    <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">Am 03.05.24 um 06:39 schrieb Sam James:<br>
    </div>
    <blockquote type="cite" cite="mid:87cyq3ldah.fsf@gentoo.org"><br>
    <pre class="moz-quote-pre" wrap="">
    What we really need is:
    a) <a class="moz-txt-link-freetext" href="https://bugs.gentoo.org/162450">https://bugs.gentoo.org/162450</a> to avoid scaring users;
    b) possibly some level of QA notice to distinguish between "check this
    out" (think e.g. qa-vdb LHS where it _might_ be unused, but not
    necessarily), and "this is definitely wrong"

    I am convinced we need a), I am not-at-all convinced we need b) - at
    least not in terms of whether bugs are reported.

    </pre>
    </blockquote>
    <p>AFAIS <span style="white-space: pre-wrap"><a class="moz-txt-link-freetext" href="https://bugs.gentoo.org/162450">https://bugs.gentoo.org/162450</a> is not implemented.</span></p>
    <p _d-id="29576"><span _d-id="30181" class="--l sentence_highlight">Maybe
    we can agree that the qa-warnings in vdr-eclass make more sense
    if i change them to "eawarn" or "einfo"?</span><span
    _d-id="30182" class="--r sentence_highlight"><br _d-id="29578">
    </span></p>
    <p _d-id="29579"><span _d-id="30184"
    class="--l --r sentence_highlight">In my opinion, most plugins
    in the vdr context will practically not develop any further
    anyway. </span><span _d-id="30187"
    class="--l --r sentence_highlight">It is more important to keep
    the current status of vdr-software in the ecosystem up to date
    as well as possible.</span></p>
    <p _d-id="29579"><span _d-id="30187"
    class="--l --r sentence_highlight">So I need a practical useful
    approach instead of a fundamental discussion please.<br>
    </span></p>
    <p></p>
    </body>
    </html>

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sam James@21:1/5 to Martin Dummer on Thu May 9 14:20:01 2024
    Martin Dummer <martin.dummer@gmx.net> writes:

    Am 03.05.24 um 06:39 schrieb Sam James:


    What we really need is:
    a) https://bugs.gentoo.org/162450 to avoid scaring users;
    b) possibly some level of QA notice to distinguish between "check this
    out" (think e.g. qa-vdb LHS where it _might_ be unused, but not
    necessarily), and "this is definitely wrong"

    I am convinced we need a), I am not-at-all convinced we need b) - at
    least not in terms of whether bugs are reported.

    AFAIS https://bugs.gentoo.org/162450 is not implemented.

    Right, that's why I didn't say "we can just use".


    Maybe we can agree that the qa-warnings in vdr-eclass make more sense if i change them to "eawarn" or "einfo"?


    Sure, make them eqawarn.

    In my opinion, most plugins in the vdr context will practically not develop any further anyway. It is more important to
    keep the current status of vdr-software in the ecosystem up to date as well as possible.

    So I need a practical useful approach instead of a fundamental discussion please.

    My point is that the QA warnings should exist, and you can worry about
    making them "developer-only" in future. Right now, they seem useful, and
    the things they flag need to be addressed.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sam James@21:1/5 to Martin Dummer on Thu May 9 15:10:01 2024
    Martin Dummer <martin.dummer@gmx.net> writes:

    Am 09.05.24 um 14:13 schrieb Sam James:

    Martin Dummer <martin.dummer@gmx.net> writes:


    Maybe we can agree that the qa-warnings in vdr-eclass make more sense if i change them to "eawarn" or "einfo"?


    Sure, make them eqawarn.

    Hmm - current state of vdr-plugin-2.eclass is: there are many "eqawarn" in there.


    In my opinion, most plugins in the vdr context will practically not develop any further anyway. It is more
    important to
    keep the current status of vdr-software in the ecosystem up to date as well as possible.

    So I need a practical useful approach instead of a fundamental discussion please.


    My point is that the QA warnings should exist, and you can worry about
    making them "developer-only" in future. Right now, they seem useful, and
    the things they flag need to be addressed.

    Basically yes, but here (vdr-plugins) the qawarn are used more in a way "to remind the plugin developers to adapt their
    sources to newer vdr build environment" or "the way i18n implemented has changed"

    The eclass fixes these problems with standardized quirks, the "equawarn" messages show when these quirks are applied.

    IMHO its not necessary to tell that to any user, only for interested packagers when they are bored and look out for some
    extra work. That's why I made the warnings conditional, printed out when the variable "VDR_MAINTAINTER_MODE" is set to a
    not-empty value.

    Finally, I am interested in an opinion whether this is acceptable or not, otherwise I tend to remove the warnings at all.

    It sounds like maybe you want to turn these into log messages (einfo - https://devmanual.gentoo.org/ebuild-writing/messages/index.html), and
    drop the "QA notice" prefix.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Martin Dummer@21:1/5 to All on Thu May 9 15:10:01 2024
    This is a multi-part message in MIME format.
    Am 09.05.24 um 14:13 schrieb Sam James:
    Martin Dummer<martin.dummer@gmx.net> writes:

    Maybe we can agree that the qa-warnings in vdr-eclass make more sense if i change them to "eawarn" or "einfo"?

    Sure, make them eqawarn.

    Hmm - current state of vdr-plugin-2.eclass is: there are many "eqawarn"
    in there.



    In my opinion, most plugins in the vdr context will practically not develop any further anyway. It is more important to
    keep the current status of vdr-software in the ecosystem up to date as well as possible.

    So I need a practical useful approach instead of a fundamental discussion please.
    My point is that the QA warnings should exist, and you can worry about
    making them "developer-only" in future. Right now, they seem useful, and
    the things they flag need to be addressed.

    Basically yes, but here (vdr-plugins) the qawarn are used more in a way
    "to remind the plugin developers to adapt their sources to newer vdr
    build environment" or "the way i18n implemented has changed"

    The eclass fixes these problems with standardized quirks, the "equawarn" messages show when these quirks are applied.

    IMHO its not necessary to tell that to any user, only for interested
    packagers when they are bored and look out for some extra work. That's
    why I made the warnings conditional, printed out when the variable "VDR_MAINTAINTER_MODE" is set to a not-empty value.

    Finally, I am interested in an opinion whether this is acceptable or
    not, otherwise I tend to remove the warnings at all.

    <!DOCTYPE html>
    <html>
    <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
    </head>
    <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">Am 09.05.24 um 14:13 schrieb Sam James:<br>
    </div>
    <blockquote type="cite" cite="mid:87le4ji3ox.fsf@gentoo.org">
    <pre class="moz-quote-pre" wrap="">Martin Dummer <a class="moz-txt-link-rfc2396E" href="mailto:martin.dummer@gmx.net">&lt;martin.dummer@gmx.net&gt;</a> writes:

    </pre>
    <span style="white-space: pre-wrap">
    </span>
    <blockquote type="cite">
    <pre class="moz-quote-pre" wrap="">
    Maybe we can agree that the qa-warnings in vdr-eclass make more sense if i change them to "eawarn" or "einfo"?

    </pre>
    </blockquote>
    <pre class="moz-quote-pre" wrap="">
    Sure, make them eqawarn.
    </pre>
    </blockquote>
    <p>Hmm - current state of vdr-plugin-2.eclass is: there are many
    "eqawarn" in there.<br>
    </p>
    <p><br>
    </p>
    <p><br>
    </p>
    <blockquote type="cite" cite="mid:87le4ji3ox.fsf@gentoo.org">
    <pre class="moz-quote-pre" wrap="">
    </pre>
    <blockquote type="cite">
    <pre class="moz-quote-pre" wrap="">In my opinion, most plugins in the vdr context will practically not develop any further anyway. It is more important to
    keep the current status of vdr-software in the ecosystem up to date as well as possible.

    So I need a practical useful approach instead of a fundamental discussion please.
    </pre>
    </blockquote>
    <pre class="moz-quote-pre" wrap="">
    My point is that the QA warnings should exist, and you can worry about
    making them "developer-only" in future. Right now, they seem useful, and
    the things they flag need to be addressed.

    </pre>
    </blockquote>
    <p>Basically yes, but here (vdr-plugins) the qawarn are used more in
    a way "to remind the plugin developers to adapt their sources to
    newer vdr build environment" or "the way i18n implemented has
    changed"</p>
    <p>The eclass fixes these problems with standardized quirks, the
    "equawarn" messages show when these quirks are applied.</p>
    <p>IMHO its not necessary to tell that to any user, only for
    interested packagers when they are bored and look out for some
    extra work. That's why I made the warnings conditional, printed
    out when the variable "VDR_MAINTAINTER_MODE" is set to a not-empty
    value.<br>
    </p>
    <p>Finally, I am interested in an opinion whether this is acceptable
    or not, otherwise I tend to remove the warnings at all.<br>
    </p>
    </body>
    </html>

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Martin Dummer@21:1/5 to All on Fri May 10 17:50:01 2024
    This is a multi-part message in MIME format.
    Am 09.05.24 um 15:08 schrieb Sam James:
    It sounds like maybe you want to turn these into log messages (einfo - https://devmanual.gentoo.org/ebuild-writing/messages/index.html), and
    drop the "QA notice" prefix.

    I changed https://github.com/gentoo/gentoo/pull/36504 accordingly and
    added the "Closes:" tags. Can you please review?

    <!DOCTYPE html>
    <html>
    <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
    </head>
    <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">Am 09.05.24 um 15:08 schrieb Sam James:<br>
    </div>
    <blockquote type="cite" cite="mid:87fruri141.fsf@gentoo.org"><span
    style="white-space: pre-wrap">
    </span>
    <pre class="moz-quote-pre" wrap="">It sounds like maybe you want to turn these into log messages (einfo -
    <a class="moz-txt-link-freetext" href="https://devmanual.gentoo.org/ebuild-writing/messages/index.html">https://devmanual.gentoo.org/ebuild-writing/messages/index.html</a>), and
    drop the "QA notice" prefix.

    </pre>
    </blockquote>
    <p>I changed <a class="moz-txt-link-freetext" href="https://github.com/gentoo/gentoo/pull/36504">https://github.com/gentoo/gentoo/pull/36504</a> accordingly
    and added the "Closes:" tags. Can you please review?<br>
    </p>
    </body>
    </html>

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)