On Wed, 01 May 2024, Maciej Barć wrote:
Also no license link. Afaik all contribs are under GPL-2.
The idea is to increase awareness of the AI policy, as well as other
rules, and to inform users before they submit a PR.
Maybe we could consider also adding something along the lines (4
additional positions):
1. I have emerged the package(s) on a Gentoo-based system (be it
"native" or virtualized by means of hardware-based virtualization or
system layer virtualization).
2. I have tested that the package(s) merge inside both the user and net sandbox without violations on a Gentoo-based system.
3. I can assure that the packages would be able to be merged on the currently default Gentoo profile (with or without modifications to USE flags).
4. If manual intervention (beyond "emerge PKG") is required ro complete
the install/update of the package(s) I have explained the steps needed
to be taken in the PR and/or package ebuild(s) and/or Gentoo Wiki.
On Wed, May 01, 2024 at 03:32:21PM +0200, Michał Górny wrote:
The idea is to increase awareness of the AI policy, as well as other
rules, and to inform users before they submit a PR.
Bit mixed feelings about this given checkboxes feel like unnecessary
churn for routine contributors and is semi-redundant with the
Signed-off-by.
I think it's great for first-time/occasional contributors though.
Having a AI-specific checkbox does feel kind of overkill when it won't concern the majority of contributors, albeit given how how hard the whole thing is pushed lately and that we have no real way to verify beside the
user being made aware of it and certifying it...
On Wed, 01 May 2024, Maciej Barć wrote:
Also no license link. Afaik all contribs are under GPL-2.
That's not entirely correct. The files in the licenses/ directory
aren't, and patches in packages' files/ dirs generally follow the
license of their upstream project.
See, so it would help to have a doc that talks about the
irregularities.
On Wed, May 01, 2024 at 03:32:21PM +0200, Michał Górny wrote:
The idea is to increase awareness of the AI policy, as well as other
rules, and to inform users before they submit a PR.
Bit mixed feelings about this given checkboxes feel like unnecessary
churn for routine contributors and is semi-redundant with the
Signed-off-by.
I think it's great for first-time/occasional contributors though.
Having a AI-specific checkbox does feel kind of overkill when it won't concern the majority of contributors, albeit given how how hard the whole thing is pushed lately and that we have no real way to verify beside the
user being made aware of it and certifying it...
On a side-note, I have nothing against having .github in the tree. Just saying given I know not everyone is happy with that.
Signed-off-by: Michał Górny <mgorny@gentoo.org>
---
.github/pull_request_template.md | 12 ++++++++++++
1 file changed, 12 insertions(+)
create mode 100644 .github/pull_request_template.md
The idea is to increase awareness of the AI policy, as well as other
rules, and to inform users before they submit a PR.
Screenshots @ https://github.com/gentoo/gentoo/pull/36503
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
new file mode 100644
index 000000000000..9e6fe061db11
--- /dev/null
+++ b/.github/pull_request_template.md
@@ -0,0 +1,12 @@
+<!-- Please put the pull request description above -->
+
+---
+
+Please check all the boxes that apply:
+
+- [ ] I can submit this contribution in agreement with the [Copyright Policy](https://www.gentoo.org/glep/glep-0076.html#certificate-of-origin).
+- [ ] This contribution has not been created with the assistance of
Natural Language Processing artificial intelligence tools, in
accordance with [AI policy](https://wiki.gentoo.org/wiki/Project:Council/AI_policy).
+- [ ] I have certified the above via adding a `Signed-off-by` line to *every* commit in the pull request.
+- [ ] I have run `pkgcheck scan --commits --net` to check for issues with my commits.
+
+Please note that all boxes must be checked for the pull request to be merged.
Sysop: | Keyop |
---|---|
Location: | Huddersfield, West Yorkshire, UK |
Users: | 403 |
Nodes: | 16 (2 / 14) |
Uptime: | 16:32:52 |
Calls: | 8,482 |
Calls today: | 4 |
Files: | 13,187 |
Messages: | 5,912,899 |