1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • Re: [gentoo-dev] [PATCH 4/4] distutils-r1.eclass: Disable LTO when usin

    From =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?=@21:1/5 to Ulrich Mueller on Wed Jul 12 19:50:01 2023
    On Wed, 2023-07-12 at 19:42 +0200, Ulrich Mueller wrote:
    On Wed, 12 Jul 2023, Michał Górny wrote:

    + if [[ ${_CARGO_ECLASS} ]]; then
    + filter-lto
    + fi

    Testing for an internal variable of another eclass seems less than
    ideal. How about "has cargo ${INHERITED}" instead?


    Sure, as long as it works.

    --
    Best regards,
    Michał Górny

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Ulrich Mueller@21:1/5 to All on Wed Jul 12 19:50:01 2023
    On Wed, 12 Jul 2023, Michał Górny wrote:

    + if [[ ${_CARGO_ECLASS} ]]; then
    + filter-lto
    + fi

    Testing for an internal variable of another eclass seems less than
    ideal. How about "has cargo ${INHERITED}" instead?

    Ulrich

    --=-=-Content-Type: application/pgp-signature; name="signature.asc"

    -----BEGIN PGP SIGNATURE-----

    iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmSu5ggPHHVsbUBnZW50 b28ub3JnAAoJEFGIM1CIQV4uyVwH/22OMBIx6N76gZfvv+CrJTpUBWvxInA/p+YW qac6gPeMB7ErXwZBK0A/SmVWxDRqOQY5HpNROlzB/Wl9HM5YMmSlYqQ6I38WjUyA XkTZEZ4TrKzorUHYNwDW3HxkgqLv0Ka2X0az1dNjJ/hb80gnF8R1xjVZ0zAUeBjh AaKSSjrmtJxrBnQLGWDCDuaMfRlSeZcxYupaLyQkotPSs7Lqe97tm43w5Z2QfhN1 DdIJmU+7RGGKjEm4gwYQaoJXXB4MbO2iefysxqTd/Hwvggi4sPkk+C6RGiRtbQe3 oB0rjw/aM5MqQ1NKXmB2q7viXLF7l0OBEkg7D1HtH5JD0gt7lzEA+
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)