1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • [gentoo-dev] [PATCH 1/3] autotools.eclass: Downgrade eqawarn for renami

    From =?UTF-8?q?Ulrich=20M=C3=BCller?=@21:1/5 to All on Sun May 28 15:20:01 2023
    At this point, almost all upstreams will have switched to configure.ac. Therefore, configure.in is most likely an indication of an inactive
    upstream, and there is no useful way for the ebuild maintainer to
    silence the warning (other than the ebuild renaming the file).

    Keep the message as einfo, so there is still an indication that the file
    was renamed.

    Bug: https://bugs.gentoo.org/426262
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>
    ---
    eclass/autotools.eclass | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/eclass/autotools.eclass b/eclass/autotools.eclass
    index 91046b9f82f3..3a040b863eea 100644
    --- a/eclass/autotools.eclass
    +++ b/eclass/autotools.eclass
    @@ -400,7 +400,7 @@ eautoconf() {
    *)
    # Move configure file to the new location only on newer EAPIs to ensure
    # checks are done rather than retroactively breaking ebuilds.
    - eqawarn "Moving configure.in to configure.ac (bug #426262)"
    + einfo "Moving configure.in to configure.ac (bug #426262)"
    mv configure.{in,ac} || die
    ;;
    esac
    --
    2.40.1

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From =?UTF-8?q?Ulrich=20M=C3=BCller?=@21:1/5 to All on Sun May 28 15:20:01 2023
    Running them in src_unpack made sense only in EAPIs 0 and 1.

    Fixes: 18fda95cea306efe8009d1100195225acd8f8756
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>
    ---
    eclass/autotools.eclass | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/eclass/autotools.eclass b/eclass/autotools.eclass
    index 3a040b863eea..7b94efc225fe 100644
    --- a/eclass/autotools.eclass
    +++ b/eclass/autotools.eclass
    @@ -560,7 +560,7 @@ autotools_run_tool() {
    shift
    done

    - if [[ ${EBUILD_PHASE_FUNC} != "src_unpack" && ${EBUILD_PHASE_FUNC} != "src_prepare" ]] ; then
    + if [[ ${EBUILD_PHASE_FUNC} != "src_prepare" ]] ; then
    eqawarn "Running '${1}' in ${EBUILD_PHASE_FUNC} phase"
    fi

    --
    2.40.1

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sam James@21:1/5 to ulm@gentoo.org on Sun May 28 15:40:01 2023
    Ulrich Müller <ulm@gentoo.org> writes:

    Running them in src_unpack made sense only in EAPIs 0 and 1.

    Fixes: 18fda95cea306efe8009d1100195225acd8f8756
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

    ok for all


    --=-=-Content-Type: application/pgp-signature; name="signature.asc"

    -----BEGIN PGP SIGNATURE-----

    iOUEARYKAI0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCZHNZS18UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MA8cc2FtQGdlbnRv by5vcmcACgkQc4QJ9SDfkZAVZQEA1sAG4IuothEYVGVOMOU9QhPA7dKV12gQLOZA 7WxHizgBAISbA+ZIaedWLYEWweBt5op2miKqEWB+w73L4ymRjsQI
    =ta5J
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sam James@21:1/5 to ulm@gentoo.org on Sun May 28 15:40:01 2023
    Ulrich Müller <ulm@gentoo.org> writes:

    At this point, almost all upstreams will have switched to configure.ac. Therefore, configure.in is most likely an indication of an inactive
    upstream, and there is no useful way for the ebuild maintainer to
    silence the warning (other than the ebuild renaming the file).

    Ionen's point was that such packages therefore regularly get updates
    so a QA warning when rarely revbumping it isn't necessarily a problem either.

    But I also don't think it's likely that upstream will ever actually
    enforce this, so OK.


    Keep the message as einfo, so there is still an indication that the file
    was renamed.

    Bug: https://bugs.gentoo.org/426262
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>
    ---
    eclass/autotools.eclass | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/eclass/autotools.eclass b/eclass/autotools.eclass
    index 91046b9f82f3..3a040b863eea 100644
    --- a/eclass/autotools.eclass
    +++ b/eclass/autotools.eclass
    @@ -400,7 +400,7 @@ eautoconf() {
    *)
    # Move configure file to the new location only on newer EAPIs to ensure
    # checks are done rather than retroactively breaking ebuilds.
    - eqawarn "Moving configure.in to configure.ac (bug #426262)"
    + einfo "Moving configure.in to configure.ac (bug #426262)"
    mv configure.{in,ac} || die
    ;;
    esac


    --=-=-Content-Type: application/pgp-signature; name="signature.asc"

    -----BEGIN PGP SIGNATURE-----

    iOUEARYKAI0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCZHNZLl8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MA8cc2FtQGdlbnRv by5vcmcACgkQc4QJ9SDfkZDq2gEA8dTeUnTEl281waGV+pXD+DzCG1OTK0J/71wd 0C9+dMQBAL+8wczac5P278ZNV1eW99RAO+IbNUA7AUko+s4q4VEP
    =+sgZ
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Pacho Ramos@21:1/5 to All on Sun May 28 15:50:01 2023
    RWwgZG9tLCAyOC0wNS0yMDIzIGEgbGFzIDE1OjE2ICswMjAwLCBVbHJpY2ggTcO8bGxlciBlc2Ny aWJpw7M6Cj4gQXQgdGhpcyBwb2ludCwgYWxtb3N0IGFsbCB1cHN0cmVhbXMgd2lsbCBoYXZlIHN3 aXRjaGVkIHRvCj4gY29uZmlndXJlLmFjLgo+IFRoZXJlZm9yZSwgY29uZmlndXJlLmluIGlzIG1v c3QgbGlrZWx5IGFuIGluZGljYXRpb24gb2YgYW4gaW5hY3RpdmUKPiB1cHN0cmVhbSwgYW5kIHRo ZXJlIGlzIG5vIHVzZWZ1bCB3YXkgZm9yIHRoZSBlYnVpbGQgbWFpbnRhaW5lciB0bwo+IHNpbGVu Y2UgdGhlIHdhcm5pbmcgKG90aGVyIHRoYW4gdGhlIGVidWlsZCByZW5hbWluZyB0aGUgZmlsZSku Cj4gCj4gS2VlcCB0aGUgbWVzc2FnZSBhcyBlaW5mbywgc28gdGhlcmUgaXMgc3RpbGwgYW4gaW5k aWNhdGlvbiB0aGF0IHRoZQo+IGZpbGUKPiB3YXMgcmVuYW1lZC4KPiAKPiBCdWc6IGh0dHBzOi8v YnVncy5nZW50b28ub3JnLzQyNjI2Mgo+IFNpZ25lZC1vZmYtYnk6IFVscmljaCBNw7xsbGVyIDx1 bG1AZ2VudG9vLm9yZz4KPiAtLS0KPiDCoGVjbGFzcy9hdXRvdG9vbHMuZWNsYXNzIHwgMiArLQo+ IMKgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2VjbGFzcy9hdXRvdG9vbHMuZWNsYXNzIGIvZWNsYXNzL2F1dG90b29scy5lY2xh c3MKPiBpbmRleCA5MTA0NmI5ZjgyZjMuLjNhMDQwYjg2M2VlYSAxMDA2NDQKPiAtLS0gYS9lY2xh c3MvYXV0b3Rvb2xzLmVjbGFzcwo+ICsrKyBiL2VjbGFzcy9hdXRvdG9vbHMuZWNsYXNzCj4gQEAg LTQwMCw3ICs0MDAsNyBAQCBlYXV0b2NvbmYoKSB7Cj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAqKQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAjIE1vdmUgY29uZmlndXJlIGZpbGUgdG8gdGhlIG5ldwo+IGxv Y2F0aW9uIG9ubHkgb24gbmV3ZXIgRUFQSXMgdG8gZW5zdXJlCj4gwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCMgY2hlY2tzIGFy ZSBkb25lIHJhdGhlciB0aGFuCj4gcmV0cm9hY3RpdmVseSBicmVha2luZyBlYnVpbGRzLgo+IC3C oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoGVxYXdhcm4gIk1vdmluZyBjb25maWd1cmUuaW4gdG8KPiBjb25maWd1cmUuYWMgKGJ1ZyAj NDI2MjYyKSIKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqBlaW5mbyAiTW92aW5nIGNvbmZpZ3VyZS5pbiB0bwo+IGNvbmZpZ3Vy ZS5hYyAoYnVnICM0MjYyNjIpIgo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBtdiBjb25maWd1cmUue2luLGFjfSB8fCBkaWUK PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqA7Owo+IMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgZXNhYwoKTEdUTQoKVGhhbmtzIQo=


    -----BEGIN PGP SIGNATURE-----

    iQEzBAABCAAdFiEE808Ng0g83FMNupoifLEMIH/AfbwFAmRzWtsACgkQfLEMIH/A fbxxaAgAjRfpN60fnrFcSeOCTSm9ups35wt8Jcl2VOnH6eJ+ZtEOnA2aBMHx6QSp VjpTSXspRUP/v3spbOT7fM/Ct4c/3fwehYfljfuQ4igRi6P041pqC7O1Nd3wKWLG kAm63/nCVJPoet/rishaU3HwCxbXsxweojp9a3Wqm1dEjh7OXvjNON5UvgUVyFVu ev7s8zSY7UxItPTQwdh9Ywm+DvHzpu09eBS5tQC3LPQAythUn5bF+fNx0y0Kj/yg 0uT/yl4b8F8agpQWnBjHK2pLLzr6b0NAhpBNPBoG3mQQ5qiQ4WSrgHWleBUpu+7V 8X4hTTg8/PFzC92+zWHqRngGqqLCHQ==
    =Aufz
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)