• [gentoo-dev] [PATCH 1/4] toolchain-autoconf.eclass: Add option to disab

    From =?UTF-8?q?Arsen=20Arsenovi=C4=87?=@21:1/5 to All on Sun Mar 26 22:40:02 2023
    Closes: https://bugs.gentoo.org/902461
    Signed-off-by: Arsen Arsenović <arsen@gentoo.org>
    ---
    eclass/toolchain-autoconf.eclass | 46 +++++++++++++++++++++++++++++---
    1 file changed, 43 insertions(+), 3 deletions(-)

    diff --git a/eclass/toolchain-autoconf.eclass b/eclass/toolchain-autoconf.eclass
    index 2ba27638468e..140ee4c9b5eb 100644
    --- a/eclass/toolchain-autoconf.eclass
    +++ b/eclass/toolchain-autoconf.eclass
    @@ -1,4 +1,4 @@
    -# Copyright 1999-2022 Gentoo Authors
    +# Copyright 1999-2023 Gentoo Authors
    # Distributed under the terms of the GNU General Public License v2

    # @ECLASS: toolchain-autoconf.eclass
    @@ -18,6 +18,20 @@ esac
    if [[ -z ${_TOOLCHAIN_AUTOCONF_ECLASS} ]]; then
    _TOOLCHAIN_AUTOCONF_ECLASS=1

    +# @ECLASS_VARIABLE: TC_AUTOCONF_BREAK_INFOS
    +# @DESCRIPTION:
    +# Enables slotting logic on the installed info pages. This includes
    +# mangling the pages in order to include a version number. Empty by
    +# default, and only exists for existing ebuild revisions to use. Set
    +# to a non-empty value to enable.
    +# @DEPRECATED: none
    +: "${TC_AUTOCONF_BREAK_INFOS:=}"
    +
    +#
  • From =?UTF-8?q?Arsen=20Arsenovi=C4=87?=@21:1/5 to All on Sun Mar 26 22:40:01 2023
    This commit replaces the Info page slotting mechanism with simple
    INFOPATH setting.

    Closes: https://bugs.gentoo.org/902461
    Signed-off-by: Arsen Arsenović <arsen@gentoo.org>
    ---
    sys-devel/automake/automake-1.11.6-r4.ebuild | 84 +++++++++++++
    sys-devel/automake/automake-1.16.5-r1.ebuild | 119 +++++++++++++++++++
    sys-devel/automake/automake-9999.ebuild | 48 +++-----
    3 files changed, 220 insertions(+), 31 deletions(-)
    create mode 100644 sys-devel/automake/automake-1.11.6-r4.ebuild
    create mode 100644 sys-devel/automake/automake-1.16.5-r1.ebuild

    diff --git a/sys-devel/automake/automake-1.11.6-r4.ebuild b/sys-devel/automake/automake-1.11.6-r4.ebuild
    new file mode 100644
    index 000000000000..4e0857012d71
    --- /dev/null
    +++ b/sys-devel/automake/automake-1.11.6-r4.ebuild
    @@ -0,0 +1,84 @@
    +# Copyright 1999-2023 Gentoo Authors
    +# Distributed under the terms of the GNU General Public License v2
    +
    +EAPI=7
    +
    +DESCRIPTION="Used to generate Makefile.in from Makefile.am" +HOMEPAGE="https://www.gnu.org/software/automake/" +SRC_URI="mirror://gnu/${PN}/${P}.tar.xz"
    +
    +LICENSE="GPL-2"
    +# Use Gentoo versioning for slotting.
    +SLOT="${PV:0:4}"
    +KEYWORDS="~alpha ~amd
  • From =?UTF-8?q?Arsen=20Arsenovi=C4=87?=@21:1/5 to All on Sun Mar 26 22:40:01 2023
    Closes: https://bugs.gentoo.org/902461
    Signed-off-by: Arsen Arsenović <arsen@gentoo.org>
    ---
    sys-devel/autoconf/autoconf-2.13-r8.ebuild | 59 +++++++++++++++
    sys-devel/autoconf/autoconf-2.69-r9.ebuild | 63 ++++++++++++++++
    sys-devel/autoconf/autoconf-2.71-r6.ebuild | 88 ++++++++++++++++++++++
    3 files changed, 210 insertions(+)
    create mode 100644 sys-devel/autoconf/autoconf-2.13-r8.ebuild
    create mode 100644 sys-devel/autoconf/autoconf-2.69-r9.ebuild
    create mode 100644 sys-devel/autoconf/autoconf-2.71-r6.ebuild

    diff --git a/sys-devel/autoconf/autoconf-2.13-r8.ebuild b/sys-devel/autoconf/autoconf-2.13-r8.ebuild
    new file mode 100644
    index 000000000000..69156d4abf78
    --- /dev/null
    +++ b/sys-devel/autoconf/autoconf-2.13-r8.ebuild
    @@ -0,0 +1,59 @@
    +# Copyright 1999-2023 Gentoo Authors
    +# Distributed under the terms of the GNU General Public License v2
    +
    +EAPI=7
    +
    +inherit toolchain-autoconf
    +
    +DESCRIPTION="Used to create autoconfiguration files" +HOMEPAGE="https://www.gnu.org/software/autoconf/autoconf.html" +SRC_URI="mirror://gnu/${PN}/${P}.tar.gz"
    +
    +LICENSE="GPL-2"
    +S
  • From Florian Schmaus@21:1/5 to All on Mon Mar 27 10:40:02 2023
    On 26/03/2023 22.30, Arsen Arsenović wrote:
    This commit replaces the Info page slotting mechanism with simple
    INFOPATH setting.

    Closes: https://bugs.gentoo.org/902461
    Signed-off-by: Arsen Arsenović <arsen@gentoo.org>
    ---
    sys-devel/automake/automake-1.11.6-r4.ebuild | 84 +++++++++++++
    sys-devel/automake/automake-1.16.5-r1.ebuild | 119 +++++++++++++++++++
    sys-devel/automake/automake-9999.ebuild | 48 +++-----
    3 files changed, 220 insertions(+), 31 deletions(-)
    create mode 100644 sys-devel/automake/automake-1.11.6-r4.ebuild
    create mode 100644 sys-devel/automake/automake-1.16.5-r1.ebuild

    diff --git a/sys-devel/automake/automake-1.11.6-r4.ebuild b/sys-devel/automake/automake-1.11.6-r4.ebuild
    new file mode 100644
    index 000000000000..4e0857012d71
    --- /dev/null
    +++ b/sys-devel/automake/automake-1.11.6-r4.ebuild
    @@ -0,0 +1,84 @@
    +# Copyright 1999-2023 Gentoo Authors
    +# Distributed under the terms of the GNU General Public License v2
    +
    +EAPI=7
    +
    +DESCRIPTION="Used to generate Makefile.in from Makefile.am" +HOMEPAGE="https://www.gnu.org/software/automake/" +SRC_URI="mirror://gnu/${PN}/${P}.tar.xz"
    +
    +LICENSE="GPL-2"
    +# Use Gentoo versioning for slotting.
    +SLOT="${PV:0:4}"
    +KEYWORDS="~alpha ~amd64 ~arm ~arm64 ~hppa ~ia64 ~m68k ~mips ~ppc ~ppc64 ~riscv ~s390 ~sparc ~x86"
    +IUSE=""
    +RESTRICT="test"
    +
    +RDEPEND=">=dev-lang/perl-5.6
    + >=sys-devel/automake-wrapper-10
    + >=sys-devel/autoconf-2.69:*
    + sys-devel/gnuconfig"
    +DEPEND="${RDEPEND}
    + sys-apps/help2man"
    +BDEPEND="app-arch/gzip"
    +
    +PATCHES=(
    + "${FILESDIR}"/${PN}-1.10-perl-5.16.patch #424453
    + "${FILESDIR}"/${PN}-1.11-install-sh-avoid-low-risk-race-in-tmp.patch
    + "${FILESDIR}"/${PN}-1.13-perl-escape-curly-bracket-r1.patch
    +)
    +
    +src_prepare() {
    + default
    + export WANT_AUTOCONF=2.5
    + export HELP2MAN=true
    + sed -i -e "/APIVERSION=/s:=.*:=${SLOT}:" configure || die
    + export TZ="UTC" #589138
    +}
    +
    +src_compile() {
    + # Also used in install.
    + infopath="${EPREFIX}/usr/share/automake-${PV}/info"

    Not sure if we have a style policy on this, but I read lowercase
    variables as local-function variables. However, 'infopath', as is, is
    used in a subsequent ebuild phase function. So maybe
    s/infopath/INFOPATH/ or maybe even MY_INFOPATH or AUTOMAKE_INFOPATH?

    - Flow

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Florian Schmaus@21:1/5 to All on Mon Mar 27 10:40:01 2023
    On 26/03/2023 22.30, Arsen Arsenović wrote:
    Closes: https://bugs.gentoo.org/902461
    Signed-off-by: Arsen Arsenović <arsen@gentoo.org>
    ---
    eclass/toolchain-autoconf.eclass | 46 +++++++++++++++++++++++++++++---
    1 file changed, 43 insertions(+), 3 deletions(-)

    diff --git a/eclass/toolchain-autoconf.eclass b/eclass/toolchain-autoconf.eclass
    index 2ba27638468e..140ee4c9b5eb 100644
    --- a/eclass/toolchain-autoconf.eclass
    +++ b/eclass/toolchain-autoconf.eclass
    @@ -1,4 +1,4 @@
    -# Copyright 1999-2022 Gentoo Authors
    +# Copyright 1999-2023 Gentoo Authors
    # Distributed under the terms of the GNU General Public License v2

    # @ECLASS: toolchain-autoconf.eclass
    @@ -18,6 +18,20 @@ esac
    if [[ -z ${_TOOLCHAIN_AUTOCONF_ECLASS} ]]; then
    _TOOLCHAIN_AUTOCONF_ECLASS=1

    +# @ECLASS_VARIABLE: TC_AUTOCONF_BREAK_INFOS
    +# @DESCRIPTION:
    +# Enables slotting logic on the installed info pages. This includes
    +# mangling the pages in order to include a version number. Empty by
    +# default, and only exists for existing ebuild revisions to use. Set

    Referring to "existing ebuild revisions" becomes confusing in the
    future, when there are existing ebuilds that do not use this variable.

    Maybe "and only set by legacy ebuilds to phase out the broken slotting
    logic. New ebuilds should not set this variable."

    - Flow

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Arsen =?utf-8?Q?Arsenovi=C4=87?=@21:1/5 to Florian Schmaus on Mon Mar 27 12:00:01 2023
    Hi Florian,

    Florian Schmaus <flow@gentoo.org> writes:

    On 26/03/2023 22.30, Arsen Arsenović wrote:
    Closes: https://bugs.gentoo.org/902461
    Signed-off-by: Arsen Arsenović <arsen@gentoo.org>
    ---
    eclass/toolchain-autoconf.eclass | 46 +++++++++++++++++++++++++++++---
    1 file changed, 43 insertions(+), 3 deletions(-)
    diff --git a/eclass/toolchain-autoconf.eclass
    b/eclass/toolchain-autoconf.eclass
    index 2ba27638468e..140ee4c9b5eb 100644
    --- a/eclass/toolchain-autoconf.eclass
    +++ b/eclass/toolchain-autoconf.eclass
    @@ -1,4 +1,4 @@
    -# Copyright 1999-2022 Gentoo Authors
    +# Copyright 1999-2023 Gentoo Authors
    # Distributed under the terms of the GNU General Public License v2
    # @ECLASS: toolchain-autoconf.eclass
    @@ -18,6 +18,20 @@ esac
    if [[ -z ${_TOOLCHAIN_AUTOCONF_ECLASS} ]]; then
    _TOOLCHAIN_AUTOCONF_ECLASS=1
    +# @ECLASS_VARIABLE: TC_AUTOCONF_BREAK_INFOS
    +# @DESCRIPTION:
    +# Enables slotting logic on the installed info pages. This includes
    +# mangling the pages in order to include a version number. Empty by
    +# default, and only exists for existing ebuild revisions to use. Set

    Referring to "existing ebuild revisions" becomes confusing in the future, when
    there are existing ebuilds that do not use this variable.

    My intention was that this variable goes away as soon as said revisions
    are out of tree, so I wasn't thinking about that time-frame but I'll
    clarify and push to my branch.

    Thanks, have a lovely day.

    Maybe "and only set by legacy ebuilds to phase out the broken slotting
    logic. New ebuilds should not set this variable."

    - Flow


    --
    Arsen Arsenović

    --=-=-Content-Type: application/pgp-signature; name="signature.asc"

    -----BEGIN PGP SIGNATURE-----

    iOcEARYKAI8WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZCFn4V8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxEcYXJzZW5AZ2Vu dG9vLm9yZwAKCRBSwpQwHqLEk1RSAP99FnytTgc+eUwEo5gt/1cMPa8qJCApTq6B Vc8bUwL5dAD/XpOu+qvnQPXG4vx8QTeyda0hWM23nFq6CtRpEEWK0gI=lvw6
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Arsen =?utf-8?Q?Arsenovi=C4=87?=@21:1/5 to Florian Schmaus on Mon Mar 27 12:00:01 2023
    Florian Schmaus <flow@gentoo.org> writes:

    On 26/03/2023 22.30, Arsen Arsenović wrote:
    This commit replaces the Info page slotting mechanism with simple
    INFOPATH setting.
    Closes: https://bugs.gentoo.org/902461
    Signed-off-by: Arsen Arsenović <arsen@gentoo.org>
    ---
    sys-devel/automake/automake-1.11.6-r4.ebuild | 84 +++++++++++++
    sys-devel/automake/automake-1.16.5-r1.ebuild | 119 +++++++++++++++++++
    sys-devel/automake/automake-9999.ebuild | 48 +++-----
    3 files changed, 220 insertions(+), 31 deletions(-)
    create mode 100644 sys-devel/automake/automake-1.11.6-r4.ebuild
    create mode 100644 sys-devel/automake/automake-1.16.5-r1.ebuild
    diff --git a/sys-devel/automake/automake-1.11.6-r4.ebuild
    b/sys-devel/automake/automake-1.11.6-r4.ebuild
    new file mode 100644
    index 000000000000..4e0857012d71
    --- /dev/null
    +++ b/sys-devel/automake/automake-1.11.6-r4.ebuild
    @@ -0,0 +1,84 @@
    +# Copyright 1999-2023 Gentoo Authors
    +# Distributed under the terms of the GNU General Public License v2
    +
    +EAPI=7
    +
    +DESCRIPTION="Used to generate Makefile.in from Makefile.am"
    +HOMEPAGE="https://www.gnu.org/software/automake/"
    +SRC_URI="mirror://gnu/${PN}/${P}.tar.xz"
    +
    +LICENSE="GPL-2"
    +# Use Gentoo versioning for slotting.
    +SLOT="${PV:0:4}"
    +KEYWORDS="~alpha ~amd64 ~arm ~arm64 ~hppa ~ia64 ~m68k ~mips ~ppc ~ppc64 ~riscv ~s390 ~sparc ~x86"
    +IUSE=""
    +RESTRICT="test"
    +
    +RDEPEND=">=dev-lang/perl-5.6
    + >=sys-devel/automake-wrapper-10
    + >=sys-devel/autoconf-2.69:*
    + sys-devel/gnuconfig"
    +DEPEND="${RDEPEND}
    + sys-apps/help2man"
    +BDEPEND="app-arch/gzip"
    +
    +PATCHES=(
    + "${FILESDIR}"/${PN}-1.10-perl-5.16.patch #424453
    + "${FILESDIR}"/${PN}-1.11-install-sh-avoid-low-risk-race-in-tmp.patch
    + "${FILESDIR}"/${PN}-1.13-perl-escape-curly-bracket-r1.patch
    +)
    +
    +src_prepare() {
    + default
    + export WANT_AUTOCONF=2.5
    + export HELP2MAN=true
    + sed -i -e "/APIVERSION=/s:=.*:=${SLOT}:" configure || die
    + export TZ="UTC" #589138
    +}
    +
    +src_compile() {
    + # Also used in install.
    + infopath="${EPREFIX}/usr/share/automake-${PV}/info"

    Not sure if we have a style policy on this, but I read lowercase variables as local-function variables. However, 'infopath', as is, is used in a subsequent ebuild phase function. So maybe s/infopath/INFOPATH/ or maybe even MY_INFOPATH
    or AUTOMAKE_INFOPATH?

    Yes, fair enough. I'll update it to MY_INFOPATH.

    - Flow


    --
    Arsen Arsenović

    --=-=-Content-Type: application/pgp-signature; name="signature.asc"

    -----BEGIN PGP SIGNATURE-----

    iOcEARYKAI8WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZCFoDF8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0RkVF MkIzRDExM0ZDMDBBMzE2MkQ2MDYxNTJDMjk0MzAxRUEyQzQ5MxEcYXJzZW5AZ2Vu dG9vLm9yZwAKCRBSwpQwHqLEk5uhAQDm8yYtIU7LKI4061jlw5OxpTy1Bya6xBm8 nggeWUYvWQD8CjOljbf/2dsxNro4X28Kek3pjQ3gWb2cmJ1lk8iJowI=BoST
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)