Signed-off-by: David Seifert <soap@gentoo.org>
---
eclass/toolchain.eclass | 110 +++++++++++++++-------------------------
1 file changed, 40 insertions(+), 70 deletions(-)

diff --git a/eclass/toolchain.eclass b/eclass/toolchain.eclass
index 61718f0d9a0..741b6dfbbcc 100644
--- a/eclass/toolchain.eclass
+++ b/eclass/toolchain.eclass
@@ -4,7 +4,7 @@
# @ECLASS: toolchain.eclass
# @MAINTAINER:
# Toolchain Ninjas <toolchain@gentoo.org>
-# @SUPPORTED_EAPIS: 5 6 7 8
+# @SUPPORTED_EAPIS: 7 8
# @BLURB: Common code for sys-devel/gcc ebuilds

DESCRIPTION="The GNU Compiler Collection"
@@ -31,7 +31,6 @@ fi
FEATURES=${FEATURES/multilib-strict/}

case ${EAPI} in
- 5|6) inherit eapi7-ver eutils ;;
7) inherit eutils ;;
8) ;;
*) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
@@ -129,16 +128,6 @@ LICENSE="GPL-3+ LGPL-3+ || ( GPL-3+ libgcc libstdc++ gcc-runtime-library-excepti
IUSE="test vanilla +nls"
RESTRICT="!test? ( test )"

-tc_supports_dostrip() {
- case ${EAPI} in
- 5|6) return 1 ;;
- 7|8) return 0 ;;
- *) die "U

The series LGTM from visual review. Note that I haven't verified
the variable moves in wider context.

--
Best regards,
Michał Górny

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On 29 Jan 2022, at 17:31, David Seifert <soap@gentoo.org> wrote:

Signed-off-by: David Seifert <soap@gentoo.org>
--

series lgtm

Best,
sam

-----BEGIN PGP SIGNATURE-----

iQGTBAEBCgB9FiEEYOpPv/uDUzOcqtTy9JIoEO6gSDsFAmH1lE5fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDYw RUE0RkJGRkI4MzUzMzM5Q0FBRDRGMkY0OTIyODEwRUVBMDQ4M0IACgkQ9JIoEO6g SDtDawf/WAVaqY/aO/rtEEUSVoalLarfr20cJv6M4CD6xEr/2DKT9zIN1qBAUkWX 38PDllAQhnOIAKvXveOKKjuPM+cFsa4fxN7PbUHrqTr0UB8QtrbxpDKDL3BbEdkA hRTx9YObgECrk/9LYfIWcfbZymeif7HDrgNHuo6IR/g7vZCB9F11NKpmgVuf4vOE TbYe/DtGccOzbgM59S5PhTlqy8PC+akDP1rT0d6+nmNgrSTxuKTP2VH4N8DK+09t j1dl2srhEYLGAbRGLKncMrCjpL+dNHLnNg+kes6mP3GXHtI8RkkrSsx+ZNBAYfH0 uq7jzVedzsE9yCBSZ7n3Z1UYG2BwzQ==
=1ulU
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

At a technical level, it looks fine.

But I want to clarify interaction for old systems.

Dilfridge had a proposal to ensure 3/6/12 month old systems could still upgrade, and I'm wondering if this could break those systems.

There are 3 commits in the last year that finally removed the EAPI 5/6 toolchain consumers:
486b77ab8d28c5bfd5a4bdfc5f9a5f432ffde563 b0a39e54065f7eda2dfc719ec05e270fa7e23e38 26f684adecb5b9135f9eba9f1b63c83e3d5e5722

The latest of those was in September 2021.

Do we need to wait X months after those removals, to be able to commit
this change?

--
Robin Hugh Johnson
Gentoo Linux: Dev, Infra Lead, Foundation Treasurer
E-Mail : robbat2@gentoo.org
GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85
GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Robbat2 @ Orbis-Terrarum Networks - The text below is a digital signature. If it doesn't make any sense to you, ignore it.

iQKTBAABCgB9FiEEveu2pS8Vb98xaNkRGTlfI8WIJsQFAmH5tqBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEJE RUJCNkE1MkYxNTZGREYzMTY4RDkxMTE5Mzk1RjIzQzU4ODI2QzQACgkQGTlfI8WI JsQ4pA//R/aC1XtIBbV6TxF5rqxkk926loVc4RykgEjMd7O3KIWXYjGi3F0Fr7ac DKkSMZJHuVKkAAJeM0ciJnxpRMY+UT9Ldw7su/XO27oruzzqjJoP1WKC1KiO3jVa J2Uzlg/jEyMCmw6u2fP+W6iKiZE6gqMXnRRsmpWFp7F5Xh5KpaX9EPtY8yVtRQjW ahgYwClKxO4xVi3baUArXRnpCrjA3aG5+Af0BJMW9DccD73tcUH9ngh8PpPMKuRK kD1jRh+xCYjURKAlxquFpUpZhIBn/NC7sjqQedTpexL6Scj1lJfK1OJdPUt53XE+ Y6LhGE5hDABDhPFdwsVoCf2JRpdOR3N/3YqvSfKjVhGP53ET2/CBvSY8WsoUK11x eNdKZA54mg8rLf7Sd++H

To: robbat2@gentoo.org (Robin H. Johnson)

Dilfridge had a proposal to ensure 3/6/12 month old systems could still upgrade, and I'm wondering if this could break those systems.

There are 3 commits in the last year that finally removed the EAPI 5/6 toolchain consumers:
486b77ab8d28c5bfd5a4bdfc5f9a5f432ffde563 b0a39e54065f7eda2dfc719ec05e270fa7e23e38 26f684adecb5b9135f9eba9f1b63c83e3d5e5722

The latest of those was in September 2021.

Do we need to wait X months after those removals, to be able to commit
this change?

Hmm. Portage saves and reuses the ebuild environment, so each installed package has its phases and related eclass code stored.

Which means this is probably fine, since
1) after syncing, the ebuilds are gone, so you'll never be able to rebuild
the consumer
2) and unmerging the consumer is done using the saved environment.

More opinions welcome...

--
Andreas K. Hüttel
dilfridge@gentoo.org
Gentoo Linux developer
(council, toolchain, base-system, perl, libreoffice)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQKTBAABCgB9FiEE6W4INB9YeKX6Qpi1TEn3nlTQogYFAmH5xLFfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEU5 NkUwODM0MUY1ODc4QTVGQTQyOThCNTRDNDlGNzlFNTREMEEyMDYACgkQTEn3nlTQ ogaVfw/9GjL3Kpjp0KFpE4RpVMSrSxxl8OL4NEz9Khh1RjZ58cbBCRU9wdzqsPF+ D9nE/k5IYpAUcNYa84wgEbiSKyQsSMJwM5eztoZOtBsANnFhuWscBePN/WdQo2nf MyVPCfpcBLA4V57cUH2vS72t41cnPapodDxfDB2zPrn9Kt2egQGZeOwkFJDDnQvC l5y4KE8zVy4KV197+Yz9svkP/dRjKFBxaAO2TQNhROdW8U2cUR1XrJy0igE/Dtlr kvoVJJvCJ0TWDU+p99EpXc6Sd21kivD2I+O/9jq9ITRb606G3HLkdNVHLjUOyNfk q+4ATnxdmco7muHxBSGB9Kc+YhTXJ6EqfVL/w5wRC3yVyvJBfqLa6p/zDw7obAMu S5Drmvch+6+vsCVH6i+ODgfxEH4U5cgyh8ApELXjlvWnLp2qbjZnB8N1+1eImIGz 1IqI9W4TXOGkZxxQNhrOEDPUNS7GksaCpyq3WuNTke7MVT5eRou1Vz6g0ROmHbbg Os/ZSfFUbWaGGxR6wZtpG0ZSSRQCu47z0EzdHb5J34ExyqRcEEepiPMHnt47PXDC PWfPW9zgTgzuHfxI15ppkq5+vbz7fuWz7oPS8wIDPCKiY3Y+Aj3kswTA