• a patch add missing extern "C"

    From black_desk@21:1/5 to All on Wed Nov 17 03:00:01 2021
    This is a multi-part message in MIME format.
    While using libdpkg-dev, I have some symbol finding issue when I try to
    link to `libdpkg.a`. It turns out that some header files I used do not
    have `extern "C"`.

    This is my first time trying to contribute to debian. Sorry for any
    mistake I may have made.

    RnJvbSA1MmZhOWIyZjczZTU4OWZhYjg0Mzk4MDljMmJhYjBlODI5NDJlOGFmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBibGFja19kZXNrIDxjbHg4MTQ3Mjc4MjNAZ21haWwu Y29tPgpEYXRlOiBUdWUsIDE2IE5vdiAyMDIxIDE3OjIxOjIyICswODAwClN1YmplY3Q6IFtQ QVRDSF0gbGliZHBrZzogQWRkIG1pc3NpbmcgZXh0ZXJuICJDIgoKLS0tCiBsaWIvZHBrZy9k Yi1jdHJsLmggICB8IDQgKysrKwogbGliL2Rwa2cvZGItZnN5cy5oICAgfCA0ICsrKysKIGxp Yi9kcGtnL2ZzeXMuaCAgICAgIHwgNCArKysrCiBsaWIvZHBrZy9wYXJzZWR1bXAuaCB8IDQg KysrKwogbGliL2Rwa2cvcGVyZi5oICAgICAgfCA2ICsrKysrKwogbGliL2Rwa2cvdGFyZm4u aCAgICAgfCA0ICsrKysKIDYgZmlsZXMgY2hhbmdlZCwgMjYgaW5zZXJ0aW9ucygrKQoKZGlm ZiAtLWdpdCBhL2xpYi9kcGtnL2RiLWN0cmwuaCBiL2xpYi9kcGtnL2RiLWN0cmwuaAppbmRl eCBlNGRjY2QyODUuLmQyMWJiN2M2NiAxMDA2NDQKLS0tIGEvbGliL2Rwa2cvZGItY3RybC5o CisrKyBiL2xpYi9kcGtnL2RiLWN0cmwuaApAQCAtMjUsNiArMjUsOCBAQAogCiAjaW5jbHVk ZSA8ZHBrZy9kcGtnLWRiLmg+CiAKK0RQS0dfQkVHSU5fREVDTFMKKwogZW51bSBwa2dfaW5m b2RiX2Zvcm1hdCB7CiAJUEtHX0lORk9EQl9GT1JNQVRfVU5LTk9XTiA9IC0xLAogCVBLR19J TkZPREJfRk9STUFUX0xFR0FDWSA9IDAsCkBAIC00OSw0ICs1MSw2IEBAIHR5cGVkZWYgdm9p ZCBwa2dfaW5mb2RiX2ZpbGVfZnVuYyhjb25zdCBjaGFyICpmaWxlbmFtZSwgY29uc3QgY2hh ciAqZmlsZXR5cGUpOwogdm9pZCBwa2dfaW5mb2RiX2ZvcmVhY2goc3RydWN0IHBrZ2luZm8g KnBrZywgc3RydWN0IHBrZ2JpbiAqcGtnYmluLAogICAgICAgICAgICAgICAgICAgICAgICAg cGtnX2luZm9kYl9maWxlX2Z1bmMgKmZ1bmMpOwogCitEUEtHX0VORF9ERUNMUworCiAjZW5k aWYgLyogTElCRFBLR19EQl9DVFJMX0ggKi8KZGlmZiAtLWdpdCBhL2xpYi9kcGtnL2RiLWZz eXMuaCBiL2xpYi9kcGtnL2RiLWZzeXMuaAppbmRleCAzMzlhMGZiNDUuLmNkOWFiZWZhZiAx MDA2NDQKLS0tIGEvbGliL2Rwa2cvZGItZnN5cy5oCisrKyBiL2xpYi9kcGtnL2RiLWZzeXMu aApAQCAtMjUsNiArMjUsOCBAQAogI2luY2x1ZGUgPGRwa2cvZmlsZS5oPgogI2luY2x1ZGUg PGRwa2cvZnN5cy5oPgogCitEUEtHX0JFR0lOX0RFQ0xTCisKIC8qCiAgKiBEYXRhIHN0cnVj dHVyZSBoZXJlIGlzIGFzIGZvbGxvd3M6CiAgKgpAQCAtNzIsNCArNzQsNiBAQCB2b2lkIHdy aXRlX2ZpbGVsaXN0X2V4Y2VwdChzdHJ1Y3QgcGtnaW5mbyAqcGtnLCBzdHJ1Y3QgcGtnYmlu ICpwa2diaW4sCiB2b2lkIHdyaXRlX2ZpbGVoYXNoX2V4Y2VwdChzdHJ1Y3QgcGtnaW5mbyAq cGtnLCBzdHJ1Y3QgcGtnYmluICpwa2diaW4sCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICBzdHJ1Y3QgZnN5c19uYW1lbm9kZV9saXN0ICpsaXN0LCBlbnVtIGZzeXNfbmFtZW5vZGVf ZmxhZ3MgbWFzayk7CiAKK0RQS0dfRU5EX0RFQ0xTCisKICNlbmRpZiAvKiBMSUJEUEtHX0RC X0ZTWVNfSCAqLwpkaWZmIC0tZ2l0IGEvbGliL2Rwa2cvZnN5cy5oIGIvbGliL2Rwa2cvZnN5 cy5oCmluZGV4IDc0OGYzYTlhZi4uOGM3OGM3N2FjIDEwMDY0NAotLS0gYS9saWIvZHBrZy9m c3lzLmgKKysrIGIvbGliL2Rwa2cvZnN5cy5oCkBAIC0yNiw2ICsyNiw4IEBACiAKICNpbmNs dWRlIDxkcGtnL2ZpbGUuaD4KIAorRFBLR19CRUdJTl9ERUNMUworCiAvKgogICogRGF0YSBz dHJ1Y3R1cmUgaGVyZSBpcyBhcyBmb2xsb3dzOgogICoKQEAgLTIwMyw0ICsyMDUsNiBAQCBj b25zdCBjaGFyICpkcGtnX2ZzeXNfc2V0X2Rpcihjb25zdCBjaGFyICpkaXIpOwogY29uc3Qg Y2hhciAqZHBrZ19mc3lzX2dldF9kaXIodm9pZCk7CiBjaGFyICpkcGtnX2ZzeXNfZ2V0X3Bh dGgoY29uc3QgY2hhciAqcGF0aHBhcnQpOwogCitEUEtHX0VORF9ERUNMUworCiAjZW5kaWYg LyogTElCRFBLR19GU1lTX0ggKi8KZGlmZiAtLWdpdCBhL2xpYi9kcGtnL3BhcnNlZHVtcC5o IGIvbGliL2Rwa2cvcGFyc2VkdW1wLmgKaW5kZXggNzMzMzFiY2E1Li4zMTZjZDFiNTEgMTAw NjQ0Ci0tLSBhL2xpYi9kcGtnL3BhcnNlZHVtcC5oCisrKyBiL2xpYi9kcGtnL3BhcnNlZHVt cC5oCkBAIC0yNyw2ICsyNyw4IEBACiAKICNpbmNsdWRlIDxkcGtnL2Vycm9yLmg+CiAKK0RQ S0dfQkVHSU5fREVDTFMKKwogLyoqCiAgKiBAZGVmZ3JvdXAgcGFyc2VkdW1wIEluLWNvcmUg cGFja2FnZSBkYXRhYmFzZSBwYXJzaW5nIGFuZCByZWFkaW5nCiAgKiBAaW5ncm91cCBkcGtn LXB1YmxpYwpAQCAtMTYzLDQgKzE2NSw2IEBAIGV4dGVybiBjb25zdCBzdHJ1Y3QgZmllbGRp bmZvIGZpZWxkaW5mb3NbXTsKIAogLyoqIEB9ICovCiAKK0RQS0dfRU5EX0RFQ0xTCisKICNl bmRpZiAvKiBMSUJEUEtHX1BBUlNFRFVNUF9IICovCmRpZmYgLS1naXQgYS9saWIvZHBrZy9w ZXJmLmggYi9saWIvZHBrZy9wZXJmLmgKaW5kZXggNmI1ZDBiZWZkLi5iOTc4YzZjMzggMTAw NjQ0Ci0tLSBhL2xpYi9kcGtnL3BlcmYuaAorKysgYi9saWIvZHBrZy9wZXJmLmgKQEAgLTMw LDYgKzMwLDEwIEBACiAjZGVmaW5lIFRFU1RfT01JVF9WQVJJQUJMRVMKICNpbmNsdWRlIDxk cGtnL3Rlc3QuaD4KIAorI2luY2x1ZGUgPGRwa2cvbWFjcm9zLmg+CisKK0RQS0dfQkVHSU5f REVDTFMKKwogc3RydWN0IHBlcmZfc2xvdCB7CiAJc3RydWN0IHRpbWVzcGVjIHRfaW5pLCB0 X2VuZDsKIH07CkBAIC03MCw0ICs3NCw2IEBAIHBlcmZfdHNfc2xvdF9wcmludChzdHJ1Y3Qg cGVyZl9zbG90ICpwcywgY29uc3QgY2hhciAqc3RyKQogI2RlZmluZSBwZXJmX3RzX3Nsb3Rf c3RhcnQocHMpIGNsb2NrX2dldHRpbWUoQ0xPQ0tfTU9OT1RPTklDLCAmKChwcyktPnRfaW5p KSkKICNkZWZpbmUgcGVyZl90c19zbG90X3N0b3AocHMpIGNsb2NrX2dldHRpbWUoQ0xPQ0tf TU9OT1RPTklDLCAmKChwcyktPnRfZW5kKSkKIAorRFBLR19FTkRfREVDTFMKKwogI2VuZGlm CmRpZmYgLS1naXQgYS9saWIvZHBrZy90YXJmbi5oIGIvbGliL2Rwa2cvdGFyZm4uaAppbmRl eCA0ZDU5MTdjZmMuLmMwM2E1OTMxMCAxMDA2NDQKLS0tIGEvbGliL2Rwa2cvdGFyZm4uaAor KysgYi9saWIvZHBrZy90YXJmbi5oCkBAIC0yOSw2ICsyOSw4IEBACiAjaW5jbHVkZSA8ZHBr Zy9lcnJvci5oPgogI2luY2x1ZGUgPGRwa2cvZmlsZS5oPgogCitEUEtHX0JFR0lOX0RFQ0xT CisKIC8qKgogICogQGRlZmdyb3VwIHRhciBUYXIgYXJjaGl2ZSBoYW5kbGluZwogICogQGlu Z3JvdXAgZHBrZy1wdWJsaWMKQEAgLTEyNyw0ICsxMjksNiBAQCB0YXJfZXh0cmFjdG9yKHN0 cnVjdCB0YXJfYXJjaGl2ZSAqdGFyKTsKIAogLyoqIEB9ICovCiAKK0RQS0dfRU5EX0RFQ0xT CisKICNlbmRpZgotLSAKMi4zMy4wCgo=

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Guillem Jover@21:1/5 to All on Sat Nov 20 19:50:02 2021
    Hi!

    On Wed, 2021-11-17 at 09:36:03 +0800, black_desk wrote:
    While using libdpkg-dev, I have some symbol finding issue when I try to link to `libdpkg.a`. It turns out that some header files I used do not have `extern "C"`.

    This is my first time trying to contribute to debian. Sorry for any mistake
    I may have made.

    Thanks for the patch! I actually had something pretty close to this
    locally, which I had not yet pushed. :/ I've done that now and it will
    be included in the upcoming release.

    https://git.dpkg.org/cgit/dpkg/dpkg.git/commit/?id=a4dfcc1ef09b9460a65c797bdab696d40b7078b8

    Thanks,
    Guillem

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Black Desk@21:1/5 to All on Mon Nov 22 03:20:02 2021
    Thanks!

    Guillem Jover <guillem@debian.org>于2021年11月21日 周日上午2:48写道:

    Hi!

    On Wed, 2021-11-17 at 09:36:03 +0800, black_desk wrote:
    While using libdpkg-dev, I have some symbol finding issue when I try to
    link
    to `libdpkg.a`. It turns out that some header files I used do not have `extern "C"`.

    This is my first time trying to contribute to debian. Sorry for any
    mistake
    I may have made.

    Thanks for the patch! I actually had something pretty close to this
    locally, which I had not yet pushed. :/ I've done that now and it will
    be included in the upcoming release.


    https://git.dpkg.org/cgit/dpkg/dpkg.git/commit/?id=a4dfcc1ef09b9460a65c797bdab696d40b7078b8

    Thanks,
    Guillem


    <div dir="ltr"><div>Thanks!</div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Guillem Jover &lt;<a href="mailto:guillem@debian.org" target="_blank">guillem@debian.org</a>&gt;于2021年11月21日 周日上午2:48写道:<br></div><
    blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)">Hi!<br>

    On Wed, 2021-11-17 at 09:36:03 +0800, black_desk wrote:<br>
    &gt; While using libdpkg-dev, I have some symbol finding issue when I try to link<br>
    &gt; to `libdpkg.a`. It turns out that some header files I used do not have<br> &gt; `extern &quot;C&quot;`.<br>
    &gt; <br>
    &gt; This is my first time trying to contribute to debian. Sorry for any mistake<br>
    &gt; I may have made.<br>

    Thanks for the patch! I actually had something pretty close to this<br> locally, which I had not yet pushed. :/ I&#39;ve done that now and it will<br> be included in the upcoming release.<br>

      <a href="https://git.dpkg.org/cgit/dpkg/dpkg.git/commit/?id=a4dfcc1ef09b9460a65c797bdab696d40b7078b8" rel="noreferrer" target="_blank">https://git.dpkg.org/cgit/dpkg/dpkg.git/commit/?id=a4dfcc1ef09b9460a65c797bdab696d40b7078b8</a><br>

    Thanks,<br>
    Guillem<br>
    </blockquote></div></div>
    </div>

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)