Dear Emacsen Maintainers,

It looks like a few Emacsen packages are marked as testing auto-removal
due to bug#999962[1]. It looks like this pcre to pcre2 migration is non-trivial, and the upstream of silversearcher-ag[2] seems to be silent
since Dec. 2020. The list of affected packages are in [3]. As most of
them have silversearcher-ag as an optional dependency, should it be
considered to drop silversearcher-ag support for now and wait for the
fixes or alternatives to be available before re-enabling the support?

[1] https://bugs.debian.org/999962

[2] https://github.com/ggreer/the_silver_searcher

[3]
https://tracker.debian.org/dumb-jump-el https://tracker.debian.org/emacs-helm-ag
https://tracker.debian.org/emacs-ivy
https://tracker.debian.org/emacs-wgrep
https://tracker.debian.org/rtags


--
Manphiz

--=-=-Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJGBAEBCgAwFiEEiKQfd6o81mjI+LWALell7WOCXJMFAmS5wLwSHG1hbnBoaXpA Z21haWwuY29tAAoJEC3pZe1jglyTr7cP+gOMDOaJXmFdrdWFCiwrUIVVQM4uxaLg OVUaLsLdaNM091Oom+4hDPONX9sRGpVIJT8Lf+htdFc6TcdECPezUkCBp7iCVTT+ OwA1z3d+NmcE32vylVAf0hdeKf/gYE96Ne3YB7P6RKPdDUZbrFas/bDugMmXspsN 7o8Kx42epO4JnR4mv6D9/NWQE+8I7jjCMtlufLK6SnU4sVkmIAvskSJd1Df9/9n/ JoWKhGtMi997mgIjMBwTqCbEhW6A/ntrhX3ovr2xYp/PmdrT3Vb4/HQI9xC86eXp NDjeYbrxFPCosbJb82GgVjL9Ks0xUSUJ8H7laD47lcCm4OAuq44I9Qh5AxqdYfhC gObmJkuq+m2hdbOTGeZd9MvfN334cX7wylweqbsv+h3EEWrDpcHzkLrMJhrYpZqW 8ctUtKhcHLtvz5P64FI3dofrcCC3kHrhxF6smGf44MdG2aXRm/7TMPzUty2DcaOI RyE0pTa9l7cfJaNmtTKnotw399OHKqM1kuhqHsCwcPVkgEExD04ovmRWd6efSTZu CxJMlH07tb3z4xjJCL8yyvin+7+n447XSBCfDHPGcSFq5y0q5hwFr88pqqVbH8hO FIXoxlWpB43aBa5RZdnlSF+PaSBnmYtGm1JQVnw2w2dvFukJCV2qQwxfueMtQn3k
SR/jNhGfxQQ0
=TDnZ
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (

Manphiz <manphiz@gmail.com> writes:

Dear Emacsen Maintainers,

It looks like a few Emacsen packages are marked as testing auto-removal
due to bug#999962[1]. It looks like this pcre to pcre2 migration is non-trivial, and the upstream of silversearcher-ag[2] seems to be silent since Dec. 2020. The list of affected packages are in [3]. As most of
them have silversearcher-ag as an optional dependency, should it be considered to drop silversearcher-ag support for now and wait for the
fixes or alternatives to be available before re-enabling the support?

I'm not a silversearch-ag user, but your suggestion makes sense to me.

d

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

David Bremner <david@tethera.net> writes:

Manphiz <manphiz@gmail.com> writes:

Dear Emacsen Maintainers,

It looks like a few Emacsen packages are marked as testing auto-removal
due to bug#999962[1]. It looks like this pcre to pcre2 migration is
non-trivial, and the upstream of silversearcher-ag[2] seems to be silent
since Dec. 2020. The list of affected packages are in [3]. As most of
them have silversearcher-ag as an optional dependency, should it be
considered to drop silversearcher-ag support for now and wait for the
fixes or alternatives to be available before re-enabling the support?

I'm not a silversearch-ag user, but your suggestion makes sense to me.

d

Thanks David! I've prepared a merge request[1] on emacs-wgrep to
implement this idea. Would be great to have your reviews and comments.
If this is an acceptable direction to go forward I will do similar work
on other affect packages. Thanks!

[1] https://salsa.debian.org/emacsen-team/emacs-wgrep/-/merge_requests/1

--
Manphiz

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Manphiz <manphiz@gmail.com> writes:

I'm not a silversearch-ag user, but your suggestion makes sense to me.

d

Thanks David! I've prepared a merge request[1] on emacs-wgrep to
implement this idea. Would be great to have your reviews and comments.
If this is an acceptable direction to go forward I will do similar work
on other affect packages. Thanks!

[1] https://salsa.debian.org/emacsen-team/emacs-wgrep/-/merge_requests/1

To be fair, the following issue wasn't introduced by this MR, but was
this MR tested? I got:

…
Ignoring upstream Makefile and building/installing with dh-elpa.
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_elpa_test
emacs -batch -Q -l package --eval "(add-to-list 'package-directory-list \"/usr/share/emacs/site-lisp/elpa\")" --eval "(add-to-list 'package-directory-list \"/usr/share/emacs/site-lisp/elpa-src\")" -f package-initialize -L . -l wgrep-subtest.el -l
wgrep-test.el --eval \(ert-run-tests-batch-and-exit\)

Error: error ("Test ‘wgrep-normal’ redefined")
mapbacktrace(#f(compiled-function (evald func args flags) #<bytecode 0x1381f8c5ebae87c2>))
debug-early-backtrace()
debug-early(error (error "Test ‘wgrep-normal’ redefined"))
error("Test `%s' redefined" wgrep-normal)
ert-set-test(wgrep-normal #s(ert-test :name wgrep-normal :documentation nil :body (lambda nil (let ((wgrep-change-readonly-file nil) (wgrep-auto-save-buffer nil)) (progn (wgrep-test-fixture "HOGE\nFOO\nBAZ\n" #'(lambda (file) (wgrep-test--grep (concat "
grep -nH -e FOO -C 1 " file)) (wgrep-change-to-wgrep-mode) (goto-char (point-min)) (let* ((fn-122 #'re-search-forward) (args-123 (condition-case err (let ((signal-hook-function #'ert--should-signal-hook)) (list "^grep" nil t)) (error (progn (setq fn-122 #
'signal) (list (car err) (cdr err))))))) (let ((value-124 'ert-form-evaluation-aborted-125)) (let (form-description-126) (if (unwind-protect (setq value-124 (apply fn-122 args-123)) (setq form-description-126 (nconc (list '(should (re-search-forward "^
grep" nil t))) (list :form (cons fn-122 args-123)) (if (eql value-124 'ert-form-evaluation-aborted-125) nil (list :value value-124)) (if (eql value-124 'ert-form-evaluation-aborted-125) nil (let* ((-explainer- (and t (ert--get-explainer 're-search-
forward)))) (if -explainer- (list :explanation (apply -explainer- args-123)) nil))))) (ert--signal-should-execution form-description-126)) nil (ert-fail form-description-126))) value-124)) (let* ((fn-127 #'delete-char) (args-128 (condition-case err (let (
(signal-hook-function #'ert--should-signal-hook)) (list 1)) (error (progn (setq fn-127 #'signal) (list (car err) (cdr err))))))) (let ((value-129 'ert-form-evaluation-aborted-130)) (let (form-description-131) (let ((errorp132 nil) (form-description-fn-
133 #'(lambda nil form-description-131))) (condition-case -condition- (unwind-protect (setq value-129 (apply fn-127 args-128)) (setq form-description-131 (nconc (list '(should-error (delete-char 1) :type 'text-read-only)) (list :form (cons fn-127 args-
128)) (if (eql value-129 'ert-form-evaluation-aborted-130) nil (list :value value-129)) (if (eql value-129 'ert-form-evaluation-aborted-130) nil (let* ((-explainer- (and t (ert--get-explainer 'delete-char)))) (if -explainer- (list :explanation (apply -
explainer- args-128)) nil))))) (ert--signal-should-execution form-description-131)) (error (setq errorp132 t) (ert--should-error-handle-error form-description-fn-133 -condition- 'text-read-only nil) (setq value-129 -condition-))) (if errorp132 nil (ert-
fail (append (funcall form-description-fn-133) (list :fail-reason "did not signal an error")))))) value-129)) (let* ((fn-134 #'re-search-forward) (args-135 (condition-case err (let ((signal-hook-function #'ert--should-signal-hook)) (list "HOGE" nil t)) (
error (progn (setq fn-134 #'signal) (list (car err) (cdr err))))))) (let ((value-136 'ert-form-evaluation-aborted-137)) (let (form-description-138) (if (unwind-protect (setq value-136 (apply fn-134 args-135)) (setq form-description-138 (nconc (list '(
should (re-search-forward "HOGE" nil t))) (list :form (cons fn-134 args-135)) (if (eql value-136 'ert-form-evaluation-aborted-137) nil (list :value value-136)) (if (eql value-136 'ert-form-evaluation-aborted-137) nil (let* ((-explainer- (and t (ert--get-
explainer 're-search-forward)))) (if -explainer- (list :explanation (apply -explainer- args-135)) nil))))) (ert--signal-should-execution form-description-138)) nil (ert-fail form-description-138))) value-136)) (wgrep-mark-deletion) (let* ((fn-139 #'re-
search-forward) (args-140 (condition-case err (let ((signal-hook-function #'ert--should-signal-hook)) (list "FOO" nil t)) (error (progn (setq fn-139 #'signal) (list (car err) (cdr err))))))) (let ((value-141 'ert-form-evaluation-aborted-142)) (let (form-
description-143) (if (unwind-protect (setq value-141 (apply fn-139 args-140)) (setq form-description-143 (nconc (list '(should (re-search-forward "FOO" nil t))) (list :form (cons fn-139 args-140)) (if (eql value-141 'ert-form-evaluation-aborted-142) nil (
list :value value-141)Test ‘wgrep-normal’ redefined
) (if (eql value-141 'ert-form-evaluation-aborted-142) nil (let* ((-explainer- (and t (ert--get-explainer 're-search-forward)))) (if -explainer- (list :explanation (apply -explainer- args-140)) nil))))) (ert--signal-should-execution form-description-143))
nil (ert-fail form-description-143))) value-141)) (replace-match "FOO2") (goto-char (point-max)) (let* ((fn-144 #'delete-char) (args-145 (condition-case err (let ((signal-hook-function #'ert--should-signal-hook)) (list -1)) (error (progn (setq fn-144 #'
signal) (list (car err) (cdr err))))))) (let ((value-146 'ert-form-evaluation-aborted-147)) (let (form-description-148) (let ((errorp149 nil) (form-description-fn-150 #'(lambda nil form-description-148))) (condition-case -condition- (unwind-protect (setq
value-146 (apply fn-144 args-145)) (setq form-description-148 (nconc (list '(should-error (delete-char -1) :type 'text-read-only)) (list :form (cons fn-144 args-145)) (if (eql value-146 'ert-form-evaluation-aborted-147) nil (list :value value-146)) (if (
eql value-146 'ert-form-evaluation-aborted-147) nil (let* ((-explainer- (and t (ert--get-explainer 'delete-char)))) (if -explainer- (list :explanation (apply -explainer- args-145)) nil))))) (ert--signal-should-execution form-description-148)) (error (
setq errorp149 t) (ert--should-error-handle-error form-description-fn-150 -condition- 'text-read-only nil) (setq value-146 -condition-))) (if errorp149 nil (ert-fail (append (funcall form-description-fn-150) (list :fail-reason "did not signal an error")))
))) value-146)) (wgrep-finish-edit) (wgrep-save-all-buffers) (let* ((fn-151 #'equal) (args-152 (condition-case err (let ((signal-hook-function #'ert--should-signal-hook)) (list "FOO2\nBAZ\n" (wgrep-test--get-contents file))) (error (progn (setq fn-151 #'
signal) (list (car err) (cdr err))))))) (let ((value-153 'ert-form-evaluation-aborted-154)) (let (form-description-155) (if (unwind-protect (setq value-153 (apply fn-151 args-152)) (setq form-description-155 (nconc (list '(should (equal "FOO2\nBAZ\n" (
wgrep-test--get-contents file)))) (list :form (cons fn-151 args-152)) (if (eql value-153 'ert-form-evaluation-aborted-154) nil (list :value value-153)) (if (eql value-153 'ert-form-evaluation-aborted-154) nil (let* ((-explainer- (and t (ert--get-
explainer 'equal)))) (if -explainer- (list :explanation (apply -explainer- args-152)) nil))))) (ert--signal-should-execution form-description-155)) nil (ert-fail form-description-155))) value-153))))))) :most-recent-result nil :expected-result-type :
passed :tags (wgrep) :file-name "/<<PKGBUILDDIR>>/wgrep-test.el"))
load-with-code-conversion("/<<PKGBUILDDIR>>/wgrep-test.el" "/<<PKGBUILDDIR>>/wgrep-test.el" nil t)
command-line-1(("-l" "package" "--eval" "(add-to-list 'package-directory-list \"/usr/share/emacs/site-lisp/elpa\")" "--eval" "(add-to-list 'package-directory-list \"/usr/share/emacs/site-lisp/elpa-src\")" "-f" "package-initialize" "-L" "." "-l" "wgrep-
subtest.el" "-l" "wgrep-test.el" "--eval" "(ert-run-tests-batch-and-exit)"))
command-line()
normal-top-level()
dh_elpa_test: error: emacs -batch -Q -l package --eval "(add-to-list 'package-directory-list \"/usr/share/emacs/site-lisp/elpa\")" --eval "(add-to-list 'package-directory-list \"/usr/share/emacs/site-lisp/elpa-src\")" -f package-initialize -L . -l wgrep-
subtest.el -l wgrep-test.el --eval \(ert-run-tests-batch-and-exit\) returned exit code 255
make: *** [debian/rules:4: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

I think that's unrelated to silversearcher-ag though ;)

Meanwhile (non Emacs), if you want to fix all packages in the archive
that depend on silversearcher-ag, in one shot:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=999962#18

BTW, are you subscribed to this mailing list? In Debian we
conventionally don't CC people on mailing lists, even though we do CC
people on bugs.

Regards,
Nicholas

--=-=-Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCgAuFiEE4qYmHjkArtfNxmcIWogwR199EGEFAmT2QjYQHHN0ZW5AZGVi aWFuLm9yZwAKCRBaiDBHX30QYUsLEACZYrAxwCuLaOXkdxuyZgE2Mi7dgNVcPqYt 0R+BTA+AyTG9l65Y+LstB8LTm53i5fnC61wIQ8VVYpFe0Z1visvVCsoHJYbgcTFl d5OF0GeXH1a+PLkDVPJFeDUtIZqn4pYlcsAX9Zw5x8+nw5iC5iL2eYDOABPrlzgc 95QnqT1JdbZ6foSXCSrsW/GrSELOTpleBfG/dyPVcMfuT8tVewZrNPEl9NfNJflv nPMbLpT3EjSB2f4F8DcatjVo0S2XKqncDOiWikrX+08KejChgItinNkwM96TDNzg UgvDCZeUQciB5424VqZpP6SbpvuNlBayfEZPljCtcwMandbmqf7IS5AYySD29t59 EQKG1ppUR4JtsrNl9o8F5NnSAQW2XhmtvTZkpVHiVyx/k50LzEynsFV+mQdzVDpd sacGJQtTq6Yuha/VcsbXZu9EJn2Mb1vfFsvyMkV7KR/Hs8QYaX+2xnMxpZXF+DHS pWRNTiAds+u3XATIi0+T038JDeWvI3W2yKVaHF32VAbvnhJ8fDd54KrNv81+HQOh 1OQx18ah9HbeazntOCKx2h8d3kz0AMklMJ/vAoqOQP6/ybu6oKdiOxprSkMfFucG 8xvyZS8SlUiPLI3KU6VAazPFCCmDtCvJQr8C4nfoqsIAgwjHHG7X4aVF2k47BlEc sxqvX8xlWA==lRYw
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Nicholas D Steeves <sten@debian.org> writes:

Manphiz <manphiz@gmail.com> writes:

I'm not a silversearch-ag user, but your suggestion makes sense to me.

d

Thanks David! I've prepared a merge request[1] on emacs-wgrep to
implement this idea. Would be great to have your reviews and comments.
If this is an acceptable direction to go forward I will do similar work
on other affect packages. Thanks!

[1] https://salsa.debian.org/emacsen-team/emacs-wgrep/-/merge_requests/1

To be fair, the following issue wasn't introduced by this MR, but was
this MR tested? I got:

…
Ignoring upstream Makefile and building/installing with dh-elpa.
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_elpa_test
emacs -batch -Q -l package --eval "(add-to-list 'package-directory-list \"/usr/share/emacs/site-lisp/elpa\")" --eval "(add-to-list 'package-directory-list \"/usr/share/emacs/site-lisp/elpa-src\")" -f package-initialize -L . -l wgrep-subtest.el -

l wgrep-test.el --eval \(ert-run-tests-batch-and-exit\)

Error: error ("Test ‘wgrep-normal’ redefined")
mapbacktrace(#f(compiled-function (evald func args flags) #<bytecode 0x1381f8c5ebae87c2>))
debug-early-backtrace()
debug-early(error (error "Test ‘wgrep-normal’ redefined"))
error("Test `%s' redefined" wgrep-normal)
ert-set-test(wgrep-normal #s(ert-test :name wgrep-normal :documentation nil :body (lambda nil (let ((wgrep-change-readonly-file nil) (wgrep-auto-save-buffer nil)) (progn (wgrep-test-fixture "HOGE\nFOO\nBAZ\n" #'(lambda (file) (wgrep-test--grep (

concat "grep -nH -e FOO -C 1 " file)) (wgrep-change-to-wgrep-mode) (goto-char (point-min)) (let* ((fn-122 #'re-search-forward) (args-123 (condition-case err (let ((signal-hook-function #'ert--should-signal-hook)) (list "^grep" nil t)) (error (progn (setq
fn-122 #'signal) (list (car err) (cdr err))))))) (let ((value-124 'ert-form-evaluation-aborted-125)) (let (form-description-126) (if (unwind-protect (setq value-124 (apply fn-122 args-123)) (setq form-description-126 (nconc (list '(should (re-search-
forward "^grep" nil t))) (list :form (cons fn-122 args-123)) (if (eql value-124 'ert-form-evaluation-aborted-125) nil (list :value value-124)) (if (eql value-124 'ert-form-evaluation-aborted-125) nil (let* ((-explainer- (and t (ert--get-explainer 're-
search-forward)))) (if -explainer- (list :explanation (apply -explainer- args-123)) nil))))) (ert--signal-should-execution form-description-126)) nil (ert-fail form-description-126))) value-124)) (let* ((fn-127 #'delete-char) (args-128 (condition-case
err (let ((signal-hook-function #'ert--should-signal-hook)) (list 1)) (error (progn (setq fn-127 #'signal) (list (car err) (cdr err))))))) (let ((value-129 'ert-form-evaluation-aborted-130)) (let (form-description-131) (let ((errorp132 nil) (form-
description-fn-133 #'(lambda nil form-description-131))) (condition-case -condition- (unwind-protect (setq value-129 (apply fn-127 args-128)) (setq form-description-131 (nconc (list '(should-error (delete-char 1) :type 'text-read-only)) (list :form (cons
fn-127 args-128)) (if (eql value-129 'ert-form-evaluation-aborted-130) nil (list :value value-129)) (if (eql value-129 'ert-form-evaluation-aborted-130) nil (let* ((-explainer- (and t (ert--get-explainer 'delete-char)))) (if -explainer- (list :
explanation (apply -explainer- args-128)) nil))))) (ert--signal-should-execution form-description-131)) (error (setq errorp132 t) (ert--should-error-handle-error form-description-fn-133 -condition- 'text-read-only nil) (setq value-129 -condition-))) (if
errorp132 nil (ert-fail (append (funcall form-description-fn-133) (list :fail-reason "did not signal an error")))))) value-129)) (let* ((fn-134 #'re-search-forward) (args-135 (condition-case err (let ((signal-hook-function #'ert--should-signal-hook)) (
list "HOGE" nil t)) (error (progn (setq fn-134 #'signal) (list (car err) (cdr err))))))) (let ((value-136 'ert-form-evaluation-aborted-137)) (let (form-description-138) (if (unwind-protect (setq value-136 (apply fn-134 args-135)) (setq form-description-
138 (nconc (list '(should (re-search-forward "HOGE" nil t))) (list :form (cons fn-134 args-135)) (if (eql value-136 'ert-form-evaluation-aborted-137) nil (list :value value-136)) (if (eql value-136 'ert-form-evaluation-aborted-137) nil (let* ((-explainer-
(and t (ert--get-explainer 're-search-forward)))) (if -explainer- (list :explanation (apply -explainer- args-135)) nil))))) (ert--signal-should-execution form-description-138)) nil (ert-fail form-description-138))) value-136)) (wgrep-mark-deletion) (let*
((fn-139 #'re-search-forward) (args-140 (condition-case err (let ((signal-hook-function #'ert--should-signal-hook)) (list "FOO" nil t)) (error (progn (setq fn-139 #'signal) (list (car err) (cdr err))))))) (let ((value-141 'ert-form-evaluation-aborted-
142)) (let (form-description-143) (if (unwind-protect (setq value-141 (apply fn-139 args-140)) (setq form-description-143 (nconc (list '(should (re-search-forward "FOO" nil t))) (list :form (cons fn-139 args-140)) (if (eql value-141 'ert-form-evaluation-
aborted-142) nil (list :value value-141)Test ‘wgrep-normal’ redefined

) (if (eql value-141 'ert-form-evaluation-aborted-142) nil (let* ((-explainer- (and t (ert--get-explainer 're-search-forward)))) (if -explainer- (list :explanation (apply -explainer- args-140)) nil))))) (ert--signal-should-execution form-description-

143)) nil (ert-fail form-description-143))) value-141)) (replace-match "FOO2") (goto-char (point-max)) (let* ((fn-144 #'delete-char) (args-145 (condition-case err (let ((signal-hook-function #'ert--should-signal-hook)) (list -1)) (error (progn (setq fn-
144 #'signal) (list (car err) (cdr err))))))) (let ((value-146 'ert-form-evaluation-aborted-147)) (let (form-description-148) (let ((errorp149 nil) (form-description-fn-150 #'(lambda nil form-description-148))) (condition-case -condition- (unwind-protect
(setq value-146 (apply fn-144 args-145)) (setq form-description-148 (nconc (list '(should-error (delete-char -1) :type 'text-read-only)) (list :form (cons fn-144 args-145)) (if (eql value-146 'ert-form-evaluation-aborted-147) nil (list :value value-146))
(if (eql value-146 'ert-form-evaluation-aborted-147) nil (let* ((-explainer- (and t (ert--get-explainer 'delete-char)))) (if -explainer- (list :explanation (apply -explainer- args-145)) nil))))) (ert--signal-should-execution form-description-148)) (error
(setq errorp149 t) (ert--should-error-handle-error form-description-fn-150 -condition- 'text-read-only nil) (setq value-146 -condition-))) (if errorp149 nil (ert-fail (append (funcall form-description-fn-150) (list :fail-reason "did not signal an error"))
)))) value-146)) (wgrep-finish-edit) (wgrep-save-all-buffers) (let* ((fn-151 #'equal) (args-152 (condition-case err (let ((signal-hook-function #'ert--should-signal-hook)) (list "FOO2\nBAZ\n" (wgrep-test--get-contents file))) (error (progn (setq fn-151 #'
signal) (list (car err) (cdr err))))))) (let ((value-153 'ert-form-evaluation-aborted-154)) (let (form-description-155) (if (unwind-protect (setq value-153 (apply fn-151 args-152)) (setq form-description-155 (nconc (list '(should (equal "FOO2\nBAZ\n" (
wgrep-test--get-contents file)))) (list :form (cons fn-151 args-152)) (if (eql value-153 'ert-form-evaluation-aborted-154) nil (list :value value-153)) (if (eql value-153 'ert-form-evaluation-aborted-154) nil (let* ((-explainer- (and t (ert--get-
explainer 'equal)))) (if -explainer- (list :explanation (apply -explainer- args-152)) nil))))) (ert--signal-should-execution form-description-155)) nil (ert-fail form-description-155))) value-153))))))) :most-recent-result nil :expected-result-type :
passed :tags (wgrep) :file-name "/<<PKGBUILDDIR>>/wgrep-test.el"))

load-with-code-conversion("/<<PKGBUILDDIR>>/wgrep-test.el" "/<<PKGBUILDDIR>>/wgrep-test.el" nil t)
command-line-1(("-l" "package" "--eval" "(add-to-list 'package-directory-list \"/usr/share/emacs/site-lisp/elpa\")" "--eval" "(add-to-list 'package-directory-list \"/usr/share/emacs/site-lisp/elpa-src\")" "-f" "package-initialize" "-L" "." "-l" "

wgrep-subtest.el" "-l" "wgrep-test.el" "--eval" "(ert-run-tests-batch-and-exit)"))

command-line()
normal-top-level()
dh_elpa_test: error: emacs -batch -Q -l package --eval "(add-to-list 'package-directory-list \"/usr/share/emacs/site-lisp/elpa\")" --eval "(add-to-list 'package-directory-list \"/usr/share/emacs/site-lisp/elpa-src\")" -f package-initialize -L . -l

wgrep-subtest.el -l wgrep-test.el --eval \(ert-run-tests-batch-and-exit\) returned exit code 255

make: *** [debian/rules:4: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

I think that's unrelated to silversearcher-ag though ;)

I don't remember seeing this (or I missed it :P) But as I mentioned
somewhere (mailing list or IRC, I forgot) it's probably easier just to
fix siversearcher-ag directly. So I'll retract this MR soon :)

Meanwhile (non Emacs), if you want to fix all packages in the archive
that depend on silversearcher-ag, in one shot:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=999962#18

It seems that the maintainer has been MIA. Do you suggest proposing an
NMU?

BTW, are you subscribed to this mailing list? In Debian we
conventionally don't CC people on mailing lists, even though we do CC
people on bugs.

I'm subscribed. Feel free to directly reply to the mailing list.

Regards,
Nicholas

--
Manphiz

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Manphiz <manphiz@gmail.com> writes:

Nicholas D Steeves <sten@debian.org> writes:

Manphiz <manphiz@gmail.com> writes:

To be fair, the following issue wasn't introduced by this MR, but was

[snip]

dh_elpa_test: error: emacs -batch -Q -l package --eval "(add-to-list 'package-directory-list \"/usr/share/emacs/site-lisp/elpa\")" --eval "(add-to-list 'package-directory-list \"/usr/share/emacs/site-lisp/elpa-src\")" -f package-initialize -L . -l

wgrep-subtest.el -l wgrep-test.el --eval \(ert-run-tests-batch-and-exit\) returned exit code 255

make: *** [debian/rules:4: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

I think that's unrelated to silversearcher-ag though ;)

I don't remember seeing this (or I missed it :P)

But as I mentioned somewhere (mailing list or IRC, I forgot) it's
probably easier just to fix siversearcher-ag directly. So I'll
retract this MR soon :)

This looks probably native-comp/trampoline-related to me, so I'm
guessing wgrep advises something. No idea why why the issues presents
in emacs29 but not in emacs28.

It seems that the maintainer has been MIA. Do you suggest proposing an
NMU?

Until a package has been orphaned by the MIA team, the question is NMU
vs salvaging:

https://wiki.debian.org/PackageSalvaging
https://www.debian.org/doc/manuals/developers-reference/pkgs.en.html#package-salvaging

If a minimal, targeted fix is possible (with a quilt patch) then an NMU
is faster, and doesn't implicate the uploader with long-term
responsibilities. The allowed changes are narrow, and strict.

If that's not possible, then salvaging the package is the only way to
save it and its reverse dependencies. Salvaging implies adoption. I
took a look at the available forks and I suspect that salvaging the
Debian package is what will be required.

BTW, are you subscribed to this mailing list? In Debian we
conventionally don't CC people on mailing lists, even though we do CC
people on bugs.

I'm subscribed. Feel free to directly reply to the mailing list.

Thanks!

Nicholas

-----BEGIN PGP SIGNATURE-----

iQJHBAEBCgAxFiEE4qYmHjkArtfNxmcIWogwR199EGEFAmT3fEgTHG5zdGVldmVz QGdtYWlsLmNvbQAKCRBaiDBHX30QYfy6D/9tIUEh8hvbYkc3JrY84i9ds/wLkreE qviRFxx8WcRFQQgzmge+RKwBJsD2Q3Bji4la0KBESmcp1qyTz6PBUAEap0NnRDQA mBK38v8ChLTbR0/LbzKrirjtPkaJxktcp46qTdWsJnJlDZsvmh66Q+swNLPv6lAP v36gvQ4dvUCjQvmCLaoLROmZF+uNmqOPemzdzsiQhh3XpGnwVFVawuvTOkOGf6o7 de2jKyFUYXeE0O6YHWKtcUvMiBOS6+jrHsHxRqsyFxBL8x+kFGF5vpzumIeDiNO5 HSwX3xk+5uPf04yHHF5xPGdvtXoxhRB1XXu2fxsp2zrcR5nxpcsNGctq+iFDjQCC AN37lLcJkgmq8okI5qBVOr0GewHhQVhV9ooBvtPe19W39x2Rb8NkcDrtLoK4L21R zQfGOfo+6mL8z1d50cDCvAY+pByHWwZ5ZV+6Cdrk7wcEQuR/7HGJ2bDfklXuKIlr bdjjJ7pOOJcjMh3Ps4tGbyXpEd2N3sD1EiW8uooYTFRlyspJHFsKCZFLMq70Yk0K NQGu3ZsZ3zBDNHxSONfROM7xAG17cOANAbnRUNvbIDpH2g+o+HvZb4+8k2CK1oeT VtAuYzzVXhm8XWvW8fCABgyBtVs6lhKgVb+gTXiRaFbr8kJ7vtMHicYauWSoQWlX lkzSMFfMXfLX1Q==
=ME2e
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Nicholas D Steeves <nsteeves@gmail.com> writes:

Manphiz <manphiz@gmail.com> writes:

[..snip..]

It seems that the maintainer has been MIA. Do you suggest proposing an
NMU?

Until a package has been orphaned by the MIA team, the question is NMU
vs salvaging:

https://wiki.debian.org/PackageSalvaging
https://www.debian.org/doc/manuals/developers-reference/pkgs.en.html#package-salvaging

If a minimal, targeted fix is possible (with a quilt patch) then an NMU
is faster, and doesn't implicate the uploader with long-term responsibilities. The allowed changes are narrow, and strict.

If that's not possible, then salvaging the package is the only way to
save it and its reverse dependencies. Salvaging implies adoption. I
took a look at the available forks and I suspect that salvaging the
Debian package is what will be required.

Added a note on the bug[1] mentioning an MR with cherrypicked/adapted a
patch set from upstream branch/fork that adds pcre2 support. Hopefully
an NMU can be considered.

BTW, are you subscribed to this mailing list? In Debian we
conventionally don't CC people on mailing lists, even though we do CC
people on bugs.

I'm subscribed. Feel free to directly reply to the mailing list.

Thanks!

Nicholas

--
Manphiz

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Manphiz <manphiz@gmail.com> writes:

Nicholas D Steeves <nsteeves@gmail.com> writes:

Manphiz <manphiz@gmail.com> writes:

[..snip..]

It seems that the maintainer has been MIA. Do you suggest proposing an
NMU?

Until a package has been orphaned by the MIA team, the question is NMU
vs salvaging:

https://wiki.debian.org/PackageSalvaging
https://www.debian.org/doc/manuals/developers-reference/pkgs.en.html#package-salvaging

If a minimal, targeted fix is possible (with a quilt patch) then an NMU
is faster, and doesn't implicate the uploader with long-term
responsibilities. The allowed changes are narrow, and strict.

If that's not possible, then salvaging the package is the only way to
save it and its reverse dependencies. Salvaging implies adoption. I
took a look at the available forks and I suspect that salvaging the
Debian package is what will be required.

Added a note on the bug[1] mentioning an MR with cherrypicked/adapted a
patch set from upstream branch/fork that adds pcre2 support. Hopefully
an NMU can be considered.

Seems I forgot about the link :P

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=999962#23

BTW, are you subscribed to this mailing list? In Debian we
conventionally don't CC people on mailing lists, even though we do CC
people on bugs.

I'm subscribed. Feel free to directly reply to the mailing list.

Thanks!

Nicholas

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Manphiz <manphiz@gmail.com> writes:

Manphiz <manphiz@gmail.com> writes:

Manphiz <manphiz@gmail.com> writes:

Added a note on the bug[1] mentioning an MR with cherrypicked/adapted a
patch set from upstream branch/fork that adds pcre2 support. Hopefully
an NMU can be considered.

Seems I forgot about the link :P

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=999962#23

Wow, that was fast! To be honest, I'd appreciate a second opinion about
if that meets the criteria for an NMU. To do this in the fastest way
possible probably means consulting the general mentor & sponsor pool by
filing an RFS.

https://mentors.debian.net/sponsors/

Did you check if enable_pcre2_support.patch looks like it might have
some new copyright statements that are not yet covered in
debian/copyright? Please note that I didn't check, but your sponsor
will expect that you have checked, and it would be best to check before
filing an RFS

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCgAuFiEE4qYmHjkArtfNxmcIWogwR199EGEFAmT6jMQQHHN0ZW5AZGVi aWFuLm9yZwAKCRBaiDBHX30QYVRKD/wIzSRq+LEtvCZgVU5tHy8EoQV2bGAX0onW BfkD1trNG3qLdUkqBsbyvUiDSbQSu8qLSh6EuGFQwd2sZFBe0CmoF2i7AvoY43CT oq7WGOk3Dgq7QOAgtR3MQ1POvNRRTtwEFLgjD4GfKAHrGKA4lQUp2DomLLiV/vsc /0/sY/8Q/nXPGWpfCOsW1c6gLRVlepLHOmaKgil2jo0UxLzwNet0GaAiCbg+Y7yg qWyGIApclyDLtgB+8Bguk0SQx7/KSntPSOz8Z+i8bRq5Wg/plrOpmoO//lffgwHj xNMHjSZ2fv1cgx8umeXusN2dWZQzVmJGk6MOE/a6yoyYSrbHBe3D8//Xr1XkUfKb e5qnDvFnMJQndzwf5ZFKkrfaMrhti89z5N1bzY2cipMVvp0n68fiDz9a9UgBXmHS HS7DhEg47nzeOZH3EdFvBItB4SRWQWio5J5YeNJ1bJoFkbWwWEUSDy1tGwFmVb8H fDE1vsqKXN1xQnXetDzNTzyerUsrgXWPvxs9yMyFvvkyB+UtmfPggfMkR2j2tbMp 7PXCamblBO9c/ESnqdB23Fjm64IvAe+I8zmIZTMBsdrsuGtG9J0VEoogHJ89KhmP 5cafIya2Vr0jkXBVIABQ0epjNTAF0w6ovm8odwu2HFAwW9P2qLqL16/g9JDFx3GA
L6QjIn8WaQ==
=2wRN
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Nicholas D Steeves <sten@debian.org> writes:

Manphiz <manphiz@gmail.com> writes:

Manphiz <manphiz@gmail.com> writes:

Manphiz <manphiz@gmail.com> writes:

Added a note on the bug[1] mentioning an MR with cherrypicked/adapted a
patch set from upstream branch/fork that adds pcre2 support. Hopefully
an NMU can be considered.

Seems I forgot about the link :P

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=999962#23

Wow, that was fast! To be honest, I'd appreciate a second opinion about
if that meets the criteria for an NMU. To do this in the fastest way possible probably means consulting the general mentor & sponsor pool by filing an RFS.

https://mentors.debian.net/sponsors/

Thanks for the pointer! Will take a look on the steps on filing a RFS
bug.

Did you check if enable_pcre2_support.patch looks like it might have
some new copyright statements that are not yet covered in
debian/copyright? Please note that I didn't check, but your sponsor
will expect that you have checked, and it would be best to check before filing an RFS

This patch is merged from a patch set from a fork[1] of the upstream.
On the surface it doesn't look like it has a different copyright notice
so it should be of the same Apache 2.0 license. Still it may be better
for a license expert to take another look.

[1] https://github.com/aswild/the_silver_searcher
--
Manphiz

--=-=-Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJGBAEBCgAwFiEEiKQfd6o81mjI+LWALell7WOCXJMFAmT67aQSHG1hbnBoaXpA Z21haWwuY29tAAoJEC3pZe1jglyTaBkP/iqAHjFfJ1OhTeuTDq3gXUEV1/jgLfAx Qts7MdMV8UOa7yw6D5KrNkaVG073S/WGFA3hpKkjWiRkmYQWJyEC7o65JwrFfmbq OSGxDZQSbMUJ6K0vS0au6Hupzs7O9wazMO7WmmB3u9vbRYUACMoFrfEafBcIHWyJ xRxvB7KeKv/bD+Zzx1SCnvVCaqntRmNG598NXPQYM43OZoPxnYrscLIg+bBR6zk4 H1+0/pGWtcRJ4YSB1eD5k/su/Vs7YME3VcXy0zF23nQnt3Qv+Qt52EHM6juZNJe9 n4ZPWw5rqpb9mlsUaU2bFJ9tkg/sPl4f2+4iPAko8H3Yt+ufdoFHGXQoP19I53ZR 9dFwnjb64FYj6XlXQX3XCDgwXH1KOnu9WXxa3au3cRYm0PecudNuT2m3e/C5AXIq 5ohmZhAmYW7UcJb8EF3q9JC4MZAqhBYNhH9LEy1txbqRk1SpX05mMoIdDRLr1cei DWxyhlWMnckYoLHxENur+yHYoHCKFfkWBYb7R3E9ZAuH8jwZWlSI9j3rn2quzSOn 1k5xLExX5CiMJDOnq1BUYnZEFvWpRe3rQEuI41wHFG9RKzyumIRtpmcrlL63URBA 42s31eCneQzqQV8aLKGboKfzB+UwbafMCBYM4ho3tpqWX3tPy9C5H6FxiPXIRaw1
E3k5Me3doSUL
=0+Sr
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (

Manphiz <manphiz@gmail.com> writes:

Nicholas D Steeves <sten@debian.org> writes:

Manphiz <manphiz@gmail.com> writes:

Did you check if enable_pcre2_support.patch looks like it might have
some new copyright statements that are not yet covered in
debian/copyright? Please note that I didn't check, but your sponsor
will expect that you have checked, and it would be best to check before
filing an RFS

This patch is merged from a patch set from a fork[1] of the upstream.
On the surface it doesn't look like it has a different copyright notice
so it should be of the same Apache 2.0 license. Still it may be better
for a license expert to take another look.

I understand ;) Yet you will probably need to use ripgrep or ack, or one
of the many license check programs but whatever tool you use, it's a
good habit to get into the following before proposing an upload:

cd root-dir-of-repo
ag copyright
ag ©
ag '\(c\)'

Most of the license check tools only require a single invocation, and
you might prefer their output.

debian/copyright isn't just about the logical license; we are also
expected to reproduce upstream license grants. In other words:

JOHN DOE worked on this, in this YEAR, and grants LICENSE, to
GROUP-OF-PEOPLE, under these CONDITIONS.

Sometimes "JOHN DOE" will be "TECH CORP", because the work was done on
company time/premises.

If I remember correctly, other distributions tend to only care about
LICENSE, and don't care about JOHN DOE, nor as much about
GROUP-OF-PEOPLE (ie: our DFSG no-descrimination policies).

As for facts: It looks like the Debian maintainer of this package didn't document copyright and license for the m4 stuff (your sponsor might
require this), and your patch is not work by Geoff Greer, so you'll
probably need to add Greer to the copyright file.

Best,
Nicholas

--=-=-Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCgAuFiEE4qYmHjkArtfNxmcIWogwR199EGEFAmT7XhUQHHN0ZW5AZGVi aWFuLm9yZwAKCRBaiDBHX30QYd4yEACIHP83rhPM3VYxS1Ohr14pfNBfjHNIHH2g MBedm1DAFDBTWMWyKVC6rw8mZLi2/aFSNucJeAt/PIKbr4yg86pN6/lf8xz8po+8 tqgVGXf7SLIX7/SkRilG4uW2oeFTJVFq7MeKyyZG7E79K6ijh5ED+fO361ahK+37 WB45JJ8kwyAGHYxuU8OKF/wvmaENin4ruJDb5ua7ouquxggV+t7ILimKHXrflL9z UvQPp3BaQdZz9y8loGrvsKTqAvlVcsad6DurP5B8vVLK1I912Bw6Vqju6dxEbxFe 5MJk/86kUjt2wSriJFbxvj+ytkiqdg6ynYRCICEu5qDf73F52XT/XLaAp3mp1Enl mI7a2uuD71SzVqQovLAkadLBvpKWPhjL9K0/9Gq2MC9dD1Jegu2E59mee7R1GYGl qvjFZYgMRFB958VKcpwZ1Wu9W5YFU9r4wbU6/8wANVa3mBiGHumP6STSrSj9aKeK lEXujnwoHYGn2gWtlqZQLEgS+DHOJUE5mgKKGMAeXD8NWqhhEj+I8if3jSBFiAlQ BzYRTwsquNAcIIrISzj5hkBzQvREJo6xjvCKHN1yAeW9sBgglJ1DM9OofEzrQpbX EkjpVQckj8AeRT9EssRP+jTpvjLT+XsZ38OJwdTJp2nSOlV2rSlOyVRZmpbjtO5m 9QK8qAmOGA==gRYs
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Nicholas D Steeves <sten@debian.org> writes:

As for facts: It looks like the Debian maintainer of this package didn't document copyright and license for the m4 stuff (your sponsor might
require this), and your patch is not work by Geoff Greer, so you'll
probably need to add Greer to the copyright file.

Gah, it looks like I wasn't paying close enough attention. "…so you'll probably need to add the copyright holder who is not Greer to the
copyright file"

--=-=-Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCgAuFiEE4qYmHjkArtfNxmcIWogwR199EGEFAmT7pg4QHHN0ZW5AZGVi aWFuLm9yZwAKCRBaiDBHX30QYWn5EACnj1x922RJdM7xxsJCbbjrtZFr0Im2Ig82 A+IeMX/KCIOZg3TRrCgpB06dd+G9BBrP2tC+dYlBxnhB/TMYGkHg4q3BIbalhFpO HfwQQzLRjZuEOJPF+HG945k/e/JaM68QnD6xz3qq7KD+PYE/p/7aK4GsL8tRP1NF IcMqkC3AYdPjPsnR0rObD4eqe5pFdyOmc4OcwP7EP0FZGy1MSeTb82OeXQBZCP2/ K3rqlhkVJNPeC5c7tpmCPDnXrIieKMuJYI8nrlxsJOLMRYGY6LxqMu7TmCe+A/QX 6VtZ8ZdSH1vqvgxb4hUMvyk6fOHErBi0ROhWNK3EpwqYAvEIJaS6ytpwv7oMFMqi K8d+HUmHUvFUWZeMmdeRobwOkTArLVcHjpdXqxsRR2jKglTrcbj7F8cySwc2KyAH 3DDEWKlfPrWh7sh9Kf2dggrzUjDtlqtPAx6Gmi33nkCpetITm9CFFXivC3kmv7rb e7JgQv48yDA6EUncb01V/+e81yowhXmvZ/k7ZRZTrHs4qGMf6aQmaAkbMWJc5c4S qYUHKMbKqNjIf79oO4FB8zdrfEjrfddpAp3KfN5pLWb3K+KqHCSkWScrkYhpBHnp qmuA3zV3desMDYVEBPvpZ1PoZ1c4g/R3dEQ3QNQtbsXGRQUpMdN/kU1R5p9P8zJJ yLJKYeow/g==5h2n
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Nicholas D Steeves <sten@debian.org> writes:

Nicholas D Steeves <sten@debian.org> writes:

As for facts: It looks like the Debian maintainer of this package didn't
document copyright and license for the m4 stuff (your sponsor might
require this), and your patch is not work by Geoff Greer, so you'll
probably need to add Greer to the copyright file.

Gah, it looks like I wasn't paying close enough attention. "…so you'll probably need to add the copyright holder who is not Greer to the
copyright file"

Thanks Nicholas! I used licensecheck and checked manually and updated d/copyright accordingly in my merge request[1]. PTAL, thanks!

[1] https://salsa.debian.org/debian/silversearcher-ag/-/merge_requests/1

--
Manphiz

--=-=-Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJGBAEBCgAwFiEEiKQfd6o81mjI+LWALell7WOCXJMFAmT+ooQSHG1hbnBoaXpA Z21haWwuY29tAAoJEC3pZe1jglyTZ/8P/RqPiFzqU1s/3o1kCB+FQ1gbaERy8gkX jPKI2OnW+g9Y1aAkEVw2KgPHNVmURgTb7EcUXBW2pdyhciPDj2OzlEJuu0prrN5F bE69VuEFr8wzdfOVDDp0QMZFGGiGKIDb/4fxNmLUDBAnDmBSXUm2dkmmLZ4Iikdw 7SGX2eOWqqSI6WueetHS9J0ZJIzqYdP93dJSRd4JUqio99T3iqjlV5zVaOzIKykG mmrvnvQsos17u7T3EbZhstoYNuYEhJxr+54QVRupJKb1kunXiWU6kwTw5njRqxAi 9FPbu1O0X7myny3fBzLuevczDz5q9+jdt3q63Ip1nfJny0WXARGXSBcgY23jBo+Q grWE+sbRqMboaXPSYImihZsL7k0jRA2WRmrQuMZ54qlBELN0eCdcAbXFxS9q09q+ lmQlWRnFqfsv6/tDtFFDAG0kDzP7S+Al1BTQO6GvKrtxlWhgMTQH14kvhBx88SGx CdQgVCoYngiULA1SS5rstLP7GN5wwG/6yXrlnAvyraoaWFPRp1b+xkL5rkAeL/ea +XQF2Qc/4Ia5KsMc3fH9ps1K8k58UYveBhzStbdofVzVOIV8NMDszlag2awyldvn O6SshnCQGJGSnzFY7rmesOAP2fEVFqTAtuCnAXdTjaOybPoYaAvdDa/tnbGBzaNZ
EOKb93ZhlZ96
=q8Bb
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (

Manphiz <manphiz@gmail.com> writes:

Nicholas D Steeves <sten@debian.org> writes:

Nicholas D Steeves <sten@debian.org> writes:

As for facts: It looks like the Debian maintainer of this package didn't >>> document copyright and license for the m4 stuff (your sponsor might
require this), and your patch is not work by Geoff Greer, so you'll
probably need to add Greer to the copyright file.

Gah, it looks like I wasn't paying close enough attention. "…so you'll
probably need to add the copyright holder who is not Greer to the
copyright file"

Thanks Nicholas! I used licensecheck and checked manually and updated d/copyright accordingly in my merge request[1]. PTAL, thanks!

[1] https://salsa.debian.org/debian/silversearcher-ag/-/merge_requests/1

Friendly ping.

--
Manphiz

--=-=-Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJGBAEBCgAwFiEEiKQfd6o81mjI+LWALell7WOCXJMFAmUKt0MSHG1hbnBoaXpA Z21haWwuY29tAAoJEC3pZe1jglyTh+cP/RQpTRfCfoRVGF4sHzdPu3UH650WGiCm DWZjAEIml3Uh7ZFORwQKMhUapcwuLspZkQ9tjoiJKpzI6uxz5Ck9jNqT4nIz+XZD XtvZ3BswFaFwJZupcWz5B5yCDYBmP4ZbnOzeKmwJ1w57anbAex1Shuol3AGj2Fwm i67eGWKz6J5wCgImJ/hxpROUGNFdt7PchHeZFHZ569IcnAf9K6eMHarf3bi3wcdJ BX/x0x7oGImE22MRiYWiCPQfXTUJQaCqdwm3kdSi/pYMArpEzasOmDCP4yK2qTsJ Q1BqYBzhZ+FHs4p7Q9jxWIsy6yL1P/TFnat/nXK1q66COHw/JxAgZ7avZHjFQzjp SRn85w48wXVEVRfSEWQZ/7qh2rWCrsHwiHa9znKKXSdDi/fNBEO3cxJU9NGeh0TS 9tgIxkselcL5TJB5aGikAyLr/weBMDieOZsVgJixhWu3fQg+X6xvxhF4D7f7NHcE +PrEztZgeovr36OqO2xZ8OoHVeF5fXiYFJnMlXHmWX6MoLMbcfvNuaeySO/WMXem QgLRPxZK6tohMbbs5nHWUiIsLWOv5fM1NU3QwzxvDiJygjow9lJieC/ZuPP5BZMr RG5k6A/dQIkiLCXUI93Q5vOenBymljonQBoOFaRnrPUuFT/GbsLT3GvYCUTvEira
kD17f7+uJdhy
=sfCm
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (