XPost: linux.debian.bugs.dist

control: tag -1 +patch

On Wed, Aug 01, 2012 at 08:07:01AM +0900, Charles Plessy wrote:

Otherwise, how about something along these lines: [...]

Commenting on Charles' patch, I think that it would be clearer to have
the 'should' and 'must' requirements in separate sentences.

Thus I am seeking seconds for the following patch:

diff --git a/policy/ch-source.rst b/policy/ch-source.rst
index f706a13..89b355a 100644
--- a/policy/ch-source.rst
+++ b/policy/ch-source.rst
@@ -99,10 +99,11 @@ later reconfigure the package without losing the changes you made.
Debian changelog: ``debian/changelog``
--------------------------------------

-Changes in the Debian version of the package should be briefly explained
-in the Debian changelog file ``debian/changelog``. [#]_ This includes -modifications made in the Debian package compared to the upstream one as
-well as other changes and updates to the package. [#]_
+Every source package must include the Debian changelog file, +``debian/changelog``. Changes in the Debian version of the package
+should be briefly explained in this file. [#]_ This includes
+modifications made in the Debian package compared to the upstream one
+as well as other changes and updates to the package. [#]_

The format of the ``debian/changelog`` allows the package building tools
to discover which version of the package is being built and find out

--
Sean Whitton

-----BEGIN P

XPost: linux.debian.bugs.dist

Sean Whitton <spwhitton@spwhitton.name> writes:

Thus I am seeking seconds for the following patch:

diff --git a/policy/ch-source.rst b/policy/ch-source.rst
index f706a13..89b355a 100644
--- a/policy/ch-source.rst
+++ b/policy/ch-source.rst
@@ -99,10 +99,11 @@ later reconfigure the package without losing the changes you made.
Debian changelog: ``debian/changelog``
--------------------------------------

-Changes in the Debian version of the package should be briefly explained
-in the Debian changelog file ``debian/changelog``. [#]_ This includes -modifications made in the Debian package compared to the upstream one as -well as other changes and updates to the package. [#]_
+Every source package must include the Debian changelog file, +``debian/changelog``. Changes in the Debian version of the package
+should be briefly explained in this file. [#]_ This includes
+modifications made in the Debian package compared to the upstream one
+as well as other changes and updates to the package. [#]_

The format of the ``debian/changelog`` allows the package building tools
to discover which version of the package is being built and find out

Looks good to me. Seconded.

--
Russ Allbery (rra@debian.org) <http://www.eyrie.org/~eagle/>

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

XPost: linux.debian.bugs.dist

Sean Whitton wrote:

On Wed, Aug 01, 2012 at 08:07:01AM +0900, Charles Plessy wrote:

Otherwise, how about something along these lines: [...]

Commenting on Charles' patch, I think that it would be clearer to have
the 'should' and 'must' requirements in separate sentences.

Thus I am seeking seconds for the following patch:

diff --git a/policy/ch-source.rst b/policy/ch-source.rst
index f706a13..89b355a 100644
--- a/policy/ch-source.rst
+++ b/policy/ch-source.rst
@@ -99,10 +99,11 @@ later reconfigure the package without losing the changes you made.
Debian changelog: ``debian/changelog``
--------------------------------------

-Changes in the Debian version of the package should be briefly explained
-in the Debian changelog file ``debian/changelog``. [#]_ This includes -modifications made in the Debian package compared to the upstream one as -well as other changes and updates to the package. [#]_
+Every source package must include the Debian changelog file, +``debian/changelog``. Changes in the Debian version of the package
+should be briefly explained in this file. [#]_ This includes
+modifications made in the Debian package compared to the upstream one
+as well as other changes and updates to the package. [#]_

The format of the ``debian/changelog`` allows the package building tools
to discover which version of the package is being built and find out

Seconded. Thanks for tying up this loose end.

Sincerely,
Jonathan

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

XPost: linux.debian.bugs.dist

On Mon, Aug 21, 2017 at 05:22:12PM -0700, Sean Whitton wrote:

Commenting on Charles' patch, I think that it would be clearer to have
the 'should' and 'must' requirements in separate sentences.

Good idea.

diff --git a/policy/ch-source.rst b/policy/ch-source.rst
index f706a13..89b355a 100644
--- a/policy/ch-source.rst
+++ b/policy/ch-source.rst
@@ -99,10 +99,11 @@ later reconfigure the package without losing the changes you made.
Debian changelog: ``debian/changelog``
--------------------------------------

-Changes in the Debian version of the package should be briefly explained
-in the Debian changelog file ``debian/changelog``. [#]_ This includes -modifications made in the Debian package compared to the upstream one as -well as other changes and updates to the package. [#]_
+Every source package must include the Debian changelog file, +``debian/changelog``. Changes in the Debian version of the package
+should be briefly explained in this file. [#]_ This includes
+modifications made in the Debian package compared to the upstream one
+as well as other changes and updates to the package. [#]_

The format of the ``debian/changelog`` allows the package building tools
to discover which version of the package is being built and find out

LGTM, seconded.


That said, I'd expect the upgrade-checklist to say that this change is
about clarifying that debian/copyright must exist (where before it was
"fine" not existing).

--
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEi3hoeGwz5cZMTQpICBa54Yx2K60FAlmbz6AACgkQCBa54Yx2 K63fMQ/9FgBcEThSg+j8if6sjzBuzgW/34setLipKU3frIxNxr5Frsdznzncwb0m pXL3+OcKEMM4CCZU0BtHyqFLbK4WvIVcOzm+WYKFanYXuijvqMi2KLoMtApFpWuY DPhEqRZzj5+WuAYY/qFlQPEU2utYGQ9OVgWk1uuFx1euGsVjYNA+pwc1fsrWQ9bO k0hIXlQWvDqHOTc20xFu8vDnlVfZTaCbQkBgUM5VIRyCNM2xJ5rETUxJbWVwICLQ r7tgMacm9vu9925xdPBPyW7HLyz3HozIu/BEepEl167+YWPnjKcDVNVfQRFisDHY /rcWLVTchCO0VkB+9VYNp304zdXaiqsR6Eq3udxWrP9/gVJ6A3tOUGsy4iMXCgSR iZ8dUmlGiYvEKS1N1nvA2aOA37u+e5p6iChdbm+vwi+NmWxy8IHbaW7qxS7m3Ybq tbZLcgejH54vks3l+n0twxIMDQepHUfzkDrZgzoV9kQtBAaWQo0yE+suj1hu2JwK vc++opmWyqwEgtIjpGICMN2FXLuj/trp3zHxF3svGH5qfBnTwUp

XPost: linux.debian.bugs.dist

control: tag -1 +pending

Hello,

On Tue, Aug 22 2017, Mattia Rizzolo wrote:

LGTM, seconded.

Applied, thanks.

That said, I'd expect the upgrade-checklist to say that this change is
about clarifying that debian/copyright must exist (where before it was
"fine" not existing).

Not sure what you're asking. Let me know if what I just pushed could be better.

--
Sean Whitton

--=-=-Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEm5FwB64DDjbk/CSLaVt65L8GYkAFAlmca5MACgkQaVt65L8G YkAXxA//bgLQSuXcVyf7eL5+AOrRbrgwwL7qJN/Z6gHK+FT9DB6oAnmYWNl7YMIB IMMNAsxq8ylwbJP9rESuRVMiCZL2UH1tEJuvVzolNwdtgOHglU34Ie+zxaa6dvhN 32fLXpSkgM9oLPWD7IZdIh88/Kou54SMcaYgNLKY9CSReGhzIyPS60cDi9n/zMT3 i+tEmMXmibR7jnXFDv/ec/h9+h6eo3A0Bm4FQ/LpV74+dPrPCgpwfYOpErL1K2L5 d1D/yHZpJM+x02cjNVcyh2IK/RCJq4vSytZ3ieqYhQIM8BazCFsBPg0pD/MW0ARg kn3pIKbB3DjLE4Kyt8xGi57JQ0YDASlavrqQcUBhwYcigtnRvBy4XCIDYp0i7FKo Sq/xiJk1Ctx6/WRquX2wUs4Hr9VSeEIQ7Alo3NCFy5tueXChfJtNkETabMU1GlGV xhSBr7iODFod4EAjPlYiPm3L/DmjdeWxQgtYVqwC/ocFciPG+oTNaLginru4+CWU kxHyBsG3f8MeJmYbliEX4+fGryUWewu2yn0PQCTpuGCH4+DPylMQHAq/i+J61N9Y qbOJQPcYDf/Y1tw/KnD1J2bVI/U9K54M5pqy/qoWI5wFBI61T0vAXH+xqxmoiDgt U06Wigx2VX5xFVFB7lBqPwt2vT39FEOogp2qaIm5AJ3HxWMVroU=vhkc
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)