• Bug#515856: [debhelper-devel] Bug#515856: debhelper: please implement d

    From Bill Allombert@21:1/5 to Helmut Grohne on Mon Sep 18 12:40:04 2017
    XPost: linux.debian.bugs.dist

    On Fri, Sep 01, 2017 at 06:52:27AM +0200, Helmut Grohne wrote:
    According to codesearch.d.n, get-orig-source is implemented by less than
    3000 source packages. This is not very low, but neither a high adoption
    rate. It certainly makes using get-orig-source somewhat useless on a distribution-scale. In contrast, we have some 22500 watch files, an
    order of magnitude more. I think it is obvious which mechanism has won.

    get-orig-source and watch files serve a different purpose.

    get-orig-source is used to build the .orig. tarball from the true
    upstream one. Most package do not need that. Watch files could not do
    that until recently.

    So the comparaison is unfair.

    What need to be checked is how many get-orig-source rules has been reimplemented in term of watch files.

    Cheers,
    --
    Bill. <ballombe@debian.org>

    Imagine a large red swirl here.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Holger Levsen@21:1/5 to Helmut Grohne on Mon Sep 18 12:10:02 2017
    XPost: linux.debian.bugs.dist

    On Fri, Sep 01, 2017 at 06:52:27AM +0200, Helmut Grohne wrote:
    According to codesearch.d.n, get-orig-source is implemented by less than
    3000 source packages. This is not very low, but neither a high adoption
    rate. It certainly makes using get-orig-source somewhat useless on a distribution-scale. In contrast, we have some 22500 watch files, an
    order of magnitude more. I think it is obvious which mechanism has won.

    agreed.

    [...]
    I believe that if debhelper is not going to support us in increasing get-orig-source adoption, then we should just stop doing it and move on
    to watch files.

    agreed.

    I am attaching the removal patch and call for seconds.

    Helmut

    diff --git a/policy/ch-source.rst b/policy/ch-source.rst
    index f706a13..27c49b5 100644
    --- a/policy/ch-source.rst
    +++ b/policy/ch-source.rst
    @@ -368,19 +368,6 @@ The targets are as follows:
    Instead, the upstream source should be repacked to remove those
    files.

    -``get-orig-source`` (optional)
    - This target fetches the most recent version of the original source
    - package from a canonical archive site (via FTP or WWW, for example),
    - does any necessary rearrangement to turn it into the original source
    - tar file format described below, and leaves it in the current
    - directory.
    -
    - This target may be invoked in any directory, and should take care to
    - clean up any temporary files it may have left.
    -
    - This target is optional, but providing it if possible is a good
    - idea.
    -

    seconded.


    --
    cheers,
    Holger

    -----BEGIN PGP SIGNATURE-----
    Version: GnuPG v1

    iQIVAwUBWb+L/gkauFYGmqocAQoqjQ/9HTkoZerHkEr2FcKQJHpPKVGuqVnGnkUJ bYN5XxWgOBg/P6EHPyhpgLTLD8+CWBwMVnQFUYMRNl0DY3f9PWYNv3IQKZaX6WTC vRN/wyPnwoJudZw/0EVBU4xjyMIsq/QfoDs0tCBNEutYs+0sAeviYZqlBi4/uCp5 p3WJBDTaAyMhQA8xtK1Q7+Blm17SCqB/L7xdefZLRM98JRE9vyoaz6ste6VirwMl v90d4QcGOPo0SJBoInIO4JK9TQbu3m2ZD1MHwS/cTQRYDuywiVTZW6leQMXyUcTD Ma0aT7o8LEYiYHHhrHW4jtQ30YakreEadPswJ6w6rJeJmc5lGgaElwYyRc5xvu3V mstQbSMFaDLxL/gXYyuVIdx67zofM2XaEvX7FiqyyfvmQXelAoe6UXjMdCY+iQVr NbIfZwV0WviWW86TByAumjTcglhiu13Z3eF+XD97oeley+j05dSlGzUrxFnes8jf JRi6jUePVMm5hCHEMr56cz7/OA5CSYe+ANlBzpR0uonFZqbKWUHCwD74thcqLPeg /7GeHRnfJvEbGKPyJVuhfHZkmJixzXkvm+YU2ekL6E2TgPqCJ9aQ7Cgwm1vEBSts lXbqSREgsuRi/WkqINOGpieh9Q5lFEnZ/8j3kMWYPJtDSojO0XIiBwQi4bA7HQgo
    REhny9KTT0s=
    =GnbK
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Bill Allombert@21:1/5 to Helmut Grohne on Mon Sep 18 14:10:01 2017
    XPost: linux.debian.bugs.dist

    On Mon, Sep 18, 2017 at 12:38:49PM +0200, Helmut Grohne wrote:
    On Mon, Sep 18, 2017 at 11:28:42AM +0200, Bill Allombert wrote:
    get-orig-source and watch files serve a different purpose.

    get-orig-source is used to build the .orig. tarball from the true
    upstream one. Most package do not need that. Watch files could not do
    that until recently.

    So the comparaison is unfair.

    What need to be checked is how many get-orig-source rules has been reimplemented in term of watch files.

    Challenge accepted. ticharich.d.o has an unpack of rules debian/rules
    files. Most of them are world-readable. A small number (~30) are inaccessible, so my analysis will have an error of around 0.2%.

    A simple method is to just look at which of them contain the string "get-orig-source" and which of them contain the string "uscan" assuming
    that when both show up, get-orig-source is implemented using uscan.

    One would need to check whether get-orig-source use uscan for repacking
    or if it only use uscan for downloading and then repack manually.

    Cheers,
    --
    Bill. <ballombe@debian.org>

    Imagine a large red swirl here.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Helmut Grohne@21:1/5 to Bill Allombert on Mon Sep 18 13:50:02 2017
    XPost: linux.debian.bugs.dist

    On Mon, Sep 18, 2017 at 11:28:42AM +0200, Bill Allombert wrote:
    get-orig-source and watch files serve a different purpose.

    get-orig-source is used to build the .orig. tarball from the true
    upstream one. Most package do not need that. Watch files could not do
    that until recently.

    So the comparaison is unfair.

    What need to be checked is how many get-orig-source rules has been reimplemented in term of watch files.

    Challenge accepted. ticharich.d.o has an unpack of rules debian/rules
    files. Most of them are world-readable. A small number (~30) are
    inaccessible, so my analysis will have an error of around 0.2%.

    A simple method is to just look at which of them contain the string "get-orig-source" and which of them contain the string "uscan" assuming
    that when both show up, get-orig-source is implemented using uscan.

    The following packages do not implement get-orig-source with uscan:

    biojava4-live
    boinc-app-seti
    cjk
    edk2
    fasttree
    freeorion
    freerdp
    gr-air-modes
    gr-fcdproplus
    gr-iqbal
    gr-osmosdr
    htmlunit
    ioquake3
    iortcw
    josm
    libb64
    libreoffice
    libtgvoip
    neobio
    nvidia-graphics-drivers
    nvidia-graphics-drivers-legacy-304xx
    pencil2d
    pixelmed
    qemu
    r-cran-rniftilib
    sagemath
    west-chamber
    zsh

    So we have around 22500 source packages with watch files, we have 3000
    packages with get-orig source, of those 28 don't use uscan. The fair
    comparison is 22500 vs. 28. That's almost 3 magnitudes. If anything,
    policy should document debian/watch, not get-orig-source. The perl
    policy, python policy, elpa policy, ... each affect more packages than get-orig-source. Keeping it is uneconomic.

    Helmut

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)