• Re: unbreaking LibreOffices tests on at least release architectures

    From Rene Engelhard@21:1/5 to All on Sun Jun 18 22:30:01 2023
    Hi again,

    some more comments.

    Am 18.06.23 um 21:28 schrieb Rob Landley:
    No, that's how I read it too. You said getting the _architectures_
    removed, not
    getting libreoffice removed from those architectures.

    That is hilarious. The subject says we are talking about LibreOffice
    here, not generally about Debian.

    I might have written architectures, but from the context it should have
    been clear. Anyway, I corrected it.

    Of course I mean "getting those architectures removed from unstable"
    *for libreoffice*.

    here.

    Besides that it would also have been clear from actually reading the IRC
    log which incidentially also says

    "17:24 < elbrus> if I were you, I'd make them fatal everywhere and ask
    for removal from architectures where reasonable tests fail
    17:25 < elbrus> extreme case you only ship on amd64 and arm64"


    (libreoffice) *removal from architectures*

    This is the same GPLv3 package that Red Hat just dropped support for?

    As I said in my other reply,  even if it was GPLv3 it wouldn't be
    relevant at all.

    LibreOffice is not GPLv3 though and never was.


    How long has the problem you're treating as a crisis been brewing?

    Basically ever since people ported, the tests back then pass and then
    new tests broke and noone seriously cared until me as not-porter needed
    to sweep it under the carpet eo get it "ready" for release (because it otherwise was supposed to be removed).

    Or since people added a new arch in LibreOffice but didn't dare of
    finishing it so that even the important tests pass.


    Even if it works now, who says that with ignored tests something
    fundamental breaks (like python thingies in riscv64, which is a integral
    part of many LO things). Or some basic functionality? Causing a RC bug
    which is unfixable for me.


    Replying with something completely unrelated doesn't help here. No idea
    why you bring up GPLv3 or RH stopping support for it (which is bad for
    this case, though, since at least they did fix some tests on s390x etc.,
    but we actually do have porters, too) here on a mail which just aims at
    porting LibreOffice / making it actually pass its tests to improve quality.


    Regards,


    Rene

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Jeffrey Walton@21:1/5 to rene@debian.org on Tue Jun 20 06:30:01 2023
    On Mon, Jun 19, 2023 at 11:50 PM Rene Engelhard <rene@debian.org> wrote:

    Am 20.06.23 um 00:03 schrieb Jeffrey Walton:

    You can usually uncover them by building the package with CFLAGS=" ... -fsanitize=undefined ... " and CXXFLAGS=" ... -fsanitize=undefined ...
    ". The UBsan sanitizer operates on real data. There are no false
    positives.

    I'd personally assume this isn't UB since upstream builds with UBsan for testing (admittedly not on mipsel, though). But once can investigate here...

    Yeah, there's a caveat: you have to have complete self tests. If the
    project lacks complete self tests, then you may not uncover the bug.

    You can run the program in production with a sanitizer build. It may
    uncover cases that were lacking in the test cases.

    And it's unfortunate some arches lack Asan and UBsan support. They are
    such powerful tools. Sometimes you can tease-out the UB on a different
    arch. Sometimes you can't.

    Jeff

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Adrian Bunk@21:1/5 to Rene Engelhard on Tue Jun 20 10:50:01 2023
    On Tue, Jun 20, 2023 at 05:52:44AM +0200, Rene Engelhard wrote:
    Hi,

    Am 19.06.23 um 23:29 schrieb Rene Engelhard:
    The pragmatic option would be to run only a smoketest for build success on architectures not tested by upstream.

    And have Format->Character in Impress crash with Bus error like on
    mipsel? That doesn't sound too good for basic quality.

    There is a "smoketest" but it does just basic start. open, close stuff.
    Not even basic usage.

    That said, that is the smoketest on mipsel:
    ...

    Assuming the smoketest currently also fails on riscv64, what about the following:
    - make all test failures fatal on a*64 (since upstream tests these), and
    - make smoketest failures fatal on all architectures (including ports)

    Regards,

    Rene

    cu
    Adrian

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Paul Wise@21:1/5 to Kurt Roeckx on Wed Jun 21 04:20:01 2023
    On Tue, 2023-06-20 at 22:46 +0200, Kurt Roeckx wrote:

    Can I suggest that if you file a few bugs and add some information in
    it so that maybe someone can look at it? If it only affects one
    architecture, send a mail to that list asking for help.

    PS: when filing architecture-specific bugs, please also set the BTS
    usertags and XCC the ports lists for the architectures effected.

    https://wiki.debian.org/Teams/Debbugs/ArchitectureTags

    --
    bye,
    pabs

    https://wiki.debian.org/PaulWise

    -----BEGIN PGP SIGNATURE-----

    iQIzBAABCgAdFiEEYQsotVz8/kXqG1Y7MRa6Xp/6aaMFAmSSXS8ACgkQMRa6Xp/6 aaPbBA//WjB4eWcONJC13C0JdjLIPLkRSOvn842amdpeRG6fazdQZJ3h6WpxbfTo ZOUkcgDXbVD+/t+rPV7uSUPh5RSXN22mg+DIkd+UTO7IJ10JunKgs9/wv28jWTZI fsmbvEjwL40612nSn7e0B8bXC6/IwVaIq7kdHWD+XMmuywJ3QBu6SRF2mIa5rBYb gFgjjYrMPtGjdOAHdSCrwep4c3rzZtToEoq1KmMmGK4aAoGboPzCQJUUvY86TpT/ En4uqVE7KsQGMvCnihUZStWV0mxHZAj+X31tTgPeoxOzpluumCnFEifFhEscu4qe nvuWE4ZrQfUoRfrHd2jqgbgDPK7AHHhrAvQXBDH/KMR7QV2KX1/j3GXuVxN8n+Q0 G7AYirvkq+UbQmsZfM16gsA5eqduEVFU6odwgA/PPEamMkqS8LcnGZqXzT04KcK1 JgTE6CEKj3gaV+lIYUhAIX0SNB73tL+iEWgP3PNZQKbgYzDvoDORh7A5pQ5Y8WRi iw0IggPjCFyo4O+x1YFjIdjOaHwyBOY/f8R+RnC0GMwiBdfKDXlbmQlCk+LNdJLa pfHck76UW6o7+JoZUi4wgmpWYv4BOFa8yT9uWfgi+ZDRU9pYVqbUrysYd9qL4RQ+ wCmIdixPfvQbuxW50eYe1LDS/iavC+D7iGB2xoH9zzK7hLRDbCg=
    =Pio6
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Andreas Schwab@21:1/5 to Rene Engelhard on Sat Jul 22 15:00:01 2023
    On Jul 22 2023, Rene Engelhard wrote:

    And that includes LibreOffice-bundled extensions like the english,hungarian,russian grammar checker for example. Ot external finnish spellchecking, hyphenation and grammer checking. Or turkish spellchecing.

    And those are extensions written in python which neither register when registering manually nor when being installed as bundled extensions (see
    the discussion in this thread, not going to reiterate)

    How can I test that? I have never used libreoffice before, so I don't
    know what to look for.

    --
    Andreas Schwab, schwab@linux-m68k.org
    GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
    "And now for something completely different."

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Andreas Schwab@21:1/5 to Rene Engelhard on Sat Jul 22 15:30:02 2023
    On Jul 22 2023, Rene Engelhard wrote:

    https://lists.debian.org/debian-riscv/2023/07/msg00014.html is for manual thing. And the IRC log shows that even libreoffice-lightproof-en etc don't appear as bundled extensions.

    $ unopkg list --bundled
    All deployed bundled extensions:

    Identifier: org.openoffice.en.hunspell.dictionaries
    Version: 2022.05.01
    URL: vnd.sun.star.expand:$BUNDLED_EXTENSIONS/lightproof-en
    is registered: yes
    Media-Type: application/vnd.sun.star.package-bundle
    Description:
    bundled Packages: {
    URL: vnd.sun.star.expand:$BUNDLED_EXTENSIONS/lightproof-en/Lightproof.components
    is registered: yes
    Media-Type: application/vnd.sun.star.uno-components
    Description:

    URL: vnd.sun.star.expand:$BUNDLED_EXTENSIONS/lightproof-en/Linguistic.xcu
    is registered: yes
    Media-Type: application/vnd.sun.star.configuration-data
    Description:

    }

    --
    Andreas Schwab, schwab@linux-m68k.org
    GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
    "And now for something completely different."

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)