1. Forum
  2. Usenet
  3. LINUX.DEBIAN.DEVEL.MENTOR

  • Re: RFS: rinetd/0.73-0.1 [NMU] [ITA] -- Internet TCP/UDP redirection se

    From Helmar Gerloni@21:1/5 to All on Tue May 17 22:00:01 2022
    First of all thanks for uploading the new package!

    I noticed one little thing: While I was working on the the code from https://github.com/samhocevar/rinetd/tags, the code in the Debian package comes from https://github.com/samhocevar/rinetd/releases. Of course the code is quite the same, but the "tags"
    code is in Unix format, the "releases" code in DOS format (with CRLF line terminators). The file /etc/rinetd.conf in the package now is in DOS format (same for README.md and index.html). Rinetd works great anyway, but CRLF line terminators are quite
    unusual on Linux.

    Am Montag, 9. Mai 2022, 22:04:01 CEST schrieb Helmar Gerloni:
    Upload #3 is now on Mentors:

    * Non-maintainer upload.
    * New upstream release (Closes: #1010732).
    * Added systemd service file debian/rinetd.service.
    * Added debian/watch.
    * debian/rules: CHANGES renamed to CHANGES.md.
    * debian/docs: README renamed to README.md.
    * debian/init: Added Description.
    * debian/copyright: Update to DEP5 format.
    * Removed debian/compat (9).
    * debian/control:
    + Added Homepage.
    + Removed debhelper (>= 9.0) from Build-Depends.
    + Added debhelper-compat (= 13) to Build-Depends.
    + Added procps to Depends (for rinetd.service).
    + Added lsb-base to Depends (lintian error).
    + Removed dh-autoreconf from Depends (lintian warning).
    + Added ${misc:Pre-Depends} to Pre-Depends (lintian warning).
    + Added UDP to Description (supported since 0.70).

    Hopefully the watch file is ok. uscan seems to be happy.
    I reverted the Standards-Version to 3.9.6.
    changelog and copyright are a little bit more precise now.

    Am Montag, 9. Mai 2022, 19:35:58 CEST schrieb Bastian Germann:
    On Fri, 29 Apr 2022 22:55:25 +0200 Helmar Gerloni <helmar@gerloni.net> wrote:
    rinetd (0.73-0.1) unstable; urgency=medium
    .
    * Non-maintainer upload.
    * New upstream release (...).
    * Added systemd service file debian/rinetd.service.

    ExecReload calls kill, so you have to add Depends: procps.

    * Added debian/watch.

    Please scan https://github.com/samhocevar/rinetd/releases for rinetd-VERSION.tar.gz.
    That will contain the autogenerated files similar to the current package's origtargz.
    Reupload should be based on that file.

    * debian/rules: CHANGES renamed to CHANGES.md.
    * debian/docs: README renamed to README.md.
    * debian/copyright: Update to DEP5 format.

    Please also add the src/getopt.* copyright.

    * Removed debian/compat.
    * debian/control:
    + Added debhelper-compat to Build-Depends.
    + Added lsb-base to Depends (lintian error).
    + Removed dh-autoreconf from Depends (lintian warning).

    That warning appears because you also raised the compat version which I do not read here...

    + Added ${misc:Pre-Depends} to Pre-Depends (lintian warning).
    + Added UDP to Description (supported since 0.70).
    + Updated Standards-Version to 4.6.0.1

    Please note that the 4th version part is ignored, so please only use the first three.
    The Standards-Version should only be raised on actually reviewing the package for adhearing to the
    newer version. If you have not reviewed the package, please drop this change.

    Else this looks good to me.




    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)