• Re: seeking RFS for pat v0.12.0-1

    From tony mancill@21:1/5 to Federico Grau on Fri Dec 31 18:00:02 2021
    On Fri, Dec 31, 2021 at 11:11:03AM -0500, Federico Grau wrote:
    On Tue, Dec 28, 2021 at 08:39:52PM -0500, Federico Grau wrote:
    On Sun, Dec 26, 2021 at 09:02:36AM -0500, Federico Grau wrote:
    ...
    seeking an upload of v2.3.0-3 of go-serial. This version has a d/patches fix
    to resolve ppc64le build errors.


    As there are cycles I'm now seeking an upload of golang-github-la5nta-wl2k-go
    v0.8.0-1. This is the next (and hopefully last for this wave) dependency for
    the `pat' ham radio email utility package.


    With wl2k v0.8.0-1 now in unstable, I'm now seeking an upload of pat v0.12.0 to hopefully close out this wave.

    I will review and sponsor an upload. Please push your pristine-tar
    branch and updated upstream branch to Salsa. At the moment, I only see
    the debian/sid and an outdated upstream branch [1].

    Cheers!
    tony

    [1] https://salsa.debian.org/debian-hamradio-team/pat/-/branches

    -----BEGIN PGP SIGNATURE-----

    iQIzBAABCgAdFiEE5Qr9Va3SequXFjqLIdIFiZdLPpYFAmHPNbYACgkQIdIFiZdL PpZOCRAAzmA4QlWHme3dTTGe+8RtPqa4BsA345yBdwCsW0T0/roNkIEBOBiX6Dpq 0Rj9AjnaXCgMc4RZR/AvpFbnq9QtZ1wq5eOEzN+8gpkXK+sU5vKJVG1qImGCqlTV OfqjHbVwMvcENEwUndiLOKlGaf39njFsJ/kCR3Ab1//D/Fn+LgoCZwwYmBbyJwJV E1yz1iIT7tqVXoWeiBqPKwetX/65F6drDQqKHjKHEVR43592dUNpxgc1vEPg2O3n P01I5u+t1CoN5wyJQKniBI8HJgGWHwdw1opkJnrKizgC7z7dpY3jLBLE4Bai6OqS S/4gIdZqwphjqp6SMXzkGR1sqmWEk93igOTeFOnXeLLC/REJvzGd1cK/RpUUNsAJ 8iMp/Hd2zNzw6Ka8uKZd2yKq2HiLHr7FUdbhsrk9PXKXMzeMGU424xuF8tfos+TI qihFR83GqfjpyRB0AMMw078EsDsoFZDBcjfWQFdDEuKHOu6tYsJGxGedRyTJNylI hS6MPLcCPOuAXPm/1VUguxTGEBAEASIhxbk0Ofv9IkSMOu3z9XtdOyS6y1/tYmDl 0VYfIQgRM7wrzm0OGVAa1ctFmuB+C2Pmca3fxkcF51n8bLTls7V1BIVFy3qhQWDB z0+7+Jupb4rKDGPx+G//IAt9x+joKY56lqtb26TgNPCtsZrHEpI=
    =JdjC
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Federico Grau@21:1/5 to Federico Grau on Fri Dec 31 17:20:01 2021
    On Tue, Dec 28, 2021 at 08:39:52PM -0500, Federico Grau wrote:
    On Sun, Dec 26, 2021 at 09:02:36AM -0500, Federico Grau wrote:
    ...
    seeking an upload of v2.3.0-3 of go-serial. This version has a d/patches fix
    to resolve ppc64le build errors.


    As there are cycles I'm now seeking an upload of golang-github-la5nta-wl2k-go v0.8.0-1. This is the next (and hopefully last for this wave) dependency for the `pat' ham radio email utility package.


    With wl2k v0.8.0-1 now in unstable, I'm now seeking an upload of pat v0.12.0
    to hopefully close out this wave.

    thanks,
    donfede


    -----BEGIN PGP SIGNATURE-----

    iQIzBAABCAAdFiEEmr4kxVySlu8VKlyYL/shsp/kV2QFAmHPK5EACgkQL/shsp/k V2Qmhw/5AftvmItz7xsbjgtIfJn197Lwuqt/+yi1u06qTcIvMoP/mxGDrwjsB/gx 6vU8Vpwn8/5SF//rVWIJBfTwv5fsVawMr/TnV/ZOW4lmE5H2DreODaoJu3Ur2iYC 54pYtwPcV3bez3dqcpCIX0Ym2arWxLSRFu+dZpOUMShgxG+mJ5Vzhex4Sw8TdlkF s3SWDnN0sb7fiDARKo6y36CGfRL0EGZj0ECuzFBe97ZTixplHt64qkVBVaQARKCt mBGFWleXT4/yMDXt0aZOnc+xzY5haUQ6k8/6xngRZ8oNBcHovsnibrGYXPf5FL6X 8dwPccsUADiT/vNcoSM2Ez26dPYAgaGmDw8KdVsBJqgPum2DI2oaLam3bkevJBBA OOtiZIuAEz3DA60OEKu/mugj60Xf4eCLQ8yj/sH9a7vOyEpKRUeTJjyZ0CpXghNw MsxBjguAvo3Wt54zpxfpGzoaYVZN6wRLGWcVlKcks9aEuETuzjg+UoaEsehzIdTo J3OQoNKxas/aYnqq8sI4F3BozY5VHHc2F6jale85ILDHMy6sK963N2+5gEJ5jlVe DME49mCdwkGcLAUORjpzuHq0g8DCrapA9SlLJ7Bs5IN/qC5fwBwVqyeVC92HDsFq ZGss30rBSOfG4bUXxNhgv9V2F5Pr4sJgq8qWzFS1fKS0CIotpqc=
    =LsZ6
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Federico Grau@21:1/5 to tony mancill on Fri Dec 31 20:30:01 2021
    On Fri, Dec 31, 2021 at 08:54:14AM -0800, tony mancill wrote:
    On Fri, Dec 31, 2021 at 11:11:03AM -0500, Federico Grau wrote:
    ...
    With wl2k v0.8.0-1 now in unstable, I'm now seeking an upload of pat v0.12.0
    to hopefully close out this wave.

    I will review and sponsor an upload. Please push your pristine-tar
    branch and updated upstream branch to Salsa. At the moment, I only see
    the debian/sid and an outdated upstream branch [1].

    Appreciate the review and feedback tony. I'll admit to still developing familiarity with git and it's possible I missed a step.


    The pat project does not use a "pristine-tar" branch, given its use of golang and the suggestion from debian-golang ( https://go-team.pages.debian.net/workflow-changes.html#wf-2017-11-pristine-tar).

    I believe to have pushed the "upstream" tags. Below is a review of my current dev environment, where there does appear to be an "upstream/0.12.0" tag.

    Is there something I should try differently (I'm on oftc irc if realtime may help)?


    #
    # console review of fresh pat build from salsa git
    #
    donfede@saltdev14:~$ mkdir hack_pat00
    donfede@saltdev14:~$ cd !$
    cd hack_pat00
    donfede@saltdev14:~/hack_pat00$ gbp clone git@salsa.debian.org:debian-hamradio-team/pat.git
    gbp:info: Cloning from 'git@salsa.debian.org:debian-hamradio-team/pat.git' donfede@saltdev14:~/hack_pat00$ cd pat
    donfede@saltdev14:~/hack_pat00/pat$ git branch -a
    * debian/sid
    upstream
    remotes/origin/HEAD -> origin/debian/sid
    remotes/origin/debian/sid
    remotes/origin/upstream
    donfede@saltdev14:~/hack_pat00/pat$
    donfede@saltdev14:~/hack_pat00/pat$ git tag | grep upstream
    upstream/0.10.0
    upstream/0.12.0
    donfede@saltdev14:~/hack_pat00/pat$
    donfede@saltdev14:~/hack_pat00/pat$ origtargz
    Trying uscan --download --download-current-version ...
    uscan: Newest version of pat on remote site is 0.12.0, specified download version is 0.12.0
    Successfully renamed ../pat-0.12.0.tar.gz to ../pat_0.12.0.orig.tar.gz. donfede@saltdev14:~/hack_pat00/pat$
    donfede@saltdev14:~/hack_pat00/pat$ time sbuild -A -v -d unstable
    dpkg-source: info: using patch list from debian/patches/series
    dpkg-source: info: applying 01_remove_ptc-go.patch
    dpkg-source: info: applying 02_fix_manpage.patch
    dpkg-source: info: applying 03_upstream_changelog.patch
    dpkg-source: info: applying
    04-update_man_pages_for_renamed_binary_994822.patch
    dh clean --builddirectory=_build --buildsystem=golang --with=golang
    dh_auto_clean -O--builddirectory=_build -O--buildsystem=golang
    dh_autoreconf_clean -O--builddirectory=_build -O--buildsystem=golang
    dh_clean -O--builddirectory=_build -O--buildsystem=golang
    dpkg-source: info: using source format '3.0 (quilt)'
    dpkg-source: info: building pat using existing ./pat_0.12.0.orig.tar.gz dpkg-source: info: using patch list from debian/patches/series
    dpkg-source: info: building pat in pat_0.12.0-1.debian.tar.xz
    dpkg-source: info: building pat in pat_0.12.0-1.dsc
    ...


    regards,
    donfede


    -----BEGIN PGP SIGNATURE-----

    iQIzBAABCAAdFiEEmr4kxVySlu8VKlyYL/shsp/kV2QFAmHPWCEACgkQL/shsp/k V2QWYg//StHcXnI6hi3FiMc32JZ2hWDqtBQE1iWjh7Mk+8wWUa7hI6pnmFV3U/nc dP2L9T7Yl/FWmr4zA7LyScZMUfDJ4oJjwGhXaei/nFGvSXie06nWpNJ4VJQyiR2c 9FV+SE1NCT2bzzoEd1iw3EHolEtHoXj7aTLP6AzGPIJSbtBS+U8eWvJtnS2RPU8k 7fs2yIh/R7CLb+PNJQRcd63dm2vLdGqPMWQAHqa+0fdOAdvDSwMFMM6dJ7ZOlKuQ 3jNqhZBAuOlAuMTZfgQ61G/uB61zaqf6HoSJmM8TIbKk1WojPj/TNAsgWjHHhIJI Pf6e83Pmg89YhujceCijXhaLQ3RzqKdAxFeghy2VkPyFUqQ0Ec4BqXRJit1e3zkS eNZvJzzzwUY5XfD3s1US1HT+O82/XPQGoLCVQh9le+7YZT4/PWT+59gCffuaxeF5 43wDgoG1xDsu9xlXeV1A8NtvDTH4oE9fPKV60nod95FPxZMcxPrhA5+EbxrIKsaa TpcPGeOfawIAxvHFoav1ORsegOIIqYJv4veXLke+cwBXqgay36KAEEpGK3os2Qjx I/KycDHXWNEgpzzZPXTl6zaq3xOuFqhT5rrITnPmtX+BiJm3assgbPYbuoFjkA2x /zpyX7TeB/fRRvpbEKUQoX4sW3ncUFsgs8qKZ201QDFx0BK3G1c=
    =wVJ1
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Federico Grau@21:1/5 to Federico Grau on Sat Jan 1 04:40:01 2022
    On Fri, Dec 31, 2021 at 02:21:11PM -0500, Federico Grau wrote:
    On Fri, Dec 31, 2021 at 08:54:14AM -0800, tony mancill wrote:
    On Fri, Dec 31, 2021 at 11:11:03AM -0500, Federico Grau wrote:
    ...
    With wl2k v0.8.0-1 now in unstable, I'm now seeking an upload of pat v0.12.0
    to hopefully close out this wave.

    I will review and sponsor an upload. Please push your pristine-tar
    branch and updated upstream branch to Salsa. At the moment, I only see
    the debian/sid and an outdated upstream branch [1].

    Appreciate the review and feedback tony. I'll admit to still developing familiarity with git and it's possible I missed a step.


    The pat project does not use a "pristine-tar" branch, given its use of golang and the suggestion from debian-golang ( https://go-team.pages.debian.net/workflow-changes.html#wf-2017-11-pristine-tar).

    I believe to have pushed the "upstream" tags. Below is a review of my current
    dev environment, where there does appear to be an "upstream/0.12.0" tag.

    Is there something I should try differently (I'm on oftc irc if realtime may help)?


    Looking closer at the salsa git UI, I see that the `pat' upstream branch was last updated for v0.10.0 (and not the current v0.12.0). I'm pretty sure I progressed the update using "gbp import-orig", but may have missed an option
    or uploading to salsa all branches after the work. Unfortunately I've since whacked and rebuilt that dev environment. I'm exploring now how to update the upstream branch (while the debian/sid branch is already updated).

    regards,
    donfede

    -----BEGIN PGP SIGNATURE-----

    iQIzBAABCAAdFiEEmr4kxVySlu8VKlyYL/shsp/kV2QFAmHPytAACgkQL/shsp/k V2T3iA//Z2nDEBxO0BcT8Db7YxIrldxVGy8wdLd/sKrH9TaqRayNMhqgqm/aCTnJ EceGrSkq/GNcs1ct1UJS6hX9s+LpM0uVnvRh23mKQXnGyZCaJBuuHho7Fxx2STGE 87ar4+bL6NeBapHp4vNJw9bkZOC3oqjcaYLByg0P56UG71ZRMY0qRvvAW7dDTFF0 Eh2dtXrHjJF2wmZZlyxNjrNrCaNwbSU/ZhDmqR6p6B7WnLxX3j5s/TiSKyBC+A6w PWzKsIMOJ7x+ohChbo75ojy4duTDgpJ2w44RP9PdncLtF6khoO9F43AFi2JTdl/A ++k7d9NtxLUo3tlBAYaXu0PkZS4TAioGdfW0vz99rXa3Sm5RQte3JXTpHKgU6IGE o62F7gqXNCxbX2cmsoBU38+L76b2HBoadSFnNgkzgMt1m3hR6FNgQ0cd45otPQvj xg9FR/+vJQRb6YEX0DWPYbzoGxAr8yv2mqX+V1JWGKUOv4VHYr18ezp0H7FKwMOt KmXhreBnF07lDuxRLu3tPT2MK5b4z0aKp9s/vU9CCIbN1lkZIsODPtVF42igUUny yJA0YlQCK58fWrrwpe871dr+qg9cytmiESQwN+82oUSC/zKimbZ+HjgqDUUf1iS/ JJiNjCCpBT/5Kvaw/wCarUti/I9XZo9XRX/qVTzjQ2AoGKs6pbc=
    =mYSe
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Federico Grau@21:1/5 to Federico Grau on Sat Jan 1 05:40:01 2022
    On Fri, Dec 31, 2021 at 10:30:30PM -0500, Federico Grau wrote:
    On Fri, Dec 31, 2021 at 02:21:11PM -0500, Federico Grau wrote:
    On Fri, Dec 31, 2021 at 08:54:14AM -0800, tony mancill wrote:
    On Fri, Dec 31, 2021 at 11:11:03AM -0500, Federico Grau wrote:
    ...
    With wl2k v0.8.0-1 now in unstable, I'm now seeking an upload of pat v0.12.0
    to hopefully close out this wave.

    I will review and sponsor an upload. Please push your pristine-tar branch and updated upstream branch to Salsa. At the moment, I only see the debian/sid and an outdated upstream branch [1].

    Appreciate the review and feedback tony. I'll admit to still developing familiarity with git and it's possible I missed a step.
    ...

    Looking closer at the salsa git UI, I see that the `pat' upstream branch was last updated for v0.10.0 (and not the current v0.12.0). I'm pretty sure I progressed the update using "gbp import-orig", but may have missed an option or uploading to salsa all branches after the work. Unfortunately I've since whacked and rebuilt that dev environment. I'm exploring now how to update the
    upstream branch (while the debian/sid branch is already updated).



    I believe I've identified steps to clean this up, but they require deleting a git tag, which I'm hesitant to try doing (if it's even possible for me). Performing these tests in my local dev environment they appear ok with no changes to debian/sid as expected. I welcome feedback or confirmation to the planned steps:

    a) Delete the existing "upstream/0.12.0" tag
    git tag -d upstream/0.12.0

    b) Re-run "gbp import-orig" to populate the upstream branch and create a new tag
    gbp import-orig -v --uscan --upstream-version=0.12.0


    regards,
    donfede


    -----BEGIN PGP SIGNATURE-----

    iQIzBAABCAAdFiEEmr4kxVySlu8VKlyYL/shsp/kV2QFAmHP2lEACgkQL/shsp/k V2TxMhAAjEC4E1KmsTzQzDsOn1XOGm3vDbcm/uCa0OZJUQ7d00vFrG0gQQy8Zb1x VjElKJtu1jxFesmsw8y5lfXEMNpdeSPbKAqUgTYoNcfQaDONCrWVTEy58tvQv+Jp c01uGxPVVEQaOUXu7l6qzUvAFZg0NORNyZg6Z+EohB1KzehhNp5lHglYfYprUCFg aoGaqidgn/vr5cfkig1wkYMjf5vLCfJosWzsKpsCQLtJ3Gz/h1Q4U8ObD+8eiA7t n4OxhpciFH5X3ImFMft92De66ygi8XksqxrZBAjJTgAI5oXfFC37+pHJzx1z3/tl 8wyaKjrJ60+iHJOXigdPBG26uEQTkY+bR8zCQBhBpaSE7a1fW04bMP0sHk6Dn53+ +NG8/44QrhNpRMcggZLl3ta2SiuXDkVgylBSk5k1zB3jtWSdlI2Zs4xECkVXW+IO KydUEa+ndmWcLHL9LHgrubvD7N1acNgIj1eT6xt/yjZkM0r/+lC152PUUZJRR0Ct pmqr1lcG1Cg+8nyt+ozdzKnL2qoYKV7O2ozJWBdq6PF4m6WTbEXCTk353hHZ0kJN UQksee3p9J0DjyIwKqp2+AgwNLDiwvFD6hcOL9KKIGVHhyP5+6p9Q2P6vKDAzdKX ZNX1k7MpRGEWG3nYGe/0oHAZR1EZfnVCNstlKTRrvkHhngYzox8=
    =I4ew
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Shengjing Zhu@21:1/5 to donfede@casagrau.org on Sat Jan 1 19:10:02 2022
    Hi,

    On Sat, Jan 1, 2022 at 12:37 PM Federico Grau <donfede@casagrau.org> wrote:

    On Fri, Dec 31, 2021 at 10:30:30PM -0500, Federico Grau wrote:
    On Fri, Dec 31, 2021 at 02:21:11PM -0500, Federico Grau wrote:
    On Fri, Dec 31, 2021 at 08:54:14AM -0800, tony mancill wrote:
    On Fri, Dec 31, 2021 at 11:11:03AM -0500, Federico Grau wrote:
    ...
    With wl2k v0.8.0-1 now in unstable, I'm now seeking an upload of pat v0.12.0
    to hopefully close out this wave.

    I will review and sponsor an upload. Please push your pristine-tar branch and updated upstream branch to Salsa. At the moment, I only see the debian/sid and an outdated upstream branch [1].

    Appreciate the review and feedback tony. I'll admit to still developing familiarity with git and it's possible I missed a step.
    ...

    Looking closer at the salsa git UI, I see that the `pat' upstream branch was
    last updated for v0.10.0 (and not the current v0.12.0). I'm pretty sure I progressed the update using "gbp import-orig", but may have missed an option
    or uploading to salsa all branches after the work. Unfortunately I've since
    whacked and rebuilt that dev environment. I'm exploring now how to update the
    upstream branch (while the debian/sid branch is already updated).



    I believe I've identified steps to clean this up, but they require deleting a git tag, which I'm hesitant to try doing (if it's even possible for me). Performing these tests in my local dev environment they appear ok with no changes to debian/sid as expected. I welcome feedback or confirmation to the planned steps:

    a) Delete the existing "upstream/0.12.0" tag
    git tag -d upstream/0.12.0

    b) Re-run "gbp import-orig" to populate the upstream branch and create a new tag
    gbp import-orig -v --uscan --upstream-version=0.12.0


    Just

    git checkout upstream
    git merge --ff upstream/0.12.0

    --
    Shengjing Zhu

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From tony mancill@21:1/5 to Federico Grau on Sat Jan 1 19:50:02 2022
    On Sat, Jan 01, 2022 at 01:38:55PM -0500, Federico Grau wrote:
    On Sun, Jan 02, 2022 at 01:46:22AM +0800, Shengjing Zhu wrote:
    git checkout upstream
    git merge --ff upstream/0.12.0


    Thanks for the feedback Shengjing Zhu,

    I've completed the suggested steps and pushed them to salsa.
    Ready for further review, feedback, or upload as cycles are available.

    Hi Federico,

    Do you mind also pushing your pristine-tar branch to Salsa? If you
    don't have one, you should be able to run the following command from the
    same directory as your git repo - that is the same directory where you
    can successfully run gbp buildpackage:

    pristine-tar commit ../build-area/pat_0.12.0.orig.tar.gz

    or

    pristine-tar commit ../tarballs/pat_0.12.0.orig.tar.gz

    (or pat_0.12.0.orig.tar.xz, if that's what you have)

    The reason your build is working locally is that the build system can
    find the orig.tar.gz. On my system, after pulling the latest from
    Salsa, the error is:

    $ gbp buildpackage
    gbp:info: Tarballs 'pat_0.12.0.orig.tar.gz' not found at '../tarballs/' gbp:warning: Pristine-tar branch "pristine-tar" not found
    gbp:info: Creating /data/debian/sponsor/pat/build-area/pat_0.12.0.orig.tar.gz gbp:error: Error creating pat_0.12.0.orig.tar.gz: Pristine-tar couldn't checkout "pat_0.12.0.orig.tar.gz": pristine-tar: no pristine-tar branch found, use "pristine-tar commit" first


    Thank you,
    tony

    -----BEGIN PGP SIGNATURE-----

    iQIzBAABCgAdFiEE5Qr9Va3SequXFjqLIdIFiZdLPpYFAmHQoa0ACgkQIdIFiZdL PpauBg/9HK9toHdgZjBlWtMiTFzU7w2BE/mvbSiPZhvRcvn5I6Kr5Xi6BzjrHcwt 6mPom4KIUQvW4DG5x6gMfskoRiQG2Zp0XCYLPx+++a2oVndCpG7mK6DOMU2CIyJF 4YetIhV1hik+9p7UwoZnSCRPQoF/vAKmKTB4gh53DdqFnEtHboN5RRp1EL5QK4EC tiHzhSLdS8Y26wuQR+hkQFDZWI/NewXBo95I8SC9txRcCJX+H6AtqxC6/PN80sAa Cj2/QyNYvJK+fIzJTemfze45qwJ/VUW4+Exa5chnQjWO7ESgjIvjwGRb96fqeUCj nywab2e35Cy2YdIVJsUC6KZ+/ljJ9zuHggkI0z8bXm6/0/yL/BsEsDrRUQfnpRse 0bSps1Qi0ll7/gImik8gRb0IUf19pg3dU2TNRXUU02FRwFpuvXAGDkEQrsMm4s6+ 6jIq/M8Yt9GDMr1jUiUpsr0l1IkGFFh+W3a0yfjuhe8OGg3BlfuEvZQHDZtqTfHR cLTJ+yvBwHLF+fiFzNiVRo+6Q/RxSd8GAkS/+LstCbuIHr9f8CWdQLa6Z49uaRsy KZiFc6QXm/OLJXTiS8zRgmSrvElfjcPdGufm5geWsLVq2tPFi8FKL61UqEfFIMjL IRG/FD4gQl1Qor3sbpfd5XS4iKRSIJsNC90i3dKPN/P5QZWMKcA=
    =zEhw
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Federico Grau@21:1/5 to Shengjing Zhu on Sat Jan 1 19:40:01 2022
    On Sun, Jan 02, 2022 at 01:46:22AM +0800, Shengjing Zhu wrote:
    Hi,

    On Sat, Jan 1, 2022 at 12:37 PM Federico Grau <donfede@casagrau.org> wrote:

    On Fri, Dec 31, 2021 at 10:30:30PM -0500, Federico Grau wrote:
    On Fri, Dec 31, 2021 at 02:21:11PM -0500, Federico Grau wrote:
    On Fri, Dec 31, 2021 at 08:54:14AM -0800, tony mancill wrote:
    On Fri, Dec 31, 2021 at 11:11:03AM -0500, Federico Grau wrote:
    ...
    With wl2k v0.8.0-1 now in unstable, I'm now seeking an upload of pat v0.12.0
    to hopefully close out this wave.

    I will review and sponsor an upload. Please push your pristine-tar branch and updated upstream branch to Salsa. At the moment, I only see
    the debian/sid and an outdated upstream branch [1].

    Appreciate the review and feedback tony. I'll admit to still developing
    familiarity with git and it's possible I missed a step.
    ...

    Looking closer at the salsa git UI, I see that the `pat' upstream branch was
    last updated for v0.10.0 (and not the current v0.12.0). I'm pretty sure I
    progressed the update using "gbp import-orig", but may have missed an option
    or uploading to salsa all branches after the work. Unfortunately I've since
    whacked and rebuilt that dev environment. I'm exploring now how to update the
    upstream branch (while the debian/sid branch is already updated).



    I believe I've identified steps to clean this up, but they require deleting a
    git tag, which I'm hesitant to try doing (if it's even possible for me). Performing these tests in my local dev environment they appear ok with no changes to debian/sid as expected. I welcome feedback or confirmation to the
    planned steps:

    a) Delete the existing "upstream/0.12.0" tag
    git tag -d upstream/0.12.0

    b) Re-run "gbp import-orig" to populate the upstream branch and create a new tag
    gbp import-orig -v --uscan --upstream-version=0.12.0


    Just

    git checkout upstream
    git merge --ff upstream/0.12.0


    Thanks for the feedback Shengjing Zhu,

    I've completed the suggested steps and pushed them to salsa.
    Ready for further review, feedback, or upload as cycles are available.

    donfede

    -----BEGIN PGP SIGNATURE-----

    iQIzBAABCAAdFiEEmr4kxVySlu8VKlyYL/shsp/kV2QFAmHQn68ACgkQL/shsp/k V2TTMw/9FvfOaYdnMTTghvjmi8rcz0eIGAnEnXIgsT0WZh0pen1dir2aNfQWPJ+X Re4hcs7Vq8lEQ2ADQXZseOU8JbGlqAM27LP9mIiUDT0s3bbxInsjwXvqKisbZKr1 78l7b1PH/fryWg5kpQQ+5joWyeX2IM6El7Sth+iHKnvQ8PcJXbPWMxmtm11p+3WC EHIYHmGt1EGr8AQPRCyFcuOjjVJW2m2uyelV+SIy5ovJABpvbKijdIVZGOJbclSj 1pA5fsBduN/HhjSzxXr1S2jFse4UuljphHMygQKTYbfwN09cGd0JWNphij14Krnl 8fXlJkmmlIAbG61h1jc+6J/Q2/34M2eRUk7LCBD5xVUPlDuxZRFQW+S4mQrcEoT/ v5nwK8B9O4MoG6fqYC47PMHEWsEbgm1w9FSjzs6UI0UwSmTOjM9xVElveZ4aPYm+ eXLRuHNbPTiYnzvPyihu455u+L8rrQQPsmFMqoXaJCBbVI86ijR3p8wGfYshFKto w8be2kHgeKVGbEDz58wpsEV62deetZXZt289+jRAaqsJVjUwZ1+pGmsVfML67qCk Vgs0W+qgej8FITEMz2XnU4YPIHPfwvU8qfvYQcJ4KnMq0PVY8inPT8SbnATdxf/y hdJiEqtOUc8ISfhyqxrjXL5UraW7OKE3pX4Gi9MRvCGMtNIRbPM=
    =dAq7
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Shengjing Zhu@21:1/5 to tmancill@debian.org on Sat Jan 1 20:10:01 2022
    On Sun, Jan 2, 2022 at 2:47 AM tony mancill <tmancill@debian.org> wrote:

    On Sat, Jan 01, 2022 at 01:38:55PM -0500, Federico Grau wrote:
    On Sun, Jan 02, 2022 at 01:46:22AM +0800, Shengjing Zhu wrote:
    git checkout upstream
    git merge --ff upstream/0.12.0


    Thanks for the feedback Shengjing Zhu,

    I've completed the suggested steps and pushed them to salsa.
    Ready for further review, feedback, or upload as cycles are available.

    Hi Federico,

    Do you mind also pushing your pristine-tar branch to Salsa? If you
    don't have one, you should be able to run the following command from the
    same directory as your git repo - that is the same directory where you
    can successfully run gbp buildpackage:

    pristine-tar commit ../build-area/pat_0.12.0.orig.tar.gz

    or

    pristine-tar commit ../tarballs/pat_0.12.0.orig.tar.gz

    (or pat_0.12.0.orig.tar.xz, if that's what you have)

    The reason your build is working locally is that the build system can
    find the orig.tar.gz. On my system, after pulling the latest from
    Salsa, the error is:

    $ gbp buildpackage
    gbp:info: Tarballs 'pat_0.12.0.orig.tar.gz' not found at '../tarballs/' gbp:warning: Pristine-tar branch "pristine-tar" not found
    gbp:info: Creating /data/debian/sponsor/pat/build-area/pat_0.12.0.orig.tar.gz gbp:error: Error creating pat_0.12.0.orig.tar.gz: Pristine-tar couldn't checkout "pat_0.12.0.orig.tar.gz": pristine-tar: no pristine-tar branch found, use "pristine-tar commit" first


    You can get rid of this error by running `gbp buildpackage --git-no-pristine-tar`, or adding `pristine-tar=False` to
    debian/gbp.conf .

    Decision to use pristine-tar or not could be not affected by this error.

    --
    Shengjing Zhu

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Federico Grau@21:1/5 to Shengjing Zhu on Sat Jan 1 20:40:02 2022
    On Sun, Jan 02, 2022 at 02:53:23AM +0800, Shengjing Zhu wrote:
    On Sun, Jan 2, 2022 at 2:47 AM tony mancill <tmancill@debian.org> wrote:

    On Sat, Jan 01, 2022 at 01:38:55PM -0500, Federico Grau wrote:
    On Sun, Jan 02, 2022 at 01:46:22AM +0800, Shengjing Zhu wrote:
    git checkout upstream
    git merge --ff upstream/0.12.0


    Thanks for the feedback Shengjing Zhu,

    I've completed the suggested steps and pushed them to salsa.
    Ready for further review, feedback, or upload as cycles are available.

    Hi Federico,

    Do you mind also pushing your pristine-tar branch to Salsa? If you
    don't have one, you should be able to run the following command from the same directory as your git repo - that is the same directory where you
    can successfully run gbp buildpackage:

    pristine-tar commit ../build-area/pat_0.12.0.orig.tar.gz

    or

    pristine-tar commit ../tarballs/pat_0.12.0.orig.tar.gz

    (or pat_0.12.0.orig.tar.xz, if that's what you have)

    The reason your build is working locally is that the build system can
    find the orig.tar.gz. On my system, after pulling the latest from
    Salsa, the error is:

    $ gbp buildpackage
    gbp:info: Tarballs 'pat_0.12.0.orig.tar.gz' not found at '../tarballs/' gbp:warning: Pristine-tar branch "pristine-tar" not found
    gbp:info: Creating /data/debian/sponsor/pat/build-area/pat_0.12.0.orig.tar.gz
    gbp:error: Error creating pat_0.12.0.orig.tar.gz: Pristine-tar couldn't checkout "pat_0.12.0.orig.tar.gz": pristine-tar: no pristine-tar branch found, use "pristine-tar commit" first


    You can get rid of this error by running `gbp buildpackage --git-no-pristine-tar`, or adding `pristine-tar=False` to
    debian/gbp.conf .


    Does the --git-no-pristine-tar option fit tony? I'm initially hesitant to introduce pristine-tar into this project, as it's not been used for past releases, and Taowa (currently on VAC) and I had elected not to use pristine-tar here. If that's the only path forward ok.

    However, I am able to build from a freshly cloned directory without errors (though I've only use sbuild; trying default gbp buildpackage errors at
    signing changes for me, given I've no key).

    # console review of builds
    donfede@saltdev14:~$ rm -fr hack_pat00
    donfede@saltdev14:~$ mkdir hack_pat00
    donfede@saltdev14:~$ cd hack_pat00
    donfede@saltdev14:~/hack_pat00$ gbp clone git@salsa.debian.org:debian-hamradio-team/pat.git
    gbp:info: Cloning from 'git@salsa.debian.org:debian-hamradio-team/pat.git' donfede@saltdev14:~/hack_pat00$ cd pat
    donfede@saltdev14:~/hack_pat00/pat$
    donfede@saltdev14:~/hack_pat00/pat$ gbp buildpackage --git-builder=sbuild -A -v -d unstable
    gbp:info: Creating pat_0.12.0.orig.tar.gz from 'upstream/0.12.0'
    gbp:info: Performing the build
    dpkg-source: info: using patch list from debian/patches/series
    dpkg-source: info: applying 01_remove_ptc-go.patch
    ...
    Package: pat
    Package-Time: 46
    Source-Version: 0.12.0-1
    Space: 152888
    Status: successful
    Version: 0.12.0-1 --------------------------------------------------------------------------------
    Finished at 2022-01-01T19:13:28Z
    Build needed 00:00:46, 152888k disk space
    donfede@saltdev14:~/hack_pat00/pat$
    donfede@saltdev14:~/hack_pat00/pat$
    donfede@saltdev14:~/hack_pat00/pat$ cd
    donfede@saltdev14:~$
    donfede@saltdev14:~$ rm -fr hack_pat00
    donfede@saltdev14:~$ mkdir hack_pat00
    donfede@saltdev14:~$ cd hack_pat00
    donfede@saltdev14:~/hack_pat00$ gbp clone git@salsa.debian.org:debian-hamradio-team/pat.git
    gbp:info: Cloning from 'git@salsa.debian.org:debian-hamradio-team/pat.git' donfede@saltdev14:~/hack_pat00$ cd pat/
    donfede@saltdev14:~/hack_pat00/pat$ origtargz
    Trying uscan --download --download-current-version ...
    uscan: Newest version of pat on remote site is 0.12.0, specified download version is 0.12.0
    Successfully renamed ../pat-0.12.0.tar.gz to ../pat_0.12.0.orig.tar.gz. donfede@saltdev14:~/hack_pat00/pat$ sbuild -A -v -d unstable
    dpkg-source: info: using patch list from debian/patches/series
    dpkg-source: info: applying 01_remove_ptc-go.patch
    ...
    Space: 152888
    Status: successful
    Version: 0.12.0-1 --------------------------------------------------------------------------------
    Finished at 2022-01-01T19:15:56Z
    Build needed 00:00:47, 152888k disk space
    donfede@saltdev14:~/hack_pat00/pat$



    regards,
    donfede




    -----BEGIN PGP SIGNATURE-----

    iQIzBAABCAAdFiEEmr4kxVySlu8VKlyYL/shsp/kV2QFAmHQrO4ACgkQL/shsp/k V2TmIw/6A9gXRGlMFKBNvRvfInhJrDVHgTqqZ9VQyWY8YXt36Ya7kpccYv92BdeQ m2IxoX8w/FuerTLpVwYIRl/uCeQ2Cz76lPvZjIJljfeEKHlOF40swQptyi3fOjlw cfeaAK03KIHE9udEfl7tJjLsibwtBMOUycXO/4abHc77GlAZ9kwWuBExgPeDKnpx dcU6Wf0i7fwRaqhfXRrTURQi7XHem6baVfSe6yudrAopneZ2a6QnGRVfl+Zghi76 9TlYgo50ffzm9wqUZVjgGetrsXmJyfr0JfC3oPki/prNDhxsEomoUbzWOmG1swHd TkkwBE+WycFLDU1eSbtnlEUUmIsjqvmAbC28CWekJgNnonWjbEm6SfqpThAygbii OsRJiwDif4lUsYVp7ab/Ao+37U2GMU1v4wW9vBcvI07hmDMN1S2ckUEubvmfGRbG jNQ0wH/ZJgM/BElEwte4szg4QbfGVAlIPt3lJ2E6R2NjIfKP0TY6rEMY3w0O6LZN nrsj/hE4rfrRW0yicMwNLgHAbQyBkf3IFyCxtzl9Lf3izVTNzjs4XeIE4SQRyh6C VPAatrYoEpScb3R3Az4M00rU8/s9j37bCooO9ElEJX0jmTbJGYrwThtkC4XZd5Ls JW/OWJSzXp0oGldjVx3vGKuj1nTYJAUrEVeJItd0AC1tfW9ZkyM=
    =O4PJ
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From tony mancill@21:1/5 to Federico Grau on Sun Jan 2 01:30:02 2022
    On Sat, Jan 01, 2022 at 02:35:23PM -0500, Federico Grau wrote:
    On Sun, Jan 02, 2022 at 02:53:23AM +0800, Shengjing Zhu wrote:
    You can get rid of this error by running `gbp buildpackage --git-no-pristine-tar`, or adding `pristine-tar=False` to
    debian/gbp.conf .

    Yes - thank you. That should have occurred to me. I've had
    pristine-tar=True in my ~/.gbp.conf for such a long time that I had
    forgotten about being able to change it if the upstream branch is
    correctly tagged. (I'm still kind of partial to the pristine-tar
    branch, but that's irrelevant.) Apologies for all of the back-and-forth
    on this.

    Does the --git-no-pristine-tar option fit tony? I'm initially hesitant to introduce pristine-tar into this project, as it's not been used for past releases, and Taowa (currently on VAC) and I had elected not to use pristine-tar here. If that's the only path forward ok.

    Yes, that's fine. Adding the pristine-tar branch won't cause any
    problems, but I don't know of a reason why it's necessary if the
    upstream branch is kept current and is tagged appropriately. I do like Shengjing Zhu's suggestion of adding adding pristine-tar=False in the debian/gbp.conf in the project. I will add a commit and push that
    change.

    The Hamradio Maintguide section on the VCS [1] refers to pristine-tar in
    all of its examples, but doesn't explicitly state that it *must* be
    used, and DEP-14 [2] doesn't give any explicit guidance beyond
    specifying the branch name.

    [1] https://salsa.debian.org/debian-hamradio-team/hamradio-maintguide/-/blob/master/vcs.rst
    [2] https://dep-team.pages.debian.net/deps/dep14/

    If there is a team standard for this, we can update hamradio-maintguide.

    However, I am able to build from a freshly cloned directory without errors (though I've only use sbuild; trying default gbp buildpackage errors at signing changes for me, given I've no key).

    Yes, I am able to build now too. I'm not sure why you're getting
    prompted to sign changes. When I look at the manpage for sbuild.conf,
    the defaults passed to dpkg-buildpackage should disable signing:

    PGP_OPTIONS
    ARRAY:STRING type. Additional signing options for dpkg-buildpackage
    Default:
    $pgp_options = [
    '-us',
    '-uc'
    ];


    I am going to add the debian/gbp.conf file and made a few minor tweaks
    based on the output of "lintian --pendantic" and then will upload and
    tag (so be sure to pull debian/sid after you see the upload).

    Thanks!
    tony

    -----BEGIN PGP SIGNATURE-----

    iQIzBAABCgAdFiEE5Qr9Va3SequXFjqLIdIFiZdLPpYFAmHQ8SMACgkQIdIFiZdL PpaEgw/+J9hbjBV87uKT5Q4RoZf/5UIjHmaciAsCf0F/PWCHnR16CTkYdhQAoFmw FWm4NLJaqJmCCla7Q/GFWSM3moBky/+SV3IAcdbtXsMKSB+AO99HYQpqEF5yCYrC 9V7V1vFagNLke1yTZpayr3jEVcDLntx/DUbzmSv2x7OHzoxtFKkNrS6po6lc/Q3B ypzOVxOx61HvuWy1AFPwk1iYzkw4upiykPtHsi7oc1fDVNnsKhif0sZCmseyLm3F bGGgEZU4A7gyVCNAiAeUfb1idsuKoqZ6TZY73yQHfaaYK6lYQ8aqm/0qrp9YSaeN 4hbO/tZVhJHH97EioLKYnUFzQB/QmSHBPNG9kHO6L2l9DK8A2IVmkk8CP0nwuLGx 3/ZAfa9r5UxoGBh6R0FEpnIy+LThNWr5CYOer7ImS5jcGuP8mB17hgxOjrRJURDB pl+a2XlE5QRvQ2Kv679vQ1bhWZSL3Dt0CXILAefF4D6mEHJE8bk7GRvDjZAT0gAe D9vhrSVYd8rNCARsTBtugLfoSQpoFm3va/Y/SHN/b7y3SoaqFt2oYBbQKLDQD1la 9B6VPdJ3o+aAqQgKvL4nP28guejLHfVS80r/hwOL20C4h8oMZY2uwaG0FKou9ptD 5pkzy93EAMoe+VXn33bE15FKcwmlpm6Oe2MrrVsa94DkrdzrcIM=
    =AaaI
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Federico Grau@21:1/5 to tony mancill on Sun Jan 2 03:50:01 2022
    On Sat, Jan 01, 2022 at 04:26:11PM -0800, tony mancill wrote:
    ...
    The Hamradio Maintguide section on the VCS [1] refers to pristine-tar in
    all of its examples, but doesn't explicitly state that it *must* be
    used, and DEP-14 [2] doesn't give any explicit guidance beyond
    specifying the branch name.

    [1] https://salsa.debian.org/debian-hamradio-team/hamradio-maintguide/-/blob/master/vcs.rst
    [2] https://dep-team.pages.debian.net/deps/dep14/

    If there is a team standard for this, we can update hamradio-maintguide.


    Not sure if there is a team standard, but expect one for this situation may be a challenge given the multiple variables here.

    The `pat' package is written in golang. While that package itself is maintained by debian-hams team, given that it's a ham radio centric utility, the rest of the supporting library packages are maintained by the
    debian-golang team. Obviously this results in a mix of cultures. Part of
    that team has the approach to not use pristine-tar ( https://go-team.pages.debian.net/workflow-changes.html#wf-2017-11-pristine-tar),
    but even that group is a mix.

    Given my earlier focus on getting the golang dependencies working and
    packaged, that influenced the packaging style I used here. Add to the mix
    that I'm a relatively new Debian community member still learning, and that the DD Taowa has been on VAC.


    Of course, with the above stated, since this package _IS_ maintained by debian-hams, advise if there is a consensus that it should be packaged differently.



    Yes, I am able to build now too. I'm not sure why you're getting
    prompted to sign changes. When I look at the manpage for sbuild.conf,
    the defaults passed to dpkg-buildpackage should disable signing:

    When I use sbuild directly or gbp builder=sbuild things work ok. It was with the default "gbp buildpackage" (possibly using default debuilder) that I was prompted for signing. I typically always use sbuild, and have no need for
    keys at this time, so I'm not concerned per these errors currently.


    I am going to add the debian/gbp.conf file and made a few minor tweaks
    based on the output of "lintian --pendantic" and then will upload and
    tag (so be sure to pull debian/sid after you see the upload).

    Thanks for the gbp and lintian polish. I had those issues in queue to
    review, and appreciate the progress. This upload is the culmination of many months of effort with support from multiple people. Again, thanks all!

    happy hacking this new year,
    donfede

    Fede Grau


    -----BEGIN PGP SIGNATURE-----

    iQIzBAABCAAdFiEEmr4kxVySlu8VKlyYL/shsp/kV2QFAmHREoQACgkQL/shsp/k V2QVGA/7BMMQpFTnVACAKOOQVXB0IZCER473Ds2VnllQqz4pHHiflgvjEPhsfVOF QMU5oOJ9qgatr0C6PbRkJhz90tPQciwmmIA1RvPS4xmTb5AF1+MSOAc0QgZ8wt1P 0P0zyQAykYJBVTeBEkIjYsu4xwQFEY8e9p/E68G4JeFLDxayJPtrN/zTVvthpkCd v5X9iKsYFnwm+QimFl1eCIgrHW4khnyXFo8PgDG9+JuFuScnFXp661DOKoH02Fll nw5AiTyygfYJUKT6983YNTtpHjsHCMwm81BB6Dbz5gb5H3m3Xdhp7MN0K/+5ULpG SA/JTTvxWb7WbEmaFW6WgOAPV8KLji5oGVsvDT8+l9KdSsP01oiC7emgVpWshRRr SgFMjXAv76jbsWF9I9VhPYQEllUiO4PFvffABM6VrbmiPL1UEg1llZDzLR61m113 RZ0twA756J6p/bcg8L2+gJBiGMoeZN9ci7N3VcdC27kzOBf+VCFC50b3j3v1AsEJ 8ReUOtv9q7pKDQliLxnVWT0AHr5kNfVdB+erC5KucNCb1ZYUvDxfkwjStGH0nIs0 YT//Nt3obeM8q1xpuO4Wk65rwlKa+wADdiU69cD8RcFyIcqHifhFTYrd0ZyLgFRr RNwz6HPhjY/YMP8S7rbCUlc8mAwfVOci+d2soEhIwwS3Ebggpl4=
    =/0xc
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)