• Hi, I am a newbie to debian-hurd development! I have created a patc

    From Richard Braun@21:1/5 to haha wang on Thu Apr 29 12:10:02 2021
    On Tue, Apr 27, 2021 at 09:25:05PM +0900, haha wang wrote:
    <div><div>Hi, everybody.</div><div> I am a newbie to debian-hurd development and want to contribute to this project. After reading the development guide at <a href="https://www.debian.org/ports/hurd/hurd-devel-debian" rel="noopener noreferrer"
    target="_blank">https://www.debian.org/ports/hurd/hurd-devel-debian</a>, I decide to fix a broken package found at the recommended page <a href="https://people.debian.org/~sthibault/out_of_date2.txt" rel="noopener noreferrer" target="_blank">https://
    people.debian.org/~sthibault/out_of_date2.txt</a> named `libtorrent`.</div><div></div><div> After I download the package source and try to build without any modifications under the debian hurd running in qemu (<strong>debian-hurd-20210219.img</
    strong>), I got the following error.</div><div></div><div> ```<div> socket_fd.cc: In member function 'bool torrent::SocketFd::set_priority(torrent::SocketFd::priority_type)':</div><div> socket_fd.cc:78:43: error: 'IPV6_TCLASS' was not declared
    in this scope; did you mean 'IPOPT_CLASS'?</div></div><div> ```</div><div></div><div> and it matches with what that page said.</div><div></div><div> I also try to build that package under my debian desktop(Debian GNU/Linux bullseye/sid x86_64)
    and it got no errors. After a quick search, i have found linux defined the `IPV6_TCLASS` macro at `bits/in.h` as follows:</div><div></div><div> ```</div><div> #define IPV6_TCLASS 67</div><div> ```</div><div></div><div>So that, I modify the `
    configure.ac` to add a conditional compilation when it detects the host operating system is hurd based, along with macro definition at the `Makefile.am` found at `src/net/`. The patch file is attached at the end of this email.</div><div></div><div>But I
    have some questions:</div><div></div><div>1. Should I only load that patch file? Is it enough? Should I provided a change file?</div><div>2. If the patch file is accepted, how it can be merged to the official deb package?</div><div>3. Should I add some
    other description information to the patch file?</div><div>4. Can somebody tell me how can I become a debian package maintainer? Is there any detailed and practical guides?</div><div></div><div>Thank you!</div><div></div><div>---</div><div>hahawang</
    <div></div><div><div>--- a/configure.ac</div><div>+++ b/configure.ac</div><div>@@ -1,5 +1,17 @@</div><div>AC_INIT(libtorrent, 0.13.8, sundell.software@gmail.com)</div><div></div><div>+AC_CANONICAL_HOST</div><div>+</div><div>+build_hurd=no</div><div>
    +</div><div>+case "${host_os}" in</div><div>+ gnu*)</div><div>+ build_hurd=yes</div><div>+ ;;</div><div>+esac</div><div>+</div><div>+AM_CONDITIONAL([BUILD_HURD], [test "$build_hurd" = "yes"])</div><div>+</div><div>LT_INIT([disable-static])</div><div></
    <div>dnl Find a better way to do this</div><div>--- a/src/net/Makefile.am</div><div>+++ b/src/net/Makefile.am</div><div>@@ -26,3 +26,7 @@</div><div>throttle_node.h</div><div></div><div>AM_CPPFLAGS = -I$(srcdir) -I$(srcdir)/.. -I$(top_srcdir)</div><
    +</div><div>+if BUILD_HURD</div><div>+AM_CPPFLAGS += -DBUILD_HURD</div><div>+endif</div><div>--- a/src/net/socket_fd.cc</div><div>+++ b/src/net/socket_fd.cc</div><div>@@ -50,6 +50,10 @@</div><div>#include "torrent/exceptions.h"</div><div>#include "
    socket_fd.h"</div><div></div><div>+#ifdef BUILD_HURD</div><div>+#define IPV6_TCLASS 67</div><div>+#endif</div><div>+</div><div>namespace torrent {<!-- --></div><div></div><div>inline void</div></div></div>

    Hello,

    Please avoid HTML emails (this applies to most open source development
    mailing lists).

    I suggest you also send to bug-hurd@gnu.org, which is the main mailing
    list concerning Hurd development.

    --
    Richard Braun

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From =?utf-8?B?Sm/Do28=?= Pedro Malhado@21:1/5 to haha wang on Thu Apr 29 15:10:01 2021
    Hello haha wang

    On Thu, Apr 27, 2021 at 09:23:43PM +0900, haha wang wrote:
    After reading the development guide at https://www.debian.org/ports/hurd/hurd-devel-debian,
    I decide to fix a broken package found at the recommended page https://people.debian.org/~sthibault/out_of_date2.txt named `libtorrent`.

    I cannot comment on the patch itself, but thank you for your initiative and enthusiasm.

    But I have some questions:

    1. Should I only load that patch file? Is it enough? Should I provided a change
    file?
    2. If the patch file is accepted, how it can be merged to the official deb package?
    3. Should I add some other description information to the patch file?

    I would say that you should submit a bug report against the libtorrent package with you patch. If the package maintainer needs something different from you, he
    or she will let you know.

    https://www.debian.org/Bugs/Reporting

    4. Can somebody tell me how can I become a debian package maintainer? Is there
    any detailed and practical guides?

    You might know that there is a specific process to apply as a Debian Developer

    https://wiki.debian.org/DebianDeveloper/JoinTheProject/NewMember

    If you want to help in the development of the Hurd port, starting to build a track record in porting packages may be a way to go.

    Regards,
    João

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Joshua Branson@21:1/5 to haha wang on Thu Apr 29 17:10:01 2021
    haha wang <hahwang@yandex.com> writes:

    Hi,
    Thank you for your advise. But I am using the yandex web client. It seems that it can not write a plain text mail. Should I use something like mutt or any
    command line tools? Any suggestions? Thank you.

    --
    haha wang


    You could install thunderbird. It supports using plaintext emails:

    http://kb.mozillazine.org/Plain_text_e-mail_%28Thunderbird%29

    --
    Joshua Branson (joshuaBPMan in #guix)
    Sent from Emacs and Gnus
    https://gnucode.me
    https://video.hardlimit.com/accounts/joshua_branson/video-channels
    https://propernaming.org
    "You can have whatever you want, as long as you help
    enough other people get what they want." - Zig Ziglar

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Samuel Thibault@21:1/5 to All on Thu Apr 29 20:00:02 2021
    João Pedro Malhado, le jeu. 29 avril 2021 14:49:40 +0200, a ecrit:
    4. Can somebody tell me how can I become a debian package maintainer? Is there
    any detailed and practical guides?

    You might know that there is a specific process to apply as a Debian Developer

    https://wiki.debian.org/DebianDeveloper/JoinTheProject/NewMember

    If you want to help in the development of the Hurd port, starting to build a track record in porting packages may be a way to go.

    Yes, aiming directly for being a Debian Developer is too far. Start with submitting patches, getting corrected, eventually get to produce
    good-quality patches, then you'll become a maintainer, continue
    improving, and then you can get a developer account.

    Samuel

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Samuel Thibault@21:1/5 to All on Thu Apr 29 20:10:02 2021
    João Pedro Malhado, le jeu. 29 avril 2021 14:49:40 +0200, a ecrit:
    On Thu, Apr 27, 2021 at 09:23:43PM +0900, haha wang wrote:
    1. Should I only load that patch file? Is it enough? Should I provided a change
    file?
    2. If the patch file is accepted, how it can be merged to the official deb package?
    3. Should I add some other description information to the patch file?

    I would say that you should submit a bug report against the libtorrent package
    with you patch.

    I'd say rather ask for advice on this list first. See Jess' feedback on
    the proposed patch for instance, we do not want to bother package
    maintainers with patches which are actually improper.

    Also, rather than reporting against the Debian package, it is usually
    better to directly send to upstream, since that's where it will have to
    land in the end anyway. That's also much better for discussing about the
    patch, avoiding to go through the Debian maintainer for no good reason.

    Samuel

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)