Hi,
I was reading through the workflow guidelines on the GitPackaging wiki
page (
https://wiki.debian.org/GitPackaging), and I have some comments on
what I think can be improved.
One change per commit.
What does "one change" entail, a file being changed, a bug being fixed,
a collection of unrelated changes in a single file? This is unclear.
The commit message should have a short (<78 characters) summary of the
change followed by a newline.
The <78 character constraint is out-of-line with Git standards. Git
suggests a hard stop at 72 characters for the subject, with a soft recommendation to keep it <=50 chars.
Also, the text should read "followed by a blank newline", instead of
just "followed by a newline". Having a blank link separating the body
and subject is much cleaner. Maybe it was just a typo.
Lastly, lines of the body should be wrapped at 72 characters. This is
very easy to configure in a text editor, like vim.
--
Best regards,
Brian T
B.S. Computer Science 2014 (Truman State University)
Minor Stasitics
Minor Chemistry
Minor Mathematics
-----BEGIN PGP SIGNATURE-----
iQIzBAABCgAdFiEEg2s9vY2mGY7y4pi9hN+ATWfRmqIFAmDjyRIACgkQhN+ATWfR mqLzMA//V7SkDC61Sucv0/yKB+7c0AH1OpLrMkQgureTHWh2u7hUyTA94gfC6KNq BP7B1cp3zcgSehPFd9aO2UaEFCBJDAdp/N7AC+7Y4mzuQOvBvGN/3eDkmjkdZ8ug ejxhIC3j5CqKLPGcFHjlCybQK61Y86dl33Y83pbKLDeY1/QBJdu+RlJPoVbsQQ6t 6pZOhEV7419KfNSKcJs9daP8ct+3uHl0QjnBDoWuAwnWF6CbJOepqMALPCW9iyk9 loqJMlah9WufzE08ybbcB7NnX8LsUL85d3CyKiVdHeO6gkMhdfEakmXZ7T1d8zso +MHIj6yAOGYcEU3U8YiyZkzTduU9aZEZlaKC/U37OHgqj7XCJKskXKKRNMqDQf5g lIhLGXYZeq6+RjhtLujP2aIFvJs57mCGCYR59tY8T9V8RzLwCZ3XTe4YBXWW0CkE 6q5N7LKekJKguHL5HF+A2F8pY3H9WRabNH4kPfs/YzsqRZyBP/rngHwL+qlrm9k2 C+2CJ5XYuRK23u5cHbwmx2/Xq3v2YyfLkzwNZ4c2Oq1FNwCuUcZyWITLJIESegeY AF6uuHV/kvUHKvqw/jyPzxbBXL92By5+v6pwCg+iJr7bk5WSy0Sn+0KCGAyW5sWW LnzHGS5mrNkSBU7pEmOl2WXi+3k9g5oLTKalLWIzSVds8ercUd8=
=PpcP
-----END PGP SIGNATURE-----
--- SoupGate-Win32 v1.05