Lintian just started erroring on 'depends-on-obsolete-package[...]
lsb-base' on many of my packages yesterday. There are no new uploads
Does somebody know what is going on?
Example:
E: mariadb-server: depends-on-obsolete-package Depends: lsb-base (>= 3.0-10)
Lintian just started erroring on 'depends-on-obsolete-package
lsb-base' on many of my packages yesterday.
There are no new uploads of lsb-base recently
and I did not find any news about this topic. The
Lintian page https://lintian.debian.org/tags/depends-on-obsolete-package
is only about the error in general, not any mention of lsb-base
specific changes.
Does somebody know what is going on?
Example:
E: mariadb-server: depends-on-obsolete-package Depends: lsb-base (>= 3.0-10)
On Wed, Jan 18, 2023 at 08:19:15AM -0800, Otto Kekäläinen wrote:
Does somebody know what is going on?
Example:
E: mariadb-server: depends-on-obsolete-package Depends: lsb-base (>= 3.0-10)
The severity of this warning is grossly overstated. It shouldn't be an "error" but a "mild warning to fix if you're bored".
On Wed, Jan 18, 2023 at 08:19:15AM -0800, Otto Kekäläinen wrote:
Lintian just started erroring on 'depends-on-obsolete-package
lsb-base' on many of my packages yesterday.
It's a very low priority cleanup; the Depends is redundant but
harmless.
There are no new uploads of lsb-base recently
Relevant changes are from September. The lsb-base package is empty,
and would have been gone completely if debootstrap understood Provides.
and I did not find any news about this topic. The
Lintian page https://lintian.debian.org/tags/depends-on-obsolete-package
is only about the error in general, not any mention of lsb-base
specific changes.
The description of "$PACKAGE1 => $PACKAGE2" are clear enough, of
"$PACKAGE => nothing" a bit less, indeed. You can just drop the dependency.
Does somebody know what is going on?
Example:
E: mariadb-server: depends-on-obsolete-package Depends: lsb-base (>= 3.0-10)
The severity of this warning is grossly overstated. It shouldn't be an "error" but a "mild warning to fix if you're bored".
I don't think it is redundant though? Just removing the lsb-base
Depends can break packages on partial upgrades in the same way lsb-base
broke stuff before it grew a versioned dependency on sysvinit-utils.
For the systemd-sysv-generator case, the LSB init script is only run ifI think that it is time to upgrade the warning, because I understand
there is no native systemd unit of the same name, which itself triggers
a Lintian warning (albeit quite a common one); so hopefully if maintainers are removing lsb-base dependencies as prompted by Lintian, they are also adding a corresponding /lib/systemd/system/foo.service for each /etc/init.d/foo in the package.
On Jan 20, Simon McVittie <smcv@debian.org> wrote:
For the systemd-sysv-generator case, the LSB init script is only run if there is no native systemd unit of the same name, which itself triggersI think that it is time to upgrade the warning, because I understand
a Lintian warning (albeit quite a common one); so hopefully if maintainers are removing lsb-base dependencies as prompted by Lintian, they are also adding a corresponding /lib/systemd/system/foo.service for each /etc/init.d/foo in the package.
that interest in continuing to maintain systemd-sysv-generator is
waning.
I will be happy to assist maintainers who want to add a .service unit to their package but are unsure about the details.
I think that it is time to upgrade the warning, because I understand
that interest in continuing to maintain systemd-sysv-generator is
waning.
I will be happy to assist maintainers who want to add a .service unit to their package but are unsure about the details.
On 2023-01-18 Otto Kekäläinen <otto@kekalainen.net> wrote:
Lintian just started erroring on 'depends-on-obsolete-package[...]
lsb-base' on many of my packages yesterday. There are no new uploads
Does somebody know what is going on?
Example:
E: mariadb-server: depends-on-obsolete-package Depends: lsb-base (>= 3.0-10)
That is this change
* Remove init.d-script-needs-depends-on-lsb-base and add lsb-base to
obsolete-packages. (Closes: #1019851)
from this commit:
commit 97f742b00553a4dd7ba681aefa4cc164ea263f71
Remove init.d-script-needs-depends-on-lsb-base and add lsb-base to obsolete-packages
The functionality of lsb-base is in the Essential:yes set since
Bullseye. The package itself is now an empty transitional package
(because debootstrap doesn't understand the Provides relationship) which
depends on the new provider of the functionality, sysvinit-utils, which
is also in the Essential:yes set.
Closes: #1019851
On Wed, 18 Jan 2023 at 09:00, Andreas Metzler <ametzler@bebt.de> wrote:
On 2023-01-18 Otto Keklinen <otto@kekalainen.net> wrote:
Lintian just started erroring on 'depends-on-obsolete-package[...]
lsb-base' on many of my packages yesterday. There are no new uploads
Does somebody know what is going on?
Example:
E: mariadb-server: depends-on-obsolete-package Depends: lsb-base (>= 3.0-10)
That is this change
* Remove init.d-script-needs-depends-on-lsb-base and add lsb-base to
obsolete-packages. (Closes: #1019851)
from this commit:
commit 97f742b00553a4dd7ba681aefa4cc164ea263f71
Remove init.d-script-needs-depends-on-lsb-base and add lsb-base to obsolete-packages
The functionality of lsb-base is in the Essential:yes set since
Bullseye. The package itself is now an empty transitional package
(because debootstrap doesn't understand the Provides relationship) which
depends on the new provider of the functionality, sysvinit-utils, which
is also in the Essential:yes set.
Closes: #1019851
Thanks for an exact reply!
About the execution of this change repository-wide:
Is anyone working on feeding https://salsa.debian.org/lintian/lintian/-/blob/master/data/fields/obsolete-packages
to https://janitor.debian.net/scrub-obsolete/ so that at least Salsa-maintained packages would swiftly get on path to get this
dependency removed (and Salsa-CI failures stopped on this Lintian
error)?
As a side note, it would be cool if the Janitor could also mass add
brackets to Lintian overrides (like done manually in https://salsa.debian.org/lintian/lintian/-/commit/6e8c0487a186e1640fe69e2409544b28e6f26164
on Lintian itself) now after that not backwards compatible change was introduced last summer so that we get it executed repository-wide.
About the execution of this change repository-wide:
Is anyone working on feeding https://salsa.debian.org/lintian/lintian/-/blob/master/data/fields/obsolete-packages
to https://janitor.debian.net/scrub-obsolete/ so that at least Salsa-maintained packages would swiftly get on path to get this
dependency removed (and Salsa-CI failures stopped on this Lintian
error)?
That's an interesting idea. The current format https://salsa.debian.org/lintian/lintian/-/blob/master/data/fields/obsolete-packages
isn't super machine-readable. Perhaps it could be split into one file
with human-readable hints, and one with straightforward replacements
(e.g. "libtinfo-dev => libncurses-dev" )?
About the execution of this change repository-wide:
Is anyone working on feeding https://salsa.debian.org/lintian/lintian/-/blob/master/data/fields/obsolete-packages
to https://janitor.debian.net/scrub-obsolete/ so that at least Salsa-maintained packages would swiftly get on path to get this dependency removed (and Salsa-CI failures stopped on this Lintian
error)?
That's an interesting idea. The current format https://salsa.debian.org/lintian/lintian/-/blob/master/data/fields/obsolete-packages
isn't super machine-readable. Perhaps it could be split into one file
with human-readable hints, and one with straightforward replacements
(e.g. "libtinfo-dev => libncurses-dev" )?
Related, current lintian-brush actually adds lsb-base back if it was removed:
$ lintian-brush --version
lintian-brush 0.145
$ lintian-brush --allow-reformatting --uncertain --yolo --modern
$ git show
commit a0a2bf5d6972348114b6d6d489619353c539bd74 (HEAD -> dev-otto)
Add missing dependency on lsb-base.
Changes-By: lintian-brush
Fixes: lintian: init.d-script-needs-depends-on-lsb-base
See-also: https://lintian.debian.org/tags/init.d-script-needs-depends-on-lsb-base.html
diff --git a/debian/control b/debian/control
index 80edd7be401..240d74914d3 100644
--- a/debian/control
+++ b/debian/control
@@ -454,7 +454,8 @@ Depends: galera-4 (>= 26.4),
- ${shlibs:Depends}
+ ${shlibs:Depends},
+ lsb-base
I have only ever found two bugs in lintian-brush, otherwise it works perfectly. I wish those who drive changes to Lintian rules would take
one extra step and also collaborate with lintian-brush to automate
fixing the issues instead of relying on all human maintainers to read
Lintian reports and address them manually.
Sysop: | Keyop |
---|---|
Location: | Huddersfield, West Yorkshire, UK |
Users: | 339 |
Nodes: | 16 (2 / 14) |
Uptime: | 00:06:57 |
Calls: | 7,466 |
Calls today: | 2 |
Files: | 12,691 |
Messages: | 5,627,862 |