• Submitting Patches

    From Phillip Smith@21:1/5 to All on Fri Oct 21 07:30:01 2022
    Apologies if this is the wrong place to be asking this, but my
    Google-fu isn't guiding me to any results... Where/How do I submit
    patches for Debian packages?

    I have a small improvement for the iptables-persistent package; I
    cloned the repo and made a patch (attached) on a branch, but it
    appears the public aren't welcome to create accounts on
    salsa.debian.org in order to create merge requests?

    Are patches even welcome?

    Thanks,
    ~p

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Phillip Smith@21:1/5 to Julien Puydt on Fri Oct 21 07:50:01 2022
    On Fri, 21 Oct 2022 at 16:30, Julien Puydt <julien.puydt@gmail.com> wrote:
    In general they are ; just attach them to a bug report against the package.

    Thanks! Is there a (recommended) tool to do this? I presume the
    recommended `bugreport` tool isn't appropriate for sending patches as
    opposed to actual bugs? I don't seem to be able to get `git
    send-email` to cooperate with the "Package" header that is required
    for submitting via email.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Julien Puydt@21:1/5 to All on Fri Oct 21 07:40:01 2022
    Hi

    Le ven. 21 oct. 2022 à 07:28, Phillip Smith <fukawi2@gmail.com> a écrit :

    Apologies if this is the wrong place to be asking this, but my
    Google-fu isn't guiding me to any results... Where/How do I submit
    patches for Debian packages?

    I have a small improvement for the iptables-persistent package; I
    cloned the repo and made a patch (attached) on a branch, but it
    appears the public aren't welcome to create accounts on
    salsa.debian.org in order to create merge requests?

    Are patches even welcome?



    In general they are ; just attach them to a bug report against the package.

    Thanks for your interest and contribution,

    J.Puydt



    <div dir="auto"><div>Hi<br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Le ven. 21 oct. 2022 à 07:28, Phillip Smith &lt;<a href="mailto:fukawi2@gmail.com">fukawi2@gmail.com</a>&gt; a écrit :<br></div><blockquote class="gmail_quote"
    style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Apologies if this is the wrong place to be asking this, but my<br>
    Google-fu isn&#39;t guiding me to any results... Where/How do I submit<br> patches for Debian packages?<br>

    I have a small improvement for the iptables-persistent package; I<br>
    cloned the repo and made a patch (attached) on a branch, but it<br>
    appears the public aren&#39;t welcome to create accounts on<br>
    <a href="http://salsa.debian.org" rel="noreferrer noreferrer" target="_blank">salsa.debian.org</a> in order to create merge requests?<br>

    Are patches even welcome?<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto"><br></div><div dir="auto">In general they are ; just attach them to a bug report against the package.</div><div dir="auto"><br></div><div dir="auto">Thanks
    for your interest and contribution,</div><div dir="auto"><br></div><div dir="auto">J.Puydt</div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
    </blockquote></div></div></div>

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From julien.puydt@gmail.com@21:1/5 to All on Fri Oct 21 08:00:02 2022
    Le vendredi 21 octobre 2022 à 16:47 +1100, Phillip Smith a écrit :
    On Fri, 21 Oct 2022 at 16:30, Julien Puydt <julien.puydt@gmail.com>
    wrote:
    In general they are ; just attach them to a bug report against the
    package.

    Thanks! Is there a (recommended) tool to do this? I presume the
    recommended `bugreport` tool isn't appropriate for sending patches as
    opposed to actual bugs? I don't seem to be able to get `git
    send-email` to cooperate with the "Package" header that is required
    for submitting via email.


    "reportbug" should do what you want as far as I know...

    Cheers,

    J.Puydt

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Phillip Smith@21:1/5 to julien.puydt@gmail.com on Fri Oct 21 08:10:01 2022
    On Fri, 21 Oct 2022 at 16:50, <julien.puydt@gmail.com> wrote:
    "reportbug" should do what you want as far as I know...

    Thank-you. I think that's been submitted now.
    I appreciate your fast replies, have a great weekend :)

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Paul Wise@21:1/5 to Phillip Smith on Fri Oct 21 11:50:02 2022
    On Fri, 2022-10-21 at 16:28 +1100, Phillip Smith wrote:

    Where/How do I submit patches for Debian packages?

    It completely depends on the preferences of the team or person who will
    be reviewing the patches. Most teams and package maintainers accept
    changes via Salsa merge requests, but, as mentioned by Julien, patches
    attached to bug reports are usually also acceptable.

    I have a small improvement for the iptables-persistent package;
    I cloned the repo and made a patch (attached) on a branch, but it
    appears the public aren't welcome to create accounts on
    salsa.debian.org in order to create merge requests?

    The public are welcome to create accounts on Salsa, but due to large
    numbers of spammers signing up for accounts and due to the Salsa admins
    being part-time volunteers, there may be some delay in the account
    approval process, so patience is helpful.

    Are patches even welcome?

    Debian always welcomes patches, although usually it is a better idea to
    submit patches upstream first, so that they benefit all users instead
    of just Debian users. When upstream isn't responsive the Debian
    maintainer can be a patch recipient of last resort though.

    Of course since iptables-persistent is a native Debian package,
    the upstream in this case is the package Debian itself.

    --
    bye,
    pabs

    https://wiki.debian.org/PaulWise

    -----BEGIN PGP SIGNATURE-----

    iQIzBAABCgAdFiEEYQsotVz8/kXqG1Y7MRa6Xp/6aaMFAmNSasYACgkQMRa6Xp/6 aaPV/Q/9FdfKlhep/6eUDkRqNwtprAELd9uGtmajT855pKmBfZzZtGCM9vM+KDWq UqXFiqY5eyQfFhn+QeCCOrG3KaH/gTVrOnd6FJFeE1JPtMUwrDbbqowvJtm7nLU/ YCUuXDqtWmvzZbVye7weWxAU0jE7kBzKMjdyXURMH//EPgLnA0VSzPnWEGf2ZmNx TJBtSoHntF7Odhcs/qG87hQRw//WfRd/l1v0CD2mxvGlkOZk4hoVFkgEX0eLz4F4 lrcrTCL8301Y4pwlh/mDZjy4GADAEfBbGMvLXgPvthIBX41ORZ6PqxRo/UG0Vdvx aWeK/TjERmVSste2yARYb6NKgoFIQToQZFbjD0vXawEeprVMzc/O0RlAip6R6aIW ZPG1UYCHv60BhD8dUhPbGZLlaXmPeTVs6NyvtnWGdlfl+6rsKfihEOkgJLBpwxuB WcptuQ/kVfoNf3zGb840w3DtWwn89AiGgaCQwvQJT8poFHSYZ2rfvuPziuBac5Dp sjAFsCtgt5gKEOjN884LIL+3X1f+qeiaZfJA+kbbheNyiujiRrRnLeMRlRbKj2so LQUpBJZ4suVP4GtTymcPZ1t5dhT7NCWYsNX9/G671gT9JMuRzsfKFHK9spiQu1yw nK+9YcOEhx7tePe8LnvfMYb72Le2jbfjZIVXZ3cZwxStmfJdbRw=
    =Whxc
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)