• Bug#1069632: viking: ruler tool makes viking hang due to uninitialized

    From Vincent Lefevre@21:1/5 to All on Mon Apr 22 00:30:01 2024
    Package: viking
    Version: 1.10-3
    Severity: important
    Tags: upstream fixed-upstream patch

    The ruler tool makes viking hang due to an uninitialized value.

    Until now I was using the attached patch fixing this problem, from

    https://github.com/viking-gps/viking/pull/175/commits/a68acdedbe7421e9980b6611229f92f5be2b65fb

    See https://github.com/viking-gps/viking/pull/175

    -- System Information:
    Debian Release: trixie/sid
    APT prefers unstable-debug
    APT policy: (500, 'unstable-debug'), (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental')
    Architecture: amd64 (x86_64)

    Kernel: Linux 6.6.15-amd64 (SMP w/16 CPU threads; PREEMPT)
    Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
    Shell: /bin/sh linked to /usr/bin/dash
    Init: systemd (via /run/systemd/system)
    LSM: AppArmor: enabled

    Versions of packages viking depends on:
    ii gpsbabel 1.9.0+ds-2+b2
    ii libbz2-1.0 1.0.8-5.1
    ii libc6 2.37-18
    ii libcairo2 1.18.0-3+b1
    ii libcurl3t64-gnutls 8.7.1-3
    ii libexpat1 2.6.2-1
    ii libgdk-pixbuf-2.0-0 2.42.10+dfsg-3+b3
    ii libgeoclue-2-0 2.7.1-2+b1
    ii libgexiv2-2 0.14.2-2+b2
    ii libglib2.0-0t64 2.78.4-6
    ii libgps30t64 3.25-3+b1
    ii libgtk-3-0t64 3.24.41-4
    ii libjson-glib-1.0-0 1.8.0-2+b1
    ii libmagic1t64 1:5.45-3
    ii libnettle8t64 3.9.1-2.2
    ii liboauth0 1.0.3-5+b1
    hi libpango-1.0-0 1.51.0+ds-4
    hi libpangocairo-1.0-0 1.51.0+ds-4
    ii libsqlite3-0 3.45.3-1
    ii libx11-6 2:1.8.7-1
    ii libzip4t64 1.7.3-1.1+b1
    ii zlib1g 1:1.3.dfsg-3.1

    Versions of packages viking recommends:
    ii expect [expect-dev] 5.45.4-3

    Versions of packages viking suggests:
    pn gpsd <none>
    ii yelp 42.2-1+b2

    -- no debconf information

    --
    Vincent Lefèvre <vincent@vinc17.net> - Web: <https://www.vinc17.net/>
    100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
    Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

    diff --git a/src/vikviewport.c b/src/vikviewport.c
    index 85adb891..3f696ab2 100644
    --- a/src/vikviewport.c
    +++ b/src/vikviewport.c
    @@ -2026,6 +2026,7 @@ void vik_viewport_compute_bearing ( VikViewport *vp, gint x1, gint y1, gint x2,
    *baseangle = M_PI - atan2(tx-x1, ty-y1);
    *angle -= *baseangle;
    } else{
    + *baseangle = 0;
    *angle = atan2((y2-y1), (x2-x1)) + M_PI_2;
    }

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)