• Bug#1068950: http_loadtime multiple target / escapeUri regression

    From Josip Rodin@21:1/5 to All on Sun Apr 14 08:30:01 2024
    Package: munin-plugins-core
    Version: 2.0.73-1

    Hi,

    This used to work while there was support for only one target:

    [http_loadtime]
    env.target http://localhost/?munin_http_loadtime=foo-front-60

    The RRD value was just a simple string and it didn't matter what the content
    of the target URL was. With the multiple target feature, however, this
    returns:

    % sudo munin-run http_loadtime http___localhost_?munin_http_loadtime=foo_front_60.value 0.0946937

    Which in turn is broken in Munin - it would create the RRD file for it,
    the value would always be critical, and munin-cgi-graph complains like
    this:

    2024/04/14 05:19:49 [RRD ERROR] Unable to graph /var/lib/munin/cgi-tmp/munin-cgi-graph/bar.baz.com/foo-front-1.bar.baz.com/http_loadtime-year.png : foo_front_60_warning is not a vname nor a number

    It sounds like the non-alphabetic characters that are included in
    the query string bother it, as they aren't escaped by:

    escapeUri() {
    echo "$1" | sed 's/[:/.-]/_/g'
    }

    Please fix it. TIA.

    --
    Josip Rodin

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)