XPost: linux.debian.devel.mentors

I had a look.

It's not called "SystemD".

Why is this line commented?

#PrivateUsers=yes


I think your patch presumes that the filesystem is utf-8 encoded and would break in other (admittedly rare) cases. Just FYI.

Commits on salsa introduce unrelated changes in 1 single commit.

Did you submit the patches to upstream? Is upstream active?

Your changes to the .service file might break CGI scripts that might be having access to all sort of things. I think a news file should be added to warn users of the possibly breaking changes.




In data sabato 13 aprile 2024 10:36:56 CEST, Alexandru Mihail ha scritto:

Hello, pinging about the RFS - mini-httpd/1.30-10.
This introduces systemd service hardening, fixes a bug related to
charsets in error pages and directory listings which was ugly.
Please help if possible.
Mentors page:

https://mentors.debian.net/package/mini-httpd/

Alternatively, you can download the package with 'dget' using this
command:

dget -x https://mentors.debian.net/debian/pool/main/m/mini-httpd/mini-httpd_1.30-10. dsc

Thanks !

--
Salvo Tomaselli

"Io non mi sento obbligato a credere che lo stesso Dio che ci ha dotato di senso, ragione ed intelletto intendesse che noi ne facessimo a meno."
-- Galileo Galilei

https://ltworf.codeberg.page/

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Hi Alexandru,

I haven't reviewed your package, however:

On Sun, 2024-04-21 at 19:42 +0300, Alexandru Mihail wrote:

Thanks a lot and have a nice day,
Alexandru Mihail
mini-httpd maintainer

It looks like you've been maintaining this package for a while now.
Have you considered applying to become a Debian Maintainer[1]? That
would allow you to eventually be given upload permissions on the mini-
httpd package, so you wouldn't need to keep filing RFS bugs. :)

Also, I suspect people might be more hesitant to sponsor packages
after the actions of "Jia Tan" and the xz backdoor. Going through the
process to become a DM can help demonstrate your commitment to good
packaging and the Debian project as a whole. (I'm not in any way trying
to suggest you might be a malicious actor, just that there's recently
been [rightfully] a lot of scrutiny of how easy it can be for someone
to mess with packages shipped by a distribution.)

Mathias

[1] -- https://nm.debian.org/public/newnm

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE1Bp60H32xfynSJ8cKe7i1uz0QvkFAmYlXZUACgkQKe7i1uz0 QvmURA/9E5ZZPeqTo/VrKXXNCen4SWN39G6MtyncVhJdVqPLajz8bx0te3IRrIAQ iHbzZJSqwbRKbXZIhRSp0VfOkA41Ly5bCEE6f4r1IaBTizfeiJAzm/vrww0vWhiE bzshaJsVPB/QySbPXurvFwDMNxowi2CvQOCJrPYafm0XLwxVzm+LholoQDpGJcSF iN4WQnlQ5ZfaijayLfZG72Rq1z7gRpvcr+SrRX0+Puw0q4LI9asg7tOCu099xnfr ilZXDyaBnZhU1JWCmfjgDXMd3Inmp5Rj9o2kyw/FVoodMisChmQlF5KMkvBAeeHR 6rUPYdKgaUL+sxaLSco6TsU5HFhvCVWUkQqFH/qj0rguNcqhttqw4cTKi2em6TJ1 4fSw3gxBjS812/aKWZOS6I2Zb0HUTfoUxitSKrsafgIT6prX61XC1Jhf2kfCTr3y BTx97ms378nVL7TegZsnehYuWFX7wCi4seEr4EEqo+/c/OgruE38FP+e1MgrreGt 7H8VrJ8d8JFnybak1/GECn7iiemZh6bjAiAK4AAZPe7bOk2WD8CQVk/80l7DgqsZ 3NRXPm+cXsKWe4KPoZyv+uZuIu58Uqv/iz3ukmri04gOxi+RjTAxbPz9itpJOcn8 KqAMk8hIuYlwdZCfeWib//97XuSjhz7FWKmbh+cNHbGAxTIbSJs=
=Uf76
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)