• Bug#1067564: bookworm-pu: package cpu/1.4.3-14~deb12u1

    From Andreas Beckmann@21:1/5 to All on Sat Mar 23 18:50:01 2024
    XPost: linux.debian.devel.release

    This is a multi-part MIME message sent by reportbug.


    Package: release.debian.org
    Severity: normal
    Tags: bookworm
    User: release.debian.org@packages.debian.org
    Usertags: pu
    Control: block 1067439 withh -1
    Control: affects -1 + src:cpu

    [ Reason ]
    The last QA upload four years ago fixed a FTBFS (multiple definitions of
    a global variable) by replacing that variable with an extern declaration
    and zero definitions. This didn't result in a linker error (missing
    symbol) because it happens in a plugin library and thus is only detected
    at runtime when the plugin gets loaded (i.e. always).
    So let's ship the plugin with *one* definition of the global variable
    ;-)

    [ Impact ]
    cpu stays unusable, but nobody noticed that for the last 4 years and two
    stable releases ...

    [ Tests ]
    Added a smoke test autopkgtest that detects the current failure.

    [ Risks ]
    We can't make the current situation much worse ;-)

    [ Checklist ]
    [*] *all* changes are documented in the d/changelog
    [*] I reviewed all changes and I approve them
    [*] attach debdiff against the package in (old)stable
    [*] the issue is verified as fixed in unstable

    [ Changes ]
    * Actually provide a definition of globalLdap. (Closes: #1067439)

    [ Other info ]
    n/a

    Andreas

    diff --git a/debian/changelog b/debian/changelog
    index ec0f291..a5aa4a2 100644
    --- a/debian/changelog
    +++ b/debian/changelog
    @@ -1,3 +1,18 @@
    +cpu (1.4.3-14~deb12u1) bookworm; urgency=medium
    +
    + * QA upload.
    + * Rebuild or bookworm.
    +
    + -- Andreas Beckmann <anbe@debian.org> Sat, 23 Mar 2024 18:03:59 +0100
    +
    +cpu (1.4.3-14) unstable; urgency=medium
    +
    + * QA upload.
    + * Actually provide a definition of globalLdap. (Closes: #1067439)
    + * Add smoke test.
    +
    + -- Andreas Beckmann <anbe@debian.org> Sat, 23 Mar 2024 14:39:06 +0100
    +
    cpu (1.4.3-13) unstable; urgency=medium

    * QA upload.
    diff --git a/debian/gbp.conf b/debian/gbp.conf
    new file mode 100644
    index 0000000..9048820
    --- /dev/null
    +++ b/debian/gbp.conf
    @@ -0,0 +1,2 @@
    +[DEFAULT]
    +debian-branch = main
    diff --git a/debian/patches/14_use-extern.patch b/debian/patches/14_use-extern.patch
    index 774b581..26b0b19 100644
    --- a/debian/patches/14_use-extern.patch
    +++ b/debian/patches/14_use-extern.patch
    @@ -1,10 +1,11 @@
    Description: Fix ftbfs with GCC-10

    Bug-Debian: https://bugs.debian.org/95710
  • From Adam D. Barratt@21:1/5 to Andreas Beckmann on Mon Mar 25 20:10:02 2024
    XPost: linux.debian.devel.release

    Control: tags -1 + confirmed

    On Sat, 2024-03-23 at 18:40 +0100, Andreas Beckmann wrote:
    The last QA upload four years ago fixed a FTBFS (multiple definitions
    of
    a global variable) by replacing that variable with an extern
    declaration
    and zero definitions. This didn't result in a linker error (missing
    symbol) because it happens in a plugin library and thus is only
    detected
    at runtime when the plugin gets loaded (i.e. always).

    Oh dear...

    Please go ahead.

    Regards,

    Adam

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Jonathan Wiltshire@21:1/5 to All on Thu Mar 28 18:40:03 2024
    XPost: linux.debian.devel.release

    package release.debian.org
    tags 1067564 = bookworm pending
    thanks

    Hi,

    The upload referenced by this bug report has been flagged for acceptance into the proposed-updates queue for Debian bookworm.

    Thanks for your contribution!

    Upload details
    ==============

    Package: cpu
    Version: 1.4.3-14~deb12u1

    Explanation: provide exactly one definition of globalLdap in ldap plugin

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)