Source: gnucash
Version: 1:5.5-1.1
Severity: serious

Simply build the package from source produces a source package that doesn't contain debian/.gitlab-ci.yml in debian.tar, one needs to rebuild the source package separately, skipping the clean target. The reason for that is that the file is listed debian/clean for some reason (alternatively, if it shouldn't be in the package, please remove it from the package).


-- System Information:
Debian Release: trixie/sid
APT prefers unstable-debug
APT policy: (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'unstable'), (500, 'testing'), (101, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.7.9-amd64 (SMP w/4 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=ru_RU.UTF-8, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Copy: wrar@debian.org (Andrey Rakhmatullin)

On Friday, 26 April 2024 12:16:39 AM AEST Andrey Rakhmatullin wrote:

Obviously '.gitlab-ci.yml' is a repository-specific file with
configuration of Gitlab CI on Salsa. There is no reason to ship it with source package

Yet you are shipping it, maybe you should reconsider that?

$ tar tvf gnucash_5.5-1.2.debian.tar.xz debian/.gitlab-ci.yml
-rw-rw-r-- 0/0 759 2024-02-23 22:55 debian/.gitlab-ci.yml

I'm not shipping it. NMU uploader must have built the package differently
to preserve the file. Oh, wait, that was you who last uploaded Ghucash.
(Thank you for your help with NMU. Much appreciated.)

I don't mind shipping the file (it is harmless) but I've made an explicit change to "debian/clean" to remove it.

Leave this matter alone please. Frankly it does not worth your time and I'd rather not play that bug reopen ping-pong.
What change you expect me to make?? Everything already works as intended.

--
Best wishes,
Dmitry Smirnov
GPG key : 4096R/52B6BBD953968D1B

---

If you have a government of good laws and bad men, you will have a bad government. For bad men will not be bound by good laws.
-- Robert LeFevre

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEULx8+TnSDCcqawZWUra72VOWjRsFAmYrj6IACgkQUra72VOW jRvY0A//aPcHoy06U0X2RlZVrhIO7SxODdP+0Y0vnHByC9xBiF9yyWs6TgZsgckb g3sDbA/qre/mACmkHYDxNqLUOQa4ZxQzDdc6ZBkMUjW5a/abHqKu2wnYJUrXCQWD 1tjgO4mGQTCD2VKwSywAFkIRs3V9OaU0m1y9nJq2UaTfgE5/Zq3R1qieF3s4k30L bqr0k5sx20ACOHMJMMbrSrXR0fk4lG2jPo/SXiYlqwm7WOLB70p+ynEis1nq3AHd SGHYTdAXlrJa/qUH0+kKzB2amko0KnOjcgzBz3OeggQPDPutHM7rArkEAyguTfVI 8J8LRoSa/+Y+BgxEPSO9gHQYY1IN+7F+lR+GKouYqyhhmxpzQdCPpTUBonhXzrWL Secw1Hsb5D4ob/nXyWUxhR28uFKn2l2NKVuwhYAC3Yr33AhAIZ1AOCcFc4KAuXtx CwP2jkMFeee6CDP5bW34ZrXKIrWlmUkcFbVlUKpSrGHGs3HuAc0LvTy5eVw61/U+ gSAa3F0myJW6eAXiiPQDkp0XgHcAUTX7S38kYQ2FGHp4JXAngYuCSD20ecvuctpz nhaYgUhGTcqYuxeWPmyQKhxgNZC3TZSx46arUFytJgIvVlkAYS5tXdsIg1ILFSbc WX/kxAyCIw+czrR/Xynn1HVKZ2I1KO25omuvRfNxmvi8QRqcAxo=
=r6/j
-----END PGP SIGNATURE-----

--- SoupGate-Wi

On Fri, Apr 26, 2024 at 09:27:30PM +1000, Dmitry Smirnov wrote:

On Friday, 26 April 2024 12:16:39 AM AEST Andrey Rakhmatullin wrote:

Obviously '.gitlab-ci.yml' is a repository-specific file with configuration of Gitlab CI on Salsa. There is no reason to ship it with source package

Yet you are shipping it, maybe you should reconsider that?

$ tar tvf gnucash_5.5-1.2.debian.tar.xz debian/.gitlab-ci.yml
-rw-rw-r-- 0/0 759 2024-02-23 22:55 debian/.gitlab-ci.yml

I'm not shipping it. NMU uploader must have built the package differently
to preserve the file. Oh, wait, that was you who last uploaded Ghucash. (Thank you for your help with NMU. Much appreciated.)

And I shipped it because the previous upload shipped it and I noticed in
the debdiff that it gets removed.
Now I see that the previous upload was also a NMU and no final debdiff has
been sent (I think), so it's possible that this file was only included
there.

I don't mind shipping the file (it is harmless) but I've made an explicit change to "debian/clean" to remove it.

Leave this matter alone please. Frankly it does not worth your time and I'd rather not play that bug reopen ping-pong.
What change you expect me to make?? Everything already works as intended.

If the file is normally not shipped in the package then I'm fine, I only
wanted to make sure that it's easy to do NMUs for the package.

--
WBR, wRAR

-----BEGIN PGP SIGNATURE-----

iQJhBAABCgBLFiEEolIP6gqGcKZh3YxVM2L3AxpJkuEFAmYrnyotFIAAAAAAFQAP cGthLWFkZHJlc3NAZ251cGcub3Jnd3JhckBkZWJpYW4ub3JnAAoJEDNi9wMaSZLh RGgP/jO8MdgAE1RMzUS5aQKmIYEWwbtQrQPozYgJrMwErV8xss9JpKcBOuttTaKe mkYLRZYbzDC/FiINOreBycd3ob0sZKf6IyDtXOC1c3cP1AEXZ801PLKg5/Xbdaa2 roaAzslKyBmBDVjL075xaNIsv5uYjkTOdTqXw4K8g5Vqip4L1YY4LOEZlMvsi3lt yOdAIQBMnrFeEDVUgTTKGGaRYuwgefi2+0g5NYUpVCQIabPGieNwvxGnoWDsX+zO 0tu0tREpc9+T0f46F06Gerp++muBacPWTfx77OPyBlIV1EXV9KGfPuM1fZvj6S0B pYNPrFwoEo/8thVDwbI754YpEX8jKEQFmrbjKI8X01dz6U8y2sWNamH8PFJTpzzm 2g8tMwNdkW80pXUY4X1t6p2sJEzFJ+gIzdrOLjhwKK7WLbOCzxnejCaslo7MNt8w eFAhjvS+mQ+ntyNwiw8X0hgBTT7RVTpW5DP0TGX2wFlUUozSDYJLqqSZncXVGwCz vaic+PIg5V90T8nZC0q/H2R6xpMGfV1Yne1Wyl+KTs3317iMldT82sxex9PBaWrR M/Wu5uiAjbiuj/MD8Ny9GFP0J5E6qUO3kNjqQ3TzKPyb6iOpCiKZ6NUIdjOGUfr8 FIV8NxDwsz9ELQX/UT6Zx0goDZX/2WIz+8r84dlj1ZHnjTUY
=Bcr/
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Copy: wrar@debian.org (Andrey Rakhmatullin)

On Friday, 26 April 2024 10:33:55 PM AEST Andrey Rakhmatullin wrote:

If the file is normally not shipped in the package then I'm fine,

Let me assure you that is exactly the case. None of my uploads have
that file. By the way, I've just uploaded new Gnucash release! ;)

I only
wanted to make sure that it's easy to do NMUs for the package.

I see... Thank you for your attention and care.

--
Regards,
Dmitry Smirnov
GPG key : 4096R/52B6BBD953968D1B

---

While it is relatively easy to see that government is a bully, a thief, and
a killer, the most baneful effect of government has always been
psychological. Government convinced man that it was an absolute necessity
for human survival. ‘No matter how bad a government may be, it is better
than no government.’ No other church had a more convincing argument.
-- Robert LeFevre, "A Way to Be Free: The Autobiography of Robert LeFevre, Volume I" (1999)

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEULx8+TnSDCcqawZWUra72VOWjRsFAmYrxI8ACgkQUra72VOW jRtOKA/+LTx+ifPtnkh7hqnj7kmULRNI7p0+peldl3l0by4AiVYCTulJYmayzcXC d0eB4xPTU+XWJayVCjhhZ6kJtjXWT9V3JmATMx0ysY7/c4CL36KZtn1dwivzy0AJ t6j4Mw+hC0pKByzbBrfBzrk2Ez3LIC7V7upJmRMxgrbmMrZsL/OAamVXbl1ryUBO H2+0Tsmh5hvJ+bZYapSmllyTBQUjRYZE0OdWkaAor/cpdSK3uSfjk9gCdM1iv1+x yhAeWIn58l+p/psaIuK4/Q4wrNrjGiYudvunqsIG/u8oHiY+k8JZ3gOSmMmrV1hx R51tXpvV39TKLrW1qOsRe17nBIOeVv0REKCtMHGD1ERC95GBxomDYe+o