Source: xmorph
Version: 1:20150712-5
Severity: serious
Tags: ftbfs

Hello,

there are multiple implicit function errors when trying to build
xmorph, some trivial, but also an API issue:
8X--------------
In file included from RgbaImage.c:935:
RgbaImage.c: In function 'rgbaImageWarp':
warp.h:19:20: error: implicit declaration of function 'warp_image_inv_new'; did you mean 'warp_image_inv_old'? [-Werror=implicit-function-declaration]
19 | #define warp_image warp_image_inv_new
| ^~~~~~~~~~~~~~~~~~
RgbaImage.c:963:3: note: in expansion of macro 'warp_image'
963 | warp_image(img_orig->ri, img_warp->ri, img_orig->ncols,
| ^~~~~~~~~~
8X--------------

warp.h contains
#define warp_image warp_image_inv_new
with warp_image_inv_new being defined in warp2.h. i.e. #include <warp.h> without including warp2.h first triggers an implicit declaration of
function error. OTOH warp2.h #includes warp.h so if everything switched
to warp.h we would be fine, but then there is no point in having a
separate warp.h.

Perhaps the proper fix would be to stop shipping an (unused) library.

cu Andreas

--
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)