• Bug#1066645: gtkterm: FTBFS: ../src/interface.c:738:9: error: implicit

    From Lucas Nussbaum@21:1/5 to All on Wed Mar 13 14:30:02 2024
    Source: gtkterm
    Version: 1.2.1-1
    Severity: serious
    Justification: FTBFS
    Tags: trixie sid ftbfs
    User: lucas@debian.org
    Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

    Hi,

    During a rebuild of all packages in sid, your package failed to build
    on amd64.

    This is most likely caused by a change in dpkg 1.22.6, that enabled -Werror=implicit-function-declaration. For more information, see https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

    Relevant part (hopefully):
    cc -Isrc/gtkterm.p -Isrc -I../src -I. -I.. -Idata -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/
    include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/x86_64-linux-gnu -I/usr/include/webp -I/usr/include/gio-unix-2.0 -I/usr/include/cloudproviders -I/usr/
    include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/vte-2.91 -I/usr/include/gudev-1.0 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -
    Winvalid-pch -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -pthread -MD -MQ src/gtkterm.
    p/interface.c.o -MF src/gtkterm.p/interface.c.o.d -o src/gtkterm.p/interface.c.o -c ../src/interface.c
    ../src/interface.c:154:9: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
    154 | {"FileExit", GTK_STOCK_QUIT, NULL, "<shift><control>Q", NULL, gtk_main_quit},
    | ^
    ../src/interface.c:155:9: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
    155 | {"ClearScreen", GTK_STOCK_CLEAR, N_("_Clear screen"), "<shift><control>L", NULL, G_CALLBACK(clear_buffer)},
    | ^
    ../src/interface.c:156:9: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
    156 | {"ClearScrollback", GTK_STOCK_CLEAR, N_("_Clear scrollback"), "<shift><control>K", NULL, G_CALLBACK(clear_scrollback)},
    | ^
    ../src/interface.c:157:9: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
    157 | {"SendFile", GTK_STOCK_JUMP_TO, N_("Send _RAW file"), "<shift><control>R", NULL, G_CALLBACK(send_raw_file)},
    | ^
    ../src/interface.c:158:9: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
    158 | {"SaveFile", GTK_STOCK_SAVE_AS, N_("_Save RAW file"), "", NULL, G_CALLBACK(save_raw_file)},
    | ^
    ../src/interface.c:161:9: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
    161 | {"EditCopy", GTK_STOCK_COPY, NULL, "<shift><control>C", NULL, G_CALLBACK(edit_copy_callback)},
    | ^
    ../src/interface.c:162:9: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
    162 | {"EditPaste", GTK_STOCK_PASTE, NULL, "<shift><control>V", NULL, G_CALLBACK(edit_paste_callback)},
    | ^
    ../src/interface.c:163:9: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
    163 | {"EditFind", GTK_STOCK_FIND, NULL, "<shift><control>F", NULL, G_CALLBACK(edit_find_callback)},
    | ^
    ../src/interface.c:164:9: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
    164 | {"EditSelectAll", GTK_STOCK_SELECT_ALL, NULL, "<shift><control>A", NULL, G_CALLBACK(edit_select_all_callback)},
    | ^
    ../src/interface.c:167:9: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
    167 | {"LogToFile", GTK_STOCK_MEDIA_RECORD, N_("To file..."), "", NULL, G_CALLBACK(logging_start)},
    | ^
    ../src/interface.c:168:9: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
    168 | {"LogPauseResume", GTK_STOCK_MEDIA_PAUSE, NULL, "", NULL, G_CALLBACK(logging_pause_resume)},
    | ^
    ../src/interface.c:169:9: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
    169 | {"LogStop", GTK_STOCK_MEDIA_STOP, NULL, "", NULL, G_CALLBACK(logging_stop)},
    | ^
    ../src/interface.c:170:9: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
    170 | {"LogClear", GTK_STOCK_CLEAR, NULL, "", NULL, G_CALLBACK(logging_clear)},
    | ^
    ../src/interface.c:173:9: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
    173 | {"ConfigPort", GTK_STOCK_PROPERTIES, N_("_Port"), "<shift><control>S", NULL, G_CALLBACK(Config_Port_Fenetre)},
    | ^
    ../src/interface.c:174:9: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
    174 | {"ConfigTerminal", GTK_STOCK_PREFERENCES, N_("_Main window"), "", NULL, G_CALLBACK(Config_Terminal)},
    | ^
    ../src/interface.c:176:9: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
    176 | {"SelectConfig", GTK_STOCK_OPEN, N_("_Load configuration"), "", NULL, G_CALLBACK(select_config_callback)},
    | ^
    ../src/interface.c:177:9: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
    177 | {"SaveConfig", GTK_STOCK_SAVE_AS, N_("_Save configuration"), "", NULL, G_CALLBACK(save_config_callback)},
    | ^
    ../src/interface.c:178:9: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
    178 | {"DeleteConfig", GTK_STOCK_DELETE, N_("_Delete configuration"), "", NULL, G_CALLBACK(delete_config_callback)},
    | ^
    ../src/interface.c:182:9: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
    182 | {"SignalsOpenPort", GTK_STOCK_OPEN, N_("_Open Port"), "F5", NULL, G_CALLBACK(signals_open_port)},
    | ^
    ../src/interface.c:183:9: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
    183 | {"SignalsClosePort", GTK_STOCK_CLOSE, N_("_Close Port"), "F6", NULL, G_CALLBACK(signals_close_port)},
    | ^
    ../src/interface.c:188:9: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
    188 | {"HelpAbout", GTK_STOCK_ABOUT, NULL, NULL, NULL, G_CALLBACK(help_about_callback)}
    | ^
    ../src/interface.c: In function ‘view_send_hex_toggled_callback’: ../src/interface.c:295:9: warning: ‘gtk_toggle_action_get_active’ is deprecated [-Wdeprecated-declarations]
    295 | if(gtk_toggle_action_get_active(GTK_TOGGLE_ACTION(action)))
    | ^~
    In file included from /usr/include/gtk-3.0/gtk/deprecated/gtkradioaction.h:36,
    from /usr/include/gtk-3.0/gtk/gtk.h:272,
    from ../src/interface.c:57: /usr/include/gtk-3.0/gtk/deprecated/gtktoggleaction.h:85:18: note: declared here
    85 | gboolean gtk_toggle_action_get_active (GtkToggleAction *action);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../src/interface.c: In function ‘view_index_toggled_callback’: ../src/interface.c:303:9: warning: ‘gtk_toggle_action_get_active’ is deprecated [-Wdeprecated-declarations]
    303 | show_index = gtk_toggle_action_get_active(GTK_TOGGLE_ACTION(action));
    | ^~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtktoggleaction.h:85:18: note: declared here
    85 | gboolean gtk_toggle_action_get_active (GtkToggleAction *action);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../src/interface.c: In function ‘view_hexadecimal_chars_radio_callback’: ../src/interface.c:310:9: warning: ‘gtk_radio_action_get_current_value’ is deprecated [-Wdeprecated-declarations]
    310 | current_value = gtk_radio_action_get_current_value(GTK_RADIO_ACTION(action));
    | ^~~~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkradioaction.h:89:17: note: declared here
    89 | gint gtk_radio_action_get_current_value (GtkRadioAction *action);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/interface.c: In function ‘set_view’:
    ../src/interface.c:322:9: warning: ‘gtk_action_group_get_action’ is deprecated [-Wdeprecated-declarations]
    322 | show_index_action = gtk_action_group_get_action(action_group, "ViewIndex");
    | ^~~~~~~~~~~~~~~~~
    In file included from /usr/include/gtk-3.0/gtk/gtk.h:254: /usr/include/gtk-3.0/gtk/deprecated/gtkactiongroup.h:195:17: note: declared here
    195 | GtkAction *gtk_action_group_get_action (GtkActionGroup *action_group,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../src/interface.c:323:9: warning: ‘gtk_action_group_get_action’ is deprecated [-Wdeprecated-declarations]
    323 | hex_chars_action = gtk_action_group_get_action(action_group, "ViewHexadecimalChars");
    | ^~~~~~~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkactiongroup.h:195:17: note: declared here
    195 | GtkAction *gtk_action_group_get_action (GtkActionGroup *action_group,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/interface.c:330:17: warning: ‘gtk_action_group_get_action’ is deprecated [-Wdeprecated-declarations]
    330 | action = gtk_action_group_get_action(action_group, "ViewASCII");
    | ^~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkactiongroup.h:195:17: note: declared here
    195 | GtkAction *gtk_action_group_get_action (GtkActionGroup *action_group,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/interface.c:331:17: warning: ‘gtk_toggle_action_set_active’ is deprecated [-Wdeprecated-declarations]
    331 | gtk_toggle_action_set_active(GTK_TOGGLE_ACTION(action), TRUE);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtktoggleaction.h:82:18: note: declared here
    82 | void gtk_toggle_action_set_active (GtkToggleAction *action,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/interface.c:332:17: warning: ‘gtk_action_set_sensitive’ is deprecated [-Wdeprecated-declarations]
    332 | gtk_action_set_sensitive(show_index_action, FALSE);
    | ^~~~~~~~~~~~~~~~~~~~~~~~
    In file included from /usr/include/gtk-3.0/gtk/deprecated/gtkactivatable.h:25,
    from /usr/include/gtk-3.0/gtk/gtk.h:252: /usr/include/gtk-3.0/gtk/deprecated/gtkaction.h:109:14: note: declared here
    109 | void gtk_action_set_sensitive (GtkAction *action,
    | ^~~~~~~~~~~~~~~~~~~~~~~~
    ../src/interface.c:333:17: warning: ‘gtk_action_set_sensitive’ is deprecated [-Wdeprecated-declarations]
    333 | gtk_action_set_sensitive(hex_chars_action, FALSE);
    | ^~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkaction.h:109:14: note: declared here
    109 | void gtk_action_set_sensitive (GtkAction *action,
    | ^~~~~~~~~~~~~~~~~~~~~~~~
    ../src/interface.c:335:34: warning: passing argument 1 of ‘set_display_func’ from incompatible pointer type [-Wincompatible-pointer-types]
    335 | set_display_func(put_text);
    | ^~~~~~~~
    | |
    | void (*)(gchar *, guint) {aka void (*)(char *, unsigned int)}
    In file included from ../src/interface.c:76:
    ../src/buffer.h:29:30: note: expected ‘void (*)(const char *, unsigned int)’ but argument is of type ‘void (*)(gchar *, guint)’ {aka ‘void (*)(char *, unsigned int)’}
    29 | void set_display_func(void (*func)(const char *, unsigned int));
    | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/interface.c:338:17: warning: ‘gtk_action_group_get_action’ is deprecated [-Wdeprecated-declarations]
    338 | action = gtk_action_group_get_action(action_group, "ViewHexadecimal");
    | ^~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkactiongroup.h:195:17: note: declared here
    195 | GtkAction *gtk_action_group_get_action (GtkActionGroup *action_group,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/interface.c:339:17: warning: ‘gtk_toggle_action_set_active’ is deprecated [-Wdeprecated-declarations]
    339 | gtk_toggle_action_set_active(GTK_TOGGLE_ACTION(action), TRUE);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtktoggleaction.h:82:18: note: declared here
    82 | void gtk_toggle_action_set_active (GtkToggleAction *action,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/interface.c:340:17: warning: ‘gtk_action_set_sensitive’ is deprecated [-Wdeprecated-declarations]
    340 | gtk_action_set_sensitive(show_index_action, TRUE);
    | ^~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkaction.h:109:14: note: declared here
    109 | void gtk_action_set_sensitive (GtkAction *action,
    | ^~~~~~~~~~~~~~~~~~~~~~~~
    ../src/interface.c:341:17: warning: ‘gtk_action_set_sensitive’ is deprecated [-Wdeprecated-declarations]
    341 | gtk_action_set_sensitive(hex_chars_action, TRUE);
    | ^~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkaction.h:109:14: note: declared here
    109 | void gtk_action_set_sensitive (GtkAction *action,
    | ^~~~~~~~~~~~~~~~~~~~~~~~
    ../src/interface.c:344:34: warning: passing argument 1 of ‘set_display_func’ from incompatible pointer type [-Wincompatible-pointer-types]
    344 | set_display_func(put_hexadecimal);
    | ^~~~~~~~~~~~~~~
    | |
    | void (*)(gchar *, guint) {aka void (*)(char *, unsigned int)}
    ../src/buffer.h:29:30: note: expected ‘void (*)(const char *, unsigned int)’ but argument is of type ‘void (*)(gchar *, guint)’ {aka ‘void (*)(char *, unsigned int)’}
    29 | void set_display_func(void (*func)(const char *, unsigned int));
    | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/interface.c: In function ‘view_radio_callback’: ../src/interface.c:355:9: warning: ‘gtk_radio_action_get_current_value’ is deprecated [-Wdeprecated-declarations]
    355 | current_value = gtk_radio_action_get_current_value(GTK_RADIO_ACTION(action));
    | ^~~~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkradioaction.h:89:17: note: declared here
    89 | gint gtk_radio_action_get_current_value (GtkRadioAction *action);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/interface.c: In function ‘Set_local_echo’: ../src/interface.c:366:9: warning: ‘gtk_action_group_get_action’ is deprecated [-Wdeprecated-declarations]
    366 | action = gtk_action_group_get_action(action_group, "LocalEcho");
    | ^~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkactiongroup.h:195:17: note: declared here
    195 | GtkAction *gtk_action_group_get_action (GtkActionGroup *action_group,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/interface.c:368:17: warning: ‘gtk_toggle_action_set_active’ is deprecated [-Wdeprecated-declarations]
    368 | gtk_toggle_action_set_active(GTK_TOGGLE_ACTION(action), echo_on);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtktoggleaction.h:82:18: note: declared here
    82 | void gtk_toggle_action_set_active (GtkToggleAction *action,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../src/interface.c: In function ‘echo_toggled_callback’: ../src/interface.c:373:9: warning: ‘gtk_toggle_action_get_active’ is deprecated [-Wdeprecated-declarations]
    373 | echo_on = gtk_toggle_action_get_active (GTK_TOGGLE_ACTION(action));
    | ^~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtktoggleaction.h:85:18: note: declared here
    85 | gboolean gtk_toggle_action_get_active (GtkToggleAction *action);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../src/interface.c: In function ‘Set_crlfauto’:
    ../src/interface.c:383:9: warning: ‘gtk_action_group_get_action’ is deprecated [-Wdeprecated-declarations]
    383 | action = gtk_action_group_get_action(action_group, "CRLFauto");
    | ^~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkactiongroup.h:195:17: note: declared here
    195 | GtkAction *gtk_action_group_get_action (GtkActionGroup *action_group,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/interface.c:385:17: warning: ‘gtk_toggle_action_set_active’ is deprecated [-Wdeprecated-declarations]
    385 | gtk_toggle_action_set_active(GTK_TOGGLE_ACTION(action), crlfauto_on);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtktoggleaction.h:82:18: note: declared here
    82 | void gtk_toggle_action_set_active (GtkToggleAction *action,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../src/interface.c: In function ‘CR_LF_auto_toggled_callback’: ../src/interface.c:390:9: warning: ‘gtk_toggle_action_get_active’ is deprecated [-Wdeprecated-declarations]
    390 | crlfauto_on = gtk_toggle_action_get_active (GTK_TOGGLE_ACTION(action));
    | ^~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtktoggleaction.h:85:18: note: declared here
    85 | gboolean gtk_toggle_action_get_active (GtkToggleAction *action);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../src/interface.c: In function ‘Set_timestamp’: ../src/interface.c:400:9: warning: ‘gtk_action_group_get_action’ is deprecated [-Wdeprecated-declarations]
    400 | action = gtk_action_group_get_action(action_group, "Timestamp");
    | ^~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkactiongroup.h:195:17: note: declared here
    195 | GtkAction *gtk_action_group_get_action (GtkActionGroup *action_group,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/interface.c:402:17: warning: ‘gtk_toggle_action_set_active’ is deprecated [-Wdeprecated-declarations]
    402 | gtk_toggle_action_set_active(GTK_TOGGLE_ACTION(action), timestamp_on);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtktoggleaction.h:82:18: note: declared here
    82 | void gtk_toggle_action_set_active (GtkToggleAction *action,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../src/interface.c: In function ‘timestamp_toggled_callback’: ../src/interface.c:407:9: warning: ‘gtk_toggle_action_get_active’ is deprecated [-Wdeprecated-declarations]
    407 | timestamp_on = gtk_toggle_action_get_active (GTK_TOGGLE_ACTION(action));
    | ^~~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtktoggleaction.h:85:18: note: declared here
    85 | gboolean gtk_toggle_action_get_active (GtkToggleAction *action);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../src/interface.c: In function ‘toggle_logging_pause_resume’: ../src/interface.c:415:9: warning: ‘gtk_action_group_get_action’ is deprecated [-Wdeprecated-declarations]
    415 | action = gtk_action_group_get_action(action_group, "LogPauseResume");
    | ^~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkactiongroup.h:195:17: note: declared here
    195 | GtkAction *gtk_action_group_get_action (GtkActionGroup *action_group,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/interface.c:419:17: warning: ‘gtk_action_set_label’ is deprecated [-Wdeprecated-declarations]
    419 | gtk_action_set_label(action, NULL);
    | ^~~~~~~~~~~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkaction.h:164:23: note: declared here
    164 | void gtk_action_set_label (GtkAction *action,
    | ^~~~~~~~~~~~~~~~~~~~
    ../src/interface.c:420:17: warning: ‘gtk_action_set_stock_id’ is deprecated [-Wdeprecated-declarations]
    420 | gtk_action_set_stock_id(action, GTK_STOCK_MEDIA_PAUSE);
    | ^~~~~~~~~~~~~~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkaction.h:179:23: note: declared here
    179 | void gtk_action_set_stock_id (GtkAction *action,
    | ^~~~~~~~~~~~~~~~~~~~~~~ ../src/interface.c:420:17: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
    420 | gtk_action_set_stock_id(action, GTK_STOCK_MEDIA_PAUSE);
    | ^~~~~~~~~~~~~~~~~~~~~~~
    ../src/interface.c:424:17: warning: ‘gtk_action_set_label’ is deprecated [-Wdeprecated-declarations]
    424 | gtk_action_set_label(action, _("Resume"));
    | ^~~~~~~~~~~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkaction.h:164:23: note: declared here
    164 | void gtk_action_set_label (GtkAction *action,
    | ^~~~~~~~~~~~~~~~~~~~
    ../src/interface.c:425:17: warning: ‘gtk_action_set_stock_id’ is deprecated [-Wdeprecated-declarations]
    425 | gtk_action_set_stock_id(action, GTK_STOCK_MEDIA_PLAY);
    | ^~~~~~~~~~~~~~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkaction.h:179:23: note: declared here
    179 | void gtk_action_set_stock_id (GtkAction *action,
    | ^~~~~~~~~~~~~~~~~~~~~~~ ../src/interface.c:425:17: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
    425 | gtk_action_set_stock_id(action, GTK_STOCK_MEDIA_PLAY);
    | ^~~~~~~~~~~~~~~~~~~~~~~
    ../src/interface.c: In function ‘toggle_logging_sensitivity’: ../src/interface.c:433:9: warning: ‘gtk_action_group_get_action’ is deprecated [-Wdeprecated-declarations]
    433 | action = gtk_action_group_get_action(action_group, "LogToFile");
    | ^~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkactiongroup.h:195:17: note: declared here
    195 | GtkAction *gtk_action_group_get_action (GtkActionGroup *action_group,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../src/interface.c:434:9: warning: ‘gtk_action_set_sensitive’ is deprecated [-Wdeprecated-declarations]
    434 | gtk_action_set_sensitive(action, !currentlyLogging);
    | ^~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkaction.h:109:14: note: declared here
    109 | void gtk_action_set_sensitive (GtkAction *action,
    | ^~~~~~~~~~~~~~~~~~~~~~~~
    ../src/interface.c:435:9: warning: ‘gtk_action_group_get_action’ is deprecated [-Wdeprecated-declarations]
    435 | action = gtk_action_group_get_action(action_group, "LogPauseResume");
    | ^~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkactiongroup.h:195:17: note: declared here
    195 | GtkAction *gtk_action_group_get_action (GtkActionGroup *action_group,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../src/interface.c:436:9: warning: ‘gtk_action_set_sensitive’ is deprecated [-Wdeprecated-declarations]
    436 | gtk_action_set_sensitive(action, currentlyLogging);
    | ^~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkaction.h:109:14: note: declared here
    109 | void gtk_action_set_sensitive (GtkAction *action,
    | ^~~~~~~~~~~~~~~~~~~~~~~~
    ../src/interface.c:437:9: warning: ‘gtk_action_group_get_action’ is deprecated [-Wdeprecated-declarations]
    437 | action = gtk_action_group_get_action(action_group, "LogStop");
    | ^~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkactiongroup.h:195:17: note: declared here
    195 | GtkAction *gtk_action_group_get_action (GtkActionGroup *action_group,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../src/interface.c:438:9: warning: ‘gtk_action_set_sensitive’ is deprecated [-Wdeprecated-declarations]
    438 | gtk_action_set_sensitive(action, currentlyLogging);
    | ^~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkaction.h:109:14: note: declared here
    109 | void gtk_action_set_sensitive (GtkAction *action,
    | ^~~~~~~~~~~~~~~~~~~~~~~~
    ../src/interface.c:439:9: warning: ‘gtk_action_group_get_action’ is deprecated [-Wdeprecated-declarations]
    439 | action = gtk_action_group_get_action(action_group, "LogClear");
    | ^~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkactiongroup.h:195:17: note: declared here
    195 | GtkAction *gtk_action_group_get_action (GtkActionGroup *action_group,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../src/interface.c:440:9: warning: ‘gtk_action_set_sensitive’ is deprecated [-Wdeprecated-declarations]
    440 | gtk_action_set_sensitive(action, currentlyLogging);
    | ^~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkaction.h:109:14: note: declared here
    109 | void gtk_action_set_sensitive (GtkAction *action,
    | ^~~~~~~~~~~~~~~~~~~~~~~~
    ../src/interface.c: In function ‘terminal_button_press_callback’: ../src/interface.c:452:17: warning: ‘gtk_menu_popup’ is deprecated: Use '(gtk_menu_popup_at_widget, gtk_menu_popup_at_pointer, gtk_menu_popup_at_rect)' instead [-Wdeprecated-declarations]
    452 | gtk_menu_popup(GTK_MENU(popup_menu), NULL, NULL, NULL, NULL,
    | ^~~~~~~~~~~~~~
    In file included from /usr/include/gtk-3.0/gtk/gtklabel.h:34,
    from /usr/include/gtk-3.0/gtk/gtkaccellabel.h:35,
    from /usr/include/gtk-3.0/gtk/gtk.h:33: /usr/include/gtk-3.0/gtk/gtkmenu.h:138:12: note: declared here
    138 | void gtk_menu_popup (GtkMenu *menu,
    | ^~~~~~~~~~~~~~
    ../src/interface.c: In function ‘terminal_popup_menu_callback’: ../src/interface.c:462:9: warning: ‘gtk_menu_popup’ is deprecated: Use '(gtk_menu_popup_at_widget, gtk_menu_popup_at_pointer, gtk_menu_popup_at_rect)' instead [-Wdeprecated-declarations]
    462 | gtk_menu_popup(GTK_MENU(popup_menu), NULL, NULL, NULL, NULL,
    | ^~~~~~~~~~~~~~
    /usr/include/gtk-3.0/gtk/gtkmenu.h:138:12: note: declared here
    138 | void gtk_menu_popup (GtkMenu *menu,
    | ^~~~~~~~~~~~~~
    ../src/interface.c: In function ‘create_main_window’: ../src/interface.c:487:9: warning: ‘gtk_ui_manager_new’ is deprecated [-Wdeprecated-declarations]
    487 | ui_manager = gtk_ui_manager_new();
    | ^~~~~~~~~~
    In file included from /usr/include/gtk-3.0/gtk/gtk.h:284: /usr/include/gtk-3.0/gtk/deprecated/gtkuimanager.h:130:16: note: declared here
    130 | GtkUIManager *gtk_ui_manager_new (void);
    | ^~~~~~~~~~~~~~~~~~
    ../src/interface.c:489:9: warning: ‘gtk_ui_manager_get_accel_group’ is deprecated [-Wdeprecated-declarations]
    489 | accel_group = gtk_ui_manager_get_accel_group (ui_manager);
    | ^~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkuimanager.h:147:16: note: declared here
    147 | GtkAccelGroup *gtk_ui_manager_get_accel_group (GtkUIManager *manager);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/interface.c:493:9: warning: ‘gtk_action_group_new’ is deprecated [-Wdeprecated-declarations]
    493 | action_group = gtk_action_group_new("MenuActions");
    | ^~~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkactiongroup.h:175:17: note: declared here
    175 | GtkActionGroup *gtk_action_group_new (const gchar *name);
    | ^~~~~~~~~~~~~~~~~~~~
    ../src/interface.c:494:9: warning: ‘gtk_action_group_set_translate_func’ is deprecated [-Wdeprecated-declarations]
    494 | gtk_action_group_set_translate_func(action_group, translate_menu, NULL, NULL);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkactiongroup.h:247:17: note: declared here
    247 | void gtk_action_group_set_translate_func (GtkActionGroup *action_group,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/interface.c:496:9: warning: ‘gtk_action_group_add_actions’ is deprecated [-Wdeprecated-declarations]
    496 | gtk_action_group_add_actions(action_group, menu_entries,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkactiongroup.h:210:17: note: declared here
    210 | void gtk_action_group_add_actions (GtkActionGroup *action_group,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/interface.c:499:9: warning: ‘gtk_action_group_add_toggle_actions’ is deprecated [-Wdeprecated-declarations]
    499 | gtk_action_group_add_toggle_actions(action_group, menu_toggle_entries,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkactiongroup.h:215:17: note: declared here
    215 | void gtk_action_group_add_toggle_actions (GtkActionGroup *action_group,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/interface.c:502:9: warning: ‘gtk_action_group_add_radio_actions’ is deprecated [-Wdeprecated-declarations]
    502 | gtk_action_group_add_radio_actions(action_group, menu_view_radio_entries,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkactiongroup.h:220:17: note: declared here
    220 | void gtk_action_group_add_radio_actions (GtkActionGroup *action_group,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/interface.c:506:9: warning: ‘gtk_action_group_add_radio_actions’ is deprecated [-Wdeprecated-declarations]
    506 | gtk_action_group_add_radio_actions(action_group, menu_hex_chars_length_radio_entries,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/gtk-3.0/gtk/deprecated/gtkactiongroup.h:220:17: note: declared here
    220 | void gtk_action_group_add_radio_actions (GtkActionGroup *action_group,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/interface.c:511:9: warning: ‘gtk_ui_manager_insert_action_group’ is deprecated [-Wdeprecated-declarations]
    511 | gtk_ui_manager_insert_action_group (ui_manager, action_group, 0);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

    [continued in next message]

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Steve Langasek@21:1/5 to All on Wed Apr 10 08:00:02 2024
    This is a multi-part MIME message sent by reportbug.


    Package: gtkterm
    Followup-For: Bug #1066645
    User: ubuntu-devel@lists.ubuntu.com
    Usertags: origin-ubuntu noble ubuntu-patch
    Control: tags -1 patch

    Please find attached a patch for this issue which has been uploaded to
    Ubuntu.

    --
    Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer https://www.debian.org/ slangasek@ubuntu.com vorlon@debian.org

    diff -Nru gtkterm-1.2.1/debian/patches/no-implicit-declarations.patch gtkterm-1.2.1/debian/patches/no-implicit-declarations.patch
    --- gtkterm-1.2.1/debian/patches/no-implicit-declarations.patch 1969-12-31 16:00:00.000000000 -0800
    +++ gtkterm-1.2.1/debian/patches/no-implicit-declarations.patch 2024-04-09 22:49:04.000000000 -0700
    @@ -0,0 +1,28 @@
    +Description: add missing includes
    +Author: Steve Langasek <steve.langasek@canonical.com>
    +Bug-Debian: https://bugs.debian.org/1066645
    +Last-Update: 2024-04-09
    +Forwarded: no
    +
    +Index: gtkterm-1.2.1/src/interface.c +===================================================================
    +--- gtkterm-1.2.1.orig/src/interface.c
    ++++ gtkterm-1.2.1/src/interface.c
    +@@ -79,6 +79,7 @@
    + #include "logging.h"
    +
    + #include <config.h>
    ++#include <glib/gstdio.h>
    + #include <glib/gi18n.h>
    +
    + guint id;
    +Index: gtkterm-1.2.1/src/user_signals.c +===================================================================
    +--- gtkterm-1.2.1.orig/src/user_signals.c
    ++++ gtkterm-1.2.1/src/user_signals.c
    +@@ -1,3 +1,5 @@
    ++#include <glib.h>
    ++#include <glib-unix.h>
    + #include <gtk/gtk.h>
    + #include