• Bug#1066592: matchbox-panel: FTBFS: panel.c:1026:7: error: implicit dec

    From Lucas Nussbaum@21:1/5 to All on Wed Mar 13 14:00:02 2024
    Source: matchbox-panel
    Version: 0.9.3+git20100816-1
    Severity: serious
    Justification: FTBFS
    Tags: trixie sid ftbfs
    User: lucas@debian.org
    Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

    Hi,

    During a rebuild of all packages in sid, your package failed to build
    on amd64.

    This is most likely caused by a change in dpkg 1.22.6, that enabled -Werror=implicit-function-declaration. For more information, see https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

    Relevant part (hopefully):
    gcc -DHAVE_CONFIG_H -I. -I.. -DDATADIR=\"/usr/share\" -DPKGDATADIR=\"/usr/share/matchbox\" -DPREFIX=\"/usr\" -g -Wall -fno-strict-aliasing -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/
    harfbuzz -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -pthread -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-
    declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o msg.o msg.c
    panel_app.c: In function ‘panel_app_name_get’:
    panel_util.c: In function ‘util_get_window_pid_from_prop’: panel_util.c:103:49: warning: pointer targets in passing argument 10 of ‘XGetWindowProperty’ differ in signedness [-Wpointer-sign]
    103 | &type, &format, &n_items,
    | ^~~~~~~~
    | |
    | long int * panel_app.c:106:49: warning: pointer targets in passing argument 10 of ‘XGetWindowProperty’ differ in signedness [-Wpointer-sign]
    106 | &type, &format, &n_items,
    | ^~~~~~~~
    | |
    | long int *
    In file included from panel.h:16,
    from panel_app.h:4,
    from panel_app.c:1:
    /usr/include/X11/Xlib.h:2700:5: note: expected ‘long unsigned int *’ but argument is of type ‘long int *’
    2700 | unsigned long* /* nitems_return */,
    | ^~~~~~~~~~~~~~
    In file included from panel.h:16,
    from panel_util.h:4,
    from panel_util.c:1:
    /usr/include/X11/Xlib.h:2700:5: note: expected ‘long unsigned int *’ but argument is of type ‘long int *’
    2700 | unsigned long* /* nitems_return */,
    | ^~~~~~~~~~~~~~
    panel_app.c:107:33: warning: pointer targets in passing argument 11 of ‘XGetWindowProperty’ differ in signedness [-Wpointer-sign]
    107 | &bytes_after, (unsigned char **)&papp->name);
    | ^~~~~~~~~~~~
    | |
    | long int *
    panel_util.c:104:33: warning: pointer targets in passing argument 11 of ‘XGetWindowProperty’ differ in signedness [-Wpointer-sign]
    104 | &bytes_after, (unsigned char **)&data);
    | ^~~~~~~~~~~~
    | |
    | long int * /usr/include/X11/Xlib.h:2701:5: note: expected ‘long unsigned int *’ but argument is of type ‘long int *’
    2701 | unsigned long* /* bytes_after_return */,
    | ^~~~~~~~~~~~~~
    /usr/include/X11/Xlib.h:2701:5: note: expected ‘long unsigned int *’ but argument is of type ‘long int *’
    2701 | unsigned long* /* bytes_after_return */,
    | ^~~~~~~~~~~~~~
    panel_app.c:122:22: warning: pointer targets in assignment from ‘char *’ to ‘unsigned char *’ differ in signedness [-Wpointer-sign]
    122 | papp->name = strdup("<unnamed>");
    | ^
    panel_app.c: In function ‘panel_app_icon_prop_data_get’: panel_app.c:167:49: warning: pointer targets in passing argument 10 of ‘XGetWindowProperty’ differ in signedness [-Wpointer-sign]
    167 | &type, &format, &n_items,
    | ^~~~~~~~
    | |
    | long int * /usr/include/X11/Xlib.h:2700:5: note: expected ‘long unsigned int *’ but argument is of type ‘long int *’
    2700 | unsigned long* /* nitems_return */,
    | ^~~~~~~~~~~~~~
    panel_util.c: In function ‘util_get_root_pixmap’:
    panel_util.c:190:49: warning: pointer targets in passing argument 10 of ‘XGetWindowProperty’ differ in signedness [-Wpointer-sign]
    190 | &type, &format, &n_items,
    | ^~~~~~~~
    | |
    | long int * /usr/include/X11/Xlib.h:2700:5: note: expected ‘long unsigned int *’ but argument is of type ‘long int *’
    2700 | unsigned long* /* nitems_return */,
    | ^~~~~~~~~~~~~~
    panel_app.c:168:33: warning: pointer targets in passing argument 11 of ‘XGetWindowProperty’ differ in signedness [-Wpointer-sign]
    168 | &bytes_after, (unsigned char **)&data);
    | ^~~~~~~~~~~~
    | |
    | long int * /usr/include/X11/Xlib.h:2701:5: note: expected ‘long unsigned int *’ but argument is of type ‘long int *’
    2701 | unsigned long* /* bytes_after_return */,
    | ^~~~~~~~~~~~~~
    panel_util.c:191:33: warning: pointer targets in passing argument 11 of ‘XGetWindowProperty’ differ in signedness [-Wpointer-sign]
    191 | &bytes_after, (unsigned char **)&data);
    | ^~~~~~~~~~~~
    | |
    | long int * /usr/include/X11/Xlib.h:2701:5: note: expected ‘long unsigned int *’ but argument is of type ‘long int *’
    2701 | unsigned long* /* bytes_after_return */,
    | ^~~~~~~~~~~~~~
    panel_util.c: In function ‘util_get_utf8_prop’:
    panel_util.c:217:49: warning: pointer targets in passing argument 10 of ‘XGetWindowProperty’ differ in signedness [-Wpointer-sign]
    217 | &type, &format, &n_items,
    | ^~~~~~~~
    | |
    | long int * /usr/include/X11/Xlib.h:2700:5: note: expected ‘long unsigned int *’ but argument is of type ‘long int *’
    2700 | unsigned long* /* nitems_return */,
    | ^~~~~~~~~~~~~~
    panel_util.c:218:33: warning: pointer targets in passing argument 11 of ‘XGetWindowProperty’ differ in signedness [-Wpointer-sign]
    218 | &bytes_after, (unsigned char **)&str);
    | ^~~~~~~~~~~~
    | |
    | long int * /usr/include/X11/Xlib.h:2701:5: note: expected ‘long unsigned int *’ but argument is of type ‘long int *’
    2701 | unsigned long* /* bytes_after_return */,
    | ^~~~~~~~~~~~~~
    session.c: In function ‘session_preexisting_win_matches_wanted’: session.c:210:7: warning: the comparison will always evaluate as ‘true’ for the address of ‘session_entry_cur’ will never be NULL [-Waddress]
    210 | if (panel->session_entry_cur) /* what were waiting on */
    | ^~~~~
    In file included from session.h:4,
    from session.c:1:
    panel.h:255:27: note: ‘session_entry_cur’ declared here
    255 | char session_entry_cur[512];
    | ^~~~~~~~~~~~~~~~~
    panel.c: In function ‘panel_set_bg’:
    panel.c:448:7: warning: the address of ‘xprop_def’ will always evaluate as ‘true’ [-Waddress]
    448 | if (xprop_def)
    | ^~~~~~~~~
    panel.c:455:40: warning: pointer targets in passing argument 7 of ‘XChangeProperty’ differ in signedness [-Wpointer-sign]
    455 | PropModeReplace, xprop_def,
    | ^~~~~~~~~
    | |
    | char *
    In file included from /usr/include/X11/Xlib.h:47,
    from panel.h:16,
    from panel.c:22:
    /usr/include/X11/Xlib.h:2089:5: note: expected ‘const unsigned char *’ but argument is of type ‘char *’
    2089 | _Xconst unsigned char* /* data */,
    | ^
    panel.c: In function ‘panel_set_theme_from_root_prop’:
    panel.c:523:36: warning: pointer targets in passing argument 3 of ‘panel_set_bg’ differ in signedness [-Wpointer-sign]
    523 | mb_dotdesktop_get(theme, "TitlebarDockBgColor"));
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    | |
    | unsigned char *
    panel.c:254:49: note: expected ‘char *’ but argument is of type ‘unsigned char *’
    254 | panel_set_bg(MBPanel *panel, int bg_type, char *bg_spec)
    | ~~~~~~^~~~~~~ panel.c:529:36: warning: pointer targets in passing argument 3 of ‘panel_set_bg’ differ in signedness [-Wpointer-sign]
    529 | mb_dotdesktop_get(theme, "TitlebarDockBgPixmap"));
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    | |
    | unsigned char *
    panel.c:254:49: note: expected ‘char *’ but argument is of type ‘unsigned char *’
    254 | panel_set_bg(MBPanel *panel, int bg_type, char *bg_spec)
    | ~~~~~~^~~~~~~ panel.c:537:36: warning: pointer targets in passing argument 3 of ‘panel_set_bg’ differ in signedness [-Wpointer-sign]
    537 | mb_dotdesktop_get(theme, "TitlebarPanelBgColor"));
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    | |
    | unsigned char *
    panel.c:254:49: note: expected ‘char *’ but argument is of type ‘unsigned char *’
    254 | panel_set_bg(MBPanel *panel, int bg_type, char *bg_spec)
    | ~~~~~~^~~~~~~ panel.c:543:36: warning: pointer targets in passing argument 3 of ‘panel_set_bg’ differ in signedness [-Wpointer-sign]
    543 | mb_dotdesktop_get(theme, "TitlebarPanelBgPixmap"));
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    | |
    | unsigned char *
    panel.c:254:49: note: expected ‘char *’ but argument is of type ‘unsigned char *’
    254 | panel_set_bg(MBPanel *panel, int bg_type, char *bg_spec)
    | ~~~~~~^~~~~~~ panel.c:558:36: warning: pointer targets in passing argument 3 of ‘panel_set_bg’ differ in signedness [-Wpointer-sign]
    558 | mb_dotdesktop_get(theme, "DockBgColor"));
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    | |
    | unsigned char *
    panel.c:254:49: note: expected ‘char *’ but argument is of type ‘unsigned char *’
    254 | panel_set_bg(MBPanel *panel, int bg_type, char *bg_spec)
    | ~~~~~~^~~~~~~ panel.c:563:36: warning: pointer targets in passing argument 3 of ‘panel_set_bg’ differ in signedness [-Wpointer-sign]
    563 | mb_dotdesktop_get(theme, "DockBgTrans"));
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    | |
    | unsigned char *
    panel.c:254:49: note: expected ‘char *’ but argument is of type ‘unsigned char *’
    254 | panel_set_bg(MBPanel *panel, int bg_type, char *bg_spec)
    | ~~~~~~^~~~~~~ panel.c:568:36: warning: pointer targets in passing argument 3 of ‘panel_set_bg’ differ in signedness [-Wpointer-sign]
    568 | mb_dotdesktop_get(theme, "DockBgPixmap"));
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    | |
    | unsigned char *
    panel.c:254:49: note: expected ‘char *’ but argument is of type ‘unsigned char *’
    254 | panel_set_bg(MBPanel *panel, int bg_type, char *bg_spec)
    | ~~~~~~^~~~~~~ panel.c:576:36: warning: pointer targets in passing argument 3 of ‘panel_set_bg’ differ in signedness [-Wpointer-sign]
    576 | mb_dotdesktop_get(theme, "PanelBgColor"));
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    | |
    | unsigned char *
    panel.c:254:49: note: expected ‘char *’ but argument is of type ‘unsigned char *’
    254 | panel_set_bg(MBPanel *panel, int bg_type, char *bg_spec)
    | ~~~~~~^~~~~~~ panel.c:581:36: warning: pointer targets in passing argument 3 of ‘panel_set_bg’ differ in signedness [-Wpointer-sign]
    581 | mb_dotdesktop_get(theme, "PanelBgTrans"));
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    | |
    | unsigned char *
    panel.c:254:49: note: expected ‘char *’ but argument is of type ‘unsigned char *’
    254 | panel_set_bg(MBPanel *panel, int bg_type, char *bg_spec)
    | ~~~~~~^~~~~~~ panel.c:586:36: warning: pointer targets in passing argument 3 of ‘panel_set_bg’ differ in signedness [-Wpointer-sign]
    586 | mb_dotdesktop_get(theme, "PanelBgPixmap"));
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    | |
    | unsigned char *
    panel.c:254:49: note: expected ‘char *’ but argument is of type ‘unsigned char *’
    254 | panel_set_bg(MBPanel *panel, int bg_type, char *bg_spec)
    | ~~~~~~^~~~~~~ panel.c:594:41: warning: pointer targets in passing argument 2 of ‘mb_font_set_from_string’ differ in signedness [-Wpointer-sign]
    594 | mb_dotdesktop_get(theme, "PanelMsgFont"));
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    | |
    | unsigned char *
    In file included from /usr/include/libmb/mb.h:27,
    from panel.h:23:
    /usr/include/libmb/mbexp.h:354:45: note: expected ‘char *’ but argument is of type ‘unsigned char *’
    354 | mb_font_set_from_string(MBFont *font, char *spec) ;
    | ~~~~~~^~~~
    panel.c:598:37: warning: pointer targets in passing argument 3 of ‘util_xcol_from_spec’ differ in signedness [-Wpointer-sign]
    598 | mb_dotdesktop_get(theme, "PanelMsgBgCol"));
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    | |
    | unsigned char *
    In file included from panel.h:329:
    panel_util.h:25:57: note: expected ‘char *’ but argument is of type ‘unsigned char *’
    25 | util_xcol_from_spec(MBPanel *panel, MBColor *col, char *spec);
    | ~~~~~~^~~~ panel.c:608:37: warning: pointer targets in passing argument 3 of ‘util_xcol_from_spec’ differ in signedness [-Wpointer-sign]
    608 | mb_dotdesktop_get(theme,
    | ^~~~~~~~~~~~~~~~~~~~~~~~
    | |
    | unsigned char *
    609 | "PanelMsgBgUrgentCol"));
    | ~~~~~~~~~~~~~~~~~~~~~~
    panel_util.h:25:57: note: expected ‘char *’ but argument is of type ‘unsigned char *’
    25 | util_xcol_from_spec(MBPanel *panel, MBColor *col, char *spec);
    | ~~~~~~^~~~ panel.c:617:37: warning: pointer targets in passing argument 3 of ‘util_xcol_from_spec’ differ in signedness [-Wpointer-sign]
    617 | mb_dotdesktop_get(theme,
    | ^~~~~~~~~~~~~~~~~~~~~~~~
    | |
    | unsigned char *
    618 | "PanelMsgFgCol"));
    | ~~~~~~~~~~~~~~~~
    panel_util.h:25:57: note: expected ‘char *’ but argument is of type ‘unsigned char *’
    25 | util_xcol_from_spec(MBPanel *panel, MBColor *col, char *spec);
    | ~~~~~~^~~~
    panel.c: In function ‘panel_handle_dock_request’:
    panel.c:821:7: warning: variable ‘app_origin_dist’ set but not used [-Wunused-but-set-variable]
    821 | int app_origin_dist = 0;
    | ^~~~~~~~~~~~~~~
    panel.c: In function ‘panel_main’:
    panel.c:1026:7: error: implicit declaration of function ‘msg_set_timeout’ [-Werror=implicit-function-declaration]
    1026 | msg_set_timeout (panel, &tvt, &tvp);
    | ^~~~~~~~~~~~~~~
    panel.c:1010:7: warning: variable ‘xfd’ set but not used [-Wunused-but-set-variable]
    1010 | int xfd;
    | ^~~
    panel.c: In function ‘panel_init’:
    panel.c:1793:56: warning: pointer targets in passing argument 4 of ‘XParseGeometry’ differ in signedness [-Wpointer-sign]
    1793 | XParseGeometry(geometry_str, &panel->x, &panel->y, &panel->w, &panel->h);
    | ^~~~~~~~~
    | |
    | int * /usr/include/X11/Xlib.h:2875:5: note: expected ‘unsigned int *’ but argument is of type ‘int *’
    2875 | unsigned int* /* width_return */,
    | ^~~~~~~~~~~~~
    panel.c:1793:67: warning: pointer targets in passing argument 5 of ‘XParseGeometry’ differ in signedness [-Wpointer-sign]
    1793 | XParseGeometry(geometry_str, &panel->x, &panel->y, &panel->w, &panel->h);
    | ^~~~~~~~~
    | |
    | int *
    /usr/include/X11/Xlib.h:2876:5: note: expected ‘unsigned int *’ but argument is of type ‘int *’
    2876 | unsigned int* /* height_return */
    | ^~~~~~~~~~~~~
    panel.c:1556:24: warning: variable ‘panel_length’ set but not used [-Wunused-but-set-variable]
    1556 | int panel_length;
    | ^~~~~~~~~~~~
    panel_menu.c: In function ‘panel_menu_update_remove_items’: panel_menu.c:104:56: warning: pointer targets in passing argument 3 of ‘mb_menu_add_item_to_menu’ differ in signedness [-Wpointer-sign]
    104 | papp->name, NULL,
    | ~~~~^~~~~~
    | |
    | unsigned char *
    In file included from /usr/include/libmb/mb.h:30,
    from panel.h:23,
    from panel_menu.h:11,
    from panel_menu.c:1:
    /usr/include/libmb/mbmenu.h:467:32: note: expected ‘char *’ but argument is of type ‘unsigned char *’
    467 | char *title,
    | ~~~~~~^~~~~
    panel_menu.c:105:56: warning: pointer targets in passing argument 5 of ‘mb_menu_add_item_to_menu’ differ in signedness [-Wpointer-sign]
    105 | papp->name,
    | ~~~~^~~~~~
    | |
    | unsigned char *
    /usr/include/libmb/mbmenu.h:469:32: note: expected ‘char *’ but argument is of type ‘unsigned char *’
    469 | char *info,
    | ~~~~~~^~~~
    panel_menu.c: In function ‘panel_menu_init’:
    panel_menu.c:212:69: warning: pointer targets in passing argument 3 of ‘mb_dot_desktop_icon_get_full_path’ differ in signedness [-Wpointer-sign]
    212 | 16, icon_str );
    | ^~~~~~~~
    | |
    | unsigned char *
    In file included from /usr/include/libmb/mbexp.h:34,
    from /usr/include/libmb/mb.h:27: /usr/include/libmb/mbdotdesktop.h:112:42: note: expected ‘char *’ but argument is of type ‘unsigned char *’
    112 | char* icon_name);
    | ~~~~~~^~~~~~~~~ panel_menu.c:214:31: warning: pointer targets in passing argument 1 of ‘strcmp’ differ in signedness [-Wpointer-sign]
    214 | if (!strcmp(mb_dotdesktop_get(ddentry, "Type"), "PanelApp"))
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    | |
    | unsigned char *
    In file included from panel.h:6:
    /usr/include/string.h:156:32: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
    156 | extern int strcmp (const char *__s1, const char *__s2)
    | ~~~~~~~~~~~~^~~~
    panel_menu.c:218:48: warning: pointer targets in passing argument 3 of ‘mb_menu_add_item_to_menu’ differ in signedness [-Wpointer-sign]
    218 | mb_dotdesktop_get(ddentry,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~
    | |
    | unsigned char *
    219 | "Name"),
    | ~~~~~~~
    /usr/include/libmb/mbmenu.h:467:32: note: expected ‘char *’ but argument is of type ‘unsigned char *’
    467 | char *title,
    | ~~~~~~^~~~~
    panel_menu.c:231:48: warning: pointer targets in passing argument 3 of ‘mb_menu_add_item_to_menu’ differ in signedness [-Wpointer-sign]
    231 | mb_dotdesktop_get(ddentry,
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~
    | |
    | unsigned char *
    232 | "Name"),
    | ~~~~~~~
    /usr/include/libmb/mbmenu.h:467:32: note: expected ‘char *’ but argument is of type ‘unsigned char *’
    467 | char *title,
    | ~~~~~~^~~~~
    panel_menu.c:188:7: warning: ignoring return value of ‘chdir’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
    188 | chdir(DATADIR "/applications");
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    panel_menu.c:248:3: warning: ignoring return value of ‘chdir’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
    248 | chdir(orig_wd);
    | ^~~~~~~~~~~~~~
    session.c: In function ‘session_preexisting_get_next’:
    session.c:301:11: warning: ‘__builtin_strncpy’ specified bound 512 equals destination size [-Wstringop-truncation]
    301 | strncpy(panel->session_entry_cur, prev_pos, 512);
    | ^
    cc1: some warnings being treated as errors
    make[3]: *** [Makefile:393: panel.o] Error 1


    The full build log is available from: http://qa-logs.debian.net/2024/03/13/matchbox-panel_0.9.3+git20100816-1_unstable.log

    All bugs filed during this archive rebuild are listed at: https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
    or: https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

    A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

    If you reassign this bug to another package, please mark it as 'affects'-ing this package. See https://www.debian.org/Bugs/server-control#affects

    If you fail to reproduce this, please provide a build log and diff it with mine so that we can identify if something relevant changed in the meantime.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)