Source: backuppc-rsync
Version: 3.1.3.0-3
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):

gcc -I. -I. -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -pedantic -DHAVE_CONFIG_H -Wall -W -Wdate-time -D_

FORTIFY_SOURCE=2 -c lib/snprintf.c -o lib/snprintf.o

lib/snprintf.c: In function ‘dopr’:
lib/snprintf.c:504:44: warning: this statement may fall through [-Wimplicit-fallthrough=]
504 | cnk->flags |= DP_F_UP;
| ^
lib/snprintf.c:505:25: note: here
505 | case 'x':
| ^~~~
lib/snprintf.c:514:44: warning: this statement may fall through [-Wimplicit-fallthrough=]
514 | cnk->flags |= DP_F_UP;
| ^
lib/snprintf.c:515:25: note: here
515 | case 'a':
| ^~~~
lib/compat.c: In function ‘sys_gettimeofday’:
lib/compat.c:154:16: error: too few arguments to function ‘gettimeofday’
154 | return gettimeofday(tv);
| ^~~~~~~~~~~~
In file included from ./rsync.h:365,
from lib/compat.c:22: /usr/include/x86_64-linux-gnu/sys/time.h:67:12: note: declared here
67 | extern int gettimeofday (struct timeval *__restrict __tv,
| ^~~~~~~~~~~~
lib/compat.c:156:1: warning: control reaches end of non-void function [-Wreturn-type]
156 | }
| ^
make[1]: *** [Makefile:65: lib/compat.o] Error 1

The full build log is available from: http://qa-logs.debian.net/2024/03/13/backuppc-rsync_3.1.3.0-3_unstable.log

All bugs filed during this archive rebuild are listed at: https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or: https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine so that we can identify if something relevant changed in the meantime.

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Le 13/03/2024 à 13:02, Lucas Nussbaum a écrit :

[…]
Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

[…]

Thanks for such information. Since no action was taken in last 2 weeks,
I opened a bug upstream [1].

[1] https://github.com/backuppc/rsync-bpc/issues/40

I was able to reproduce this bug, but I am not able to resolv it as I do
not understand how rsync-bpc is made from rsync. :-/


Thanks for any hint and regards.
--
J. Fernando Lagrange
Absent les mercredis des semaines paires
PROBESYS - Spécialistes OpenSource
9 rue de chamrousse
38100 Grenoble
Standard : 09 74 76 47 86
GLPi: 01 86 95 99 85
site web : https://www.probesys.com

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

This fixes the build:

--- a/configure.ac
+++ b/configure.ac
@@ -852,6 +852,7 @@ fi

AC_CACHE_CHECK([if gettimeofday takes tz argument],rsync_cv_HAVE_GETTIMEOFDAY_TZ,[
AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <sys/time.h>
+#include <stdlib.h>
#include <unistd.h>]], [[struct timeval tv; exit(gettimeofday(&tv, NULL));]])],[rsync_cv_HAVE_GETTIMEOFDAY_TZ=yes],[rsync_cv_HAVE_GETTIMEOFDAY_TZ=no])])
if test x"$rsync_cv_HAVE_GETTIMEOFDAY_TZ" != x"no"; then
AC_DEFINE(HAVE_GETTIMEOFDAY_TZ, 1, [Define to 1 if gettimeofday()
takes a time-zone arg])

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Control: tag -1 + patch

Hi Andreas,

Andreas Hasenack wrote:

This fixes the build:

--- a/configure.ac
+++ b/configure.ac
@@ -852,6 +852,7 @@ fi

AC_CACHE_CHECK([if gettimeofday takes tz argument],rsync_cv_HAVE_GETTIMEOFDAY_TZ,[
AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <sys/time.h>
+#include <stdlib.h>
#include <unistd.h>]], [[struct timeval tv; exit(gettimeofday(&tv, NULL));]])],[rsync_cv_HAVE_GETTIMEOFDAY_TZ=yes],[rsync_cv_HAVE_GETTIMEOFDAY_TZ=no])])
if test x"$rsync_cv_HAVE_GETTIMEOFDAY_TZ" != x"no"; then
AC_DEFINE(HAVE_GETTIMEOFDAY_TZ, 1, [Define to 1 if gettimeofday()
takes a time-zone arg])

Thanks a lot! I was always trying to add that include line into actual
C files. It didn't occur to me that I need to add it to configure.

Regards, Axel
--
,''`. | Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
`- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)