Source: lftp
Version: 4.9.2-2
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):

/bin/bash ../libtool --silent --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -

Wformat -Werror=format-security -fcf-protection -g -Wall -Wall -MT argmatch.lo -MD -MP -MF $depbase.Tpo -c -o argmatch.lo argmatch.c &&\

mv -f $depbase.Tpo $depbase.Plo
In file included from argmatch.c:22:
./config.h:2540:11: fatal error: trio.h: No such file or directory
2540 | # include "trio.h"
| ^~~~~~~~
compilation terminated.
make[5]: *** [Makefile:2321: argmatch.lo] Error 1

The full build log is available from: http://qa-logs.debian.net/2024/03/13/lftp_4.9.2-2_unstable.log

All bugs filed during this archive rebuild are listed at: https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or: https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine so that we can identify if something relevant changed in the meantime.

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Control: tags -1 patch

On 2024-03-24 Andrey Rakhmatullin <wrar@debian.org> wrote:

On Wed, Mar 13, 2024 at 01:03:20PM +0100, Lucas Nussbaum wrote:

./config.h:2540:11: fatal error: trio.h: No such file or directory
2540 | # include "trio.h"
| ^~~~~~~~

(this suggests that using trio is not actually supported but that's irrelevant)
This is caused by the stdio detection failing and should be fixed by
adding #include <stdio.h> to the test case code in m4/needtrio.m4 but this package doesn't run autoreconf so fixing d/rules to at least do that is
also needed.

[...]

As a hotfix touch-magic can also be used.

cu Andreas


diff --git a/debian/rules b/debian/rules
index e0872ed..ab41336 100755
--- a/debian/rules
+++ b/debian/rules
@@ -19,6 +19,9 @@ CFLAGS += -g -Wall

#configure: configure-stamp
configure-stamp:
+ # Avoid autoconf rebuild due to patching input files.
+ touch --reference=aclocal.m4 configure m4/needtrio.m4
+ touch --reference=Makefile.am m4/needtrio.m4
dh_testdir
# Add here commands to configure the package.
CFLAGS="$(CFLAGS)" CXXFLAGS="$(CXXFLAGS)" CPPFLAGS="$(CPPFLAGS)" LDFLAGS="$(LDFLAGS)" ./configure \

--- lftp-4.9.2.orig/configure
+++ lftp-4.9.2/configure
@@ -57429,6 +57429,7 @@ else
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
/* end confdefs.h. */

+ #include <stdio.h>
int main()
{
unsigned long long x=0,x1;
--- lftp-4.9.2.orig/m4/needtrio.m4
+++ lftp-4.9.2/m4/needtrio.m4
@@ -9,6 +9,7 @@ AC_DEFUN([LFTP_NEED_TRIO],[
else

AC_RUN_IFELSE([AC_LANG_SOURCE([[
+ #include <stdio.h>
int main()
{
unsigned long long x=0,x1;

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)