• Bug#1066257: expect: FTBFS: exp_clib.c:1859:17: error: implicit declara

    From Lucas Nussbaum@21:1/5 to All on Wed Mar 13 13:00:11 2024
    Source: expect
    Version: 5.45.4-2
    Severity: serious
    Justification: FTBFS
    Tags: trixie sid ftbfs
    User: lucas@debian.org
    Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

    Hi,

    During a rebuild of all packages in sid, your package failed to build
    on amd64.

    This is most likely caused by a change in dpkg 1.22.6, that enabled -Werror=implicit-function-declaration. For more information, see https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

    Relevant part (hopefully):
    gcc -DPACKAGE_NAME=\"expect\" -DPACKAGE_TARNAME=\"expect\" -DPACKAGE_VERSION=\"5.45.4\" -DPACKAGE_STRING=\"expect\ 5.45.4\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DBUILD_expect=/\*\*/ -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_
    INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DHAVE_SYS_TIME_H=1 -DSTDC_HEADERS=1 -DHAVE_LIMITS_H=1 -DHAVE_SYS_PARAM_H=1 -DUSE_THREAD_ALLOC=1 -D_REENTRANT=1 -D_THREAD_SAFE=1 -DTCL_THREADS=1 -
    DMODULE_SCOPE=extern\ __attribute__\(\(__visibility__\(\"hidden\"\)\)\) -D_LARGEFILE64_SOURCE=1 -DTCL_WIDE_INT_IS_LONG=1 -DUSE_TCL_STUBS=1 -DUSE_TCL_STUBS=1 -DHAVE_SYS_SELECT_H=1 -DHAVE_SYSMACROS_H=1 -DHAVE_SYS_FCNTL_H=1 -DRETSIGTYPE=void -DHAVE_SYS_TIME_
    H=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_STRUCT_TM_TM_ZONE=1 -DHAVE_TM_ZONE=1 -DHAVE_GMTIME_R=1 -DHAVE_LOCALTIME_R=1 -DHAVE_TM_GMTOFF=1 -DNO_UNION_WAIT=1 -DHAVE_OPENPTY=1 -DHAVE_MEMMOVE=1 -DHAVE_SYSCONF=1 -DHAVE_STRFTIME=1 -DHAVE_STRCHR=1 -DHAVE_TIMEZONE=1 -
    DHAVE_SIGLONGJMP=1 -DWNOHANG_BACKUP_VALUE=1 -DSELECT_MASK_TYPE=fd_set -DHAVE_TCSETATTR=1 -DPOSIX=1 -DHAVE_TERMIO=1 -DHAVE_TERMIOS=1 -DSETPGRP_VOID=1 -DHAVE_SV_TIMEZONE=1 -DHAVE_LONG_FILE_NAMES=1 -DTCL_DEBUGGER -DUSE_NON_CONST -DSCRIPTDIR=\"/usr/lib/
    expect5.45.4\" -DEXECSCRIPTDIR=\"/usr/lib/x86_64-linux-gnu/expect5.45.4\" -DSTTY_BIN=\"/bin/stty\" -DDFLT_STTY="\"sane\"" -I. -I"." -I"/usr/include/tcl8.6/tcl-private/generic" -I"/usr/include/tcl8.6/tcl-private/unix" -g -O2 -Werror=implicit-function-
    declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wall -g -D_BSD_SOURCE -ansi -D_SVID_SOURCE -D_POSIX_SOURCE -pipe -O2 -fomit-frame-pointer -Wall -fPIC -
    Wdate-time -D_FORTIFY_SOURCE=2 -c `echo exp_clib.c` -o exp_clib.o
    In file included from /usr/include/unistd.h:25,
    from exp_clib.c:10:
    /usr/include/features.h:195:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp]
    195 | # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE"
    | ^~~~~~~
    exp_clib.c: In function ‘exp_spawnv’:
    exp_clib.c:1859:17: error: implicit declaration of function ‘exp_init_tty’; did you mean ‘exp_init_pty’? [-Werror=implicit-function-declaration]
    1859 | exp_init_tty();
    | ^~~~~~~~~~~~
    | exp_init_pty
    exp_clib.c:1843:13: warning: unused variable ‘ttyfd’ [-Wunused-variable]
    1843 | int ttyfd;
    | ^~~~~
    exp_clib.c: In function ‘exp_disconnect’:
    exp_clib.c:2864:13: warning: unused variable ‘ttyfd’ [-Wunused-variable]
    2864 | int ttyfd;
    | ^~~~~
    exp_clib.c: In function ‘exp_spawnv’:
    exp_clib.c:2233:9: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
    2233 | write(status_pipe[1], &errno, sizeof errno);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    exp_clib.c: In function ‘exp_disconnect’:
    exp_clib.c:2874:9: warning: ignoring return value of ‘freopen’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
    2874 | freopen("/dev/null","r",stdin);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    exp_clib.c:2875:9: warning: ignoring return value of ‘freopen’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
    2875 | freopen("/dev/null","w",stdout);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    exp_clib.c:2876:9: warning: ignoring return value of ‘freopen’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
    2876 | freopen("/dev/null","w",stderr);
    | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    exp_clib.c: At top level:
    exp_clib.c:1819:1: warning: ‘exp_setpgrp’ defined but not used [-Wunused-function]
    1819 | exp_setpgrp()
    | ^~~~~~~~~~~
    exp_clib.c: In function ‘expectv’:
    exp_clib.c:2695:16: warning: ‘return_val’ may be used uninitialized [-Wmaybe-uninitialized]
    2695 | return return_val;
    | ^~~~~~~~~~
    exp_clib.c:2452:13: note: ‘return_val’ was declared here
    2452 | int return_val;
    | ^~~~~~~~~~
    cc1: some warnings being treated as errors
    make[2]: *** [Makefile:318: exp_clib.o] Error 1


    The full build log is available from: http://qa-logs.debian.net/2024/03/13/expect_5.45.4-2_unstable.log

    All bugs filed during this archive rebuild are listed at: https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
    or: https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

    A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

    If you reassign this bug to another package, please mark it as 'affects'-ing this package. See https://www.debian.org/Bugs/server-control#affects

    If you fail to reproduce this, please provide a build log and diff it with mine so that we can identify if something relevant changed in the meantime.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)