Source: kraptor
Version: 0.0.20040403+ds-3
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled -Werror=implicit-function-declaration. For more information, see https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):

cc -Iinclude -Wall -O2 `dpkg-buildflags --get CFLAGS` `dpkg-buildflags --get CPPFLAGS` -c src/pmask.c -o obj/linux/pmask.o
src/main.c: In function ‘main’:
src/main.c:57:5: error: implicit declaration of function ‘mkdir’ [-Werror=implicit-function-declaration]
57 | mkdir(str, 0755);
| ^~~~~
src/main.c:159:1: warning: ‘textout’ is deprecated [-Wdeprecated-declarations]
159 | textout(screen, font,"Wait... loading...",0,SCREEN_H - text_height(font)*2, makecol(255,255,255));
| ^~~~~~~
In file included from /usr/include/allegro/base.h:41,
from /usr/include/allegro.h:25,
from src/main.c:23:
/usr/include/allegro/alcompat.h:139:1: note: declared here
139 | AL_INLINE_DEPRECATED(void, textout, (struct BITMAP *bmp, AL_CONST FONT *f, AL_CONST char *str, int x, int y, int color),
| ^~~~~~~~~~~~~~~~~~~~
cc -Iinclude -Wall -O2 `dpkg-buildflags --get CFLAGS` `dpkg-buildflags --get CPPFLAGS` -c src/premio.c -o obj/linux/premio.o
cc1: some warnings being treated as errors
make[2]: *** [makefile.all:17: obj/linux/main.o] Error 1

The full build log is available from: http://qa-logs.debian.net/2024/03/13/kraptor_0.0.20040403+ds-3_unstable.log

All bugs filed during this archive rebuild are listed at: https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or: https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine so that we can identify if something relevant changed in the meantime.

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

This is a multi-part MIME message sent by reportbug.


Package: kraptor
Followup-For: Bug #1066315
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Please find attached a patch for this issue which has been uploaded to
Ubuntu.

--
Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer https://www.debian.org/ slangasek@ubuntu.com vorlon@debian.org

diff -Nru kraptor-0.0.20040403+ds/debian/patches/no-implicit-declarations.patch kraptor-0.0.20040403+ds/debian/patches/no-implicit-declarations.patch
--- kraptor-0.0.20040403+ds/debian/patches/no-implicit-declarations.patch 1969-12-31 16:00:00.000000000 -0800
+++ kraptor-0.0.20040403+ds/debian/patches/no-implicit-declarations.patch 2024-04-12 16:42:20.000000000 -0700
@@ -0,0 +1,18 @@
+Description: add missing include
+Author: Steve Langasek <steve.langasek@canonical.com>
+Bug-Debian: https://bugs.debian.org/1066315
+Last-Update: 2024-04-12
+Forwarded: no
+
+Index: kraptor-0.0.20040403+ds/src/main.c +===================================================================
+--- kraptor-0.0.20040403+ds.orig/src/main.c
++++ kraptor-0.0.20040403+ds/src/main.c
+@@ -19,6 +19,7 @@
+ // --------------------------------------------------------
+ #include <stdio.h>
+ #include <stdlib.h>
++#include <sys/stat.h>
+ #include <string.h>
+ #include <allegro.h>
+ #include <aldumb.h> /* DUMB: musica MOD, XM, etc */
diff -Nru kraptor-0.0.20040403+ds/debian/patches/series kraptor-0.0.20040403+ds/debian/patches/series
--- kraptor-0.0.20040403+ds/debian/patches/