Source: libdigidoc
Version: 3.10.5-4.1
Severity: serious
Tags: ftbfs
Justification: fails to build from source (but built successfully in the past) X-Debbugs-Cc: sramacher@debian.org

https://buildd.debian.org/status/fetch.php?pkg=libdigidoc&arch=armel&ver=3.10.5-4.1&stamp=1709133165&raw=0

/<<PKGBUILDDIR>>/libdigidoc/DigiDocService.c:327:19: error: implicit declaration of function ‘ddocAddSignatureFromMemory’ [-Werror=implicit-function-declaration]
327 | err = ddocAddSignatureFromMemory(pSigDoc, szFileName, (const void*)p1, strlen(p1));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[3]: *** [libdigidoc/CMakeFiles/digidoc.dir/build.make:359: libdigidoc/CMakeFiles/digidoc.dir/DigiDocService.c.o] Error 1

Cheers
--
Sebastian Ramacher

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

This is a multi-part MIME message sent by reportbug.


Package: libdigidoc
Followup-For: Bug #1065774
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Please find attached a patch for this issue that has been uploaded to
Ubuntu.

--
Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer https://www.debian.org/ slangasek@ubuntu.com vorlon@debian.org

diff -Nru libdigidoc-3.10.5/debian/patches/no-implicit-declarations.patch libdigidoc-3.10.5/debian/patches/no-implicit-declarations.patch
--- libdigidoc-3.10.5/debian/patches/no-implicit-declarations.patch 1969-12-31 16:00:00.000000000 -0800
+++ libdigidoc-3.10.5/debian/patches/no-implicit-declarations.patch 2024-04-10 16:10:25.000000000 -0700
@@ -0,0 +1,30 @@
+Description: add missing define and includes required for prototypes
+Author: Steve Langasek <steve.langasek@canonical.com>
+Bug-Debian: https://bugs.debian.org/1065774
+Last-Update: 2024-04-10
+Forwarded: no
+
+Index: libdigidoc-3.10.5/libdigidoc/DigiDocVerify.c +===================================================================
+--- libdigidoc-3.10.5.orig/libdigidoc/DigiDocVerify.c
++++ libdigidoc-3.10.5/libdigidoc/DigiDocVerify.c
+@@ -20,6 +20,7 @@
+ // Creation
+ //==================================================
+
++#define WITH_DEPRECATED_FUNCTIONS
+ #include "DigiDocVerify.h"
+ #include "DigiDocError.h"
+ #include "DigiDocLib.h"
+Index: libdigidoc-3.10.5/libdigidoc/DigiDocService.c +=====================================================