• Bug#1065371: unable to disable bug-implicit-func for time64

    From Matthias Klose@21:1/5 to All on Sun Mar 3 15:50:01 2024
    XPost: linux.debian.maint.dpkg

    Package: dpkg-dev
    Version: 1.22.5
    Severity: important

    It's not possible to disable bug-implicit-func on architectures where
    time64 is enabled by default:

    DEB_BUILD_OPTIONS=qa=-bug-implicit-func dpkg-buildflags |grep ^CFLAGS
    CFLAGS=-g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/root/doko/heimdal-7.8.git20221117.28daf24+dfsg=. -fstack-protector-strong -Wformat -Werror=format-security -fno-stack-clash-protection -fdebug-prefix-map=/root/doko/heimdal-7.8.git20221117.28daf24+dfsg=/usr/src/heimdal-7.8.git20221117.28daf24+dfsg-4.1ubuntu1

    This is seen when building heimdal for abi=time64, the configure check
    for checking for the crypt library fails, and later the build fails.

    There should be a way to override this.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Matthias Klose@21:1/5 to Guillem Jover on Sun Mar 3 17:10:01 2024
    XPost: linux.debian.maint.dpkg

    [CCing Lucas]

    On 03.03.24 16:46, Guillem Jover wrote:
    Hi!

    On Sun, 2024-03-03 at 16:11:36 +0100, Matthias Klose wrote:
    Control: severity -1 serious

    I just filed another bug report for bc, together with the one for heimdal. >>
    Please turn this off for a while, it's really harmful for the time64
    bootstrap.

    This was added on request by Steve, to help with the time64 changes.

    When you turn it on again,

    - please provide an opt-out option.

    This is a bug, which I should fix.

    - turn it on on all architectures, so that everbody
    can reproduce the effects.

    I'd be fine with that.

    - before turning it on again, please do an archive wide
    test rebuild and file bug reports for it.

    My impression is that this was done as part of the time64 checks? If
    not, and the consensus is to disable the flag, I'm very unlikely to
    drive this, and someone else will need to do those rebuilds and post
    results.

    I can do that, but we will need a stable dpkg version and a dpkg upload providing that setting on amd64 without time64 set. Then I'll ask Lucas
    for two test rebuilds (at this stage, that would be testing).

    Doing test rebuilds with time64 enabled on testing doesn't make sense
    for now, and unstable is too unstable.

    I think making the opt-out functional might be enough to help with
    this, and I could upload a fix later today, which would not disarm
    this safety net for the time64 transition. But at this point I don't
    mind either way, and if people prefer disabling the warning then I can
    do that instead.

    at least for heimdal, three people spent several hours looking for the
    cause of the failure. I'm not sure we want these kind of delays for the transition.

    Matthias

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)