• Bug#1065081: Doesn't include the systemd unit needed for socket activat

    From Sebastien Bacher@21:1/5 to All on Thu Feb 29 16:00:01 2024
    This is a multi-part message in MIME format.
    Package: speech-dispatcher
    Version: 0.12.0~rc2-1
    Tags: patch
    User: ubuntu-devel@lists.ubuntu.com
    Usertags: origin-ubuntu noble ubuntu-patch

    While rebasing the Ubuntu package on the new Debian version I noticed
    that the .install doesn't include the new systemd socket activation
    units (which is needed for tts in the firefox snap for example). THe
    attached patch fixes the issue, I've also bumped the compat level to 13
    which default to --fail-missing and would catch such errors


    ZGlmZiAtTnJ1IHNwZWVjaC1kaXNwYXRjaGVyLTAuMTIuMH5yYzIvZGViaWFuL2NoYW5nZWxv ZyBzcGVlY2gtZGlzcGF0Y2hlci0wLjEyLjB+cmMyL2RlYmlhbi9jaGFuZ2Vsb2cKLS0tIHNw ZWVjaC1kaXNwYXRjaGVyLTAuMTIuMH5yYzIvZGViaWFuL2NoYW5nZWxvZwkyMDI0LTAyLTIy IDIwOjI2OjM5LjAwMDAwMDAwMCArMDEwMAorKysgc3BlZWNoLWRpc3BhdGNoZXItMC4xMi4w fnJjMi9kZWJpYW4vY2hhbmdlbG9nCTIwMjQtMDItMjkgMTQ6NTA6MzEuMDAwMDAwMDAwICsw MTAwCkBAIC0xLDMgKzEsMTMgQEAKK3NwZWVjaC1kaXNwYXRjaGVyICgwLjEyLjB+cmMyLTIp IFVOUkVMRUFTRUQ7IHVyZ2VuY3k9bWVkaXVtCisKKyAgKiBkZWJpYW4vY29udHJvbDogCisg ICAgLSB1cGRhdGUgdG8gY29tcGF0IDEzIHdoaWNoIGRlZmF1bHQgdG8gZGhfbWlzc2luZyAt LWZhaWwtbWlzc2luZworICAqIGRlYmlhbi9ydWxlcywgZGViaWFuL3NwZWVjaC1kaXNwYXRj aGVyLmluc3RhbGw6CisgICAgLSBpbmNsdWRlIHRoZSB1c3IvbGliL3N5c3RlbWQvdXNlciBk aXJlY3Rvcnkgd2hpY2ggaGFzIHRoZSBuZXcKKyAgICAgIHNvY2tldCBhY3RpdmF0aW9uIGVu dHJ5CisKKyAtLSBTZWJhc3RpZW4gQmFjaGVyIDxzZWIxMjhAdWJ1bnR1LmNvbT4gIFRodSwg MjkgRmViIDIwMjQgMTQ6NTA6MzEgKzAxMDAKKwogc3BlZWNoLWRpc3BhdGNoZXIgKDAuMTIu MH5yYzItMSkgZXhwZXJpbWVudGFsOyB1cmdlbmN5PW1lZGl1bQogCiAgICogTmV3IHVwc3Ry ZWFtIFJDIHJlbGVhc2UKZGlmZiAtTnJ1IHNwZWVjaC1kaXNwYXRjaGVyLTAuMTIuMH5yYzIv ZGViaWFuL2NvbnRyb2wgc3BlZWNoLWRpc3BhdGNoZXItMC4xMi4wfnJjMi9kZWJpYW4vY29u dHJvbAotLS0gc3BlZWNoLWRpc3BhdGNoZXItMC4xMi4wfnJjMi9kZWJpYW4vY29udHJvbAky MDI0LTAyLTIyIDIwOjIwOjQ2LjAwMDAwMDAwMCArMDEwMAorKysgc3BlZWNoLWRpc3BhdGNo ZXItMC4xMi4wfnJjMi9kZWJpYW4vY29udHJvbAkyMDI0LTAyLTI5IDE0OjUwOjMxLjAwMDAw MDAwMCArMDEwMApAQCAtNSw3ICs1LDcgQEAKIFVwbG9hZGVyczoKICBQYXVsIEdldmVycyA8 ZWxicnVzQGRlYmlhbi5vcmc+LCBTYW11ZWwgVGhpYmF1bHQgPHN0aGliYXVsdEBkZWJpYW4u b3JnPgogQnVpbGQtRGVwZW5kczoKLSBkZWJoZWxwZXItY29tcGF0ICg9IDEyKSwgZGgtZXhl YywgZGgtc2VxdWVuY2UtcHl0aG9uMywKKyBkZWJoZWxwZXItY29tcGF0ICg9IDEzKSwgZGgt ZXhlYywgZGgtc2VxdWVuY2UtcHl0aG9uMywKICBhdXRvbWFrZSwgbGlidG9vbCwKICBweXRo b24zOmFueSwgcHl0aG9uMy14ZGcsCiAgZmxpdGUxLWRldiAoPj0gMS40KSwgZmxpdGUsCmRp ZmYgLU5ydSBzcGVlY2gtZGlzcGF0Y2hlci0wLjEyLjB+cmMyL2RlYmlhbi9ydWxlcyBzcGVl Y2gtZGlzcGF0Y2hlci0wLjEyLjB+cmMyL2RlYmlhbi9ydWxlcwotLS0gc3BlZWNoLWRpc3Bh dGNoZXItMC4xMi4wfnJjMi9kZWJpYW4vcnVsZXMJMjAyNC0wMi0yMiAyMDoyMDo0Ni4wMDAw MDAwMDAgKzAxMDAKKysrIHNwZWVjaC1kaXNwYXRjaGVyLTAuMTIuMH5yYzIvZGViaWFuL3J1 bGVzCTIwMjQtMDItMjkgMTQ6NTA6MzEuMDAwMDAwMDAwICswMTAwCkBAIC00LDYgKzQsNyBA QAogaW5jbHVkZSAvdXNyL3NoYXJlL2Rwa2cvcGtnLWluZm8ubWsKIAogZXhwb3J0IGRlYl9z eXN0ZW1kc3lzdGVtdW5pdGRpciA9ICQoc2hlbGwgcGtnY29uZiAtLXZhcmlhYmxlPXN5c3Rl bWRzeXN0ZW11bml0ZGlyIHN5c3RlbWQgfCBzZWQgcyxeLywsKQorZXhwb3J0IGRlYl9zeXN0 ZW1kdXNlcnVuaXRkaXIgPSAkKHNoZWxsIHBrZ2NvbmYgLS12YXJpYWJsZT1zeXN0ZW1kdXNl cnVuaXRkaXIgc3lzdGVtZCB8IHNlZCBzLF4vLCwpCiAKICMgTkFTIGlzIGluIHVuaXZlcnNl IGluIFVidW50dQogaWZlcSAoJChzaGVsbCBkcGtnLXZlbmRvciAtLWRlcml2ZXMtZnJvbSBV YnVudHUgJiYgZWNobyB5ZXMpLHllcykKZGlmZiAtTnJ1IHNwZWVjaC1kaXNwYXRjaGVyLTAu MTIuMH5yYzIvZGViaWFuL3NwZWVjaC1kaXNwYXRjaGVyLmluc3RhbGwgc3BlZWNoLWRpc3Bh dGNoZXItMC4xMi4wfnJjMi9kZWJpYW4vc3BlZWNoLWRpc3BhdGNoZXIuaW5zdGFsbAotLS0g c3BlZWNoLWRpc3BhdGNoZXItMC4xMi4wfnJjMi9kZWJpYW4vc3BlZWNoLWRpc3BhdGNoZXIu aW5zdGFsbAkyMDI0LTAyLTIyIDIwOjI2OjM5LjAwMDAwMDAwMCArMDEwMAorKysgc3BlZWNo LWRpc3BhdGNoZXItMC4xMi4wfnJjMi9kZWJpYW4vc3BlZWNoLWRpc3BhdGNoZXIuaW5zdGFs bAkyMDI0LTAyLTI5IDE0OjUwOjMxLjAwMDAwMDAwMCArMDEwMApAQCAtMTAsNSArMTAsNyBA QAogdXNyL3NoYXJlL3NwZWVjaC1kaXNwYXRjaGVyCiBldGMvc3BlZWNoLWRpc3BhdGNoZXIK IFtsaW51eC1hbnldICR7ZGViX3N5c3RlbWRzeXN0ZW11bml0ZGlyfS9zcGVlY2gtZGlzcGF0 Y2hlcmQuc2VydmljZQorW2xpbnV4LWFueV0gJHtkZWJfc3lzdGVtZHVzZXJ1bml0ZGlyfS9z cGVlY2gtZGlzcGF0Y2hlci5zZXJ2aWNlCitbbGludXgtYW55XSAke2RlYl9zeXN0ZW1kdXNl cnVuaXRkaXJ9L3NwZWVjaC1kaXNwYXRjaGVyLnNvY2tldAogdXNyL3NoYXJlL21hbi9tYW4x L3NwZWVjaC1kaXNwYXRjaGVyLjEKIHVzci9zaGFyZS9tYW4vbWFuMS9zcGQtc2F5LjEK

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Samuel Thibault@21:1/5 to All on Mon Mar 4 02:30:01 2024
    Hello,

    Sebastien Bacher, le jeu. 29 févr. 2024 15:49:03 +0100, a ecrit:
    While rebasing the Ubuntu package on the new Debian version I noticed that the .install doesn't include the new systemd socket activation units (which is needed for tts in the firefox snap for example). THe attached patch fixes the issue, I've also bumped the compat level to 13 which default to --fail-missing and would catch such errors

    Indeed, thanks!

    Samuel

    diff -Nru speech-dispatcher-0.12.0~rc2/debian/changelog speech-dispatcher-0.12.0~rc2/debian/changelog
    --- speech-dispatcher-0.12.0~rc2/debian/changelog 2024-02-22 20:26:39.000000000 +0100
    +++ speech-dispatcher-0.12.0~rc2/debian/changelog 2024-02-29 14:50:31.000000000 +0100
    @@ -1,3 +1,13 @@
    +speech-dispatcher (0.12.0~rc2-2) UNRELEASED; urgency=medium
    +
    + * debian/control:
    + - update to compat 13 which default to dh_missing --fail-missing
    + * debian/rules, debian/speech-dispatcher.install:
    + - include the usr/lib/systemd/user directory which has the new
    + socket activation entry
    +
    + -- Sebastien Bacher <seb128@ubuntu.com> Thu, 29 Feb 2024 14:50:31 +0100
    +
    speech-dispatcher (0.12.0~rc2-1) experimental; urgency=medium

    * New upstream RC release
    diff -Nru speech-dispatcher-0.12.0~rc2/debian/control speech-dispatcher-0.12.0~rc2/debian/control
    --- speech-dispatcher-0.12.0~rc2/debian/control 2024-02-22 20:20:46.000000000 +0100
    +++ speech-dispatcher-0.12.0~rc2/debian/control 2024-02-29 14:50:31.000000000 +0100
    @@ -5,7 +5,7 @@
    Uploaders:
    Paul Gevers <elbrus@debian.org>, Samuel Thibault <sthibault@debian.org>
    Build-Depends:
    - debhelper-compat (= 12), dh-exec, dh-sequence-python3,
    + debhelper-compat (= 13), dh-exec, dh-sequence-python3,
    automake, libtool,
    python3:any, python3-xdg,
    flite1-dev (>= 1.4), flite,
    diff -Nru speech-dispatcher-0.12.0~rc2/debian/rules speech-dispatcher-0.12.0~rc2/debian/rules
    --- speech-dispatcher-0.12.0~rc2/debian/rules 2024-02-22 20:20:46.000000000 +0100
    +++ speech-dispatcher-0.12.0~rc2/debian/rules 2024-02-29 14:50:31.000000000 +0100
    @@ -4,6 +4,7 @@
    include /usr/share/dpkg/pkg-info.mk

    export deb_systemdsystemunitdir = $(shell pkgconf --variable=systemdsystemunitdir systemd | sed s,^/,,)
    +export deb_systemduserunitdir = $(shell pkgconf --variable=systemduserunitdir systemd | sed s,^/,,)

    # NAS is in universe in Ubuntu
    ifeq ($(shell dpkg-vendor --derives-from Ubuntu && echo yes),yes)
    diff -Nru speech-dispatcher-0.12.0~rc2/debian/speech-dispatcher.install speech-dispatcher-0.12.0~rc2/debian/speech-dispatcher.install
    --- speech-dispatcher-0.12.0~rc2/debian/speech-dispatcher.install 2024-02-22 20:26:39.000000000 +0100
    +++ speech-dispatcher-0.12.0~rc2/debian/speech-dispatcher.install 2024-02-29 14:50:31.000000000 +0100
    @@ -10,5 +10,7 @@
    usr/share/speech-dispatcher
    etc/speech-dispatcher
    [linux-any] ${deb_systemdsystemunitdir}/speech-dispatcherd.service +[linux-any] ${deb_systemduserunitdir}/speech-dispatcher.service
    +[linux-any] ${deb_systemduserunitdir}/speech-dispatcher.socket
    usr/share/man/man1/speech-dispatcher.1
    usr/share/man/man1/spd-say.1

    _______________________________________________
    Tts-project mailing list
    Tts-project@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/tts-project


    --
    Samuel
    ---
    Pour une évaluation indépendante, transparente et rigoureuse !
    Je soutiens la Commission d'Évaluation de l'Inria.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)