Source: lightdm
Version: 1.32.0-4
Severity: serious
Tags: ftbfs

https://buildd.debian.org/status/fetch.php?pkg=lightdm&arch=armel&ver=1.32.0-4%2Bb3&stamp=1711185127&raw=0

/bin/bash ../../libtool --tag=CC --mode=link gcc -Wall
-Wstrict-prototypes -Wnested-externs -Werror=missing-prototypes -Werror=implicit-function- declaration -Werror=pointer-arith
-Werror=init-self -Werror=format-security
-Werror=format=2 -Werror=missing-include-dirs -I/usr/include/glib-2.0 -I/usr/lib/arm-linux-gnueabi/glib-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/arm-linux-gnueabi/glib-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/arm-linux-gnueabi/glib-2.0/include -pthread -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -I/usr/include/glib-2.0 -I/usr/lib/arm-linux-gnueabi/glib-2.0/include -pthread -I/usr/include/libmount -I/usr/include/blkid -g -O2 -Werror=implicit-function- declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -O0 -Wl,-z,relro -Wl,-z,now -Wl,-O1 -o Xvnc Xvnc-Xvnc.o Xvnc-x-authority.o Xvnc-x-common.o Xvnc- x-server.o Xvnc-status.o -lgobject-2.0 -lglib-2.0 -lglib-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0
/tmp/ccCHYR2t.s: Assembler messages:
/tmp/ccCHYR2t.s:2779: Error: symbol `open64' is already defined /tmp/ccCHYR2t.s:3181: Error: symbol `creat64' is already defined /tmp/ccCHYR2t.s:3508: Error: symbol `__stat64_time64' is already defined


-- System Information:
Debian Release: trixie/sid
APT prefers unstable-debug
APT policy: (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'unstable'), (500, 'testing'), (101, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.7.9-amd64 (SMP w/4 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=ru_RU.UTF-8, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Hi, thanks for the patch. It looks a bit strong though, undefining stuff like that unconditionally. Do you have pointers to the Ubuntu bug or something? I've looked at upstream commits and issues and couldn't see anything there.

My understanding of the issue.

In glibc _FILE_OFFSET_BITS=64 is used to substitute the standard file
handling types and functions with versions that use 64-bit file
offsets. Similarly _TIME_BITS=64 is used to susbstitute time handling
types and functions with versions that use 64-bit seconds counts.

All of this only applies to 32-bit architectures, on 64-bit
architectures the default types in glibc are 64-bit.

The "time64" transition was implemented by defining _TIME_BITS=64 and _FILE_OFFSET_BITS=64 by default in both dpkg-buildflags and the compiler.

That's fine for normal code, but tests/src/libsystem.c is not normal
code, it's a file of "test mocks" that override functions in glibc
for testing purposes. If _FILE_OFFSET_BITS=64 is defined, it ends up
trying to override "open64" twice, rather than trying to override both
"open" and "open64"

If we undef _FILE_OFFSET_BITS then we must also undef _TIME_BITS,
otherwise the glibc headers will refuse to compile.

So the patch seems reasonable to me, and since this is only test
code, it appears to be pretty low risk. We would appreciate having
this fix in unstable so the time_t transition can move forward.

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On Fri, 2024-04-19 at 00:01 +0100, Peter Green wrote:

Thanks, upstream has now accepted a patch that takes a slightly different approach to fixing the issue.

https://github.com/canonical/lightdm/issues/352

Yes I saw. That's why I think this should have been reported and talked directly with upstream, before the NMU, but eh...

Could we get this uploaded to sid, so that the lightweight desktops
are installable on armel/armhf again?

Yes I'll look into it.

Regards,
- --
Yves-Alexis
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEE8vi34Qgfo83x35gF3rYcyPpXRFsFAmYiRuIACgkQ3rYcyPpX RFsQkQgA1h8bIbWp0Sj6VqgcdG/dkwKEQ6Xrcuh6gpL7Gy2BiT2d1tY4HFN94bhG FJVz9E9QOqlZt2Mo7JQ6EBYyvcTspO0T09ZU/22VjA2NdP0eSRHTiyiFXq4hyoYf OBnPpKTxq0Wp9L7Tefta7uNPIBX+lsVlw9cdwv6PIEy6jlF3xjX+B8FoK/K/fIeY FuQh5qOw/k/nnPAM4pHxYGAfRw+BNBEnI3ADFCCWDvpQSgZ9uJ9UB3wnEo50aXub dsNsXAZx3UIX2CfDBs1jXsPc/B37csOr9sJIqDn1xJKaT/Q6Yk1A/LV8uTa38wGh MykmdfDqWLT0nK4atbVH5fxjkTNdDg==
=Fysh
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

This is a multi-part message in MIME format...

Your message dated Fri, 19 Apr 2024 14:35:05 +0000
with message-id <E1rxpKT-0075Ff-Ot@fasolo.debian.org>
and subject line Bug#1067561: fixed in lightdm 1.32.0-5
has caused the Debian Bug report #1067561,
regarding FTBFS: Error: symbol `open64' is already defined
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


--
1067561: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1067561
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

Received: (at submit) by bugs.debian.org; 23 Mar 2024 16:57:01 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.6-bugs.debian.org_2005_01_02
(2021-04-09) on buxtehude.debian.org
X-Spam-Level:
X-Spam-Status: No, score=-8.9 required=4.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,FORGED_SPF_HELO,FOURLA,FROMDEVELOPER,SPF_HELO_PASS,SPF_NONE,
XMAILER_REPORTBUG autolearn=ham autolearn_force=no
version=3.4.6-bugs.debian.org_2005_01_02
X-Spam-Bayes: score:0.0000 Tokens: new, 41; hammy, 150; neutral, 128; spammy,
0. spammytokens: hammytokens:0.000-+--pkgbuilddir,
0.000-+--PKGBUILDDIR, 0.000-+--sk:buildd.,
0.000-+--UD:buildd.debian.org, 0.000-+--buildddebianorg
Return-path: <wrar@debian.org>
Received: from wrar.name ([116.203.248.210]:51460 helo=durkon.wrar.name)
by buxtehude.debian.org with esmtps (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256